[INFO] crate slacker 0.1.3 is already in cache [INFO] extracting crate slacker 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/slacker/0.1.3 [INFO] extracting crate slacker 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slacker/0.1.3 [INFO] validating manifest of slacker-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of slacker-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing slacker-0.1.3 [INFO] finished frobbing slacker-0.1.3 [INFO] frobbed toml for slacker-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/slacker/0.1.3/Cargo.toml [INFO] started frobbing slacker-0.1.3 [INFO] finished frobbing slacker-0.1.3 [INFO] frobbed toml for slacker-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slacker/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting slacker-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/slacker/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c18d683b2ee1b625ff3f46329764099b5f6d5dd4afeaf5a640c2952754bfa94d [INFO] running `"docker" "start" "-a" "c18d683b2ee1b625ff3f46329764099b5f6d5dd4afeaf5a640c2952754bfa94d"` [INFO] [stderr] Checking maplit v0.1.6 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Checking slacker v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | fname: fname, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `fname` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | fname: fname, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `fname` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tio::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/lib.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | use tio::codec::Framed; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tio::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/lib.rs:47:22 [INFO] [stderr] | [INFO] [stderr] 47 | type Transport = Framed; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tio::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/lib.rs:110:22 [INFO] [stderr] | [INFO] [stderr] 110 | type Transport = Framed; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tio::AsyncRead::framed': Use tokio_codec::Decoder::framed instead [INFO] [stderr] --> src/lib.rs:52:15 [INFO] [stderr] | [INFO] [stderr] 52 | Ok(io.framed(SlackerCodec)) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tio::AsyncRead::framed': Use tokio_codec::Decoder::framed instead [INFO] [stderr] --> src/lib.rs:115:15 [INFO] [stderr] | [INFO] [stderr] 115 | Ok(io.framed(SlackerCodec)) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tio::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/lib.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | use tio::codec::Framed; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tio::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/lib.rs:47:22 [INFO] [stderr] | [INFO] [stderr] 47 | type Transport = Framed; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tio::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/lib.rs:110:22 [INFO] [stderr] | [INFO] [stderr] 110 | type Transport = Framed; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tio::AsyncRead::framed': Use tokio_codec::Decoder::framed instead [INFO] [stderr] --> src/lib.rs:52:15 [INFO] [stderr] | [INFO] [stderr] 52 | Ok(io.framed(SlackerCodec)) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tio::AsyncRead::framed': Use tokio_codec::Decoder::framed instead [INFO] [stderr] --> src/lib.rs:115:15 [INFO] [stderr] | [INFO] [stderr] 115 | Ok(io.framed(SlackerCodec)) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/codecs.rs:33:15 [INFO] [stderr] | [INFO] [stderr] 33 | fn encode<'a>(&mut self, frame_in: Self::Item, buf0: &mut BytesMut) -> Result<(), Self::Error> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:169:1 [INFO] [stderr] | [INFO] [stderr] 169 | / named!(pub slacker_all <&[u8], SlackerPacket>, [INFO] [stderr] 170 | | do_parse!(header: slacker_header >> [INFO] [stderr] 171 | | body: switch!(value!(header.packet_type), [INFO] [stderr] 172 | | PACKET_TYPE_REQUEST => call!(slacker_request) | [INFO] [stderr] ... | [INFO] [stderr] 180 | | (SlackerPacket(header, body)) [INFO] [stderr] 181 | | )); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/service.rs:64:59 [INFO] [stderr] | [INFO] [stderr] 64 | let mut resp_header = header.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `header` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/service.rs:87:39 [INFO] [stderr] | [INFO] [stderr] 87 | let mut resp_header = header.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/service.rs:155:59 [INFO] [stderr] | [INFO] [stderr] 155 | let mut resp_header = header.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/service.rs:175:39 [INFO] [stderr] | [INFO] [stderr] 175 | let mut resp_header = header.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `client::ClientManager` [INFO] [stderr] --> src/client.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / pub fn new() -> ClientManager { [INFO] [stderr] 26 | | let serializer = Arc::new(JsonSerializer); [INFO] [stderr] 27 | | ClientManager { serializer } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | impl Default for client::ClientManager { [INFO] [stderr] 25 | fn default() -> Self { [INFO] [stderr] 26 | Self::new() [INFO] [stderr] 27 | } [INFO] [stderr] 28 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/codecs.rs:33:15 [INFO] [stderr] | [INFO] [stderr] 33 | fn encode<'a>(&mut self, frame_in: Self::Item, buf0: &mut BytesMut) -> Result<(), Self::Error> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:169:1 [INFO] [stderr] | [INFO] [stderr] 169 | / named!(pub slacker_all <&[u8], SlackerPacket>, [INFO] [stderr] 170 | | do_parse!(header: slacker_header >> [INFO] [stderr] 171 | | body: switch!(value!(header.packet_type), [INFO] [stderr] 172 | | PACKET_TYPE_REQUEST => call!(slacker_request) | [INFO] [stderr] ... | [INFO] [stderr] 180 | | (SlackerPacket(header, body)) [INFO] [stderr] 181 | | )); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/service.rs:64:59 [INFO] [stderr] | [INFO] [stderr] 64 | let mut resp_header = header.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `header` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/service.rs:87:39 [INFO] [stderr] | [INFO] [stderr] 87 | let mut resp_header = header.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/service.rs:155:59 [INFO] [stderr] | [INFO] [stderr] 155 | let mut resp_header = header.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/service.rs:175:39 [INFO] [stderr] | [INFO] [stderr] 175 | let mut resp_header = header.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `client::ClientManager` [INFO] [stderr] --> src/client.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / pub fn new() -> ClientManager { [INFO] [stderr] 26 | | let serializer = Arc::new(JsonSerializer); [INFO] [stderr] 27 | | ClientManager { serializer } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | impl Default for client::ClientManager { [INFO] [stderr] 25 | fn default() -> Self { [INFO] [stderr] 26 | Self::new() [INFO] [stderr] 27 | } [INFO] [stderr] 28 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> examples/thread_server.rs:16:12 [INFO] [stderr] | [INFO] [stderr] 16 | fn echo(s: &Vec) -> Json { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 16 | fn echo(s: &[Json]) -> Json { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] help: change `s.clone()` to [INFO] [stderr] | [INFO] [stderr] 18 | Json::Array(s.to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> examples/server.rs:15:12 [INFO] [stderr] | [INFO] [stderr] 15 | fn echo(s: &Vec) -> Oneshot { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Json]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.92s [INFO] running `"docker" "inspect" "c18d683b2ee1b625ff3f46329764099b5f6d5dd4afeaf5a640c2952754bfa94d"` [INFO] running `"docker" "rm" "-f" "c18d683b2ee1b625ff3f46329764099b5f6d5dd4afeaf5a640c2952754bfa94d"` [INFO] [stdout] c18d683b2ee1b625ff3f46329764099b5f6d5dd4afeaf5a640c2952754bfa94d