[INFO] crate slack 0.22.0 is already in cache [INFO] extracting crate slack 0.22.0 into work/ex/clippy-test-run/sources/stable/reg/slack/0.22.0 [INFO] extracting crate slack 0.22.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slack/0.22.0 [INFO] validating manifest of slack-0.22.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of slack-0.22.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing slack-0.22.0 [INFO] finished frobbing slack-0.22.0 [INFO] frobbed toml for slack-0.22.0 written to work/ex/clippy-test-run/sources/stable/reg/slack/0.22.0/Cargo.toml [INFO] started frobbing slack-0.22.0 [INFO] finished frobbing slack-0.22.0 [INFO] frobbed toml for slack-0.22.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slack/0.22.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting slack-0.22.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/slack/0.22.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f35b521dd141145848325c3ceade68996953c349c1399d5fc04dc193cb3bd96d [INFO] running `"docker" "start" "-a" "f35b521dd141145848325c3ceade68996953c349c1399d5fc04dc193cb3bd96d"` [INFO] [stderr] Checking tungstenite v0.6.1 [INFO] [stderr] Checking uuid v0.7.2 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking hyper v0.12.23 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.9 [INFO] [stderr] Checking slack_api v0.21.0 [INFO] [stderr] Checking slack v0.22.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | tx: tx, [INFO] [stderr] | ^^^^^^ help: replace it with: `tx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:181:16 [INFO] [stderr] | [INFO] [stderr] 181 | start_response: start_response, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_response` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:182:16 [INFO] [stderr] | [INFO] [stderr] 182 | sender: sender, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:183:16 [INFO] [stderr] | [INFO] [stderr] 183 | rx: rx, [INFO] [stderr] | ^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | tx: tx, [INFO] [stderr] | ^^^^^^ help: replace it with: `tx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:181:16 [INFO] [stderr] | [INFO] [stderr] 181 | start_response: start_response, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_response` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:182:16 [INFO] [stderr] | [INFO] [stderr] 182 | sender: sender, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:183:16 [INFO] [stderr] | [INFO] [stderr] 183 | rx: rx, [INFO] [stderr] | ^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/events.rs:265:5 [INFO] [stderr] | [INFO] [stderr] 265 | / DesktopNotification { [INFO] [stderr] 266 | | #[serde(rename = "avatarImage")] [INFO] [stderr] 267 | | avatar_image: Option, [INFO] [stderr] 268 | | channel: Option, [INFO] [stderr] ... | [INFO] [stderr] 281 | | title: Option, [INFO] [stderr] 282 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/events.rs:265:5 [INFO] [stderr] | [INFO] [stderr] 265 | / DesktopNotification { [INFO] [stderr] 266 | | #[serde(rename = "avatarImage")] [INFO] [stderr] 267 | | avatar_image: Option, [INFO] [stderr] 268 | | channel: Option, [INFO] [stderr] ... | [INFO] [stderr] 281 | | title: Option, [INFO] [stderr] 282 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/events.rs:265:5 [INFO] [stderr] | [INFO] [stderr] 265 | / DesktopNotification { [INFO] [stderr] 266 | | #[serde(rename = "avatarImage")] [INFO] [stderr] 267 | | avatar_image: Option, [INFO] [stderr] 268 | | channel: Option, [INFO] [stderr] ... | [INFO] [stderr] 281 | | title: Option, [INFO] [stderr] 282 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/events.rs:265:5 [INFO] [stderr] | [INFO] [stderr] 265 | / DesktopNotification { [INFO] [stderr] 266 | | #[serde(rename = "avatarImage")] [INFO] [stderr] 267 | | avatar_image: Option, [INFO] [stderr] 268 | | channel: Option, [INFO] [stderr] ... | [INFO] [stderr] 281 | | title: Option, [INFO] [stderr] 282 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:192:14 [INFO] [stderr] | [INFO] [stderr] 192 | .ok_or(Error::Api("Slack did not provide a URL".into()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Api("Slack did not provide a URL".into()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:192:14 [INFO] [stderr] | [INFO] [stderr] 192 | .ok_or(Error::Api("Slack did not provide a URL".into()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Api("Slack did not provide a URL".into()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 05s [INFO] running `"docker" "inspect" "f35b521dd141145848325c3ceade68996953c349c1399d5fc04dc193cb3bd96d"` [INFO] running `"docker" "rm" "-f" "f35b521dd141145848325c3ceade68996953c349c1399d5fc04dc193cb3bd96d"` [INFO] [stdout] f35b521dd141145848325c3ceade68996953c349c1399d5fc04dc193cb3bd96d