[INFO] crate sl-gx 0.0.0 is already in cache [INFO] extracting crate sl-gx 0.0.0 into work/ex/clippy-test-run/sources/stable/reg/sl-gx/0.0.0 [INFO] extracting crate sl-gx 0.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sl-gx/0.0.0 [INFO] validating manifest of sl-gx-0.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sl-gx-0.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sl-gx-0.0.0 [INFO] finished frobbing sl-gx-0.0.0 [INFO] frobbed toml for sl-gx-0.0.0 written to work/ex/clippy-test-run/sources/stable/reg/sl-gx/0.0.0/Cargo.toml [INFO] started frobbing sl-gx-0.0.0 [INFO] finished frobbing sl-gx-0.0.0 [INFO] frobbed toml for sl-gx-0.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sl-gx/0.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sl-gx-0.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sl-gx/0.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 38ad049778674cb497389b6bb9645e29390bfce96397a6f35ab2e4fb2044aa06 [INFO] running `"docker" "start" "-a" "38ad049778674cb497389b6bb9645e29390bfce96397a6f35ab2e4fb2044aa06"` [INFO] [stderr] Checking sl-gx v0.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | let i = self.color_index; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | let i = self.color_index; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/font.rs:249:3 [INFO] [stderr] | [INFO] [stderr] 249 | / return match c { [INFO] [stderr] 250 | | '0' => C0, [INFO] [stderr] 251 | | '1' => C1, [INFO] [stderr] 252 | | '2' => C2, [INFO] [stderr] ... | [INFO] [stderr] 274 | | _ => "" [INFO] [stderr] 275 | | }; [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 249 | match c { [INFO] [stderr] 250 | '0' => C0, [INFO] [stderr] 251 | '1' => C1, [INFO] [stderr] 252 | '2' => C2, [INFO] [stderr] 253 | '3' => C3, [INFO] [stderr] 254 | '4' => C4, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:38:35 [INFO] [stderr] | [INFO] [stderr] 38 | const GRAY: Color = Color{value: 0x00808080}; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0080_8080` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:39:35 [INFO] [stderr] | [INFO] [stderr] 39 | const WHITE: Color = Color{value: 0x00ffffff}; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:40:35 [INFO] [stderr] | [INFO] [stderr] 40 | const BLUE: Color = Color{value: 0x00000080}; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:41:39 [INFO] [stderr] | [INFO] [stderr] 41 | const LIGHTGRAY: Color = Color{value: 0x00e4e4e0}; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00e4_e4e0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:45:45 [INFO] [stderr] | [INFO] [stderr] 45 | pub const BLACK: Color = Color{value: 0x00000000}; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:46:45 [INFO] [stderr] | [INFO] [stderr] 46 | pub const GRAY: Color = Color{value: 0x00808080}; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0080_8080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:47:45 [INFO] [stderr] | [INFO] [stderr] 47 | pub const WHITE: Color = Color{value: 0x00ffffff}; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:48:45 [INFO] [stderr] | [INFO] [stderr] 48 | pub const BLUE: Color = Color{value: 0x00000080}; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:49:45 [INFO] [stderr] | [INFO] [stderr] 49 | pub const MAGENTA: Color = Color{value: 0x00800060}; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0080_0060` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:50:45 [INFO] [stderr] | [INFO] [stderr] 50 | pub const GREEN: Color = Color{value: 0x00006000}; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_6000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:51:45 [INFO] [stderr] | [INFO] [stderr] 51 | pub const RED: Color = Color{value: 0x00a00000}; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00a0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:52:45 [INFO] [stderr] | [INFO] [stderr] 52 | pub const BROWN: Color = Color{value: 0x00808000}; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0080_8000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:53:47 [INFO] [stderr] | [INFO] [stderr] 53 | pub const LIGHTGRAY: Color = Color{value: 0x00e4e4e0}; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00e4_e4e0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | / return Canvas{buffer, px: (width/2) as isize, py: (height/2) as isize, [INFO] [stderr] 68 | | mx: 40.0, my: 40.0, wx: 10.0, wy: 10.0, x: 0.0, y: 0.0, n: 1000, [INFO] [stderr] 69 | | color: BLUE, color_index: 0 [INFO] [stderr] 70 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 67 | Canvas{buffer, px: (width/2) as isize, py: (height/2) as isize, [INFO] [stderr] 68 | mx: 40.0, my: 40.0, wx: 10.0, wy: 10.0, x: 0.0, y: 0.0, n: 1000, [INFO] [stderr] 69 | color: BLUE, color_index: 0 [INFO] [stderr] 70 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | return bv; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `bv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:190:9 [INFO] [stderr] | [INFO] [stderr] 190 | return (px,py); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `(px,py)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/font.rs:249:3 [INFO] [stderr] | [INFO] [stderr] 249 | / return match c { [INFO] [stderr] 250 | | '0' => C0, [INFO] [stderr] 251 | | '1' => C1, [INFO] [stderr] 252 | | '2' => C2, [INFO] [stderr] ... | [INFO] [stderr] 274 | | _ => "" [INFO] [stderr] 275 | | }; [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 249 | match c { [INFO] [stderr] 250 | '0' => C0, [INFO] [stderr] 251 | '1' => C1, [INFO] [stderr] 252 | '2' => C2, [INFO] [stderr] 253 | '3' => C3, [INFO] [stderr] 254 | '4' => C4, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:38:35 [INFO] [stderr] | [INFO] [stderr] 38 | const GRAY: Color = Color{value: 0x00808080}; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0080_8080` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:39:35 [INFO] [stderr] | [INFO] [stderr] 39 | const WHITE: Color = Color{value: 0x00ffffff}; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:40:35 [INFO] [stderr] | [INFO] [stderr] 40 | const BLUE: Color = Color{value: 0x00000080}; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:41:39 [INFO] [stderr] | [INFO] [stderr] 41 | const LIGHTGRAY: Color = Color{value: 0x00e4e4e0}; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00e4_e4e0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:45:45 [INFO] [stderr] | [INFO] [stderr] 45 | pub const BLACK: Color = Color{value: 0x00000000}; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:46:45 [INFO] [stderr] | [INFO] [stderr] 46 | pub const GRAY: Color = Color{value: 0x00808080}; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0080_8080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:47:45 [INFO] [stderr] | [INFO] [stderr] 47 | pub const WHITE: Color = Color{value: 0x00ffffff}; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:48:45 [INFO] [stderr] | [INFO] [stderr] 48 | pub const BLUE: Color = Color{value: 0x00000080}; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:49:45 [INFO] [stderr] | [INFO] [stderr] 49 | pub const MAGENTA: Color = Color{value: 0x00800060}; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0080_0060` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:50:45 [INFO] [stderr] | [INFO] [stderr] 50 | pub const GREEN: Color = Color{value: 0x00006000}; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_6000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:51:45 [INFO] [stderr] | [INFO] [stderr] 51 | pub const RED: Color = Color{value: 0x00a00000}; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00a0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:52:45 [INFO] [stderr] | [INFO] [stderr] 52 | pub const BROWN: Color = Color{value: 0x00808000}; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0080_8000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:53:47 [INFO] [stderr] | [INFO] [stderr] 53 | pub const LIGHTGRAY: Color = Color{value: 0x00e4e4e0}; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00e4_e4e0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | / return Canvas{buffer, px: (width/2) as isize, py: (height/2) as isize, [INFO] [stderr] 68 | | mx: 40.0, my: 40.0, wx: 10.0, wy: 10.0, x: 0.0, y: 0.0, n: 1000, [INFO] [stderr] 69 | | color: BLUE, color_index: 0 [INFO] [stderr] 70 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 67 | Canvas{buffer, px: (width/2) as isize, py: (height/2) as isize, [INFO] [stderr] 68 | mx: 40.0, my: 40.0, wx: 10.0, wy: 10.0, x: 0.0, y: 0.0, n: 1000, [INFO] [stderr] 69 | color: BLUE, color_index: 0 [INFO] [stderr] 70 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | return bv; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `bv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:190:9 [INFO] [stderr] | [INFO] [stderr] 190 | return (px,py); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `(px,py)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:33:22 [INFO] [stderr] | [INFO] [stderr] 33 | Color{value: (r as u32)<<16 | (g as u32)<<8 | (b as u32)} [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:33:39 [INFO] [stderr] | [INFO] [stderr] 33 | Color{value: (r as u32)<<16 | (g as u32)<<8 | (b as u32)} [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:33:55 [INFO] [stderr] | [INFO] [stderr] 33 | Color{value: (r as u32)<<16 | (g as u32)<<8 | (b as u32)} [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:86:22 [INFO] [stderr] | [INFO] [stderr] 86 | self.vline(x as f64,LIGHTGRAY); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:87:23 [INFO] [stderr] | [INFO] [stderr] 87 | self.vprint(x as f64-0.1, -0.1, &format!("{}",x)); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:90:22 [INFO] [stderr] | [INFO] [stderr] 90 | self.vline(x as f64,LIGHTGRAY); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:91:23 [INFO] [stderr] | [INFO] [stderr] 91 | self.vprint(x as f64-0.1, -0.1, &format!("{}",x)); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:94:22 [INFO] [stderr] | [INFO] [stderr] 94 | self.hline(y as f64,LIGHTGRAY); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:95:28 [INFO] [stderr] | [INFO] [stderr] 95 | self.vprint(0.2, y as f64+0.2, &format!("{}",y)); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:98:22 [INFO] [stderr] | [INFO] [stderr] 98 | self.hline(y as f64,LIGHTGRAY); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:99:28 [INFO] [stderr] | [INFO] [stderr] 99 | self.vprint(0.2, y as f64+0.2, &format!("{}",y)); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:212:17 [INFO] [stderr] | [INFO] [stderr] 212 | pub fn save(bv: &Vec, id: &str) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:33:22 [INFO] [stderr] | [INFO] [stderr] 33 | Color{value: (r as u32)<<16 | (g as u32)<<8 | (b as u32)} [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:33:39 [INFO] [stderr] | [INFO] [stderr] 33 | Color{value: (r as u32)<<16 | (g as u32)<<8 | (b as u32)} [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:33:55 [INFO] [stderr] | [INFO] [stderr] 33 | Color{value: (r as u32)<<16 | (g as u32)<<8 | (b as u32)} [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:86:22 [INFO] [stderr] | [INFO] [stderr] 86 | self.vline(x as f64,LIGHTGRAY); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:87:23 [INFO] [stderr] | [INFO] [stderr] 87 | self.vprint(x as f64-0.1, -0.1, &format!("{}",x)); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:90:22 [INFO] [stderr] | [INFO] [stderr] 90 | self.vline(x as f64,LIGHTGRAY); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:91:23 [INFO] [stderr] | [INFO] [stderr] 91 | self.vprint(x as f64-0.1, -0.1, &format!("{}",x)); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:94:22 [INFO] [stderr] | [INFO] [stderr] 94 | self.hline(y as f64,LIGHTGRAY); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:95:28 [INFO] [stderr] | [INFO] [stderr] 95 | self.vprint(0.2, y as f64+0.2, &format!("{}",y)); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:98:22 [INFO] [stderr] | [INFO] [stderr] 98 | self.hline(y as f64,LIGHTGRAY); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:99:28 [INFO] [stderr] | [INFO] [stderr] 99 | self.vprint(0.2, y as f64+0.2, &format!("{}",y)); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:212:17 [INFO] [stderr] | [INFO] [stderr] 212 | pub fn save(bv: &Vec, id: &str) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.89s [INFO] running `"docker" "inspect" "38ad049778674cb497389b6bb9645e29390bfce96397a6f35ab2e4fb2044aa06"` [INFO] running `"docker" "rm" "-f" "38ad049778674cb497389b6bb9645e29390bfce96397a6f35ab2e4fb2044aa06"` [INFO] [stdout] 38ad049778674cb497389b6bb9645e29390bfce96397a6f35ab2e4fb2044aa06