[INFO] crate skylane_scanner 0.1.1 is already in cache [INFO] extracting crate skylane_scanner 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/skylane_scanner/0.1.1 [INFO] extracting crate skylane_scanner 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/skylane_scanner/0.1.1 [INFO] validating manifest of skylane_scanner-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of skylane_scanner-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing skylane_scanner-0.1.1 [INFO] finished frobbing skylane_scanner-0.1.1 [INFO] frobbed toml for skylane_scanner-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/skylane_scanner/0.1.1/Cargo.toml [INFO] started frobbing skylane_scanner-0.1.1 [INFO] finished frobbing skylane_scanner-0.1.1 [INFO] frobbed toml for skylane_scanner-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/skylane_scanner/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting skylane_scanner-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/skylane_scanner/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9e69505c335ca6d61d6f4134f178f73aa30952c77c8dd0cc7bb788899619e8ab [INFO] running `"docker" "start" "-a" "9e69505c335ca6d61d6f4134f178f73aa30952c77c8dd0cc7bb788899619e8ab"` [INFO] [stderr] Checking skylane_scanner v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner.rs:195:16 [INFO] [stderr] | [INFO] [stderr] 195 | Text { text: text } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner.rs:216:13 [INFO] [stderr] | [INFO] [stderr] 216 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner.rs:250:13 [INFO] [stderr] | [INFO] [stderr] 250 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner.rs:251:13 [INFO] [stderr] | [INFO] [stderr] 251 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | rust_type: rust_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rust_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner.rs:294:13 [INFO] [stderr] | [INFO] [stderr] 294 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner.rs:315:13 [INFO] [stderr] | [INFO] [stderr] 315 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner.rs:316:13 [INFO] [stderr] | [INFO] [stderr] 316 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner.rs:459:13 [INFO] [stderr] | [INFO] [stderr] 459 | indent: indent, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `indent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner.rs:1336:22 [INFO] [stderr] | [INFO] [stderr] 1336 | Aggregator { parser: parser } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner.rs:195:16 [INFO] [stderr] | [INFO] [stderr] 195 | Text { text: text } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner.rs:216:13 [INFO] [stderr] | [INFO] [stderr] 216 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner.rs:250:13 [INFO] [stderr] | [INFO] [stderr] 250 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner.rs:251:13 [INFO] [stderr] | [INFO] [stderr] 251 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | rust_type: rust_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rust_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner.rs:294:13 [INFO] [stderr] | [INFO] [stderr] 294 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner.rs:315:13 [INFO] [stderr] | [INFO] [stderr] 315 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner.rs:316:13 [INFO] [stderr] | [INFO] [stderr] 316 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner.rs:459:13 [INFO] [stderr] | [INFO] [stderr] 459 | indent: indent, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `indent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner.rs:1336:22 [INFO] [stderr] | [INFO] [stderr] 1336 | Aggregator { parser: parser } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scanner.rs:110:38 [INFO] [stderr] | [INFO] [stderr] 110 | pub fn from_arguments(arguments: &Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Argument]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/scanner.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | self.names.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.names.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/scanner.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | / match variable_type { [INFO] [stderr] 142 | | &VariableType::String(_) => return true, [INFO] [stderr] 143 | | _ => (), [INFO] [stderr] 144 | | } [INFO] [stderr] | |_____________^ help: try this: `if let &VariableType::String(_) = variable_type { return true }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/scanner.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | / match variable_type { [INFO] [stderr] 142 | | &VariableType::String(_) => return true, [INFO] [stderr] 143 | | _ => (), [INFO] [stderr] 144 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 141 | match *variable_type { [INFO] [stderr] 142 | VariableType::String(_) => return true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/scanner.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | for ref mut interface in self.interfaces.iter_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ -------------------------- help: try: `let interface = &mut self.interfaces.iter_mut();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/scanner.rs:393:21 [INFO] [stderr] | [INFO] [stderr] 393 | pub fn get_size(&self) -> Size { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scanner.rs:413:45 [INFO] [stderr] | [INFO] [stderr] 413 | pub fn get_attr(name: &str, attributes: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scanner.rs:423:54 [INFO] [stderr] | [INFO] [stderr] 423 | pub fn get_optional_attr(name: &str, attributes: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scanner.rs:1206:32 [INFO] [stderr] | [INFO] [stderr] 1206 | arguments: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Argument]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/scanner.rs:1232:12 [INFO] [stderr] | [INFO] [stderr] 1232 | if arguments.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!arguments.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/scanner.rs:1280:9 [INFO] [stderr] | [INFO] [stderr] 1280 | interface.events.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!interface.events.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/scanner.rs:1310:9 [INFO] [stderr] | [INFO] [stderr] 1310 | interface.events.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!interface.events.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scanner.rs:1447:40 [INFO] [stderr] | [INFO] [stderr] 1447 | attributes: &Vec) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scanner.rs:1492:38 [INFO] [stderr] | [INFO] [stderr] 1492 | attributes: &Vec) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scanner.rs:1533:36 [INFO] [stderr] | [INFO] [stderr] 1533 | attributes: &Vec) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scanner.rs:1572:46 [INFO] [stderr] | [INFO] [stderr] 1572 | fn aggregate_enum(&mut self, attributes: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scanner.rs:1610:46 [INFO] [stderr] | [INFO] [stderr] 1610 | fn aggregate_protocol(&self, attributes: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scanner.rs:1615:46 [INFO] [stderr] | [INFO] [stderr] 1615 | fn aggregate_argument(&self, attributes: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scanner.rs:1622:43 [INFO] [stderr] | [INFO] [stderr] 1622 | fn aggregate_entry(&self, attributes: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scanner.rs:110:38 [INFO] [stderr] | [INFO] [stderr] 110 | pub fn from_arguments(arguments: &Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Argument]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/scanner.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | self.names.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.names.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/scanner.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | / match variable_type { [INFO] [stderr] 142 | | &VariableType::String(_) => return true, [INFO] [stderr] 143 | | _ => (), [INFO] [stderr] 144 | | } [INFO] [stderr] | |_____________^ help: try this: `if let &VariableType::String(_) = variable_type { return true }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/scanner.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | / match variable_type { [INFO] [stderr] 142 | | &VariableType::String(_) => return true, [INFO] [stderr] 143 | | _ => (), [INFO] [stderr] 144 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 141 | match *variable_type { [INFO] [stderr] 142 | VariableType::String(_) => return true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/scanner.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | for ref mut interface in self.interfaces.iter_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ -------------------------- help: try: `let interface = &mut self.interfaces.iter_mut();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/scanner.rs:393:21 [INFO] [stderr] | [INFO] [stderr] 393 | pub fn get_size(&self) -> Size { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scanner.rs:413:45 [INFO] [stderr] | [INFO] [stderr] 413 | pub fn get_attr(name: &str, attributes: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scanner.rs:423:54 [INFO] [stderr] | [INFO] [stderr] 423 | pub fn get_optional_attr(name: &str, attributes: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scanner.rs:1206:32 [INFO] [stderr] | [INFO] [stderr] 1206 | arguments: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Argument]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/scanner.rs:1232:12 [INFO] [stderr] | [INFO] [stderr] 1232 | if arguments.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!arguments.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/scanner.rs:1280:9 [INFO] [stderr] | [INFO] [stderr] 1280 | interface.events.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!interface.events.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/scanner.rs:1310:9 [INFO] [stderr] | [INFO] [stderr] 1310 | interface.events.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!interface.events.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scanner.rs:1447:40 [INFO] [stderr] | [INFO] [stderr] 1447 | attributes: &Vec) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scanner.rs:1492:38 [INFO] [stderr] | [INFO] [stderr] 1492 | attributes: &Vec) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scanner.rs:1533:36 [INFO] [stderr] | [INFO] [stderr] 1533 | attributes: &Vec) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scanner.rs:1572:46 [INFO] [stderr] | [INFO] [stderr] 1572 | fn aggregate_enum(&mut self, attributes: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scanner.rs:1610:46 [INFO] [stderr] | [INFO] [stderr] 1610 | fn aggregate_protocol(&self, attributes: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scanner.rs:1615:46 [INFO] [stderr] | [INFO] [stderr] 1615 | fn aggregate_argument(&self, attributes: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scanner.rs:1622:43 [INFO] [stderr] | [INFO] [stderr] 1622 | fn aggregate_entry(&self, attributes: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/bin.rs:34:22 [INFO] [stderr] | [INFO] [stderr] 34 | .expect(format!("Initialize scanner for file {:?}", &path).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Initialize scanner for file {:?}", &path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/bin.rs:34:22 [INFO] [stderr] | [INFO] [stderr] 34 | .expect(format!("Initialize scanner for file {:?}", &path).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Initialize scanner for file {:?}", &path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.14s [INFO] running `"docker" "inspect" "9e69505c335ca6d61d6f4134f178f73aa30952c77c8dd0cc7bb788899619e8ab"` [INFO] running `"docker" "rm" "-f" "9e69505c335ca6d61d6f4134f178f73aa30952c77c8dd0cc7bb788899619e8ab"` [INFO] [stdout] 9e69505c335ca6d61d6f4134f178f73aa30952c77c8dd0cc7bb788899619e8ab