[INFO] crate skylane 0.1.2 is already in cache [INFO] extracting crate skylane 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/skylane/0.1.2 [INFO] extracting crate skylane 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/skylane/0.1.2 [INFO] validating manifest of skylane-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of skylane-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing skylane-0.1.2 [INFO] finished frobbing skylane-0.1.2 [INFO] frobbed toml for skylane-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/skylane/0.1.2/Cargo.toml [INFO] started frobbing skylane-0.1.2 [INFO] finished frobbing skylane-0.1.2 [INFO] frobbed toml for skylane-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/skylane/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting skylane-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/skylane/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3b201a50ec9028e600d12cffe40388b7e3bb3681879dc2dd1320f07d9c30e2f6 [INFO] running `"docker" "start" "-a" "3b201a50ec9028e600d12cffe40388b7e3bb3681879dc2dd1320f07d9c30e2f6"` [INFO] [stderr] Checking nix v0.8.1 [INFO] [stderr] Checking skylane v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bundle.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bundle.rs:146:45 [INFO] [stderr] | [INFO] [stderr] 146 | Err(SkylaneError::WrongObject { object_id: object_id }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `object_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | bundle: bundle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bundle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sockets.rs:186:13 [INFO] [stderr] | [INFO] [stderr] 186 | fd: fd, [INFO] [stderr] | ^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bundle.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bundle.rs:146:45 [INFO] [stderr] | [INFO] [stderr] 146 | Err(SkylaneError::WrongObject { object_id: object_id }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `object_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | bundle: bundle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bundle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sockets.rs:186:13 [INFO] [stderr] | [INFO] [stderr] 186 | fd: fd, [INFO] [stderr] | ^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/object.rs:70:48 [INFO] [stderr] | [INFO] [stderr] 70 | pub const SERVER_START_ID: ObjectId = ObjectId(0xff000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xff00_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/object.rs:70:48 [INFO] [stderr] | [INFO] [stderr] 70 | pub const SERVER_START_ID: ObjectId = ObjectId(0xff000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xff00_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/connection.rs:201:22 [INFO] [stderr] | [INFO] [stderr] 201 | mut bytes_buf: &mut Cursor<&[u8]>, [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/connection.rs:202:22 [INFO] [stderr] | [INFO] [stderr] 202 | mut fds_buf: &mut Cursor<&[u8]>) [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/object.rs:38:22 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn get_value(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/object.rs:43:24 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn incremented(&self) -> ObjectId { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/object.rs:48:20 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn is_null(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/bundle.rs:34:14 [INFO] [stderr] | [INFO] [stderr] 34 | objects: Rc>>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: The function/method `socket::recvmsg` doesn't need a mutable reference [INFO] [stderr] --> src/sockets.rs:142:44 [INFO] [stderr] | [INFO] [stderr] 142 | let msg = socket::recvmsg(self.fd, &mut iov[..], Some(&mut cmsg), socket::MSG_DONTWAIT)?; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/sockets.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | / match cmsg { [INFO] [stderr] 148 | | socket::ControlMessage::ScmRights(newfds) => { [INFO] [stderr] 149 | | buf.write_i32::(newfds[0])?; [INFO] [stderr] 150 | | num_fds += 1; [INFO] [stderr] 151 | | } [INFO] [stderr] 152 | | _ => {} [INFO] [stderr] 153 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 147 | if let socket::ControlMessage::ScmRights(newfds) = cmsg { [INFO] [stderr] 148 | buf.write_i32::(newfds[0])?; [INFO] [stderr] 149 | num_fds += 1; [INFO] [stderr] 150 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/connection.rs:201:22 [INFO] [stderr] | [INFO] [stderr] 201 | mut bytes_buf: &mut Cursor<&[u8]>, [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/connection.rs:202:22 [INFO] [stderr] | [INFO] [stderr] 202 | mut fds_buf: &mut Cursor<&[u8]>) [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/object.rs:38:22 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn get_value(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/object.rs:43:24 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn incremented(&self) -> ObjectId { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/object.rs:48:20 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn is_null(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/bundle.rs:34:14 [INFO] [stderr] | [INFO] [stderr] 34 | objects: Rc>>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: The function/method `socket::recvmsg` doesn't need a mutable reference [INFO] [stderr] --> src/sockets.rs:142:44 [INFO] [stderr] | [INFO] [stderr] 142 | let msg = socket::recvmsg(self.fd, &mut iov[..], Some(&mut cmsg), socket::MSG_DONTWAIT)?; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/sockets.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | / match cmsg { [INFO] [stderr] 148 | | socket::ControlMessage::ScmRights(newfds) => { [INFO] [stderr] 149 | | buf.write_i32::(newfds[0])?; [INFO] [stderr] 150 | | num_fds += 1; [INFO] [stderr] 151 | | } [INFO] [stderr] 152 | | _ => {} [INFO] [stderr] 153 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 147 | if let socket::ControlMessage::ScmRights(newfds) = cmsg { [INFO] [stderr] 148 | buf.write_i32::(newfds[0])?; [INFO] [stderr] 149 | num_fds += 1; [INFO] [stderr] 150 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.06s [INFO] running `"docker" "inspect" "3b201a50ec9028e600d12cffe40388b7e3bb3681879dc2dd1320f07d9c30e2f6"` [INFO] running `"docker" "rm" "-f" "3b201a50ec9028e600d12cffe40388b7e3bb3681879dc2dd1320f07d9c30e2f6"` [INFO] [stdout] 3b201a50ec9028e600d12cffe40388b7e3bb3681879dc2dd1320f07d9c30e2f6