[INFO] crate skullrump 0.1.0 is already in cache [INFO] extracting crate skullrump 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/skullrump/0.1.0 [INFO] extracting crate skullrump 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/skullrump/0.1.0 [INFO] validating manifest of skullrump-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of skullrump-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing skullrump-0.1.0 [INFO] finished frobbing skullrump-0.1.0 [INFO] frobbed toml for skullrump-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/skullrump/0.1.0/Cargo.toml [INFO] started frobbing skullrump-0.1.0 [INFO] finished frobbing skullrump-0.1.0 [INFO] frobbed toml for skullrump-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/skullrump/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting skullrump-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/skullrump/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a441fb5966aed5e0dde78cd7bac33fcc6d82c7699db49f3376c47265bde42e73 [INFO] running `"docker" "start" "-a" "a441fb5966aed5e0dde78cd7bac33fcc6d82c7699db49f3376c47265bde42e73"` [INFO] [stderr] Checking skullrump v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/skullrump.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | return Ok(entries); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(entries)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/skullrump.rs:46:15 [INFO] [stderr] | [INFO] [stderr] 46 | .and(Ok(buffer_out.clear())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 46 | .and(Ok(())) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/skullrump.rs:90:16 [INFO] [stderr] | [INFO] [stderr] 90 | if let Err(_) = self.seek(SeekFrom::End(-tail_position)) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 91 | | StreamFlow::Forward [INFO] [stderr] 92 | | } else { [INFO] [stderr] 93 | | StreamFlow::Backward [INFO] [stderr] 94 | | } [INFO] [stderr] | |_________- help: try this: `if self.seek(SeekFrom::End(-tail_position)).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/skullrump.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | return Ok(entries); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(entries)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:92:7 [INFO] [stderr] | [INFO] [stderr] 92 | return Ok(CustomType(p1, p2)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(CustomType(p1, p2))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/skullrump.rs:46:15 [INFO] [stderr] | [INFO] [stderr] 46 | .and(Ok(buffer_out.clear())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 46 | .and(Ok(())) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/skullrump.rs:90:16 [INFO] [stderr] | [INFO] [stderr] 90 | if let Err(_) = self.seek(SeekFrom::End(-tail_position)) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 91 | | StreamFlow::Forward [INFO] [stderr] 92 | | } else { [INFO] [stderr] 93 | | StreamFlow::Backward [INFO] [stderr] 94 | | } [INFO] [stderr] | |_________- help: try this: `if self.seek(SeekFrom::End(-tail_position)).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:147:23 [INFO] [stderr] | [INFO] [stderr] 147 | assert_eq!(1i64, *(result.get(0).unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&result[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:148:23 [INFO] [stderr] | [INFO] [stderr] 148 | assert_eq!(2i64, *(result.get(1).unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&result[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:166:23 [INFO] [stderr] | [INFO] [stderr] 166 | assert_eq!(1i64, *(result.get(0).unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&result[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:167:23 [INFO] [stderr] | [INFO] [stderr] 167 | assert_eq!(2i64, *(result.get(1).unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&result[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:200:23 [INFO] [stderr] | [INFO] [stderr] 200 | assert_eq!(1i64, *(result.get(0).unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&result[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:201:23 [INFO] [stderr] | [INFO] [stderr] 201 | assert_eq!(2i64, *(result.get(1).unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&result[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:234:23 [INFO] [stderr] | [INFO] [stderr] 234 | assert_eq!(1i64, *(result.get(0).unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&result[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:235:23 [INFO] [stderr] | [INFO] [stderr] 235 | assert_eq!(2i64, *(result.get(1).unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&result[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.01s [INFO] running `"docker" "inspect" "a441fb5966aed5e0dde78cd7bac33fcc6d82c7699db49f3376c47265bde42e73"` [INFO] running `"docker" "rm" "-f" "a441fb5966aed5e0dde78cd7bac33fcc6d82c7699db49f3376c47265bde42e73"` [INFO] [stdout] a441fb5966aed5e0dde78cd7bac33fcc6d82c7699db49f3376c47265bde42e73