[INFO] crate skimmer 0.0.2 is already in cache [INFO] extracting crate skimmer 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/skimmer/0.0.2 [INFO] extracting crate skimmer 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/skimmer/0.0.2 [INFO] validating manifest of skimmer-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of skimmer-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing skimmer-0.0.2 [INFO] finished frobbing skimmer-0.0.2 [INFO] frobbed toml for skimmer-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/skimmer/0.0.2/Cargo.toml [INFO] started frobbing skimmer-0.0.2 [INFO] finished frobbing skimmer-0.0.2 [INFO] frobbed toml for skimmer-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/skimmer/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting skimmer-0.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/skimmer/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dab6215e84dd15faf0e432839bd204adc75526e22f5cf0301db91d104f0c83fa [INFO] running `"docker" "start" "-a" "dab6215e84dd15faf0e432839bd204adc75526e22f5cf0301db91d104f0c83fa"` [INFO] [stderr] Checking skimmer v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/marker.rs:11:18 [INFO] [stderr] | [INFO] [stderr] 11 | Marker { pos1: pos1, pos2: pos2 } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pos1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/marker.rs:11:30 [INFO] [stderr] | [INFO] [stderr] 11 | Marker { pos1: pos1, pos2: pos2 } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pos2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/marker.rs:11:18 [INFO] [stderr] | [INFO] [stderr] 11 | Marker { pos1: pos1, pos2: pos2 } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pos1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/marker.rs:11:30 [INFO] [stderr] | [INFO] [stderr] 11 | Marker { pos1: pos1, pos2: pos2 } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pos2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: trait `Datum` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/data.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | / pub trait Datum : Clone + Debug { [INFO] [stderr] 8 | | fn len (&self) -> usize; [INFO] [stderr] 9 | | [INFO] [stderr] 10 | | fn as_slice (&self) -> &[u8]; [INFO] [stderr] 11 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/data.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | let ref datum = self.data[marker.pos1.0]; [INFO] [stderr] | ----^^^^^^^^^---------------------------- help: try: `let datum = &self.data[marker.pos1.0];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/data.rs:68:25 [INFO] [stderr] | [INFO] [stderr] 68 | let ref datum = self.data[pos2.0]; [INFO] [stderr] | ----^^^^^^^^^--------------------- help: try: `let datum = &self.data[pos2.0];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/data.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | / fn _chunk_slice<'a> (&'a self, datum_idx: usize, start: usize, end: usize) -> Chunk<'a> { [INFO] [stderr] 92 | | Chunk::Slice (&self.data[datum_idx].as_slice ()[start .. end]) [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/reader/slice_reader.rs:126:59 [INFO] [stderr] | [INFO] [stderr] 126 | fn get_byte_at (&mut self, at: usize) -> Option { self.content.content.get (self.pointer + at).map (|b| *b) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.content.content.get (self.pointer + at).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/reader/slice_reader.rs:129:54 [INFO] [stderr] | [INFO] [stderr] 129 | fn get_byte_at_start (&mut self) -> Option { self.content.content.get (self.pointer).map (|b| *b) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.content.content.get (self.pointer).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/reader/bytes_reader.rs:135:59 [INFO] [stderr] | [INFO] [stderr] 135 | fn get_byte_at (&mut self, at: usize) -> Option { self.content.content.get (self.pointer + at).map (|b| *b) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.content.content.get (self.pointer + at).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/reader/bytes_reader.rs:138:54 [INFO] [stderr] | [INFO] [stderr] 138 | fn get_byte_at_start (&mut self) -> Option { self.content.content.get (self.pointer).map (|b| *b) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.content.content.get (self.pointer).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/reader/ioreadeof_reader.rs:142:59 [INFO] [stderr] | [INFO] [stderr] 142 | fn get_byte_at (&mut self, at: usize) -> Option { self.content.content.get (self.pointer + at).map (|b| *b) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.content.content.get (self.pointer + at).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/reader/ioreadeof_reader.rs:145:54 [INFO] [stderr] | [INFO] [stderr] 145 | fn get_byte_at_start (&mut self) -> Option { self.content.content.get (self.pointer).map (|b| *b) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.content.content.get (self.pointer).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: trait `Datum` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/data.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | / pub trait Datum : Clone + Debug { [INFO] [stderr] 8 | | fn len (&self) -> usize; [INFO] [stderr] 9 | | [INFO] [stderr] 10 | | fn as_slice (&self) -> &[u8]; [INFO] [stderr] 11 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/data.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | let ref datum = self.data[marker.pos1.0]; [INFO] [stderr] | ----^^^^^^^^^---------------------------- help: try: `let datum = &self.data[marker.pos1.0];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/data.rs:68:25 [INFO] [stderr] | [INFO] [stderr] 68 | let ref datum = self.data[pos2.0]; [INFO] [stderr] | ----^^^^^^^^^--------------------- help: try: `let datum = &self.data[pos2.0];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/data.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | / fn _chunk_slice<'a> (&'a self, datum_idx: usize, start: usize, end: usize) -> Chunk<'a> { [INFO] [stderr] 92 | | Chunk::Slice (&self.data[datum_idx].as_slice ()[start .. end]) [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/reader/slice_reader.rs:126:59 [INFO] [stderr] | [INFO] [stderr] 126 | fn get_byte_at (&mut self, at: usize) -> Option { self.content.content.get (self.pointer + at).map (|b| *b) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.content.content.get (self.pointer + at).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/reader/slice_reader.rs:129:54 [INFO] [stderr] | [INFO] [stderr] 129 | fn get_byte_at_start (&mut self) -> Option { self.content.content.get (self.pointer).map (|b| *b) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.content.content.get (self.pointer).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/reader/bytes_reader.rs:135:59 [INFO] [stderr] | [INFO] [stderr] 135 | fn get_byte_at (&mut self, at: usize) -> Option { self.content.content.get (self.pointer + at).map (|b| *b) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.content.content.get (self.pointer + at).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/reader/bytes_reader.rs:138:54 [INFO] [stderr] | [INFO] [stderr] 138 | fn get_byte_at_start (&mut self) -> Option { self.content.content.get (self.pointer).map (|b| *b) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.content.content.get (self.pointer).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/reader/ioreadeof_reader.rs:142:59 [INFO] [stderr] | [INFO] [stderr] 142 | fn get_byte_at (&mut self, at: usize) -> Option { self.content.content.get (self.pointer + at).map (|b| *b) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.content.content.get (self.pointer + at).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/reader/ioreadeof_reader.rs:145:54 [INFO] [stderr] | [INFO] [stderr] 145 | fn get_byte_at_start (&mut self) -> Option { self.content.content.get (self.pointer).map (|b| *b) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.content.content.get (self.pointer).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.07s [INFO] running `"docker" "inspect" "dab6215e84dd15faf0e432839bd204adc75526e22f5cf0301db91d104f0c83fa"` [INFO] running `"docker" "rm" "-f" "dab6215e84dd15faf0e432839bd204adc75526e22f5cf0301db91d104f0c83fa"` [INFO] [stdout] dab6215e84dd15faf0e432839bd204adc75526e22f5cf0301db91d104f0c83fa