[INFO] crate skeptic 0.13.4 is already in cache [INFO] extracting crate skeptic 0.13.4 into work/ex/clippy-test-run/sources/stable/reg/skeptic/0.13.4 [INFO] extracting crate skeptic 0.13.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/skeptic/0.13.4 [INFO] validating manifest of skeptic-0.13.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of skeptic-0.13.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing skeptic-0.13.4 [INFO] finished frobbing skeptic-0.13.4 [INFO] frobbed toml for skeptic-0.13.4 written to work/ex/clippy-test-run/sources/stable/reg/skeptic/0.13.4/Cargo.toml [INFO] started frobbing skeptic-0.13.4 [INFO] finished frobbing skeptic-0.13.4 [INFO] frobbed toml for skeptic-0.13.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/skeptic/0.13.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting skeptic-0.13.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/skeptic/0.13.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a15aee1ab31766b4e6e73182cee96a1829bc7ec92b5b3147f2e189478f221138 [INFO] running `"docker" "start" "-a" "a15aee1ab31766b4e6e73182cee96a1829bc7ec92b5b3147f2e189478f221138"` [INFO] [stderr] Checking unindent v0.1.3 [INFO] [stderr] Checking semver v0.9.0 [INFO] [stderr] Checking cargo_metadata v0.6.4 [INFO] [stderr] Checking skeptic v0.13.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | out_file: out_file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `out_file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | docs: docs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `docs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:166:23 [INFO] [stderr] | [INFO] [stderr] 166 | Ok(DocTestSuite { doc_tests: doc_tests }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `doc_tests` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:190:9 [INFO] [stderr] | [INFO] [stderr] 190 | templates: templates, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `templates` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:251:29 [INFO] [stderr] | [INFO] [stderr] 251 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> lib.rs:461:9 [INFO] [stderr] | [INFO] [stderr] 461 | "\n", [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(s, "")` [INFO] [stderr] --> lib.rs:486:5 [INFO] [stderr] | [INFO] [stderr] 486 | writeln!(s, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(s)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:642:17 [INFO] [stderr] | [INFO] [stderr] 642 | rlib: rlib, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rlib` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:643:17 [INFO] [stderr] | [INFO] [stderr] 643 | mtime: mtime, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `mtime` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | out_file: out_file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `out_file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | docs: docs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `docs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:166:23 [INFO] [stderr] | [INFO] [stderr] 166 | Ok(DocTestSuite { doc_tests: doc_tests }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `doc_tests` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:190:9 [INFO] [stderr] | [INFO] [stderr] 190 | templates: templates, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `templates` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:251:29 [INFO] [stderr] | [INFO] [stderr] 251 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> lib.rs:461:9 [INFO] [stderr] | [INFO] [stderr] 461 | "\n", [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(s, "")` [INFO] [stderr] --> lib.rs:486:5 [INFO] [stderr] | [INFO] [stderr] 486 | writeln!(s, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(s)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:642:17 [INFO] [stderr] | [INFO] [stderr] 642 | rlib: rlib, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rlib` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:643:17 [INFO] [stderr] | [INFO] [stderr] 643 | mtime: mtime, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `mtime` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> lib.rs:399:62 [INFO] [stderr] | [INFO] [stderr] 399 | let template = doc_test.templates.get(t).expect(&format!( [INFO] [stderr] | ______________________________________________________________^ [INFO] [stderr] 400 | | "template {} not found for {}", [INFO] [stderr] 401 | | t, [INFO] [stderr] 402 | | doc_test.path.display() [INFO] [stderr] 403 | | )); [INFO] [stderr] | |______________________^ help: try this: `unwrap_or_else(|| panic!("template {} not found for {}", t))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `write!(stdout(), ...).unwrap()`. Consider using `print!` instead [INFO] [stderr] --> lib.rs:844:9 [INFO] [stderr] | [INFO] [stderr] 844 | / write!( [INFO] [stderr] 845 | | io::stdout(), [INFO] [stderr] 846 | | "{}", [INFO] [stderr] 847 | | String::from_utf8(output.stdout).unwrap() [INFO] [stderr] 848 | | ).unwrap(); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `write!(stderr(), ...).unwrap()`. Consider using `eprint!` instead [INFO] [stderr] --> lib.rs:849:9 [INFO] [stderr] | [INFO] [stderr] 849 | / write!( [INFO] [stderr] 850 | | io::stderr(), [INFO] [stderr] 851 | | "{}", [INFO] [stderr] 852 | | String::from_utf8(output.stderr).unwrap() [INFO] [stderr] 853 | | ).unwrap(); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> lib.rs:399:62 [INFO] [stderr] | [INFO] [stderr] 399 | let template = doc_test.templates.get(t).expect(&format!( [INFO] [stderr] | ______________________________________________________________^ [INFO] [stderr] 400 | | "template {} not found for {}", [INFO] [stderr] 401 | | t, [INFO] [stderr] 402 | | doc_test.path.display() [INFO] [stderr] 403 | | )); [INFO] [stderr] | |______________________^ help: try this: `unwrap_or_else(|| panic!("template {} not found for {}", t))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `write!(stdout(), ...).unwrap()`. Consider using `print!` instead [INFO] [stderr] --> lib.rs:844:9 [INFO] [stderr] | [INFO] [stderr] 844 | / write!( [INFO] [stderr] 845 | | io::stdout(), [INFO] [stderr] 846 | | "{}", [INFO] [stderr] 847 | | String::from_utf8(output.stdout).unwrap() [INFO] [stderr] 848 | | ).unwrap(); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `write!(stderr(), ...).unwrap()`. Consider using `eprint!` instead [INFO] [stderr] --> lib.rs:849:9 [INFO] [stderr] | [INFO] [stderr] 849 | / write!( [INFO] [stderr] 850 | | io::stderr(), [INFO] [stderr] 851 | | "{}", [INFO] [stderr] 852 | | String::from_utf8(output.stderr).unwrap() [INFO] [stderr] 853 | | ).unwrap(); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> lib.rs:954:18 [INFO] [stderr] | [INFO] [stderr] 954 | .map(|test| get_line_number_from_test_name(test)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `get_line_number_from_test_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> lib.rs:997:18 [INFO] [stderr] | [INFO] [stderr] 997 | .map(|test| get_line_number_from_test_name(test)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `get_line_number_from_test_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.67s [INFO] running `"docker" "inspect" "a15aee1ab31766b4e6e73182cee96a1829bc7ec92b5b3147f2e189478f221138"` [INFO] running `"docker" "rm" "-f" "a15aee1ab31766b4e6e73182cee96a1829bc7ec92b5b3147f2e189478f221138"` [INFO] [stdout] a15aee1ab31766b4e6e73182cee96a1829bc7ec92b5b3147f2e189478f221138