[INFO] crate sion-rs 0.1.1 is already in cache
[INFO] extracting crate sion-rs 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/sion-rs/0.1.1
[INFO] extracting crate sion-rs 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sion-rs/0.1.1
[INFO] validating manifest of sion-rs-0.1.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of sion-rs-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing sion-rs-0.1.1
[INFO] finished frobbing sion-rs-0.1.1
[INFO] frobbed toml for sion-rs-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/sion-rs/0.1.1/Cargo.toml
[INFO] started frobbing sion-rs-0.1.1
[INFO] finished frobbing sion-rs-0.1.1
[INFO] frobbed toml for sion-rs-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sion-rs/0.1.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting sion-rs-0.1.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sion-rs/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 3acad197d90f1744c1e2da7bb4f4928a103fed3424a6c2a21acffab453adf8a8
[INFO] running `"docker" "start" "-a" "3acad197d90f1744c1e2da7bb4f4928a103fed3424a6c2a21acffab453adf8a8"`
[INFO] [stderr]     Checking sion-rs v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/number.rs:532:32
[INFO] [stderr]     |
[INFO] [stderr] 532 |         assert_eq!(result, Int(1234567890));
[INFO] [stderr]     |                                ^^^^^^^^^^ help: consider: `1_234_567_890`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/number.rs:545:35
[INFO] [stderr]     |
[INFO] [stderr] 545 |         assert_eq!(result, Double(1234.567890));
[INFO] [stderr]     |                                   ^^^^^^^^^^^ help: consider: `1_234.567_890`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/de.rs:73:29
[INFO] [stderr]    |
[INFO] [stderr] 73 |         while let Some(c) = chars.next() {
[INFO] [stderr]    |                             ^^^^^^^^^^^^ help: try: `for c in chars { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/number.rs:100:14
[INFO] [stderr]     |
[INFO] [stderr] 100 |     fn radix(&self) -> u32 {
[INFO] [stderr]     |              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/number.rs:108:20
[INFO] [stderr]     |
[INFO] [stderr] 108 |     fn is_exponent(&self, c: char) -> bool {
[INFO] [stderr]     |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/number.rs:116:17
[INFO] [stderr]     |
[INFO] [stderr] 116 |     fn exponent(&self) -> u32 {
[INFO] [stderr]     |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/number.rs:249:34
[INFO] [stderr]     |
[INFO] [stderr] 249 |         while let Some((i, c)) = char_indices.next() {
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^ help: try: `for (i, c) in char_indices { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/ser.rs:201:35
[INFO] [stderr]     |
[INFO] [stderr] 201 |         if !self.output.ends_with("[") {
[INFO] [stderr]     |                                   ^^^ help: try using a char instead: `'['`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/ser.rs:221:35
[INFO] [stderr]     |
[INFO] [stderr] 221 |         if !self.output.ends_with("[") {
[INFO] [stderr]     |                                   ^^^ help: try using a char instead: `'['`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/ser.rs:241:35
[INFO] [stderr]     |
[INFO] [stderr] 241 |         if !self.output.ends_with("[") {
[INFO] [stderr]     |                                   ^^^ help: try using a char instead: `'['`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/ser.rs:261:35
[INFO] [stderr]     |
[INFO] [stderr] 261 |         if !self.output.ends_with("[") {
[INFO] [stderr]     |                                   ^^^ help: try using a char instead: `'['`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/ser.rs:281:35
[INFO] [stderr]     |
[INFO] [stderr] 281 |         if !self.output.ends_with("[") {
[INFO] [stderr]     |                                   ^^^ help: try using a char instead: `'['`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/ser.rs:296:34
[INFO] [stderr]     |
[INFO] [stderr] 296 |         if self.output.ends_with("[") {
[INFO] [stderr]     |                                  ^^^ help: try using a char instead: `'['`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/ser.rs:312:35
[INFO] [stderr]     |
[INFO] [stderr] 312 |         if !self.output.ends_with("[") {
[INFO] [stderr]     |                                   ^^^ help: try using a char instead: `'['`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/ser.rs:321:34
[INFO] [stderr]     |
[INFO] [stderr] 321 |         if self.output.ends_with("[") {
[INFO] [stderr]     |                                  ^^^ help: try using a char instead: `'['`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/ser.rs:337:35
[INFO] [stderr]     |
[INFO] [stderr] 337 |         if !self.output.ends_with("[") {
[INFO] [stderr]     |                                   ^^^ help: try using a char instead: `'['`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/ser.rs:346:34
[INFO] [stderr]     |
[INFO] [stderr] 346 |         if self.output.ends_with("[") {
[INFO] [stderr]     |                                  ^^^ help: try using a char instead: `'['`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/value/de.rs:38:31
[INFO] [stderr]    |
[INFO] [stderr] 38 |                 Ok(Value::Int(i64::from(value)))
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^ help: consider removing `i64::from()`: `value`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/de.rs:73:29
[INFO] [stderr]    |
[INFO] [stderr] 73 |         while let Some(c) = chars.next() {
[INFO] [stderr]    |                             ^^^^^^^^^^^^ help: try: `for c in chars { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/number.rs:100:14
[INFO] [stderr]     |
[INFO] [stderr] 100 |     fn radix(&self) -> u32 {
[INFO] [stderr]     |              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/number.rs:108:20
[INFO] [stderr]     |
[INFO] [stderr] 108 |     fn is_exponent(&self, c: char) -> bool {
[INFO] [stderr]     |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/number.rs:116:17
[INFO] [stderr]     |
[INFO] [stderr] 116 |     fn exponent(&self) -> u32 {
[INFO] [stderr]     |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/number.rs:249:34
[INFO] [stderr]     |
[INFO] [stderr] 249 |         while let Some((i, c)) = char_indices.next() {
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^ help: try: `for (i, c) in char_indices { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/ser.rs:201:35
[INFO] [stderr]     |
[INFO] [stderr] 201 |         if !self.output.ends_with("[") {
[INFO] [stderr]     |                                   ^^^ help: try using a char instead: `'['`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/ser.rs:221:35
[INFO] [stderr]     |
[INFO] [stderr] 221 |         if !self.output.ends_with("[") {
[INFO] [stderr]     |                                   ^^^ help: try using a char instead: `'['`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/ser.rs:241:35
[INFO] [stderr]     |
[INFO] [stderr] 241 |         if !self.output.ends_with("[") {
[INFO] [stderr]     |                                   ^^^ help: try using a char instead: `'['`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/ser.rs:261:35
[INFO] [stderr]     |
[INFO] [stderr] 261 |         if !self.output.ends_with("[") {
[INFO] [stderr]     |                                   ^^^ help: try using a char instead: `'['`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/ser.rs:281:35
[INFO] [stderr]     |
[INFO] [stderr] 281 |         if !self.output.ends_with("[") {
[INFO] [stderr]     |                                   ^^^ help: try using a char instead: `'['`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/ser.rs:296:34
[INFO] [stderr]     |
[INFO] [stderr] 296 |         if self.output.ends_with("[") {
[INFO] [stderr]     |                                  ^^^ help: try using a char instead: `'['`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/ser.rs:312:35
[INFO] [stderr]     |
[INFO] [stderr] 312 |         if !self.output.ends_with("[") {
[INFO] [stderr]     |                                   ^^^ help: try using a char instead: `'['`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/ser.rs:321:34
[INFO] [stderr]     |
[INFO] [stderr] 321 |         if self.output.ends_with("[") {
[INFO] [stderr]     |                                  ^^^ help: try using a char instead: `'['`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/ser.rs:337:35
[INFO] [stderr]     |
[INFO] [stderr] 337 |         if !self.output.ends_with("[") {
[INFO] [stderr]     |                                   ^^^ help: try using a char instead: `'['`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/ser.rs:346:34
[INFO] [stderr]     |
[INFO] [stderr] 346 |         if self.output.ends_with("[") {
[INFO] [stderr]     |                                  ^^^ help: try using a char instead: `'['`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/value/de.rs:38:31
[INFO] [stderr]    |
[INFO] [stderr] 38 |                 Ok(Value::Int(i64::from(value)))
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^ help: consider removing `i64::from()`: `value`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly
[INFO] [stderr]   --> src/value/mod.rs:31:31
[INFO] [stderr]    |
[INFO] [stderr] 31 |             to_string(&Double(3.1415.into())).unwrap(),
[INFO] [stderr]    |                               ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::approx_constant)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant
[INFO] [stderr] 
[INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly
[INFO] [stderr]   --> src/value/mod.rs:79:65
[INFO] [stderr]    |
[INFO] [stderr] 79 |         assert_eq!(from_str::<Value>("3.1415").unwrap(), Double(3.1415.into()));
[INFO] [stderr]    |                                                                 ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `sion-rs`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "3acad197d90f1744c1e2da7bb4f4928a103fed3424a6c2a21acffab453adf8a8"`
[INFO] running `"docker" "rm" "-f" "3acad197d90f1744c1e2da7bb4f4928a103fed3424a6c2a21acffab453adf8a8"`
[INFO] [stdout] 3acad197d90f1744c1e2da7bb4f4928a103fed3424a6c2a21acffab453adf8a8