[INFO] crate sincere 0.5.9 is already in cache [INFO] extracting crate sincere 0.5.9 into work/ex/clippy-test-run/sources/stable/reg/sincere/0.5.9 [INFO] extracting crate sincere 0.5.9 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sincere/0.5.9 [INFO] validating manifest of sincere-0.5.9 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sincere-0.5.9 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sincere-0.5.9 [INFO] finished frobbing sincere-0.5.9 [INFO] frobbed toml for sincere-0.5.9 written to work/ex/clippy-test-run/sources/stable/reg/sincere/0.5.9/Cargo.toml [INFO] started frobbing sincere-0.5.9 [INFO] finished frobbing sincere-0.5.9 [INFO] frobbed toml for sincere-0.5.9 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sincere/0.5.9/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sincere-0.5.9 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sincere/0.5.9:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 36b7b0799f3805d19deaddbbe3095c5e8d3584c503ebe99f948a01fb74135989 [INFO] running `"docker" "start" "-a" "36b7b0799f3805d19deaddbbe3095c5e8d3584c503ebe99f948a01fb74135989"` [INFO] [stderr] Checking twoway v0.1.8 [INFO] [stderr] Checking buf_redux v0.6.3 [INFO] [stderr] Checking nson v0.1.3 [INFO] [stderr] Checking queen-log v0.1.2 [INFO] [stderr] Checking sincere v0.5.9 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/request.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | uri: uri, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `uri` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/request.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | method: method, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/request.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/request.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | body: body [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/response.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | status_code: status_code, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `status_code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/response.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/plus/server/boundary.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | boundary: boundary, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `boundary` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/plus/server/field.rs:187:66 [INFO] [stderr] | [INFO] [stderr] 187 | Ok(Some(ContentDisp { field_name: field_name.to_owned(), filename: filename })) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/route.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | method: method, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/route.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/context.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | app: app, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `app` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/context.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | request: request, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `request` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/context.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | response: response, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `response` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/request.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | uri: uri, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `uri` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/request.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | method: method, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/request.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/request.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | body: body [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/response.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | status_code: status_code, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `status_code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/response.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/plus/server/boundary.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | boundary: boundary, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `boundary` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/plus/server/field.rs:187:66 [INFO] [stderr] | [INFO] [stderr] 187 | Ok(Some(ContentDisp { field_name: field_name.to_owned(), filename: filename })) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/route.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | method: method, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/route.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/context.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | app: app, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `app` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/context.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | request: request, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `request` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/context.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | response: response, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `response` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error[E0432]: unresolved import `nson::Object` [INFO] [stderr] --> src/app/context.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use nson::Object; [INFO] [stderr] | ^^^^^^^^^^^^ no `Object` in the root [INFO] [stderr] [INFO] [stderr] error[E0432]: unresolved import `nson::Object` [INFO] [stderr] --> src/app/context.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use nson::Object; [INFO] [stderr] | ^^^^^^^^^^^^ no `Object` in the root [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/request.rs:100:25 [INFO] [stderr] | [INFO] [stderr] 100 | return Some(value.to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(value.to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/request.rs:102:29 [INFO] [stderr] | [INFO] [stderr] 102 | None => return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/request.rs:105:21 [INFO] [stderr] | [INFO] [stderr] 105 | None => return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/http/plus/server/field.rs:151:27 [INFO] [stderr] | [INFO] [stderr] 151 | const CONT_DISP: &'static str = "Content-Disposition"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/http/plus/server/field.rs:158:22 [INFO] [stderr] | [INFO] [stderr] 158 | const NAME: &'static str = "name="; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/http/plus/server/field.rs:159:26 [INFO] [stderr] | [INFO] [stderr] 159 | const FILENAME: &'static str = "filename="; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/http/plus/server/field.rs:192:26 [INFO] [stderr] | [INFO] [stderr] 192 | const CONTENT_TYPE: &'static str = "Content-Type"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/http/plus/server/field.rs:268:24 [INFO] [stderr] | [INFO] [stderr] 268 | const DATA_INNER_ERR: &'static str = "MultipartFile::inner taken and not replaced; this is likely \ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/plus/server/save.rs:296:46 [INFO] [stderr] | [INFO] [stderr] 296 | Err(e) => if buf.len() < 4 { return SaveResult::Partial(0, e.into())} else { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `SaveResult::Partial(0, e.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/app/route.rs:122:20 [INFO] [stderr] | [INFO] [stderr] 122 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 123 | | if ch == '}' { [INFO] [stderr] 124 | | bracket_count -= 1; [INFO] [stderr] 125 | | if intermediate > 0 { [INFO] [stderr] ... | [INFO] [stderr] 200 | | } [INFO] [stderr] 201 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 122 | } else if ch == '}' { [INFO] [stderr] 123 | bracket_count -= 1; [INFO] [stderr] 124 | if intermediate > 0 { [INFO] [stderr] 125 | if bracket_count == 0 { [INFO] [stderr] 126 | [INFO] [stderr] 127 | number_matches += 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/app/route.rs:125:21 [INFO] [stderr] | [INFO] [stderr] 125 | / if intermediate > 0 { [INFO] [stderr] 126 | | if bracket_count == 0 { [INFO] [stderr] 127 | | [INFO] [stderr] 128 | | number_matches += 1; [INFO] [stderr] ... | [INFO] [stderr] 197 | | } [INFO] [stderr] 198 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 125 | if intermediate > 0 && bracket_count == 0 { [INFO] [stderr] 126 | [INFO] [stderr] 127 | number_matches += 1; [INFO] [stderr] 128 | variable = ""; [INFO] [stderr] 129 | regexp = ""; [INFO] [stderr] 130 | item = &pattern[marker..cursor]; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/app/route.rs:170:48 [INFO] [stderr] | [INFO] [stderr] 170 | } else { [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 171 | | if regexp_ch == ')' { [INFO] [stderr] 172 | | found_pattern = 2; [INFO] [stderr] 173 | | break; [INFO] [stderr] 174 | | } [INFO] [stderr] 175 | | } [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 170 | } else if regexp_ch == ')' { [INFO] [stderr] 171 | found_pattern = 2; [INFO] [stderr] 172 | break; [INFO] [stderr] 173 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/app/route.rs:207:20 [INFO] [stderr] | [INFO] [stderr] 207 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 208 | | if ch == ')' { [INFO] [stderr] 209 | | parenthese_count -= 1; [INFO] [stderr] 210 | | if parenthese_count == 0 { [INFO] [stderr] ... | [INFO] [stderr] 213 | | } [INFO] [stderr] 214 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 207 | } else if ch == ')' { [INFO] [stderr] 208 | parenthese_count -= 1; [INFO] [stderr] 209 | if parenthese_count == 0 { [INFO] [stderr] 210 | number_matches += 1; [INFO] [stderr] 211 | } [INFO] [stderr] 212 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/app/route.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | / if parenthese_count == 0 && prev_ch != '\\' { [INFO] [stderr] 221 | | if ch == '.' || ch == '+' || ch == '|' || ch == '#' { [INFO] [stderr] 222 | | route = route + "\\"; [INFO] [stderr] 223 | | } [INFO] [stderr] 224 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 220 | if parenthese_count == 0 && prev_ch != '\\' && (ch == '.' || ch == '+' || ch == '|' || ch == '#') { [INFO] [stderr] 221 | route = route + "\\"; [INFO] [stderr] 222 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/app/mod.rs:491:28 [INFO] [stderr] | [INFO] [stderr] 491 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 492 | | if pattern == path { [INFO] [stderr] 493 | | route_found = true; [INFO] [stderr] 494 | | } [INFO] [stderr] 495 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 491 | } else if pattern == path { [INFO] [stderr] 492 | route_found = true; [INFO] [stderr] 493 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/request.rs:100:25 [INFO] [stderr] | [INFO] [stderr] 100 | return Some(value.to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(value.to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/request.rs:102:29 [INFO] [stderr] | [INFO] [stderr] 102 | None => return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/request.rs:105:21 [INFO] [stderr] | [INFO] [stderr] 105 | None => return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/http/plus/server/field.rs:151:27 [INFO] [stderr] | [INFO] [stderr] 151 | const CONT_DISP: &'static str = "Content-Disposition"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/http/plus/server/field.rs:158:22 [INFO] [stderr] | [INFO] [stderr] 158 | const NAME: &'static str = "name="; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/http/plus/server/field.rs:159:26 [INFO] [stderr] | [INFO] [stderr] 159 | const FILENAME: &'static str = "filename="; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/http/plus/server/field.rs:192:26 [INFO] [stderr] | [INFO] [stderr] 192 | const CONTENT_TYPE: &'static str = "Content-Type"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/http/plus/server/field.rs:268:24 [INFO] [stderr] | [INFO] [stderr] 268 | const DATA_INNER_ERR: &'static str = "MultipartFile::inner taken and not replaced; this is likely \ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/plus/server/save.rs:296:46 [INFO] [stderr] | [INFO] [stderr] 296 | Err(e) => if buf.len() < 4 { return SaveResult::Partial(0, e.into())} else { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `SaveResult::Partial(0, e.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/app/route.rs:122:20 [INFO] [stderr] | [INFO] [stderr] 122 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 123 | | if ch == '}' { [INFO] [stderr] 124 | | bracket_count -= 1; [INFO] [stderr] 125 | | if intermediate > 0 { [INFO] [stderr] ... | [INFO] [stderr] 200 | | } [INFO] [stderr] 201 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 122 | } else if ch == '}' { [INFO] [stderr] 123 | bracket_count -= 1; [INFO] [stderr] 124 | if intermediate > 0 { [INFO] [stderr] 125 | if bracket_count == 0 { [INFO] [stderr] 126 | [INFO] [stderr] 127 | number_matches += 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/app/route.rs:125:21 [INFO] [stderr] | [INFO] [stderr] 125 | / if intermediate > 0 { [INFO] [stderr] 126 | | if bracket_count == 0 { [INFO] [stderr] 127 | | [INFO] [stderr] 128 | | number_matches += 1; [INFO] [stderr] ... | [INFO] [stderr] 197 | | } [INFO] [stderr] 198 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 125 | if intermediate > 0 && bracket_count == 0 { [INFO] [stderr] 126 | [INFO] [stderr] 127 | number_matches += 1; [INFO] [stderr] 128 | variable = ""; [INFO] [stderr] 129 | regexp = ""; [INFO] [stderr] 130 | item = &pattern[marker..cursor]; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/app/route.rs:170:48 [INFO] [stderr] | [INFO] [stderr] 170 | } else { [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 171 | | if regexp_ch == ')' { [INFO] [stderr] 172 | | found_pattern = 2; [INFO] [stderr] 173 | | break; [INFO] [stderr] 174 | | } [INFO] [stderr] 175 | | } [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 170 | } else if regexp_ch == ')' { [INFO] [stderr] 171 | found_pattern = 2; [INFO] [stderr] 172 | break; [INFO] [stderr] 173 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/app/route.rs:207:20 [INFO] [stderr] | [INFO] [stderr] 207 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 208 | | if ch == ')' { [INFO] [stderr] 209 | | parenthese_count -= 1; [INFO] [stderr] 210 | | if parenthese_count == 0 { [INFO] [stderr] ... | [INFO] [stderr] 213 | | } [INFO] [stderr] 214 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 207 | } else if ch == ')' { [INFO] [stderr] 208 | parenthese_count -= 1; [INFO] [stderr] 209 | if parenthese_count == 0 { [INFO] [stderr] 210 | number_matches += 1; [INFO] [stderr] 211 | } [INFO] [stderr] 212 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/app/route.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | / if parenthese_count == 0 && prev_ch != '\\' { [INFO] [stderr] 221 | | if ch == '.' || ch == '+' || ch == '|' || ch == '#' { [INFO] [stderr] 222 | | route = route + "\\"; [INFO] [stderr] 223 | | } [INFO] [stderr] 224 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 220 | if parenthese_count == 0 && prev_ch != '\\' && (ch == '.' || ch == '+' || ch == '|' || ch == '#') { [INFO] [stderr] 221 | route = route + "\\"; [INFO] [stderr] 222 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/app/mod.rs:491:28 [INFO] [stderr] | [INFO] [stderr] 491 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 492 | | if pattern == path { [INFO] [stderr] 493 | | route_found = true; [INFO] [stderr] 494 | | } [INFO] [stderr] 495 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 491 | } else if pattern == path { [INFO] [stderr] 492 | route_found = true; [INFO] [stderr] 493 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0432`. [INFO] [stderr] error: Could not compile `sincere`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0432`. [INFO] [stderr] error: Could not compile `sincere`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "36b7b0799f3805d19deaddbbe3095c5e8d3584c503ebe99f948a01fb74135989"` [INFO] running `"docker" "rm" "-f" "36b7b0799f3805d19deaddbbe3095c5e8d3584c503ebe99f948a01fb74135989"` [INFO] [stdout] 36b7b0799f3805d19deaddbbe3095c5e8d3584c503ebe99f948a01fb74135989