[INFO] crate simulacrum_mock 0.1.0 is already in cache
[INFO] extracting crate simulacrum_mock 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/simulacrum_mock/0.1.0
[INFO] extracting crate simulacrum_mock 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/simulacrum_mock/0.1.0
[INFO] validating manifest of simulacrum_mock-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of simulacrum_mock-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing simulacrum_mock-0.1.0
[INFO] finished frobbing simulacrum_mock-0.1.0
[INFO] frobbed toml for simulacrum_mock-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/simulacrum_mock/0.1.0/Cargo.toml
[INFO] started frobbing simulacrum_mock-0.1.0
[INFO] finished frobbing simulacrum_mock-0.1.0
[INFO] frobbed toml for simulacrum_mock-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/simulacrum_mock/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting simulacrum_mock-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/simulacrum_mock/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 8b42fc2b5de6e1dcdde49db3677873f47a345fcc372baef4e725a9245a5e27b3
[INFO] running `"docker" "start" "-a" "8b42fc2b5de6e1dcdde49db3677873f47a345fcc372baef4e725a9245a5e27b3"`
[INFO] [stderr]     Checking handlebox v0.3.0
[INFO] [stderr]    Compiling debugit v0.1.2
[INFO] [stderr]     Checking simulacrum_shared v0.1.0
[INFO] [stderr]     Checking simulacrum_user v0.1.0
[INFO] [stderr]     Checking simulacrum_mock v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/store.rs:242:13
[INFO] [stderr]     |
[INFO] [stderr] 242 |             result
[INFO] [stderr]     |             ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/store.rs:241:26
[INFO] [stderr]     |
[INFO] [stderr] 241 |             let result = self.store.0.lock().unwrap().expectations.get_mut(&id).unwrap().as_any().downcast_mut::<Expectation<I, O>>().unwrap().return_value_for(&cell);
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/constraint/result.rs:18:9
[INFO] [stderr]    |
[INFO] [stderr] 18 | /         match self {
[INFO] [stderr] 19 | |             &ConstraintError::AlwaysFail => {
[INFO] [stderr] 20 | |                 write!(f, "Expectation will always fail.")
[INFO] [stderr] 21 | |             },
[INFO] [stderr] ...  |
[INFO] [stderr] 36 | |             },
[INFO] [stderr] 37 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 18 |         match *self {
[INFO] [stderr] 19 |             ConstraintError::AlwaysFail => {
[INFO] [stderr] 20 |                 write!(f, "Expectation will always fail.")
[INFO] [stderr] 21 |             },
[INFO] [stderr] 22 |             ConstraintError::CalledTooFewTimes(times) => {
[INFO] [stderr] 23 |                 write!(f, "Called {} times fewer than expected.", times)
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `constraint::ConstraintMock`
[INFO] [stderr]   --> src/constraint/mod.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 | /     pub fn new() -> Self {
[INFO] [stderr] 30 | |         Self {
[INFO] [stderr] 31 | |             handle_call_expected: false,
[INFO] [stderr] 32 | |             handle_call_called: false
[INFO] [stderr] 33 | |         }
[INFO] [stderr] 34 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 23 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `mock::Expectations`
[INFO] [stderr]   --> src/mock.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 | /     pub fn new() -> Self {
[INFO] [stderr] 16 | |         Expectations {
[INFO] [stderr] 17 | |             store: ExpectationStore::new()
[INFO] [stderr] 18 | |         }
[INFO] [stderr] 19 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 13 | impl Default for mock::Expectations {
[INFO] [stderr] 14 |     fn default() -> Self {
[INFO] [stderr] 15 |         Self::new()
[INFO] [stderr] 16 |     }
[INFO] [stderr] 17 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/store.rs:75:27
[INFO] [stderr]    |
[INFO] [stderr] 75 |             let mut ids = inner.eras.get(inner.current_unverified_era).unwrap().clone();
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `inner.eras[inner.current_unverified_era]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/store.rs:242:13
[INFO] [stderr]     |
[INFO] [stderr] 242 |             result
[INFO] [stderr]     |             ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/store.rs:241:26
[INFO] [stderr]     |
[INFO] [stderr] 241 |             let result = self.store.0.lock().unwrap().expectations.get_mut(&id).unwrap().as_any().downcast_mut::<Expectation<I, O>>().unwrap().return_value_for(&cell);
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/constraint/result.rs:18:9
[INFO] [stderr]    |
[INFO] [stderr] 18 | /         match self {
[INFO] [stderr] 19 | |             &ConstraintError::AlwaysFail => {
[INFO] [stderr] 20 | |                 write!(f, "Expectation will always fail.")
[INFO] [stderr] 21 | |             },
[INFO] [stderr] ...  |
[INFO] [stderr] 36 | |             },
[INFO] [stderr] 37 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 18 |         match *self {
[INFO] [stderr] 19 |             ConstraintError::AlwaysFail => {
[INFO] [stderr] 20 |                 write!(f, "Expectation will always fail.")
[INFO] [stderr] 21 |             },
[INFO] [stderr] 22 |             ConstraintError::CalledTooFewTimes(times) => {
[INFO] [stderr] 23 |                 write!(f, "Called {} times fewer than expected.", times)
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `constraint::ConstraintMock`
[INFO] [stderr]   --> src/constraint/mod.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 | /     pub fn new() -> Self {
[INFO] [stderr] 30 | |         Self {
[INFO] [stderr] 31 | |             handle_call_expected: false,
[INFO] [stderr] 32 | |             handle_call_called: false
[INFO] [stderr] 33 | |         }
[INFO] [stderr] 34 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 23 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `mock::Expectations`
[INFO] [stderr]   --> src/mock.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 | /     pub fn new() -> Self {
[INFO] [stderr] 16 | |         Expectations {
[INFO] [stderr] 17 | |             store: ExpectationStore::new()
[INFO] [stderr] 18 | |         }
[INFO] [stderr] 19 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 13 | impl Default for mock::Expectations {
[INFO] [stderr] 14 |     fn default() -> Self {
[INFO] [stderr] 15 |         Self::new()
[INFO] [stderr] 16 |     }
[INFO] [stderr] 17 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/store.rs:75:27
[INFO] [stderr]    |
[INFO] [stderr] 75 |             let mut ids = inner.eras.get(inner.current_unverified_era).unwrap().clone();
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `inner.eras[inner.current_unverified_era]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.70s
[INFO] running `"docker" "inspect" "8b42fc2b5de6e1dcdde49db3677873f47a345fcc372baef4e725a9245a5e27b3"`
[INFO] running `"docker" "rm" "-f" "8b42fc2b5de6e1dcdde49db3677873f47a345fcc372baef4e725a9245a5e27b3"`
[INFO] [stdout] 8b42fc2b5de6e1dcdde49db3677873f47a345fcc372baef4e725a9245a5e27b3