[INFO] crate simplist 0.0.5 is already in cache [INFO] extracting crate simplist 0.0.5 into work/ex/clippy-test-run/sources/stable/reg/simplist/0.0.5 [INFO] extracting crate simplist 0.0.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/simplist/0.0.5 [INFO] validating manifest of simplist-0.0.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of simplist-0.0.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing simplist-0.0.5 [INFO] finished frobbing simplist-0.0.5 [INFO] frobbed toml for simplist-0.0.5 written to work/ex/clippy-test-run/sources/stable/reg/simplist/0.0.5/Cargo.toml [INFO] started frobbing simplist-0.0.5 [INFO] finished frobbing simplist-0.0.5 [INFO] frobbed toml for simplist-0.0.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/simplist/0.0.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting simplist-0.0.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/simplist/0.0.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1c10376829e3464ef9fa5e01c2e6be16f22d0d3ac4cdfb8fd47761cc32d0dac5 [INFO] running `"docker" "start" "-a" "1c10376829e3464ef9fa5e01c2e6be16f22d0d3ac4cdfb8fd47761cc32d0dac5"` [INFO] [stderr] Checking simplist v0.0.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simplist-stable/client.rs:186:25 [INFO] [stderr] | [INFO] [stderr] 186 | core: core, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `core` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simplist-stable/client.rs:186:25 [INFO] [stderr] | [INFO] [stderr] 186 | core: core, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `core` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/hina/task.rs:127:17 [INFO] [stderr] | [INFO] [stderr] 127 | Err(_) => panic!(d!["task was cancelled"]), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/hina/task.rs:127:17 [INFO] [stderr] | [INFO] [stderr] 127 | Err(_) => panic!(d!["task was cancelled"]), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `simplist::request::HttpRequest` [INFO] [stderr] --> src/simplist-stable/request.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / pub fn new() -> HttpRequest { [INFO] [stderr] 58 | | let url = Url::default(); [INFO] [stderr] 59 | | let underlying = Request::new(Method::Get, Uri::default()); [INFO] [stderr] 60 | | [INFO] [stderr] 61 | | HttpRequest { url, underlying } [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 47 | impl Default for simplist::request::HttpRequest { [INFO] [stderr] 48 | fn default() -> Self { [INFO] [stderr] 49 | Self::new() [INFO] [stderr] 50 | } [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `simplist::request::HttpRequest` [INFO] [stderr] --> src/simplist-stable/request.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / pub fn new() -> HttpRequest { [INFO] [stderr] 58 | | let url = Url::default(); [INFO] [stderr] 59 | | let underlying = Request::new(Method::Get, Uri::default()); [INFO] [stderr] 60 | | [INFO] [stderr] 61 | | HttpRequest { url, underlying } [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 47 | impl Default for simplist::request::HttpRequest { [INFO] [stderr] 48 | fn default() -> Self { [INFO] [stderr] 49 | Self::new() [INFO] [stderr] 50 | } [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.60s [INFO] running `"docker" "inspect" "1c10376829e3464ef9fa5e01c2e6be16f22d0d3ac4cdfb8fd47761cc32d0dac5"` [INFO] running `"docker" "rm" "-f" "1c10376829e3464ef9fa5e01c2e6be16f22d0d3ac4cdfb8fd47761cc32d0dac5"` [INFO] [stdout] 1c10376829e3464ef9fa5e01c2e6be16f22d0d3ac4cdfb8fd47761cc32d0dac5