[INFO] crate simplisp 0.4.0 is already in cache [INFO] extracting crate simplisp 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/simplisp/0.4.0 [INFO] extracting crate simplisp 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/simplisp/0.4.0 [INFO] validating manifest of simplisp-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of simplisp-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing simplisp-0.4.0 [INFO] finished frobbing simplisp-0.4.0 [INFO] frobbed toml for simplisp-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/simplisp/0.4.0/Cargo.toml [INFO] started frobbing simplisp-0.4.0 [INFO] finished frobbing simplisp-0.4.0 [INFO] frobbed toml for simplisp-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/simplisp/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting simplisp-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/simplisp/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a7cc7a3fcdbb43238c35a039ee8af85f9bb4f95bca4136ca0bc9bf8cd9135464 [INFO] running `"docker" "start" "-a" "a7cc7a3fcdbb43238c35a039ee8af85f9bb4f95bca4136ca0bc9bf8cd9135464"` [INFO] [stderr] Checking error-chain v0.5.0 [INFO] [stderr] Checking simplisp v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lisp/abstract_syntax_tree_node.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | objects: objects, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `objects` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lisp/execution_tree.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | root: root, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lisp/execution_tree_node.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | objects: objects, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `objects` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lisp/abstract_syntax_tree_node.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | objects: objects, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `objects` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lisp/execution_tree.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | root: root, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lisp/execution_tree_node.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | objects: objects, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `objects` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lisp/environment.rs:32:28 [INFO] [stderr] | [INFO] [stderr] 32 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 33 | | if let Some((first, _)) = Self::split(inner_objects.into_iter()) { [INFO] [stderr] 34 | | self.evaluate(arg, &first) [INFO] [stderr] 35 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 32 | } else if let Some((first, _)) = Self::split(inner_objects.into_iter()) { [INFO] [stderr] 33 | self.evaluate(arg, &first) [INFO] [stderr] 34 | } else { [INFO] [stderr] 35 | let nil = ExecutionTreeObject::nil(); [INFO] [stderr] 36 | Ok(nil) [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lisp/environment.rs:32:28 [INFO] [stderr] | [INFO] [stderr] 32 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 33 | | if let Some((first, _)) = Self::split(inner_objects.into_iter()) { [INFO] [stderr] 34 | | self.evaluate(arg, &first) [INFO] [stderr] 35 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 32 | } else if let Some((first, _)) = Self::split(inner_objects.into_iter()) { [INFO] [stderr] 33 | self.evaluate(arg, &first) [INFO] [stderr] 34 | } else { [INFO] [stderr] 35 | let nil = ExecutionTreeObject::nil(); [INFO] [stderr] 36 | Ok(nil) [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/error/mod.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / error_chain! { [INFO] [stderr] 13 | | types { } [INFO] [stderr] 14 | | [INFO] [stderr] 15 | | links { } [INFO] [stderr] ... | [INFO] [stderr] 201 | | } [INFO] [stderr] 202 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/lisp/abstract_syntax_tree.rs:105:46 [INFO] [stderr] | [INFO] [stderr] 105 | while let Some((index, character)) = enumerated_text.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `for (index, character) in enumerated_text { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/lisp/abstract_syntax_tree.rs:136:46 [INFO] [stderr] | [INFO] [stderr] 136 | while let Some((index, character)) = enumerated_text.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `for (index, character) in enumerated_text { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lisp/abstract_syntax_tree.rs:153:9 [INFO] [stderr] | [INFO] [stderr] 153 | / match *current_word_start_option { [INFO] [stderr] 154 | | Some(current_word_start) => { [INFO] [stderr] 155 | | let current_word = &program_text[current_word_start..current_word_end]; [INFO] [stderr] 156 | | let string_object = AbstractSyntaxTreeObject::String(current_word); [INFO] [stderr] ... | [INFO] [stderr] 160 | | None => { }, [INFO] [stderr] 161 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 153 | if let Some(current_word_start) = *current_word_start_option { [INFO] [stderr] 154 | let current_word = &program_text[current_word_start..current_word_end]; [INFO] [stderr] 155 | let string_object = AbstractSyntaxTreeObject::String(current_word); [INFO] [stderr] 156 | objects.push(string_object); [INFO] [stderr] 157 | *current_word_start_option = None; [INFO] [stderr] 158 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `lisp::environment::Environment` [INFO] [stderr] --> src/lisp/environment.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Self { [INFO] [stderr] 16 | | Environment { [INFO] [stderr] 17 | | call_stack: Vec::new(), [INFO] [stderr] 18 | | global_frame: Frame::new(), [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | impl Default for lisp::environment::Environment { [INFO] [stderr] 15 | fn default() -> Self { [INFO] [stderr] 16 | Self::new() [INFO] [stderr] 17 | } [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lisp/environment.rs:33:77 [INFO] [stderr] | [INFO] [stderr] 33 | if let Some((first, _)) = Self::split(inner_objects.into_iter()) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lisp/environment.rs:107:58 [INFO] [stderr] | [INFO] [stderr] 107 | unsafe fn evaluate_list(&mut self, arg: &TArg, list: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ExecutionTreeObject]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lisp/environment.rs:112:59 [INFO] [stderr] | [INFO] [stderr] 112 | if let Some((first, rest)) = Self::split(list.into_iter()) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lisp/environment.rs:164:39 [INFO] [stderr] | [INFO] [stderr] 164 | for stack_frame in call_stack.into_iter().rev() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lisp/execution_tree.rs:35:25 [INFO] [stderr] | [INFO] [stderr] 35 | let mut chars = string.chars().into_iter(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `string.chars()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lisp/execution_tree_object.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | / match self { [INFO] [stderr] 100 | | &ExecutionTreeObject::Bool(_) => Self::bool_str(), [INFO] [stderr] 101 | | &ExecutionTreeObject::Char(_) => Self::char_str(), [INFO] [stderr] 102 | | &ExecutionTreeObject::F32(_) => Self::f32_str(), [INFO] [stderr] ... | [INFO] [stderr] 116 | | &ExecutionTreeObject::USize(_) => Self::usize_str(), [INFO] [stderr] 117 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 99 | match *self { [INFO] [stderr] 100 | ExecutionTreeObject::Bool(_) => Self::bool_str(), [INFO] [stderr] 101 | ExecutionTreeObject::Char(_) => Self::char_str(), [INFO] [stderr] 102 | ExecutionTreeObject::F32(_) => Self::f32_str(), [INFO] [stderr] 103 | ExecutionTreeObject::F64(_) => Self::f64_str(), [INFO] [stderr] 104 | ExecutionTreeObject::I8(_) => Self::i8_str(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lisp/execution_tree_object.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | / match self { [INFO] [stderr] 123 | | &ExecutionTreeObject::Bool(ref some) => some.to_string(), [INFO] [stderr] 124 | | &ExecutionTreeObject::Char(ref some) => format!("'{}'", some.to_string()), [INFO] [stderr] 125 | | &ExecutionTreeObject::F32(ref some) => format!("{}f32", some.to_string()), [INFO] [stderr] ... | [INFO] [stderr] 139 | | &ExecutionTreeObject::USize(ref some) => format!("{}usize", some.to_string()), [INFO] [stderr] 140 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 122 | match *self { [INFO] [stderr] 123 | ExecutionTreeObject::Bool(ref some) => some.to_string(), [INFO] [stderr] 124 | ExecutionTreeObject::Char(ref some) => format!("'{}'", some.to_string()), [INFO] [stderr] 125 | ExecutionTreeObject::F32(ref some) => format!("{}f32", some.to_string()), [INFO] [stderr] 126 | ExecutionTreeObject::F64(ref some) => format!("{}f64", some.to_string()), [INFO] [stderr] 127 | ExecutionTreeObject::I8(ref some) => format!("{}i8", some.to_string()), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `lisp::frame::Frame` [INFO] [stderr] --> src/lisp/frame.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> Self { [INFO] [stderr] 10 | | Frame { [INFO] [stderr] 11 | | symbols: BTreeMap::new(), [INFO] [stderr] 12 | | } [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lisp/last_char_type.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | / match self { [INFO] [stderr] 33 | | &LastCharType::CloseParen => Self::close_paren_str(), [INFO] [stderr] 34 | | &LastCharType::OpenParen => Self::open_paren_str(), [INFO] [stderr] 35 | | &LastCharType::Quote => Self::quote_str(), [INFO] [stderr] 36 | | &LastCharType::WhiteSpace => Self::white_space_str(), [INFO] [stderr] 37 | | &LastCharType::Word => Self::word_str(), [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | match *self { [INFO] [stderr] 33 | LastCharType::CloseParen => Self::close_paren_str(), [INFO] [stderr] 34 | LastCharType::OpenParen => Self::open_paren_str(), [INFO] [stderr] 35 | LastCharType::Quote => Self::quote_str(), [INFO] [stderr] 36 | LastCharType::WhiteSpace => Self::white_space_str(), [INFO] [stderr] 37 | LastCharType::Word => Self::word_str(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lisp/symbol.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | / match self { [INFO] [stderr] 13 | | &Symbol::Object(ref some) => Symbol::Object(some.clone()), [INFO] [stderr] 14 | | &Symbol::BuiltInFunc(some) => Symbol::BuiltInFunc(some), [INFO] [stderr] 15 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 12 | match *self { [INFO] [stderr] 13 | Symbol::Object(ref some) => Symbol::Object(some.clone()), [INFO] [stderr] 14 | Symbol::BuiltInFunc(some) => Symbol::BuiltInFunc(some), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/error/mod.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / error_chain! { [INFO] [stderr] 13 | | types { } [INFO] [stderr] 14 | | [INFO] [stderr] 15 | | links { } [INFO] [stderr] ... | [INFO] [stderr] 201 | | } [INFO] [stderr] 202 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/lisp/abstract_syntax_tree.rs:105:46 [INFO] [stderr] | [INFO] [stderr] 105 | while let Some((index, character)) = enumerated_text.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `for (index, character) in enumerated_text { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/lisp/abstract_syntax_tree.rs:136:46 [INFO] [stderr] | [INFO] [stderr] 136 | while let Some((index, character)) = enumerated_text.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `for (index, character) in enumerated_text { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lisp/abstract_syntax_tree.rs:153:9 [INFO] [stderr] | [INFO] [stderr] 153 | / match *current_word_start_option { [INFO] [stderr] 154 | | Some(current_word_start) => { [INFO] [stderr] 155 | | let current_word = &program_text[current_word_start..current_word_end]; [INFO] [stderr] 156 | | let string_object = AbstractSyntaxTreeObject::String(current_word); [INFO] [stderr] ... | [INFO] [stderr] 160 | | None => { }, [INFO] [stderr] 161 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 153 | if let Some(current_word_start) = *current_word_start_option { [INFO] [stderr] 154 | let current_word = &program_text[current_word_start..current_word_end]; [INFO] [stderr] 155 | let string_object = AbstractSyntaxTreeObject::String(current_word); [INFO] [stderr] 156 | objects.push(string_object); [INFO] [stderr] 157 | *current_word_start_option = None; [INFO] [stderr] 158 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `lisp::environment::Environment` [INFO] [stderr] --> src/lisp/environment.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Self { [INFO] [stderr] 16 | | Environment { [INFO] [stderr] 17 | | call_stack: Vec::new(), [INFO] [stderr] 18 | | global_frame: Frame::new(), [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | impl Default for lisp::environment::Environment { [INFO] [stderr] 15 | fn default() -> Self { [INFO] [stderr] 16 | Self::new() [INFO] [stderr] 17 | } [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lisp/environment.rs:33:77 [INFO] [stderr] | [INFO] [stderr] 33 | if let Some((first, _)) = Self::split(inner_objects.into_iter()) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lisp/environment.rs:107:58 [INFO] [stderr] | [INFO] [stderr] 107 | unsafe fn evaluate_list(&mut self, arg: &TArg, list: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ExecutionTreeObject]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lisp/environment.rs:112:59 [INFO] [stderr] | [INFO] [stderr] 112 | if let Some((first, rest)) = Self::split(list.into_iter()) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lisp/environment.rs:164:39 [INFO] [stderr] | [INFO] [stderr] 164 | for stack_frame in call_stack.into_iter().rev() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lisp/execution_tree.rs:35:25 [INFO] [stderr] | [INFO] [stderr] 35 | let mut chars = string.chars().into_iter(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `string.chars()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lisp/execution_tree_object.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | / match self { [INFO] [stderr] 100 | | &ExecutionTreeObject::Bool(_) => Self::bool_str(), [INFO] [stderr] 101 | | &ExecutionTreeObject::Char(_) => Self::char_str(), [INFO] [stderr] 102 | | &ExecutionTreeObject::F32(_) => Self::f32_str(), [INFO] [stderr] ... | [INFO] [stderr] 116 | | &ExecutionTreeObject::USize(_) => Self::usize_str(), [INFO] [stderr] 117 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 99 | match *self { [INFO] [stderr] 100 | ExecutionTreeObject::Bool(_) => Self::bool_str(), [INFO] [stderr] 101 | ExecutionTreeObject::Char(_) => Self::char_str(), [INFO] [stderr] 102 | ExecutionTreeObject::F32(_) => Self::f32_str(), [INFO] [stderr] 103 | ExecutionTreeObject::F64(_) => Self::f64_str(), [INFO] [stderr] 104 | ExecutionTreeObject::I8(_) => Self::i8_str(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lisp/execution_tree_object.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | / match self { [INFO] [stderr] 123 | | &ExecutionTreeObject::Bool(ref some) => some.to_string(), [INFO] [stderr] 124 | | &ExecutionTreeObject::Char(ref some) => format!("'{}'", some.to_string()), [INFO] [stderr] 125 | | &ExecutionTreeObject::F32(ref some) => format!("{}f32", some.to_string()), [INFO] [stderr] ... | [INFO] [stderr] 139 | | &ExecutionTreeObject::USize(ref some) => format!("{}usize", some.to_string()), [INFO] [stderr] 140 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 122 | match *self { [INFO] [stderr] 123 | ExecutionTreeObject::Bool(ref some) => some.to_string(), [INFO] [stderr] 124 | ExecutionTreeObject::Char(ref some) => format!("'{}'", some.to_string()), [INFO] [stderr] 125 | ExecutionTreeObject::F32(ref some) => format!("{}f32", some.to_string()), [INFO] [stderr] 126 | ExecutionTreeObject::F64(ref some) => format!("{}f64", some.to_string()), [INFO] [stderr] 127 | ExecutionTreeObject::I8(ref some) => format!("{}i8", some.to_string()), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `lisp::frame::Frame` [INFO] [stderr] --> src/lisp/frame.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> Self { [INFO] [stderr] 10 | | Frame { [INFO] [stderr] 11 | | symbols: BTreeMap::new(), [INFO] [stderr] 12 | | } [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lisp/last_char_type.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | / match self { [INFO] [stderr] 33 | | &LastCharType::CloseParen => Self::close_paren_str(), [INFO] [stderr] 34 | | &LastCharType::OpenParen => Self::open_paren_str(), [INFO] [stderr] 35 | | &LastCharType::Quote => Self::quote_str(), [INFO] [stderr] 36 | | &LastCharType::WhiteSpace => Self::white_space_str(), [INFO] [stderr] 37 | | &LastCharType::Word => Self::word_str(), [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | match *self { [INFO] [stderr] 33 | LastCharType::CloseParen => Self::close_paren_str(), [INFO] [stderr] 34 | LastCharType::OpenParen => Self::open_paren_str(), [INFO] [stderr] 35 | LastCharType::Quote => Self::quote_str(), [INFO] [stderr] 36 | LastCharType::WhiteSpace => Self::white_space_str(), [INFO] [stderr] 37 | LastCharType::Word => Self::word_str(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lisp/symbol.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | / match self { [INFO] [stderr] 13 | | &Symbol::Object(ref some) => Symbol::Object(some.clone()), [INFO] [stderr] 14 | | &Symbol::BuiltInFunc(some) => Symbol::BuiltInFunc(some), [INFO] [stderr] 15 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 12 | match *self { [INFO] [stderr] 13 | Symbol::Object(ref some) => Symbol::Object(some.clone()), [INFO] [stderr] 14 | Symbol::BuiltInFunc(some) => Symbol::BuiltInFunc(some), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.77s [INFO] running `"docker" "inspect" "a7cc7a3fcdbb43238c35a039ee8af85f9bb4f95bca4136ca0bc9bf8cd9135464"` [INFO] running `"docker" "rm" "-f" "a7cc7a3fcdbb43238c35a039ee8af85f9bb4f95bca4136ca0bc9bf8cd9135464"` [INFO] [stdout] a7cc7a3fcdbb43238c35a039ee8af85f9bb4f95bca4136ca0bc9bf8cd9135464