[INFO] crate simpleflake 0.0.4 is already in cache [INFO] extracting crate simpleflake 0.0.4 into work/ex/clippy-test-run/sources/stable/reg/simpleflake/0.0.4 [INFO] extracting crate simpleflake 0.0.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/simpleflake/0.0.4 [INFO] validating manifest of simpleflake-0.0.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of simpleflake-0.0.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing simpleflake-0.0.4 [INFO] finished frobbing simpleflake-0.0.4 [INFO] frobbed toml for simpleflake-0.0.4 written to work/ex/clippy-test-run/sources/stable/reg/simpleflake/0.0.4/Cargo.toml [INFO] started frobbing simpleflake-0.0.4 [INFO] finished frobbing simpleflake-0.0.4 [INFO] frobbed toml for simpleflake-0.0.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/simpleflake/0.0.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting simpleflake-0.0.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/simpleflake/0.0.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 30060547a459facdb07c1e22b32e41fb0b88720a10a59850f1032eff66c1fd30 [INFO] running `"docker" "start" "-a" "30060547a459facdb07c1e22b32e41fb0b88720a10a59850f1032eff66c1fd30"` [INFO] [stderr] Checking simpleflake v0.0.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:28:10 [INFO] [stderr] | [INFO] [stderr] 28 | Id { timestamp: timestamp, random_bits: random_bits } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:28:32 [INFO] [stderr] | [INFO] [stderr] 28 | Id { timestamp: timestamp, random_bits: random_bits } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `random_bits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:28:10 [INFO] [stderr] | [INFO] [stderr] 28 | Id { timestamp: timestamp, random_bits: random_bits } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:28:32 [INFO] [stderr] | [INFO] [stderr] 28 | Id { timestamp: timestamp, random_bits: random_bits } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `random_bits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:4:20 [INFO] [stderr] | [INFO] [stderr] 4 | static EPOCH:f64 = 946702800.0; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `946_702_800.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:6:31 [INFO] [stderr] | [INFO] [stderr] 6 | static RANDOM_MAX_VALUE:u32 = 4194303; [INFO] [stderr] | ^^^^^^^ help: consider: `4_194_303` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:19:38 [INFO] [stderr] | [INFO] [stderr] 19 | (timestamp << TIMESTAMP_SHIFT) | (random_bits as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(random_bits)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:32:20 [INFO] [stderr] | [INFO] [stderr] 32 | let mut nsec = spec.nsec as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(spec.nsec)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:4:20 [INFO] [stderr] | [INFO] [stderr] 4 | static EPOCH:f64 = 946702800.0; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `946_702_800.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:6:31 [INFO] [stderr] | [INFO] [stderr] 6 | static RANDOM_MAX_VALUE:u32 = 4194303; [INFO] [stderr] | ^^^^^^^ help: consider: `4_194_303` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:19:38 [INFO] [stderr] | [INFO] [stderr] 19 | (timestamp << TIMESTAMP_SHIFT) | (random_bits as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(random_bits)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:32:20 [INFO] [stderr] | [INFO] [stderr] 32 | let mut nsec = spec.nsec as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(spec.nsec)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | assert_eq!(output, 12.34); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | assert_eq!(output, 12.34); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `simpleflake`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lib.rs:19:18 [INFO] [stderr] | [INFO] [stderr] 19 | assert!(id > 1000000000000000000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `1_000_000_000_000_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lib.rs:24:14 [INFO] [stderr] | [INFO] [stderr] 24 | let id = 3878068333444056242; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `3_878_068_333_444_056_242` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lib.rs:27:33 [INFO] [stderr] | [INFO] [stderr] 27 | assert_eq!(parts.timestamp, 1409004570.859); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `1_409_004_570.859` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lib.rs:28:35 [INFO] [stderr] | [INFO] [stderr] 28 | assert_eq!(parts.random_bits, 2081970); [INFO] [stderr] | ^^^^^^^ help: consider: `2_081_970` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lib.rs:33:14 [INFO] [stderr] | [INFO] [stderr] 33 | let id = 3878068333444056242; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `3_878_068_333_444_056_242` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/lib.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | assert_eq!(parts.timestamp, 1409004570.859); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/lib.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | assert_eq!(parts.timestamp, 1409004570.859); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `simpleflake`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "30060547a459facdb07c1e22b32e41fb0b88720a10a59850f1032eff66c1fd30"` [INFO] running `"docker" "rm" "-f" "30060547a459facdb07c1e22b32e41fb0b88720a10a59850f1032eff66c1fd30"` [INFO] [stdout] 30060547a459facdb07c1e22b32e41fb0b88720a10a59850f1032eff66c1fd30