[INFO] crate simple_nats_client 0.1.0 is already in cache [INFO] extracting crate simple_nats_client 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/simple_nats_client/0.1.0 [INFO] extracting crate simple_nats_client 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/simple_nats_client/0.1.0 [INFO] validating manifest of simple_nats_client-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of simple_nats_client-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing simple_nats_client-0.1.0 [INFO] finished frobbing simple_nats_client-0.1.0 [INFO] frobbed toml for simple_nats_client-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/simple_nats_client/0.1.0/Cargo.toml [INFO] started frobbing simple_nats_client-0.1.0 [INFO] finished frobbing simple_nats_client-0.1.0 [INFO] frobbed toml for simple_nats_client-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/simple_nats_client/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting simple_nats_client-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/simple_nats_client/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5a732caaa255c5dd8225c6fe2ce3a57546c9ebf6aa8852538d0b71d8133c5d0f [INFO] running `"docker" "start" "-a" "5a732caaa255c5dd8225c6fe2ce3a57546c9ebf6aa8852538d0b71d8133c5d0f"` [INFO] [stderr] Checking simple_nats_client v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nats_client.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | server_info: server_info, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `server_info` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nats_client.rs:377:49 [INFO] [stderr] | [INFO] [stderr] 377 | sid: sid, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nats_client.rs:378:49 [INFO] [stderr] | [INFO] [stderr] 378 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nats_client.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | server_info: server_info, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `server_info` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nats_client.rs:377:49 [INFO] [stderr] | [INFO] [stderr] 377 | sid: sid, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nats_client.rs:378:49 [INFO] [stderr] | [INFO] [stderr] 378 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/nats_client.rs:199:17 [INFO] [stderr] | [INFO] [stderr] 199 | / return Err(NatsError::ConnectionError(e, [INFO] [stderr] 200 | | "NatsClient::set_read_timeout_internal" [INFO] [stderr] 201 | | .to_owned())) [INFO] [stderr] | |_______________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 199 | Err(NatsError::ConnectionError(e, [INFO] [stderr] 200 | "NatsClient::set_read_timeout_internal" [INFO] [stderr] 201 | .to_owned())) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/nats_client.rs:470:9 [INFO] [stderr] | [INFO] [stderr] 470 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/nats_client.rs:199:17 [INFO] [stderr] | [INFO] [stderr] 199 | / return Err(NatsError::ConnectionError(e, [INFO] [stderr] 200 | | "NatsClient::set_read_timeout_internal" [INFO] [stderr] 201 | | .to_owned())) [INFO] [stderr] | |_______________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 199 | Err(NatsError::ConnectionError(e, [INFO] [stderr] 200 | "NatsClient::set_read_timeout_internal" [INFO] [stderr] 201 | .to_owned())) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/nats_client.rs:470:9 [INFO] [stderr] | [INFO] [stderr] 470 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/nats_client.rs:62:19 [INFO] [stderr] | [INFO] [stderr] 62 | let msg = match self { [INFO] [stderr] | ___________________^ [INFO] [stderr] 63 | | &NatsError::ServerError(ref v) => format!("server error:{}", v.error_message), [INFO] [stderr] 64 | | &NatsError::ConnectionError(ref e, ref loc) => { [INFO] [stderr] 65 | | format!("connection error({}): {}", loc, e) [INFO] [stderr] ... | [INFO] [stderr] 76 | | &NatsError::MessageInfiniteLoop => format!("infinite wait loop in parse_message") [INFO] [stderr] 77 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 62 | let msg = match *self { [INFO] [stderr] 63 | NatsError::ServerError(ref v) => format!("server error:{}", v.error_message), [INFO] [stderr] 64 | NatsError::ConnectionError(ref e, ref loc) => { [INFO] [stderr] 65 | format!("connection error({}): {}", loc, e) [INFO] [stderr] 66 | } [INFO] [stderr] 67 | NatsError::EncodingError(ref e) => format!("encoding error:{}", e), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/nats_client.rs:75:45 [INFO] [stderr] | [INFO] [stderr] 75 | &NatsError::WaitInfiniteLoop => format!("infinite wait loop in wait_message"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"infinite wait loop in wait_message".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/nats_client.rs:76:48 [INFO] [stderr] | [INFO] [stderr] 76 | &NatsError::MessageInfiniteLoop => format!("infinite wait loop in parse_message") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"infinite wait loop in parse_message".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/nats_client.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | / match read_timeout { [INFO] [stderr] 155 | | Some(t) => Self::set_read_timeout_internal(&mut client, Some(t))?, [INFO] [stderr] 156 | | None => {} [INFO] [stderr] 157 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(t) = read_timeout { Self::set_read_timeout_internal(&mut client, Some(t))? }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/nats_client.rs:168:44 [INFO] [stderr] | [INFO] [stderr] 168 | let args: Vec<&str> = parsed.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/nats_client.rs:183:22 [INFO] [stderr] | [INFO] [stderr] 183 | verbose: match &opt { [INFO] [stderr] | ______________________^ [INFO] [stderr] 184 | | &Some(ref v) => v.verbose, [INFO] [stderr] 185 | | &None => true, [INFO] [stderr] 186 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 183 | verbose: match opt { [INFO] [stderr] 184 | Some(ref v) => v.verbose, [INFO] [stderr] 185 | None => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/nats_client.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | / match opt { [INFO] [stderr] 190 | | Some(opt) => ret.send_connect_option(&opt)?, [INFO] [stderr] 191 | | None => {} [INFO] [stderr] 192 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(opt) = opt { ret.send_connect_option(&opt)? }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/nats_client.rs:209:57 [INFO] [stderr] | [INFO] [stderr] 209 | return Err(NatsError::MessageParseError(format!("json serialization error"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"json serialization error".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: The function/method `::write_request` doesn't need a mutable reference [INFO] [stderr] --> src/nats_client.rs:245:51 [INFO] [stderr] | [INFO] [stderr] 245 | Self::write_request(&mut self.tcp_client, &mut crlf_bytes, "NatsClient::publish")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::write_request` doesn't need a mutable reference [INFO] [stderr] --> src/nats_client.rs:273:51 [INFO] [stderr] | [INFO] [stderr] 273 | Self::write_request(&mut self.tcp_client, &mut datastr.as_bytes(), "subscribe")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/nats_client.rs:303:62 [INFO] [stderr] | [INFO] [stderr] 303 | let headers: Vec<&str> = header_string.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/nats_client.rs:365:34 [INFO] [stderr] | [INFO] [stderr] 365 | let src_slice: Vec = self.receive_buffer[copylen..].iter().cloned().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `connect_option::ConnectOption` [INFO] [stderr] --> src/connect_option.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> ConnectOption { [INFO] [stderr] 17 | | Self::new_internal(None, None, None, None) [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/nats_client.rs:62:19 [INFO] [stderr] | [INFO] [stderr] 62 | let msg = match self { [INFO] [stderr] | ___________________^ [INFO] [stderr] 63 | | &NatsError::ServerError(ref v) => format!("server error:{}", v.error_message), [INFO] [stderr] 64 | | &NatsError::ConnectionError(ref e, ref loc) => { [INFO] [stderr] 65 | | format!("connection error({}): {}", loc, e) [INFO] [stderr] ... | [INFO] [stderr] 76 | | &NatsError::MessageInfiniteLoop => format!("infinite wait loop in parse_message") [INFO] [stderr] 77 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 62 | let msg = match *self { [INFO] [stderr] 63 | NatsError::ServerError(ref v) => format!("server error:{}", v.error_message), [INFO] [stderr] 64 | NatsError::ConnectionError(ref e, ref loc) => { [INFO] [stderr] 65 | format!("connection error({}): {}", loc, e) [INFO] [stderr] 66 | } [INFO] [stderr] 67 | NatsError::EncodingError(ref e) => format!("encoding error:{}", e), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/nats_client.rs:75:45 [INFO] [stderr] | [INFO] [stderr] 75 | &NatsError::WaitInfiniteLoop => format!("infinite wait loop in wait_message"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"infinite wait loop in wait_message".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/nats_client.rs:76:48 [INFO] [stderr] | [INFO] [stderr] 76 | &NatsError::MessageInfiniteLoop => format!("infinite wait loop in parse_message") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"infinite wait loop in parse_message".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/nats_client.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | / match read_timeout { [INFO] [stderr] 155 | | Some(t) => Self::set_read_timeout_internal(&mut client, Some(t))?, [INFO] [stderr] 156 | | None => {} [INFO] [stderr] 157 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(t) = read_timeout { Self::set_read_timeout_internal(&mut client, Some(t))? }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/nats_client.rs:168:44 [INFO] [stderr] | [INFO] [stderr] 168 | let args: Vec<&str> = parsed.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/nats_client.rs:183:22 [INFO] [stderr] | [INFO] [stderr] 183 | verbose: match &opt { [INFO] [stderr] | ______________________^ [INFO] [stderr] 184 | | &Some(ref v) => v.verbose, [INFO] [stderr] 185 | | &None => true, [INFO] [stderr] 186 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 183 | verbose: match opt { [INFO] [stderr] 184 | Some(ref v) => v.verbose, [INFO] [stderr] 185 | None => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/nats_client.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | / match opt { [INFO] [stderr] 190 | | Some(opt) => ret.send_connect_option(&opt)?, [INFO] [stderr] 191 | | None => {} [INFO] [stderr] 192 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(opt) = opt { ret.send_connect_option(&opt)? }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/nats_client.rs:209:57 [INFO] [stderr] | [INFO] [stderr] 209 | return Err(NatsError::MessageParseError(format!("json serialization error"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"json serialization error".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: The function/method `::write_request` doesn't need a mutable reference [INFO] [stderr] --> src/nats_client.rs:245:51 [INFO] [stderr] | [INFO] [stderr] 245 | Self::write_request(&mut self.tcp_client, &mut crlf_bytes, "NatsClient::publish")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::write_request` doesn't need a mutable reference [INFO] [stderr] --> src/nats_client.rs:273:51 [INFO] [stderr] | [INFO] [stderr] 273 | Self::write_request(&mut self.tcp_client, &mut datastr.as_bytes(), "subscribe")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/nats_client.rs:303:62 [INFO] [stderr] | [INFO] [stderr] 303 | let headers: Vec<&str> = header_string.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/nats_client.rs:365:34 [INFO] [stderr] | [INFO] [stderr] 365 | let src_slice: Vec = self.receive_buffer[copylen..].iter().cloned().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `connect_option::ConnectOption` [INFO] [stderr] --> src/connect_option.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> ConnectOption { [INFO] [stderr] 17 | | Self::new_internal(None, None, None, None) [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/bench.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `simple_nats_client`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/multithread.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / return [(val & 0xff) as u8, [INFO] [stderr] 20 | | ((val >> 8) & 0xff) as u8, [INFO] [stderr] 21 | | ((val >> 16) & 0xff) as u8, [INFO] [stderr] 22 | | ((val >> 24) & 0xff) as u8]; [INFO] [stderr] | |________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 19 | [(val & 0xff) as u8, [INFO] [stderr] 20 | ((val >> 8) & 0xff) as u8, [INFO] [stderr] 21 | ((val >> 16) & 0xff) as u8, [INFO] [stderr] 22 | ((val >> 24) & 0xff) as u8] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/multithread.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | return val as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `val as i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `dat` [INFO] [stderr] --> tests/test.rs:68:30 [INFO] [stderr] | [INFO] [stderr] 68 | for j in 0..dat.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 68 | for (j, ) in dat.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> tests/multithread.rs:26:15 [INFO] [stderr] | [INFO] [stderr] 26 | let val = (ar[0] as u32) + ((ar[1] as u32) << 8) + ((ar[2] as u32) << 16) + [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(ar[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> tests/multithread.rs:26:33 [INFO] [stderr] | [INFO] [stderr] 26 | let val = (ar[0] as u32) + ((ar[1] as u32) << 8) + ((ar[2] as u32) << 16) + [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(ar[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> tests/multithread.rs:26:57 [INFO] [stderr] | [INFO] [stderr] 26 | let val = (ar[0] as u32) + ((ar[1] as u32) << 8) + ((ar[2] as u32) << 16) + [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(ar[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> tests/multithread.rs:27:16 [INFO] [stderr] | [INFO] [stderr] 27 | ((ar[3] as u32) << 24); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(ar[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "5a732caaa255c5dd8225c6fe2ce3a57546c9ebf6aa8852538d0b71d8133c5d0f"` [INFO] running `"docker" "rm" "-f" "5a732caaa255c5dd8225c6fe2ce3a57546c9ebf6aa8852538d0b71d8133c5d0f"` [INFO] [stdout] 5a732caaa255c5dd8225c6fe2ce3a57546c9ebf6aa8852538d0b71d8133c5d0f