[INFO] crate simple_kbuckets 0.2.0 is already in cache [INFO] extracting crate simple_kbuckets 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/simple_kbuckets/0.2.0 [INFO] extracting crate simple_kbuckets 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/simple_kbuckets/0.2.0 [INFO] validating manifest of simple_kbuckets-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of simple_kbuckets-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing simple_kbuckets-0.2.0 [INFO] finished frobbing simple_kbuckets-0.2.0 [INFO] frobbed toml for simple_kbuckets-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/simple_kbuckets/0.2.0/Cargo.toml [INFO] started frobbing simple_kbuckets-0.2.0 [INFO] finished frobbing simple_kbuckets-0.2.0 [INFO] frobbed toml for simple_kbuckets-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/simple_kbuckets/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting simple_kbuckets-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/simple_kbuckets/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ef7f11d4e88a46f9da7c5264c616f805e4891b0b4428c5b50992b7e55b693035 [INFO] running `"docker" "start" "-a" "ef7f11d4e88a46f9da7c5264c616f805e4891b0b4428c5b50992b7e55b693035"` [INFO] [stderr] Checking simple_kbuckets v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bucket.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | max_size: max_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `max_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | buckets: buckets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `buckets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | my_key: my_key, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `my_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bucket.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | max_size: max_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `max_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | buckets: buckets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `buckets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | my_key: my_key, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `my_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/table.rs:15:23 [INFO] [stderr] | [INFO] [stderr] 15 | let buckets = (0..max_bits+1).map(|_| Bucket::new(max_bucket_size)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `(0..=max_bits)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/table.rs:36:57 [INFO] [stderr] | [INFO] [stderr] 36 | let bucket = self.buckets.get_mut(bucket_index).expect( [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 37 | | &format!("Distance between {:?} and {:?} is greater than 2^max_bits.", [INFO] [stderr] 38 | | self.my_key, key)); [INFO] [stderr] | |__________________________________^ help: try this: `unwrap_or_else(|| panic!("Distance between {:?} and {:?} is greater than 2^max_bits.", self.my_key))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/table.rs:15:23 [INFO] [stderr] | [INFO] [stderr] 15 | let buckets = (0..max_bits+1).map(|_| Bucket::new(max_bucket_size)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `(0..=max_bits)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/table.rs:36:57 [INFO] [stderr] | [INFO] [stderr] 36 | let bucket = self.buckets.get_mut(bucket_index).expect( [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 37 | | &format!("Distance between {:?} and {:?} is greater than 2^max_bits.", [INFO] [stderr] 38 | | self.my_key, key)); [INFO] [stderr] | |__________________________________^ help: try this: `unwrap_or_else(|| panic!("Distance between {:?} and {:?} is greater than 2^max_bits.", self.my_key))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.52s [INFO] running `"docker" "inspect" "ef7f11d4e88a46f9da7c5264c616f805e4891b0b4428c5b50992b7e55b693035"` [INFO] running `"docker" "rm" "-f" "ef7f11d4e88a46f9da7c5264c616f805e4891b0b4428c5b50992b7e55b693035"` [INFO] [stdout] ef7f11d4e88a46f9da7c5264c616f805e4891b0b4428c5b50992b7e55b693035