[INFO] crate simple_jwt 1.2.1 is already in cache [INFO] extracting crate simple_jwt 1.2.1 into work/ex/clippy-test-run/sources/stable/reg/simple_jwt/1.2.1 [INFO] extracting crate simple_jwt 1.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/simple_jwt/1.2.1 [INFO] validating manifest of simple_jwt-1.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of simple_jwt-1.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing simple_jwt-1.2.1 [INFO] finished frobbing simple_jwt-1.2.1 [INFO] frobbed toml for simple_jwt-1.2.1 written to work/ex/clippy-test-run/sources/stable/reg/simple_jwt/1.2.1/Cargo.toml [INFO] started frobbing simple_jwt-1.2.1 [INFO] finished frobbing simple_jwt-1.2.1 [INFO] frobbed toml for simple_jwt-1.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/simple_jwt/1.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting simple_jwt-1.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/simple_jwt/1.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ef2690959fe2de5ad2c496768d0f1383d48e53d5b7d583c50aa311acd8cb6638 [INFO] running `"docker" "start" "-a" "ef2690959fe2de5ad2c496768d0f1383d48e53d5b7d583c50aa311acd8cb6638"` [INFO] [stderr] Checking base64 v0.7.0 [INFO] [stderr] Checking simple_jwt v1.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | Header {alg: alg, typ: "JWT".to_string()} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `alg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | Header {alg: alg, typ: "JWT".to_string()} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `alg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'openssl::sign::Signer::finish': renamed to sign_to_vec [INFO] [stderr] --> src/digest.rs:54:32 [INFO] [stderr] | [INFO] [stderr] 54 | let byte_vec = try!(signer.finish()); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'openssl::sign::Signer::finish': renamed to sign_to_vec [INFO] [stderr] --> src/digest.rs:79:30 [INFO] [stderr] | [INFO] [stderr] 79 | let result = try!(signer.finish()); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'openssl::sign::Verifier::finish': renamed to `verify` [INFO] [stderr] --> src/digest.rs:92:27 [INFO] [stderr] | [INFO] [stderr] 92 | let b = try!(verifier.finish(sig)); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'openssl::sign::Signer::finish': renamed to sign_to_vec [INFO] [stderr] --> src/digest.rs:107:30 [INFO] [stderr] | [INFO] [stderr] 107 | let result = try!(signer.finish()); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'openssl::sign::Verifier::finish': renamed to `verify` [INFO] [stderr] --> src/digest.rs:122:27 [INFO] [stderr] | [INFO] [stderr] 122 | let b = try!(verifier.finish(&der_sig)); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/utils.rs:31:33 [INFO] [stderr] | [INFO] [stderr] 31 | s.get(i).map(|u| u.clone()).ok_or(ErrorKind::InvalidSignature.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::InvalidSignature.into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/utils.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | s.get(i).map(|u| u.clone()).ok_or(ErrorKind::InvalidSignature.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `s.get(i).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/utils.rs:31:22 [INFO] [stderr] | [INFO] [stderr] 31 | s.get(i).map(|u| u.clone()).ok_or(ErrorKind::InvalidSignature.into()) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*u` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/utils.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | r_len = r_len << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `r_len <<= 8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/utils.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | r_len = r_len | (_safe_get_u8s(s, idx)? as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `r_len |= (_safe_get_u8s(s, idx)? as usize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/utils.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | s_len = s_len << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `s_len <<= 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/utils.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | s_len = s_len | (_safe_get_u8s(s, idx)? as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `s_len |= (_safe_get_u8s(s, idx)? as usize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/utils.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | temp = temp >> 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `temp >>= 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/utils.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | temp = temp >> 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `temp >>= 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/utils.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | temp = temp >> 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `temp >>= 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/utils.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | temp = temp >> 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `temp >>= 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/utils.rs:201:9 [INFO] [stderr] | [INFO] [stderr] 201 | temp = temp >> 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `temp >>= 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/utils.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | temp = temp >> 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `temp >>= 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `rs` [INFO] [stderr] --> src/utils.rs:231:14 [INFO] [stderr] | [INFO] [stderr] 231 | for i in 0..rs.len() { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 231 | for (i, ) in rs.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `ss` [INFO] [stderr] --> src/utils.rs:249:14 [INFO] [stderr] | [INFO] [stderr] 249 | for i in 0..ss.len() { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 249 | for (i, ) in ss.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'openssl::sign::Signer::finish': renamed to sign_to_vec [INFO] [stderr] --> src/digest.rs:54:32 [INFO] [stderr] | [INFO] [stderr] 54 | let byte_vec = try!(signer.finish()); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'openssl::sign::Signer::finish': renamed to sign_to_vec [INFO] [stderr] --> src/digest.rs:79:30 [INFO] [stderr] | [INFO] [stderr] 79 | let result = try!(signer.finish()); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'openssl::sign::Verifier::finish': renamed to `verify` [INFO] [stderr] --> src/digest.rs:92:27 [INFO] [stderr] | [INFO] [stderr] 92 | let b = try!(verifier.finish(sig)); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'openssl::sign::Signer::finish': renamed to sign_to_vec [INFO] [stderr] --> src/digest.rs:107:30 [INFO] [stderr] | [INFO] [stderr] 107 | let result = try!(signer.finish()); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'openssl::sign::Verifier::finish': renamed to `verify` [INFO] [stderr] --> src/digest.rs:122:27 [INFO] [stderr] | [INFO] [stderr] 122 | let b = try!(verifier.finish(&der_sig)); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/utils.rs:31:33 [INFO] [stderr] | [INFO] [stderr] 31 | s.get(i).map(|u| u.clone()).ok_or(ErrorKind::InvalidSignature.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::InvalidSignature.into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/utils.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | s.get(i).map(|u| u.clone()).ok_or(ErrorKind::InvalidSignature.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `s.get(i).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/utils.rs:31:22 [INFO] [stderr] | [INFO] [stderr] 31 | s.get(i).map(|u| u.clone()).ok_or(ErrorKind::InvalidSignature.into()) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*u` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/utils.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | r_len = r_len << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `r_len <<= 8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/utils.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | r_len = r_len | (_safe_get_u8s(s, idx)? as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `r_len |= (_safe_get_u8s(s, idx)? as usize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/utils.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | s_len = s_len << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `s_len <<= 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/utils.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | s_len = s_len | (_safe_get_u8s(s, idx)? as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `s_len |= (_safe_get_u8s(s, idx)? as usize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/utils.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | temp = temp >> 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `temp >>= 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/utils.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | temp = temp >> 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `temp >>= 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/utils.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | temp = temp >> 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `temp >>= 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/utils.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | temp = temp >> 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `temp >>= 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/utils.rs:201:9 [INFO] [stderr] | [INFO] [stderr] 201 | temp = temp >> 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `temp >>= 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/utils.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | temp = temp >> 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `temp >>= 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `rs` [INFO] [stderr] --> src/utils.rs:231:14 [INFO] [stderr] | [INFO] [stderr] 231 | for i in 0..rs.len() { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 231 | for (i, ) in rs.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `ss` [INFO] [stderr] --> src/utils.rs:249:14 [INFO] [stderr] | [INFO] [stderr] 249 | for i in 0..ss.len() { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 249 | for (i, ) in ss.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:89:36 [INFO] [stderr] | [INFO] [stderr] 89 | ($err:expr, $kind:pat) => (match $err.kind() { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 90 | | &$kind => assert!(true, "{:?} is of kind {:?}", $err, stringify!($kind)), [INFO] [stderr] 91 | | _ => assert!(false, "{:?} is NOT of kind {:?}", $err, stringify!($kind)) [INFO] [stderr] 92 | | }); [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 172 | assert_error_kind!(err, ErrorKind::InvalidSignature); [INFO] [stderr] | ----------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.37s [INFO] running `"docker" "inspect" "ef2690959fe2de5ad2c496768d0f1383d48e53d5b7d583c50aa311acd8cb6638"` [INFO] running `"docker" "rm" "-f" "ef2690959fe2de5ad2c496768d0f1383d48e53d5b7d583c50aa311acd8cb6638"` [INFO] [stdout] ef2690959fe2de5ad2c496768d0f1383d48e53d5b7d583c50aa311acd8cb6638