[INFO] crate simple_excel_writer 0.1.4 is already in cache [INFO] extracting crate simple_excel_writer 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/simple_excel_writer/0.1.4 [INFO] extracting crate simple_excel_writer 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/simple_excel_writer/0.1.4 [INFO] validating manifest of simple_excel_writer-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of simple_excel_writer-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing simple_excel_writer-0.1.4 [INFO] finished frobbing simple_excel_writer-0.1.4 [INFO] frobbed toml for simple_excel_writer-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/simple_excel_writer/0.1.4/Cargo.toml [INFO] started frobbing simple_excel_writer-0.1.4 [INFO] finished frobbing simple_excel_writer-0.1.4 [INFO] frobbed toml for simple_excel_writer-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/simple_excel_writer/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting simple_excel_writer-0.1.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/simple_excel_writer/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 446dcce964604e0b0545b47abc2ee4367fa8c3b96271f9d276606ed832f0f559 [INFO] running `"docker" "start" "-a" "446dcce964604e0b0545b47abc2ee4367fa8c3b96271f9d276606ed832f0f559"` [INFO] [stderr] Checking simple_excel_writer v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sheet.rs:110:74 [INFO] [stderr] | [INFO] [stderr] 110 | self.cells.push(Cell { column_index: self.max_col_index, value: value }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sheet.rs:208:13 [INFO] [stderr] | [INFO] [stderr] 208 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sheet.rs:271:23 [INFO] [stderr] | [INFO] [stderr] 271 | SheetWriter { sheet: sheet, writer: writer } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `sheet` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sheet.rs:271:37 [INFO] [stderr] | [INFO] [stderr] 271 | SheetWriter { sheet: sheet, writer: writer } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sheet.rs:110:74 [INFO] [stderr] | [INFO] [stderr] 110 | self.cells.push(Cell { column_index: self.max_col_index, value: value }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sheet.rs:208:13 [INFO] [stderr] | [INFO] [stderr] 208 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sheet.rs:271:23 [INFO] [stderr] | [INFO] [stderr] 271 | SheetWriter { sheet: sheet, writer: writer } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `sheet` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sheet.rs:271:37 [INFO] [stderr] | [INFO] [stderr] 271 | SheetWriter { sheet: sheet, writer: writer } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/sheet.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | / match cv { [INFO] [stderr] 148 | | &CellValue::Bool(b) => { [INFO] [stderr] 149 | | let v = match b { [INFO] [stderr] 150 | | true => 1, [INFO] [stderr] ... | [INFO] [stderr] 164 | | &CellValue::Blank(_) => {}, [INFO] [stderr] 165 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 147 | match *cv { [INFO] [stderr] 148 | CellValue::Bool(b) => { [INFO] [stderr] 149 | let v = match b { [INFO] [stderr] 150 | true => 1, [INFO] [stderr] 151 | false => 0, [INFO] [stderr] 152 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/sheet.rs:149:21 [INFO] [stderr] | [INFO] [stderr] 149 | let v = match b { [INFO] [stderr] | _____________________^ [INFO] [stderr] 150 | | true => 1, [INFO] [stderr] 151 | | false => 0, [INFO] [stderr] 152 | | }; [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if b { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/sheet.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | / match cv { [INFO] [stderr] 148 | | &CellValue::Bool(b) => { [INFO] [stderr] 149 | | let v = match b { [INFO] [stderr] 150 | | true => 1, [INFO] [stderr] ... | [INFO] [stderr] 164 | | &CellValue::Blank(_) => {}, [INFO] [stderr] 165 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 147 | match *cv { [INFO] [stderr] 148 | CellValue::Bool(b) => { [INFO] [stderr] 149 | let v = match b { [INFO] [stderr] 150 | true => 1, [INFO] [stderr] 151 | false => 0, [INFO] [stderr] 152 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/sheet.rs:149:21 [INFO] [stderr] | [INFO] [stderr] 149 | let v = match b { [INFO] [stderr] | _____________________^ [INFO] [stderr] 150 | | true => 1, [INFO] [stderr] 151 | | false => 0, [INFO] [stderr] 152 | | }; [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if b { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> examples/simple.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.26s [INFO] running `"docker" "inspect" "446dcce964604e0b0545b47abc2ee4367fa8c3b96271f9d276606ed832f0f559"` [INFO] running `"docker" "rm" "-f" "446dcce964604e0b0545b47abc2ee4367fa8c3b96271f9d276606ed832f0f559"` [INFO] [stdout] 446dcce964604e0b0545b47abc2ee4367fa8c3b96271f9d276606ed832f0f559