[INFO] crate simple_asn1 0.2.1 is already in cache [INFO] extracting crate simple_asn1 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/simple_asn1/0.2.1 [INFO] extracting crate simple_asn1 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/simple_asn1/0.2.1 [INFO] validating manifest of simple_asn1-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of simple_asn1-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing simple_asn1-0.2.1 [INFO] finished frobbing simple_asn1-0.2.1 [INFO] frobbed toml for simple_asn1-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/simple_asn1/0.2.1/Cargo.toml [INFO] started frobbing simple_asn1-0.2.1 [INFO] finished frobbing simple_asn1-0.2.1 [INFO] frobbed toml for simple_asn1-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/simple_asn1/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting simple_asn1-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/simple_asn1/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0e584bb9090bdd3b37d03f775250ded27577fbb446decd2bd7832a1b820b4efc [INFO] running `"docker" "start" "-a" "0e584bb9090bdd3b37d03f775250ded27577fbb446decd2bd7832a1b820b4efc"` [INFO] [stderr] Checking quickcheck v0.7.2 [INFO] [stderr] Checking simple_asn1 v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:1206:25 [INFO] [stderr] | [INFO] [stderr] 1206 | let h = g.gen_range::(0,24); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:1208:25 [INFO] [stderr] | [INFO] [stderr] 1208 | let s = g.gen_range::(0,60); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:1209:25 [INFO] [stderr] | [INFO] [stderr] 1209 | let t = d.and_hms(h,m,s); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:1227:25 [INFO] [stderr] | [INFO] [stderr] 1227 | let h = g.gen_range::(0,24); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:1229:25 [INFO] [stderr] | [INFO] [stderr] 1229 | let s = g.gen_range::(0,60); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:1230:25 [INFO] [stderr] | [INFO] [stderr] 1230 | let n = g.gen_range::(0,1000000000); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:1231:25 [INFO] [stderr] | [INFO] [stderr] 1231 | let t = d.and_hms_nano(h,m,s,n); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:242:25 [INFO] [stderr] | [INFO] [stderr] 242 | const PRINTABLE_CHARS: &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:850:35 [INFO] [stderr] | [INFO] [stderr] 850 | res.insert(0, cbyte | 0b00011111); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:883:39 [INFO] [stderr] | [INFO] [stderr] 883 | ASN1Class::Universal => 0b00000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:884:39 [INFO] [stderr] | [INFO] [stderr] 884 | ASN1Class::Application => 0b01000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:885:39 [INFO] [stderr] | [INFO] [stderr] 885 | ASN1Class::ContextSpecific => 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:886:39 [INFO] [stderr] | [INFO] [stderr] 886 | ASN1Class::Private => 0b11000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / match self { [INFO] [stderr] 90 | | &ASN1Block::Boolean(c,_,_) => c, [INFO] [stderr] 91 | | &ASN1Block::Integer(c,_,_) => c, [INFO] [stderr] 92 | | &ASN1Block::BitString(c,_,_,_) => c, [INFO] [stderr] ... | [INFO] [stderr] 106 | | &ASN1Block::Unknown(c,_,_,_) => c [INFO] [stderr] 107 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 89 | match *self { [INFO] [stderr] 90 | ASN1Block::Boolean(c,_,_) => c, [INFO] [stderr] 91 | ASN1Block::Integer(c,_,_) => c, [INFO] [stderr] 92 | ASN1Block::BitString(c,_,_,_) => c, [INFO] [stderr] 93 | ASN1Block::OctetString(c,_,_) => c, [INFO] [stderr] 94 | ASN1Block::Null(c,_) => c, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | / match self { [INFO] [stderr] 114 | | &ASN1Block::Boolean(_,o,_) => o, [INFO] [stderr] 115 | | &ASN1Block::Integer(_,o,_) => o, [INFO] [stderr] 116 | | &ASN1Block::BitString(_,o,_,_) => o, [INFO] [stderr] ... | [INFO] [stderr] 130 | | &ASN1Block::Unknown(_,o,_,_) => o [INFO] [stderr] 131 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 113 | match *self { [INFO] [stderr] 114 | ASN1Block::Boolean(_,o,_) => o, [INFO] [stderr] 115 | ASN1Block::Integer(_,o,_) => o, [INFO] [stderr] 116 | ASN1Block::BitString(_,o,_,_) => o, [INFO] [stderr] 117 | ASN1Block::OctetString(_,o,_) => o, [INFO] [stderr] 118 | ASN1Block::Null(_,o) => o, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:370:27 [INFO] [stderr] | [INFO] [stderr] 370 | Some(0x03) if body.len() == 0 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `body.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:396:25 [INFO] [stderr] | [INFO] [stderr] 396 | value2 = value2 - BigUint::from_u8(40).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value2 -= BigUint::from_u8(40).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:399:25 [INFO] [stderr] | [INFO] [stderr] 399 | value2 = value2 - BigUint::from_u8(80).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value2 -= BigUint::from_u8(80).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:609:5 [INFO] [stderr] | [INFO] [stderr] 609 | / match i { [INFO] [stderr] 610 | | // BOOLEAN [INFO] [stderr] 611 | | &ASN1Block::Boolean(cl, _, val) => { [INFO] [stderr] 612 | | let inttag = BigUint::one(); [INFO] [stderr] ... | [INFO] [stderr] 807 | | } [INFO] [stderr] 808 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 609 | match *i { [INFO] [stderr] 610 | // BOOLEAN [INFO] [stderr] 611 | ASN1Block::Boolean(cl, _, val) => { [INFO] [stderr] 612 | let inttag = BigUint::one(); [INFO] [stderr] 613 | let mut tagbytes = encode_tag(cl, &inttag); [INFO] [stderr] 614 | tagbytes.push(1); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:677:24 [INFO] [stderr] | [INFO] [stderr] 677 | if v1 > &two { [INFO] [stderr] | ^^^^^---- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `two` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:685:24 [INFO] [stderr] | [INFO] [stderr] 685 | if v2 > &bound { [INFO] [stderr] | ^^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `bound` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:811:68 [INFO] [stderr] | [INFO] [stderr] 811 | fn encode_asn1_string(tag: u8, force_chars: bool, c: ASN1Class, s: &String) [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:865:9 [INFO] [stderr] | [INFO] [stderr] 865 | acc = acc >> 7; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `acc >>= 7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:901:13 [INFO] [stderr] | [INFO] [stderr] 901 | work = work >> 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `work >>= 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:1206:25 [INFO] [stderr] | [INFO] [stderr] 1206 | let h = g.gen_range::(0,24); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:1208:25 [INFO] [stderr] | [INFO] [stderr] 1208 | let s = g.gen_range::(0,60); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:1209:25 [INFO] [stderr] | [INFO] [stderr] 1209 | let t = d.and_hms(h,m,s); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:1227:25 [INFO] [stderr] | [INFO] [stderr] 1227 | let h = g.gen_range::(0,24); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:1229:25 [INFO] [stderr] | [INFO] [stderr] 1229 | let s = g.gen_range::(0,60); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:1230:25 [INFO] [stderr] | [INFO] [stderr] 1230 | let n = g.gen_range::(0,1000000000); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:1231:25 [INFO] [stderr] | [INFO] [stderr] 1231 | let t = d.and_hms_nano(h,m,s,n); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:242:25 [INFO] [stderr] | [INFO] [stderr] 242 | const PRINTABLE_CHARS: &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:850:35 [INFO] [stderr] | [INFO] [stderr] 850 | res.insert(0, cbyte | 0b00011111); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:883:39 [INFO] [stderr] | [INFO] [stderr] 883 | ASN1Class::Universal => 0b00000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:884:39 [INFO] [stderr] | [INFO] [stderr] 884 | ASN1Class::Application => 0b01000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:885:39 [INFO] [stderr] | [INFO] [stderr] 885 | ASN1Class::ContextSpecific => 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:886:39 [INFO] [stderr] | [INFO] [stderr] 886 | ASN1Class::Private => 0b11000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1013:18 [INFO] [stderr] | [INFO] [stderr] 1013 | (v & 0b11000000) == encode_class(decode_class(v)) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1230:50 [INFO] [stderr] | [INFO] [stderr] 1230 | let n = g.gen_range::(0,1000000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / match self { [INFO] [stderr] 90 | | &ASN1Block::Boolean(c,_,_) => c, [INFO] [stderr] 91 | | &ASN1Block::Integer(c,_,_) => c, [INFO] [stderr] 92 | | &ASN1Block::BitString(c,_,_,_) => c, [INFO] [stderr] ... | [INFO] [stderr] 106 | | &ASN1Block::Unknown(c,_,_,_) => c [INFO] [stderr] 107 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 89 | match *self { [INFO] [stderr] 90 | ASN1Block::Boolean(c,_,_) => c, [INFO] [stderr] 91 | ASN1Block::Integer(c,_,_) => c, [INFO] [stderr] 92 | ASN1Block::BitString(c,_,_,_) => c, [INFO] [stderr] 93 | ASN1Block::OctetString(c,_,_) => c, [INFO] [stderr] 94 | ASN1Block::Null(c,_) => c, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | / match self { [INFO] [stderr] 114 | | &ASN1Block::Boolean(_,o,_) => o, [INFO] [stderr] 115 | | &ASN1Block::Integer(_,o,_) => o, [INFO] [stderr] 116 | | &ASN1Block::BitString(_,o,_,_) => o, [INFO] [stderr] ... | [INFO] [stderr] 130 | | &ASN1Block::Unknown(_,o,_,_) => o [INFO] [stderr] 131 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 113 | match *self { [INFO] [stderr] 114 | ASN1Block::Boolean(_,o,_) => o, [INFO] [stderr] 115 | ASN1Block::Integer(_,o,_) => o, [INFO] [stderr] 116 | ASN1Block::BitString(_,o,_,_) => o, [INFO] [stderr] 117 | ASN1Block::OctetString(_,o,_) => o, [INFO] [stderr] 118 | ASN1Block::Null(_,o) => o, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:370:27 [INFO] [stderr] | [INFO] [stderr] 370 | Some(0x03) if body.len() == 0 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `body.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:396:25 [INFO] [stderr] | [INFO] [stderr] 396 | value2 = value2 - BigUint::from_u8(40).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value2 -= BigUint::from_u8(40).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:399:25 [INFO] [stderr] | [INFO] [stderr] 399 | value2 = value2 - BigUint::from_u8(80).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value2 -= BigUint::from_u8(80).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:609:5 [INFO] [stderr] | [INFO] [stderr] 609 | / match i { [INFO] [stderr] 610 | | // BOOLEAN [INFO] [stderr] 611 | | &ASN1Block::Boolean(cl, _, val) => { [INFO] [stderr] 612 | | let inttag = BigUint::one(); [INFO] [stderr] ... | [INFO] [stderr] 807 | | } [INFO] [stderr] 808 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 609 | match *i { [INFO] [stderr] 610 | // BOOLEAN [INFO] [stderr] 611 | ASN1Block::Boolean(cl, _, val) => { [INFO] [stderr] 612 | let inttag = BigUint::one(); [INFO] [stderr] 613 | let mut tagbytes = encode_tag(cl, &inttag); [INFO] [stderr] 614 | tagbytes.push(1); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:677:24 [INFO] [stderr] | [INFO] [stderr] 677 | if v1 > &two { [INFO] [stderr] | ^^^^^---- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `two` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:685:24 [INFO] [stderr] | [INFO] [stderr] 685 | if v2 > &bound { [INFO] [stderr] | ^^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `bound` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:811:68 [INFO] [stderr] | [INFO] [stderr] 811 | fn encode_asn1_string(tag: u8, force_chars: bool, c: ASN1Class, s: &String) [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:865:9 [INFO] [stderr] | [INFO] [stderr] 865 | acc = acc >> 7; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `acc >>= 7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:901:13 [INFO] [stderr] | [INFO] [stderr] 901 | work = work >> 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `work >>= 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:1009:44 [INFO] [stderr] | [INFO] [stderr] 1009 | c == decode_class(encode_class(c.clone())) [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:1297:38 [INFO] [stderr] | [INFO] [stderr] 1297 | let v2 = rvec.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&rvec[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:1329:69 [INFO] [stderr] | [INFO] [stderr] 1329 | let b = ASN1Block::GeneralizedTime(ASN1Class::Universal, 0, d.clone()); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1343:29 [INFO] [stderr] | [INFO] [stderr] 1343 | assert_eq!(from_der(&vec![0x02,0x01,0x00]), result_int(0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0x02,0x01,0x00]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1344:29 [INFO] [stderr] | [INFO] [stderr] 1344 | assert_eq!(from_der(&vec![0x02,0x01,0x7F]), result_int(127)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0x02,0x01,0x7F]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1345:29 [INFO] [stderr] | [INFO] [stderr] 1345 | assert_eq!(from_der(&vec![0x02,0x02,0x00,0x80]), result_int(128)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0x02,0x02,0x00,0x80]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1346:29 [INFO] [stderr] | [INFO] [stderr] 1346 | assert_eq!(from_der(&vec![0x02,0x02,0x01,0x00]), result_int(256)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0x02,0x02,0x01,0x00]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1347:29 [INFO] [stderr] | [INFO] [stderr] 1347 | assert_eq!(from_der(&vec![0x02,0x01,0x80]), result_int(-128)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0x02,0x01,0x80]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:1348:29 [INFO] [stderr] | [INFO] [stderr] 1348 | assert_eq!(from_der(&vec![0x02,0x02,0xFF,0x7F]), result_int(-129)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0x02,0x02,0xFF,0x7F]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.96s [INFO] running `"docker" "inspect" "0e584bb9090bdd3b37d03f775250ded27577fbb446decd2bd7832a1b820b4efc"` [INFO] running `"docker" "rm" "-f" "0e584bb9090bdd3b37d03f775250ded27577fbb446decd2bd7832a1b820b4efc"` [INFO] [stdout] 0e584bb9090bdd3b37d03f775250ded27577fbb446decd2bd7832a1b820b4efc