[INFO] crate simple-http-server 0.4.6 is already in cache [INFO] extracting crate simple-http-server 0.4.6 into work/ex/clippy-test-run/sources/stable/reg/simple-http-server/0.4.6 [INFO] extracting crate simple-http-server 0.4.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/simple-http-server/0.4.6 [INFO] validating manifest of simple-http-server-0.4.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of simple-http-server-0.4.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing simple-http-server-0.4.6 [INFO] finished frobbing simple-http-server-0.4.6 [INFO] frobbed toml for simple-http-server-0.4.6 written to work/ex/clippy-test-run/sources/stable/reg/simple-http-server/0.4.6/Cargo.toml [INFO] started frobbing simple-http-server-0.4.6 [INFO] finished frobbing simple-http-server-0.4.6 [INFO] frobbed toml for simple-http-server-0.4.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/simple-http-server/0.4.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting simple-http-server-0.4.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/simple-http-server/0.4.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ad8d57fed8311dc8dc87319ab17509d9b2f36cfc201f4f3d80a1638fde4be591 [INFO] running `"docker" "start" "-a" "ad8d57fed8311dc8dc87319ab17509d9b2f36cfc201f4f3d80a1638fde4be591"` [INFO] [stderr] Checking filetime v0.1.15 [INFO] [stderr] Checking twoway v0.1.8 [INFO] [stderr] Checking buf_redux v0.6.3 [INFO] [stderr] Checking pretty-bytes v0.2.2 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking iron v0.5.1 [INFO] [stderr] Checking tiny_http v0.5.9 [INFO] [stderr] Compiling mime_guess v1.8.6 [INFO] [stderr] Checking iron-cors v0.5.1 [INFO] [stderr] Checking multipart v0.12.0 [INFO] [stderr] Checking simple-http-server v0.4.6 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:147:60 [INFO] [stderr] | [INFO] [stderr] 147 | if parts.len() < 2 || parts.len() >= 2 && parts[1].len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `parts[1].is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:149:28 [INFO] [stderr] | [INFO] [stderr] 149 | } else if parts[0].len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `parts[0].is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:147:60 [INFO] [stderr] | [INFO] [stderr] 147 | if parts.len() < 2 || parts.len() >= 2 && parts[1].len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `parts[1].is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:149:28 [INFO] [stderr] | [INFO] [stderr] 149 | } else if parts[0].len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `parts[0].is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/main.rs:709:77 [INFO] [stderr] | [INFO] [stderr] 709 | Some(&IfRange::Date(HttpDate(ref date_ifrange))) => &time::at(modified) <= date_ifrange, [INFO] [stderr] | -------------------^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `time::at(modified)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/main.rs:709:77 [INFO] [stderr] | [INFO] [stderr] 709 | Some(&IfRange::Date(HttpDate(ref date_ifrange))) => &time::at(modified) <= date_ifrange, [INFO] [stderr] | -------------------^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `time::at(modified)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.31s [INFO] running `"docker" "inspect" "ad8d57fed8311dc8dc87319ab17509d9b2f36cfc201f4f3d80a1638fde4be591"` [INFO] running `"docker" "rm" "-f" "ad8d57fed8311dc8dc87319ab17509d9b2f36cfc201f4f3d80a1638fde4be591"` [INFO] [stdout] ad8d57fed8311dc8dc87319ab17509d9b2f36cfc201f4f3d80a1638fde4be591