[INFO] crate simlink 0.1.0 is already in cache [INFO] extracting crate simlink 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/simlink/0.1.0 [INFO] extracting crate simlink 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/simlink/0.1.0 [INFO] validating manifest of simlink-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of simlink-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing simlink-0.1.0 [INFO] finished frobbing simlink-0.1.0 [INFO] frobbed toml for simlink-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/simlink/0.1.0/Cargo.toml [INFO] started frobbing simlink-0.1.0 [INFO] finished frobbing simlink-0.1.0 [INFO] frobbed toml for simlink-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/simlink/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting simlink-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/simlink/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e03391a2046279d69b220d945fabc7e55298148dbf1c3c0510e582e4aa2af775 [INFO] running `"docker" "start" "-a" "e03391a2046279d69b220d945fabc7e55298148dbf1c3c0510e582e4aa2af775"` [INFO] [stderr] Checking simlink v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:6:17 [INFO] [stderr] | [INFO] [stderr] 6 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:8:45 [INFO] [stderr] | [INFO] [stderr] 8 | fn link(existing_file: &str, new_link:&str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:26:44 [INFO] [stderr] | [INFO] [stderr] 26 | fn exit_for_humans(msg: &str, status: i32) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:54:12 [INFO] [stderr] | [INFO] [stderr] 54 | if let None = path_a.to_str() { [INFO] [stderr] | _____- ^^^^ [INFO] [stderr] 55 | | exit_for_humans("Invalid filename for ", -1); [INFO] [stderr] 56 | | }; [INFO] [stderr] | |_____- help: try this: `if path_a.to_str().is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:58:12 [INFO] [stderr] | [INFO] [stderr] 58 | if let None = path_b.to_str() { [INFO] [stderr] | _____- ^^^^ [INFO] [stderr] 59 | | exit_for_humans("Invalid filename for ", -1); [INFO] [stderr] 60 | | }; [INFO] [stderr] | |_____- help: try this: `if path_b.to_str().is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:6:17 [INFO] [stderr] | [INFO] [stderr] 6 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:8:45 [INFO] [stderr] | [INFO] [stderr] 8 | fn link(existing_file: &str, new_link:&str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:26:44 [INFO] [stderr] | [INFO] [stderr] 26 | fn exit_for_humans(msg: &str, status: i32) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:54:12 [INFO] [stderr] | [INFO] [stderr] 54 | if let None = path_a.to_str() { [INFO] [stderr] | _____- ^^^^ [INFO] [stderr] 55 | | exit_for_humans("Invalid filename for ", -1); [INFO] [stderr] 56 | | }; [INFO] [stderr] | |_____- help: try this: `if path_a.to_str().is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:58:12 [INFO] [stderr] | [INFO] [stderr] 58 | if let None = path_b.to_str() { [INFO] [stderr] | _____- ^^^^ [INFO] [stderr] 59 | | exit_for_humans("Invalid filename for ", -1); [INFO] [stderr] 60 | | }; [INFO] [stderr] | |_____- help: try this: `if path_b.to_str().is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.23s [INFO] running `"docker" "inspect" "e03391a2046279d69b220d945fabc7e55298148dbf1c3c0510e582e4aa2af775"` [INFO] running `"docker" "rm" "-f" "e03391a2046279d69b220d945fabc7e55298148dbf1c3c0510e582e4aa2af775"` [INFO] [stdout] e03391a2046279d69b220d945fabc7e55298148dbf1c3c0510e582e4aa2af775