[INFO] crate signalo_sources 0.5.1 is already in cache [INFO] extracting crate signalo_sources 0.5.1 into work/ex/clippy-test-run/sources/stable/reg/signalo_sources/0.5.1 [INFO] extracting crate signalo_sources 0.5.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/signalo_sources/0.5.1 [INFO] validating manifest of signalo_sources-0.5.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of signalo_sources-0.5.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing signalo_sources-0.5.1 [INFO] finished frobbing signalo_sources-0.5.1 [INFO] frobbed toml for signalo_sources-0.5.1 written to work/ex/clippy-test-run/sources/stable/reg/signalo_sources/0.5.1/Cargo.toml [INFO] started frobbing signalo_sources-0.5.1 [INFO] finished frobbing signalo_sources-0.5.1 [INFO] frobbed toml for signalo_sources-0.5.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/signalo_sources/0.5.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting signalo_sources-0.5.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/signalo_sources/0.5.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3df4c3bd398dd51d8b52c51b1194cf5cb06286ed0a0329b9c6b2f9d9436449de [INFO] running `"docker" "start" "-a" "3df4c3bd398dd51d8b52c51b1194cf5cb06286ed0a0329b9c6b2f9d9436449de"` [INFO] [stderr] Compiling dimensioned v0.7.0 [INFO] [stderr] Checking signalo_traits v0.4.0 [INFO] [stderr] Checking nearly_eq v0.2.4 [INFO] [stderr] Checking signalo_sources v0.5.1 (/opt/crater/workdir) [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/peek.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | pub peeked: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/unit_system.rs:59:47 [INFO] [stderr] | [INFO] [stderr] 59 | self.state.inner.source().map(|value| $t::new(value)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `$t::new` [INFO] [stderr] ... [INFO] [stderr] 65 | impl_dimensioned!(CGS); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/unit_system.rs:59:47 [INFO] [stderr] | [INFO] [stderr] 59 | self.state.inner.source().map(|value| $t::new(value)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `$t::new` [INFO] [stderr] ... [INFO] [stderr] 66 | impl_dimensioned!(FPS); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/unit_system.rs:59:47 [INFO] [stderr] | [INFO] [stderr] 59 | self.state.inner.source().map(|value| $t::new(value)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `$t::new` [INFO] [stderr] ... [INFO] [stderr] 67 | impl_dimensioned!(MKS); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/unit_system.rs:59:47 [INFO] [stderr] | [INFO] [stderr] 59 | self.state.inner.source().map(|value| $t::new(value)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `$t::new` [INFO] [stderr] ... [INFO] [stderr] 68 | impl_dimensioned!(SI); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/unit_system.rs:59:47 [INFO] [stderr] | [INFO] [stderr] 59 | self.state.inner.source().map(|value| $t::new(value)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `$t::new` [INFO] [stderr] ... [INFO] [stderr] 69 | impl_dimensioned!(UCUM); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/peek.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | pub peeked: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/unit_system.rs:59:47 [INFO] [stderr] | [INFO] [stderr] 59 | self.state.inner.source().map(|value| $t::new(value)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `$t::new` [INFO] [stderr] ... [INFO] [stderr] 65 | impl_dimensioned!(CGS); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/unit_system.rs:59:47 [INFO] [stderr] | [INFO] [stderr] 59 | self.state.inner.source().map(|value| $t::new(value)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `$t::new` [INFO] [stderr] ... [INFO] [stderr] 66 | impl_dimensioned!(FPS); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/unit_system.rs:59:47 [INFO] [stderr] | [INFO] [stderr] 59 | self.state.inner.source().map(|value| $t::new(value)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `$t::new` [INFO] [stderr] ... [INFO] [stderr] 67 | impl_dimensioned!(MKS); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/unit_system.rs:59:47 [INFO] [stderr] | [INFO] [stderr] 59 | self.state.inner.source().map(|value| $t::new(value)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `$t::new` [INFO] [stderr] ... [INFO] [stderr] 68 | impl_dimensioned!(SI); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/unit_system.rs:59:47 [INFO] [stderr] | [INFO] [stderr] 59 | self.state.inner.source().map(|value| $t::new(value)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `$t::new` [INFO] [stderr] ... [INFO] [stderr] 69 | impl_dimensioned!(UCUM); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/unit_system.rs:105:40 [INFO] [stderr] | [INFO] [stderr] 105 | .map(|unitless| Meter::new(unitless.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*unitless` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.98s [INFO] running `"docker" "inspect" "3df4c3bd398dd51d8b52c51b1194cf5cb06286ed0a0329b9c6b2f9d9436449de"` [INFO] running `"docker" "rm" "-f" "3df4c3bd398dd51d8b52c51b1194cf5cb06286ed0a0329b9c6b2f9d9436449de"` [INFO] [stdout] 3df4c3bd398dd51d8b52c51b1194cf5cb06286ed0a0329b9c6b2f9d9436449de