[INFO] crate siege 0.1.2 is already in cache [INFO] extracting crate siege 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/siege/0.1.2 [INFO] extracting crate siege 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/siege/0.1.2 [INFO] validating manifest of siege-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of siege-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing siege-0.1.2 [INFO] finished frobbing siege-0.1.2 [INFO] frobbed toml for siege-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/siege/0.1.2/Cargo.toml [INFO] started frobbing siege-0.1.2 [INFO] finished frobbing siege-0.1.2 [INFO] frobbed toml for siege-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/siege/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting siege-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/siege/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f3c7a6393e256eb13e6b7c65435afa9f576ebd9c706000a45f0eb50d22f4fe2d [INFO] running `"docker" "start" "-a" "f3c7a6393e256eb13e6b7c65435afa9f576ebd9c706000a45f0eb50d22f4fe2d"` [INFO] [stderr] Checking siege v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:41:31 [INFO] [stderr] | [INFO] [stderr] 41 | Material::Wood => 0x8F563B, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x008F_563B` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:42:32 [INFO] [stderr] | [INFO] [stderr] 42 | Material::Metal => 0x696A6A, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0069_6A6A` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:43:31 [INFO] [stderr] | [INFO] [stderr] 43 | Material::Rope => 0xD9A066, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00D9_A066` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:76:31 [INFO] [stderr] | [INFO] [stderr] 76 | Material::Wood => 0x8F563B, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x008F_563B` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:77:32 [INFO] [stderr] | [INFO] [stderr] 77 | Material::Metal => 0x696A6A, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0069_6A6A` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:78:31 [INFO] [stderr] | [INFO] [stderr] 78 | Material::Rope => 0xD9A066, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00D9_A066` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | start: (start.0 as f64, start.1 as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(start.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:34:37 [INFO] [stderr] | [INFO] [stderr] 34 | start: (start.0 as f64, start.1 as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(start.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:35:19 [INFO] [stderr] | [INFO] [stderr] 35 | end: (end.0 as f64, end.1 as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(end.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:35:33 [INFO] [stderr] | [INFO] [stderr] 35 | end: (end.0 as f64, end.1 as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(end.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:41:31 [INFO] [stderr] | [INFO] [stderr] 41 | Material::Wood => 0x8F563B, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x008F_563B` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:42:32 [INFO] [stderr] | [INFO] [stderr] 42 | Material::Metal => 0x696A6A, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0069_6A6A` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:43:31 [INFO] [stderr] | [INFO] [stderr] 43 | Material::Rope => 0xD9A066, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00D9_A066` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:76:31 [INFO] [stderr] | [INFO] [stderr] 76 | Material::Wood => 0x8F563B, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x008F_563B` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:77:32 [INFO] [stderr] | [INFO] [stderr] 77 | Material::Metal => 0x696A6A, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0069_6A6A` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:78:31 [INFO] [stderr] | [INFO] [stderr] 78 | Material::Rope => 0xD9A066, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00D9_A066` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:18 [INFO] [stderr] | [INFO] [stderr] 64 | let dx = (end.0 - start.0) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(end.0 - start.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:65:18 [INFO] [stderr] | [INFO] [stderr] 65 | let dy = (end.1 - start.1) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(end.1 - start.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:69:19 [INFO] [stderr] | [INFO] [stderr] 69 | pos: (start.0 as f64, start.1 as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(start.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:69:35 [INFO] [stderr] | [INFO] [stderr] 69 | pos: (start.0 as f64, start.1 as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(start.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | / if let &Part::Beam(ref beam) = part { [INFO] [stderr] 108 | | beam.draw(dst, dst_width, self.pos); [INFO] [stderr] 109 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 107 | if let Part::Beam(ref beam) = *part { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | / if let &Part::Wheel(ref wheel) = part { [INFO] [stderr] 111 | | wheel.draw(dst, dst_width, self.pos); [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 110 | if let Part::Wheel(ref wheel) = *part { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | start: (start.0 as f64, start.1 as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(start.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:34:37 [INFO] [stderr] | [INFO] [stderr] 34 | start: (start.0 as f64, start.1 as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(start.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:35:19 [INFO] [stderr] | [INFO] [stderr] 35 | end: (end.0 as f64, end.1 as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(end.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:35:33 [INFO] [stderr] | [INFO] [stderr] 35 | end: (end.0 as f64, end.1 as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(end.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:18 [INFO] [stderr] | [INFO] [stderr] 64 | let dx = (end.0 - start.0) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(end.0 - start.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:65:18 [INFO] [stderr] | [INFO] [stderr] 65 | let dy = (end.1 - start.1) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(end.1 - start.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:69:19 [INFO] [stderr] | [INFO] [stderr] 69 | pos: (start.0 as f64, start.1 as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(start.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:69:35 [INFO] [stderr] | [INFO] [stderr] 69 | pos: (start.0 as f64, start.1 as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(start.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | / if let &Part::Beam(ref beam) = part { [INFO] [stderr] 108 | | beam.draw(dst, dst_width, self.pos); [INFO] [stderr] 109 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 107 | if let Part::Beam(ref beam) = *part { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | / if let &Part::Wheel(ref wheel) = part { [INFO] [stderr] 111 | | wheel.draw(dst, dst_width, self.pos); [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 110 | if let Part::Wheel(ref wheel) = *part { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.81s [INFO] running `"docker" "inspect" "f3c7a6393e256eb13e6b7c65435afa9f576ebd9c706000a45f0eb50d22f4fe2d"` [INFO] running `"docker" "rm" "-f" "f3c7a6393e256eb13e6b7c65435afa9f576ebd9c706000a45f0eb50d22f4fe2d"` [INFO] [stdout] f3c7a6393e256eb13e6b7c65435afa9f576ebd9c706000a45f0eb50d22f4fe2d