[INFO] crate sid 0.6.0 is already in cache [INFO] extracting crate sid 0.6.0 into work/ex/clippy-test-run/sources/stable/reg/sid/0.6.0 [INFO] extracting crate sid 0.6.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sid/0.6.0 [INFO] validating manifest of sid-0.6.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sid-0.6.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sid-0.6.0 [INFO] finished frobbing sid-0.6.0 [INFO] frobbed toml for sid-0.6.0 written to work/ex/clippy-test-run/sources/stable/reg/sid/0.6.0/Cargo.toml [INFO] started frobbing sid-0.6.0 [INFO] finished frobbing sid-0.6.0 [INFO] frobbed toml for sid-0.6.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sid/0.6.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sid-0.6.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sid/0.6.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fe81f2b33973c4fd21b26fd77540a36f5ab9ee8e4818bc82678276fc40d21dd1 [INFO] running `"docker" "start" "-a" "fe81f2b33973c4fd21b26fd77540a36f5ab9ee8e4818bc82678276fc40d21dd1"` [INFO] [stderr] Checking sid v0.6.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/id_range.rs:177:26 [INFO] [stderr] | [INFO] [stderr] 177 | ReverseIdRange { range: range } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `range` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/id_vector.rs:372:13 [INFO] [stderr] | [INFO] [stderr] 372 | slice: slice, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slice` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/id_vector.rs:479:13 [INFO] [stderr] | [INFO] [stderr] 479 | slice: slice, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slice` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/id_range.rs:177:26 [INFO] [stderr] | [INFO] [stderr] 177 | ReverseIdRange { range: range } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `range` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/id_vector.rs:372:13 [INFO] [stderr] | [INFO] [stderr] 372 | slice: slice, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slice` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/id_vector.rs:479:13 [INFO] [stderr] | [INFO] [stderr] 479 | slice: slice, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slice` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_range.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | / return Id { [INFO] [stderr] 68 | | handle: self.start + i, [INFO] [stderr] 69 | | _marker: PhantomData, [INFO] [stderr] 70 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 67 | Id { [INFO] [stderr] 68 | handle: self.start + i, [INFO] [stderr] 69 | _marker: PhantomData, [INFO] [stderr] 70 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_range.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | return Some(IdRange::new((self.start + H::one())..self.end)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(IdRange::new((self.start + H::one())..self.end))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_range.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | / return Some(IdRange::new( [INFO] [stderr] 114 | | self.start..FromUsize::from_usize(self.end.to_usize() - 1), [INFO] [stderr] 115 | | )); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 113 | Some(IdRange::new( [INFO] [stderr] 114 | self.start..FromUsize::from_usize(self.end.to_usize() - 1), [INFO] [stderr] 115 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_range.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | return IdRange::new(start..end); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `IdRange::new(start..end)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_range.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_range.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | return (self.len().to_usize(), Some(self.len().to_usize())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.len().to_usize(), Some(self.len().to_usize()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_range.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_vector.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | return FromUsize::from_usize(index); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `FromUsize::from_usize(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_vector.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | / return if self.data.len() > 0 { [INFO] [stderr] 228 | | Some(ID::from_usize(0)) [INFO] [stderr] 229 | | } else { [INFO] [stderr] 230 | | None [INFO] [stderr] 231 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 227 | if self.data.len() > 0 { [INFO] [stderr] 228 | Some(ID::from_usize(0)) [INFO] [stderr] 229 | } else { [INFO] [stderr] 230 | None [INFO] [stderr] 231 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_vector.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | / return if self.data.len() > 0 { [INFO] [stderr] 237 | | Some(ID::from_usize(self.data.len() - 1)) [INFO] [stderr] 238 | | } else { [INFO] [stderr] 239 | | None [INFO] [stderr] 240 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 236 | if self.data.len() > 0 { [INFO] [stderr] 237 | Some(ID::from_usize(self.data.len() - 1)) [INFO] [stderr] 238 | } else { [INFO] [stderr] 239 | None [INFO] [stderr] 240 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_vector.rs:284:9 [INFO] [stderr] | [INFO] [stderr] 284 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_vector.rs:414:9 [INFO] [stderr] | [INFO] [stderr] 414 | / return if self.slice.len() > 0 { [INFO] [stderr] 415 | | Some(ID::from_usize(0)) [INFO] [stderr] 416 | | } else { [INFO] [stderr] 417 | | None [INFO] [stderr] 418 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 414 | if self.slice.len() > 0 { [INFO] [stderr] 415 | Some(ID::from_usize(0)) [INFO] [stderr] 416 | } else { [INFO] [stderr] 417 | None [INFO] [stderr] 418 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_vector.rs:423:9 [INFO] [stderr] | [INFO] [stderr] 423 | / return if self.slice.len() > 0 { [INFO] [stderr] 424 | | Some(ID::from_usize(self.slice.len() - 1)) [INFO] [stderr] 425 | | } else { [INFO] [stderr] 426 | | None [INFO] [stderr] 427 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 423 | if self.slice.len() > 0 { [INFO] [stderr] 424 | Some(ID::from_usize(self.slice.len() - 1)) [INFO] [stderr] 425 | } else { [INFO] [stderr] 426 | None [INFO] [stderr] 427 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_list.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | return new_id; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `new_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_list.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | return new_id; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `new_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_list.rs:172:9 [INFO] [stderr] | [INFO] [stderr] 172 | / return if next == C::null_id() { [INFO] [stderr] 173 | | None [INFO] [stderr] 174 | | } else { [INFO] [stderr] 175 | | Some(next) [INFO] [stderr] 176 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 172 | if next == C::null_id() { [INFO] [stderr] 173 | None [INFO] [stderr] 174 | } else { [INFO] [stderr] 175 | Some(next) [INFO] [stderr] 176 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_list.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | / return if prev == C::null_id() { [INFO] [stderr] 184 | | None [INFO] [stderr] 185 | | } else { [INFO] [stderr] 186 | | Some(prev) [INFO] [stderr] 187 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 183 | if prev == C::null_id() { [INFO] [stderr] 184 | None [INFO] [stderr] 185 | } else { [INFO] [stderr] 186 | Some(prev) [INFO] [stderr] 187 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_list.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | / return if self.first == C::null_id() { [INFO] [stderr] 193 | | None [INFO] [stderr] 194 | | } else { [INFO] [stderr] 195 | | Some(self.first) [INFO] [stderr] 196 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 192 | if self.first == C::null_id() { [INFO] [stderr] 193 | None [INFO] [stderr] 194 | } else { [INFO] [stderr] 195 | Some(self.first) [INFO] [stderr] 196 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_range.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | / return Id { [INFO] [stderr] 68 | | handle: self.start + i, [INFO] [stderr] 69 | | _marker: PhantomData, [INFO] [stderr] 70 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 67 | Id { [INFO] [stderr] 68 | handle: self.start + i, [INFO] [stderr] 69 | _marker: PhantomData, [INFO] [stderr] 70 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_range.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | return Some(IdRange::new((self.start + H::one())..self.end)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(IdRange::new((self.start + H::one())..self.end))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_range.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | / return Some(IdRange::new( [INFO] [stderr] 114 | | self.start..FromUsize::from_usize(self.end.to_usize() - 1), [INFO] [stderr] 115 | | )); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 113 | Some(IdRange::new( [INFO] [stderr] 114 | self.start..FromUsize::from_usize(self.end.to_usize() - 1), [INFO] [stderr] 115 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_range.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | return IdRange::new(start..end); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `IdRange::new(start..end)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_range.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_range.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | return (self.len().to_usize(), Some(self.len().to_usize())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.len().to_usize(), Some(self.len().to_usize()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_range.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_vector.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | return FromUsize::from_usize(index); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `FromUsize::from_usize(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_vector.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | / return if self.data.len() > 0 { [INFO] [stderr] 228 | | Some(ID::from_usize(0)) [INFO] [stderr] 229 | | } else { [INFO] [stderr] 230 | | None [INFO] [stderr] 231 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 227 | if self.data.len() > 0 { [INFO] [stderr] 228 | Some(ID::from_usize(0)) [INFO] [stderr] 229 | } else { [INFO] [stderr] 230 | None [INFO] [stderr] 231 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_vector.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | / return if self.data.len() > 0 { [INFO] [stderr] 237 | | Some(ID::from_usize(self.data.len() - 1)) [INFO] [stderr] 238 | | } else { [INFO] [stderr] 239 | | None [INFO] [stderr] 240 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 236 | if self.data.len() > 0 { [INFO] [stderr] 237 | Some(ID::from_usize(self.data.len() - 1)) [INFO] [stderr] 238 | } else { [INFO] [stderr] 239 | None [INFO] [stderr] 240 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_vector.rs:284:9 [INFO] [stderr] | [INFO] [stderr] 284 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_vector.rs:414:9 [INFO] [stderr] | [INFO] [stderr] 414 | / return if self.slice.len() > 0 { [INFO] [stderr] 415 | | Some(ID::from_usize(0)) [INFO] [stderr] 416 | | } else { [INFO] [stderr] 417 | | None [INFO] [stderr] 418 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 414 | if self.slice.len() > 0 { [INFO] [stderr] 415 | Some(ID::from_usize(0)) [INFO] [stderr] 416 | } else { [INFO] [stderr] 417 | None [INFO] [stderr] 418 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_vector.rs:423:9 [INFO] [stderr] | [INFO] [stderr] 423 | / return if self.slice.len() > 0 { [INFO] [stderr] 424 | | Some(ID::from_usize(self.slice.len() - 1)) [INFO] [stderr] 425 | | } else { [INFO] [stderr] 426 | | None [INFO] [stderr] 427 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 423 | if self.slice.len() > 0 { [INFO] [stderr] 424 | Some(ID::from_usize(self.slice.len() - 1)) [INFO] [stderr] 425 | } else { [INFO] [stderr] 426 | None [INFO] [stderr] 427 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_list.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | return new_id; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `new_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_list.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | return new_id; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `new_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_list.rs:172:9 [INFO] [stderr] | [INFO] [stderr] 172 | / return if next == C::null_id() { [INFO] [stderr] 173 | | None [INFO] [stderr] 174 | | } else { [INFO] [stderr] 175 | | Some(next) [INFO] [stderr] 176 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 172 | if next == C::null_id() { [INFO] [stderr] 173 | None [INFO] [stderr] 174 | } else { [INFO] [stderr] 175 | Some(next) [INFO] [stderr] 176 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_list.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | / return if prev == C::null_id() { [INFO] [stderr] 184 | | None [INFO] [stderr] 185 | | } else { [INFO] [stderr] 186 | | Some(prev) [INFO] [stderr] 187 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 183 | if prev == C::null_id() { [INFO] [stderr] 184 | None [INFO] [stderr] 185 | } else { [INFO] [stderr] 186 | Some(prev) [INFO] [stderr] 187 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_list.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | / return if self.first == C::null_id() { [INFO] [stderr] 193 | | None [INFO] [stderr] 194 | | } else { [INFO] [stderr] 195 | | Some(self.first) [INFO] [stderr] 196 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 192 | if self.first == C::null_id() { [INFO] [stderr] 193 | None [INFO] [stderr] 194 | } else { [INFO] [stderr] 195 | Some(self.first) [INFO] [stderr] 196 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/id_list.rs:240:9 [INFO] [stderr] | [INFO] [stderr] 240 | return FromUsize::from_usize(::std::u32::MAX as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `FromUsize::from_usize(::std::u32::MAX as usize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `id_vector::IdVec` [INFO] [stderr] --> src/id_vector.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new() -> Self { [INFO] [stderr] 22 | | IdVec { [INFO] [stderr] 23 | | data: Vec::new(), [INFO] [stderr] 24 | | _idtype: PhantomData, [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/id_vector.rs:114:33 [INFO] [stderr] | [INFO] [stderr] 114 | IdSlice::new(&self.data[..(id.to_usize()+1)]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `..=id.to_usize()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/id_vector.rs:119:40 [INFO] [stderr] | [INFO] [stderr] 119 | MutIdSlice::new(&mut self.data[..(id.to_usize()+1)]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `..=id.to_usize()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/id_vector.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | / pub fn iter<'l>(&'l self) -> slice::Iter<'l, T> { [INFO] [stderr] 137 | | self.data.iter() [INFO] [stderr] 138 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/id_vector.rs:142:5 [INFO] [stderr] | [INFO] [stderr] 142 | / pub fn iter_mut<'l>(&'l mut self) -> slice::IterMut<'l, T> { [INFO] [stderr] 143 | | self.data.iter_mut() [INFO] [stderr] 144 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/id_vector.rs:227:19 [INFO] [stderr] | [INFO] [stderr] 227 | return if self.data.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/id_vector.rs:236:19 [INFO] [stderr] | [INFO] [stderr] 236 | return if self.data.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/id_vector.rs:290:5 [INFO] [stderr] | [INFO] [stderr] 290 | / fn index<'l>(&'l self, id: ID) -> &'l T { [INFO] [stderr] 291 | | &self.data[id.to_usize()] [INFO] [stderr] 292 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/id_vector.rs:296:5 [INFO] [stderr] | [INFO] [stderr] 296 | / fn index_mut<'l>(&'l mut self, id: ID) -> &'l mut T { [INFO] [stderr] 297 | | &mut self.data[id.to_usize()] [INFO] [stderr] 298 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/id_vector.rs:315:22 [INFO] [stderr] | [INFO] [stderr] 315 | (&self.data).into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the Vec [INFO] [stderr] --> src/id_vector.rs:324:26 [INFO] [stderr] | [INFO] [stderr] 324 | (&mut self.data).into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: item `id_vector::IdSlice<'l, ID, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/id_vector.rs:365:1 [INFO] [stderr] | [INFO] [stderr] 365 | / impl<'l, T, ID: Identifier> IdSlice<'l, ID, T> [INFO] [stderr] 366 | | where [INFO] [stderr] 367 | | T: 'l, [INFO] [stderr] 368 | | { [INFO] [stderr] ... | [INFO] [stderr] 454 | | } [INFO] [stderr] 455 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/id_vector.rs:383:5 [INFO] [stderr] | [INFO] [stderr] 383 | / pub fn untyped<'a>(&'a self) -> &'a [T] { [INFO] [stderr] 384 | | self.slice [INFO] [stderr] 385 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/id_vector.rs:388:5 [INFO] [stderr] | [INFO] [stderr] 388 | / pub fn iter<'a>(&'a self) -> slice::Iter<'a, T> { [INFO] [stderr] 389 | | self.slice.iter() [INFO] [stderr] 390 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/id_vector.rs:414:19 [INFO] [stderr] | [INFO] [stderr] 414 | return if self.slice.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/id_vector.rs:423:19 [INFO] [stderr] | [INFO] [stderr] 423 | return if self.slice.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/id_vector.rs:453:34 [INFO] [stderr] | [INFO] [stderr] 453 | IdSlice::new(&self.slice[..(id.to_usize()+1)]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `..=id.to_usize()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/id_vector.rs:463:5 [INFO] [stderr] | [INFO] [stderr] 463 | / fn index<'a>(&'a self, id: ID) -> &'a T { [INFO] [stderr] 464 | | &self.slice[id.to_usize()] [INFO] [stderr] 465 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: item `id_vector::MutIdSlice<'l, ID, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/id_vector.rs:475:1 [INFO] [stderr] | [INFO] [stderr] 475 | / impl<'l, ID: Identifier, T: 'l> MutIdSlice<'l, ID, T> { [INFO] [stderr] 476 | | #[inline] [INFO] [stderr] 477 | | pub fn new(slice: &'l mut [T]) -> MutIdSlice<'l, ID, T> { [INFO] [stderr] 478 | | MutIdSlice { [INFO] [stderr] ... | [INFO] [stderr] 542 | | } [INFO] [stderr] 543 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/id_vector.rs:495:5 [INFO] [stderr] | [INFO] [stderr] 495 | / pub fn iter<'a>(&'a self) -> slice::Iter<'a, T> { [INFO] [stderr] 496 | | self.slice.iter() [INFO] [stderr] 497 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/id_vector.rs:500:5 [INFO] [stderr] | [INFO] [stderr] 500 | / pub fn iter_mut<'a>(&'a mut self) -> slice::IterMut<'a, T> { [INFO] [stderr] 501 | | self.slice.iter_mut() [INFO] [stderr] 502 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/id_vector.rs:541:41 [INFO] [stderr] | [INFO] [stderr] 541 | MutIdSlice::new(&mut self.slice[..(id.to_usize()+1)]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `..=id.to_usize()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/id_vector.rs:566:5 [INFO] [stderr] | [INFO] [stderr] 566 | / fn index<'a>(&'a self, id: ID) -> &'a T { [INFO] [stderr] 567 | | &self.slice[id.to_usize()] [INFO] [stderr] 568 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/id_vector.rs:573:5 [INFO] [stderr] | [INFO] [stderr] 573 | / fn index_mut<'a>(&'a mut self, id: ID) -> &'a mut T { [INFO] [stderr] 574 | | &mut self.slice[id.to_usize()] [INFO] [stderr] 575 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `id_list::IdFreeList` [INFO] [stderr] --> src/id_list.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn new() -> IdFreeList { [INFO] [stderr] 27 | | IdFreeList { [INFO] [stderr] 28 | | data: Vec::new(), [INFO] [stderr] 29 | | first: C::null_id(), [INFO] [stderr] ... | [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | impl Default for id_list::IdFreeList { [INFO] [stderr] 25 | fn default() -> Self { [INFO] [stderr] 26 | Self::new() [INFO] [stderr] 27 | } [INFO] [stderr] 28 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/id_list.rs:202:5 [INFO] [stderr] | [INFO] [stderr] 202 | / fn index<'l>(&'l self, id: ID) -> &'l Data { [INFO] [stderr] 203 | | // Enabling assertion is very expensive [INFO] [stderr] 204 | | //debug_assert!(self.has_id(id)); [INFO] [stderr] 205 | | &self.data[id.to_usize()].payload [INFO] [stderr] 206 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/id_list.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | / fn index_mut<'l>(&'l mut self, id: ID) -> &'l mut Data { [INFO] [stderr] 211 | | // Enabling assertion is very expensive [INFO] [stderr] 212 | | //debug_assert!(self.has_id(id)); [INFO] [stderr] 213 | | &mut self.data[id.to_usize()].payload [INFO] [stderr] 214 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `id_vector::IdVec` [INFO] [stderr] --> src/id_vector.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new() -> Self { [INFO] [stderr] 22 | | IdVec { [INFO] [stderr] 23 | | data: Vec::new(), [INFO] [stderr] 24 | | _idtype: PhantomData, [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/id_vector.rs:114:33 [INFO] [stderr] | [INFO] [stderr] 114 | IdSlice::new(&self.data[..(id.to_usize()+1)]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `..=id.to_usize()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/id_vector.rs:119:40 [INFO] [stderr] | [INFO] [stderr] 119 | MutIdSlice::new(&mut self.data[..(id.to_usize()+1)]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `..=id.to_usize()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/id_vector.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | / pub fn iter<'l>(&'l self) -> slice::Iter<'l, T> { [INFO] [stderr] 137 | | self.data.iter() [INFO] [stderr] 138 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/id_vector.rs:142:5 [INFO] [stderr] | [INFO] [stderr] 142 | / pub fn iter_mut<'l>(&'l mut self) -> slice::IterMut<'l, T> { [INFO] [stderr] 143 | | self.data.iter_mut() [INFO] [stderr] 144 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/id_vector.rs:227:19 [INFO] [stderr] | [INFO] [stderr] 227 | return if self.data.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/id_vector.rs:236:19 [INFO] [stderr] | [INFO] [stderr] 236 | return if self.data.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/id_vector.rs:290:5 [INFO] [stderr] | [INFO] [stderr] 290 | / fn index<'l>(&'l self, id: ID) -> &'l T { [INFO] [stderr] 291 | | &self.data[id.to_usize()] [INFO] [stderr] 292 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/id_vector.rs:296:5 [INFO] [stderr] | [INFO] [stderr] 296 | / fn index_mut<'l>(&'l mut self, id: ID) -> &'l mut T { [INFO] [stderr] 297 | | &mut self.data[id.to_usize()] [INFO] [stderr] 298 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/id_vector.rs:315:22 [INFO] [stderr] | [INFO] [stderr] 315 | (&self.data).into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the Vec [INFO] [stderr] --> src/id_vector.rs:324:26 [INFO] [stderr] | [INFO] [stderr] 324 | (&mut self.data).into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: item `id_vector::IdSlice<'l, ID, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/id_vector.rs:365:1 [INFO] [stderr] | [INFO] [stderr] 365 | / impl<'l, T, ID: Identifier> IdSlice<'l, ID, T> [INFO] [stderr] 366 | | where [INFO] [stderr] 367 | | T: 'l, [INFO] [stderr] 368 | | { [INFO] [stderr] ... | [INFO] [stderr] 454 | | } [INFO] [stderr] 455 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/id_vector.rs:383:5 [INFO] [stderr] | [INFO] [stderr] 383 | / pub fn untyped<'a>(&'a self) -> &'a [T] { [INFO] [stderr] 384 | | self.slice [INFO] [stderr] 385 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/id_vector.rs:388:5 [INFO] [stderr] | [INFO] [stderr] 388 | / pub fn iter<'a>(&'a self) -> slice::Iter<'a, T> { [INFO] [stderr] 389 | | self.slice.iter() [INFO] [stderr] 390 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/id_vector.rs:414:19 [INFO] [stderr] | [INFO] [stderr] 414 | return if self.slice.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/id_vector.rs:423:19 [INFO] [stderr] | [INFO] [stderr] 423 | return if self.slice.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/id_vector.rs:453:34 [INFO] [stderr] | [INFO] [stderr] 453 | IdSlice::new(&self.slice[..(id.to_usize()+1)]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `..=id.to_usize()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/id_vector.rs:463:5 [INFO] [stderr] | [INFO] [stderr] 463 | / fn index<'a>(&'a self, id: ID) -> &'a T { [INFO] [stderr] 464 | | &self.slice[id.to_usize()] [INFO] [stderr] 465 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: item `id_vector::MutIdSlice<'l, ID, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/id_vector.rs:475:1 [INFO] [stderr] | [INFO] [stderr] 475 | / impl<'l, ID: Identifier, T: 'l> MutIdSlice<'l, ID, T> { [INFO] [stderr] 476 | | #[inline] [INFO] [stderr] 477 | | pub fn new(slice: &'l mut [T]) -> MutIdSlice<'l, ID, T> { [INFO] [stderr] 478 | | MutIdSlice { [INFO] [stderr] ... | [INFO] [stderr] 542 | | } [INFO] [stderr] 543 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/id_vector.rs:495:5 [INFO] [stderr] | [INFO] [stderr] 495 | / pub fn iter<'a>(&'a self) -> slice::Iter<'a, T> { [INFO] [stderr] 496 | | self.slice.iter() [INFO] [stderr] 497 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/id_vector.rs:500:5 [INFO] [stderr] | [INFO] [stderr] 500 | / pub fn iter_mut<'a>(&'a mut self) -> slice::IterMut<'a, T> { [INFO] [stderr] 501 | | self.slice.iter_mut() [INFO] [stderr] 502 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/id_vector.rs:541:41 [INFO] [stderr] | [INFO] [stderr] 541 | MutIdSlice::new(&mut self.slice[..(id.to_usize()+1)]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `..=id.to_usize()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/id_vector.rs:566:5 [INFO] [stderr] | [INFO] [stderr] 566 | / fn index<'a>(&'a self, id: ID) -> &'a T { [INFO] [stderr] 567 | | &self.slice[id.to_usize()] [INFO] [stderr] 568 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/id_vector.rs:573:5 [INFO] [stderr] | [INFO] [stderr] 573 | / fn index_mut<'a>(&'a mut self, id: ID) -> &'a mut T { [INFO] [stderr] 574 | | &mut self.slice[id.to_usize()] [INFO] [stderr] 575 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the variable `idx` is used as a loop counter. Consider using `for (idx, item) in &v.enumerate()` or similar iterators [INFO] [stderr] --> src/id_vector.rs:621:16 [INFO] [stderr] | [INFO] [stderr] 621 | for elt in &v { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `idx` is used as a loop counter. Consider using `for (idx, item) in &v.enumerate()` or similar iterators [INFO] [stderr] --> src/id_vector.rs:631:16 [INFO] [stderr] | [INFO] [stderr] 631 | for elt in &v { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `id_list::IdFreeList` [INFO] [stderr] --> src/id_list.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn new() -> IdFreeList { [INFO] [stderr] 27 | | IdFreeList { [INFO] [stderr] 28 | | data: Vec::new(), [INFO] [stderr] 29 | | first: C::null_id(), [INFO] [stderr] ... | [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | impl Default for id_list::IdFreeList { [INFO] [stderr] 25 | fn default() -> Self { [INFO] [stderr] 26 | Self::new() [INFO] [stderr] 27 | } [INFO] [stderr] 28 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/id_list.rs:202:5 [INFO] [stderr] | [INFO] [stderr] 202 | / fn index<'l>(&'l self, id: ID) -> &'l Data { [INFO] [stderr] 203 | | // Enabling assertion is very expensive [INFO] [stderr] 204 | | //debug_assert!(self.has_id(id)); [INFO] [stderr] 205 | | &self.data[id.to_usize()].payload [INFO] [stderr] 206 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/id_list.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | / fn index_mut<'l>(&'l mut self, id: ID) -> &'l mut Data { [INFO] [stderr] 211 | | // Enabling assertion is very expensive [INFO] [stderr] 212 | | //debug_assert!(self.has_id(id)); [INFO] [stderr] 213 | | &mut self.data[id.to_usize()].payload [INFO] [stderr] 214 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 36 [INFO] [stderr] --> src/id_list.rs:248:1 [INFO] [stderr] | [INFO] [stderr] 248 | / fn vector_list() { [INFO] [stderr] 249 | | let mut list: TestIdFreeList = TestIdFreeList::with_capacity(10); [INFO] [stderr] 250 | | assert!(list.is_empty()); [INFO] [stderr] 251 | | assert_eq!(list.count(), 0); [INFO] [stderr] ... | [INFO] [stderr] 302 | | assert!(list.first_id().is_none()); [INFO] [stderr] 303 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.10s [INFO] running `"docker" "inspect" "fe81f2b33973c4fd21b26fd77540a36f5ab9ee8e4818bc82678276fc40d21dd1"` [INFO] running `"docker" "rm" "-f" "fe81f2b33973c4fd21b26fd77540a36f5ab9ee8e4818bc82678276fc40d21dd1"` [INFO] [stdout] fe81f2b33973c4fd21b26fd77540a36f5ab9ee8e4818bc82678276fc40d21dd1