[INFO] crate shrinkwraprs 0.2.0 is already in cache [INFO] extracting crate shrinkwraprs 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/shrinkwraprs/0.2.0 [INFO] extracting crate shrinkwraprs 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shrinkwraprs/0.2.0 [INFO] validating manifest of shrinkwraprs-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shrinkwraprs-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shrinkwraprs-0.2.0 [INFO] finished frobbing shrinkwraprs-0.2.0 [INFO] frobbed toml for shrinkwraprs-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/shrinkwraprs/0.2.0/Cargo.toml [INFO] started frobbing shrinkwraprs-0.2.0 [INFO] finished frobbing shrinkwraprs-0.2.0 [INFO] frobbed toml for shrinkwraprs-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shrinkwraprs/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shrinkwraprs-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/shrinkwraprs/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1eb47d27cf1e9da470931f91aadf65024c530a30c0b5eb4a30fa0a133cbca98a [INFO] running `"docker" "start" "-a" "1eb47d27cf1e9da470931f91aadf65024c530a30c0b5eb4a30fa0a133cbca98a"` [INFO] [stderr] Compiling itertools v0.7.11 [INFO] [stderr] Checking syn v0.12.15 [INFO] [stderr] Compiling shrinkwraprs v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ast.rs:17:27 [INFO] [stderr] | [INFO] [stderr] 17 | const SW_MUT = 0b00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ast.rs:18:27 [INFO] [stderr] | [INFO] [stderr] 18 | const SW_IGNORE_VIS = 0b00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/impl_immut.rs:26:26 [INFO] [stderr] | [INFO] [stderr] 26 | assert!(email.contains("+")); [INFO] [stderr] | ^^^ help: try using a char instead: `'+'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ast.rs:17:27 [INFO] [stderr] | [INFO] [stderr] 17 | const SW_MUT = 0b00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ast.rs:18:27 [INFO] [stderr] | [INFO] [stderr] 18 | const SW_IGNORE_VIS = 0b00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/ast.rs:81:10 [INFO] [stderr] | [INFO] [stderr] 81 | if &ident == tag { [INFO] [stderr] | ------^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ast.rs:162:6 [INFO] [stderr] | [INFO] [stderr] 162 | if fields.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `fields.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ast.rs:180:6 [INFO] [stderr] | [INFO] [stderr] 180 | if fields.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `fields.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/visibility.rs:64:6 [INFO] [stderr] | [INFO] [stderr] 64 | if &field_vis == &vec![ PathComponent::Pub ] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 64 | if field_vis == < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ) { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/visibility.rs:70:6 [INFO] [stderr] | [INFO] [stderr] 70 | if &struct_vis == &vec![ PathComponent::Pub ] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 70 | if struct_vis == < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ) { [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/visibility.rs:80:3 [INFO] [stderr] | [INFO] [stderr] 80 | / match path { [INFO] [stderr] 81 | | &Public(..) => vec![ PathComponent::Pub ], [INFO] [stderr] 82 | | &Crate(..) => vec![ PathComponent::Pub, PathComponent::Crate ], [INFO] [stderr] 83 | | &Inherited => vec![ PathComponent::Inherited ], [INFO] [stderr] 84 | | &Restricted(ref vis) => to_path_restricted(&vis.path) [INFO] [stderr] 85 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 80 | match *path { [INFO] [stderr] 81 | Public(..) => vec![ PathComponent::Pub ], [INFO] [stderr] 82 | Crate(..) => vec![ PathComponent::Pub, PathComponent::Crate ], [INFO] [stderr] 83 | Inherited => vec![ PathComponent::Inherited ], [INFO] [stderr] 84 | Restricted(ref vis) => to_path_restricted(&vis.path) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/ast.rs:81:10 [INFO] [stderr] | [INFO] [stderr] 81 | if &ident == tag { [INFO] [stderr] | ------^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ast.rs:162:6 [INFO] [stderr] | [INFO] [stderr] 162 | if fields.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `fields.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ast.rs:180:6 [INFO] [stderr] | [INFO] [stderr] 180 | if fields.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `fields.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/visibility.rs:64:6 [INFO] [stderr] | [INFO] [stderr] 64 | if &field_vis == &vec![ PathComponent::Pub ] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 64 | if field_vis == < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ) { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/visibility.rs:70:6 [INFO] [stderr] | [INFO] [stderr] 70 | if &struct_vis == &vec![ PathComponent::Pub ] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 70 | if struct_vis == < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ) { [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/visibility.rs:80:3 [INFO] [stderr] | [INFO] [stderr] 80 | / match path { [INFO] [stderr] 81 | | &Public(..) => vec![ PathComponent::Pub ], [INFO] [stderr] 82 | | &Crate(..) => vec![ PathComponent::Pub, PathComponent::Crate ], [INFO] [stderr] 83 | | &Inherited => vec![ PathComponent::Inherited ], [INFO] [stderr] 84 | | &Restricted(ref vis) => to_path_restricted(&vis.path) [INFO] [stderr] 85 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 80 | match *path { [INFO] [stderr] 81 | Public(..) => vec![ PathComponent::Pub ], [INFO] [stderr] 82 | Crate(..) => vec![ PathComponent::Pub, PathComponent::Crate ], [INFO] [stderr] 83 | Inherited => vec![ PathComponent::Inherited ], [INFO] [stderr] 84 | Restricted(ref vis) => to_path_restricted(&vis.path) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.25s [INFO] running `"docker" "inspect" "1eb47d27cf1e9da470931f91aadf65024c530a30c0b5eb4a30fa0a133cbca98a"` [INFO] running `"docker" "rm" "-f" "1eb47d27cf1e9da470931f91aadf65024c530a30c0b5eb4a30fa0a133cbca98a"` [INFO] [stdout] 1eb47d27cf1e9da470931f91aadf65024c530a30c0b5eb4a30fa0a133cbca98a