[INFO] crate shrev 1.0.1 is already in cache
[INFO] extracting crate shrev 1.0.1 into work/ex/clippy-test-run/sources/stable/reg/shrev/1.0.1
[INFO] extracting crate shrev 1.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shrev/1.0.1
[INFO] validating manifest of shrev-1.0.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of shrev-1.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing shrev-1.0.1
[INFO] finished frobbing shrev-1.0.1
[INFO] frobbed toml for shrev-1.0.1 written to work/ex/clippy-test-run/sources/stable/reg/shrev/1.0.1/Cargo.toml
[INFO] started frobbing shrev-1.0.1
[INFO] finished frobbing shrev-1.0.1
[INFO] frobbed toml for shrev-1.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shrev/1.0.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting shrev-1.0.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/shrev/1.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d196d788c25f68caab1bc81d5cdf6a3f9c56d7f15deb880b7c672dab47c37bd5
[INFO] running `"docker" "start" "-a" "d196d788c25f68caab1bc81d5cdf6a3f9c56d7f15deb880b7c672dab47c37bd5"`
[INFO] [stderr]     Checking shrev v1.0.1 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/storage.rs:450:9
[INFO] [stderr]     |
[INFO] [stderr] 450 |         iter
[INFO] [stderr]     |         ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/storage.rs:444:20
[INFO] [stderr]     |
[INFO] [stderr] 444 |           let iter = StorageIterator {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 445 | |             data: &self.data,
[INFO] [stderr] 446 | |             end: self.last_index.index,
[INFO] [stderr] 447 | |             index,
[INFO] [stderr] 448 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/storage.rs:450:9
[INFO] [stderr]     |
[INFO] [stderr] 450 |         iter
[INFO] [stderr]     |         ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/storage.rs:444:20
[INFO] [stderr]     |
[INFO] [stderr] 444 |           let iter = StorageIterator {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 445 | |             data: &self.data,
[INFO] [stderr] 446 | |             end: self.last_index.index,
[INFO] [stderr] 447 | |             index,
[INFO] [stderr] 448 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]    --> src/storage.rs:141:19
[INFO] [stderr]     |
[INFO] [stderr] 141 |         let src = self.data.as_ptr().offset(cursor as isize);
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data.as_ptr().add(cursor)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_offset_with_cast)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]    --> src/storage.rs:142:19
[INFO] [stderr]     |
[INFO] [stderr] 142 |         let dst = self.data.as_mut_ptr().offset((cursor + by) as isize);
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data.as_mut_ptr().add((cursor + by))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/storage.rs:490:9
[INFO] [stderr]     |
[INFO] [stderr] 490 | /         match self.index.is_magic() {
[INFO] [stderr] 491 | |             true => 0,
[INFO] [stderr] 492 | |             false => (CircularIndex::new(self.end, self.index.size) - self.index.index) + 1,
[INFO] [stderr] 493 | |         }
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if self.index.is_magic() { 0 } else { (CircularIndex::new(self.end, self.index.size) - self.index.index) + 1 }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]   --> src/lib.rs:77:40
[INFO] [stderr]    |
[INFO] [stderr] 77 |         self.storage.iter_write(events.into_iter().cloned());
[INFO] [stderr]    |                                        ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]    --> src/storage.rs:141:19
[INFO] [stderr]     |
[INFO] [stderr] 141 |         let src = self.data.as_ptr().offset(cursor as isize);
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data.as_ptr().add(cursor)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_offset_with_cast)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]    --> src/storage.rs:142:19
[INFO] [stderr]     |
[INFO] [stderr] 142 |         let dst = self.data.as_mut_ptr().offset((cursor + by) as isize);
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data.as_mut_ptr().add((cursor + by))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/storage.rs:490:9
[INFO] [stderr]     |
[INFO] [stderr] 490 | /         match self.index.is_magic() {
[INFO] [stderr] 491 | |             true => 0,
[INFO] [stderr] 492 | |             false => (CircularIndex::new(self.end, self.index.size) - self.index.index) + 1,
[INFO] [stderr] 493 | |         }
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if self.index.is_magic() { 0 } else { (CircularIndex::new(self.end, self.index.size) - self.index.index) + 1 }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]   --> src/lib.rs:77:40
[INFO] [stderr]    |
[INFO] [stderr] 77 |         self.storage.iter_write(events.into_iter().cloned());
[INFO] [stderr]    |                                        ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.81s
[INFO] running `"docker" "inspect" "d196d788c25f68caab1bc81d5cdf6a3f9c56d7f15deb880b7c672dab47c37bd5"`
[INFO] running `"docker" "rm" "-f" "d196d788c25f68caab1bc81d5cdf6a3f9c56d7f15deb880b7c672dab47c37bd5"`
[INFO] [stdout] d196d788c25f68caab1bc81d5cdf6a3f9c56d7f15deb880b7c672dab47c37bd5