[INFO] crate shred 0.7.1 is already in cache [INFO] extracting crate shred 0.7.1 into work/ex/clippy-test-run/sources/stable/reg/shred/0.7.1 [INFO] extracting crate shred 0.7.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shred/0.7.1 [INFO] validating manifest of shred-0.7.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shred-0.7.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shred-0.7.1 [INFO] removed 10 missing examples [INFO] finished frobbing shred-0.7.1 [INFO] frobbed toml for shred-0.7.1 written to work/ex/clippy-test-run/sources/stable/reg/shred/0.7.1/Cargo.toml [INFO] started frobbing shred-0.7.1 [INFO] removed 10 missing examples [INFO] finished frobbing shred-0.7.1 [INFO] frobbed toml for shred-0.7.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shred/0.7.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shred-0.7.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/shred/0.7.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 03adb47f540c2b9a78a035312c25f516e03b4b674f26e52b88a5b01a64c477cc [INFO] running `"docker" "start" "-a" "03adb47f540c2b9a78a035312c25f516e03b4b674f26e52b88a5b01a64c477cc"` [INFO] [stderr] warning: An explicit [[example]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other example targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a example target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/examples/thread_local.rs [INFO] [stderr] * /opt/crater/workdir/examples/par_seq.rs [INFO] [stderr] * /opt/crater/workdir/examples/seq_dispatch.rs [INFO] [stderr] * /opt/crater/workdir/examples/derive_bundle.rs [INFO] [stderr] * /opt/crater/workdir/examples/async.rs [INFO] [stderr] * /opt/crater/workdir/examples/generic_derive.rs [INFO] [stderr] * /opt/crater/workdir/examples/dyn_sys_data.rs [INFO] [stderr] * /opt/crater/workdir/examples/custom_bundle.rs [INFO] [stderr] * /opt/crater/workdir/examples/basic_dispatch.rs [INFO] [stderr] * /opt/crater/workdir/examples/fetch_opt.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a example target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autoexamples = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Checking cgmath v0.16.1 [INFO] [stderr] Compiling shred-derive v0.5.1 [INFO] [stderr] Checking shred v0.7.1 (/opt/crater/workdir) [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/system.rs:355:5 [INFO] [stderr] | [INFO] [stderr] 355 | #![cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#![rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/dispatch/stage.rs:313:24 [INFO] [stderr] | [INFO] [stderr] 313 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 314 | | if check_intersection(new_dep.iter(), ids[stage][group].iter()) { [INFO] [stderr] 315 | | dep_conflict = true; [INFO] [stderr] 316 | | [INFO] [stderr] ... | [INFO] [stderr] 320 | | } [INFO] [stderr] 321 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 313 | } else if check_intersection(new_dep.iter(), ids[stage][group].iter()) { [INFO] [stderr] 314 | dep_conflict = true; [INFO] [stderr] 315 | [INFO] [stderr] 316 | true [INFO] [stderr] 317 | } else { [INFO] [stderr] 318 | false [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/system.rs:225:9 [INFO] [stderr] | [INFO] [stderr] 225 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/dispatch/builder.rs:157:22 [INFO] [stderr] | [INFO] [stderr] 157 | .expect(&format!("No such system registered (\"{}\")", *x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("No such system registered (\"{}\")", *x))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/dispatch/stage.rs:194:36 [INFO] [stderr] | [INFO] [stderr] 194 | let mut name = map.get(system).unwrap().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map[system]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut ()`) to a reference type (`&T`) [INFO] [stderr] --> src/res/mod.rs:82:1 [INFO] [stderr] | [INFO] [stderr] 82 | mopafy!(Resource); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut ()`) to a reference type (`&mut T`) [INFO] [stderr] --> src/res/mod.rs:82:1 [INFO] [stderr] | [INFO] [stderr] 82 | mopafy!(Resource); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/system.rs:355:5 [INFO] [stderr] | [INFO] [stderr] 355 | #![cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#![rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/bench.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `shred`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: The function/method `dispatch` doesn't need a mutable reference [INFO] [stderr] --> tests/dispatch.rs:90:16 [INFO] [stderr] | [INFO] [stderr] 90 | d.dispatch(&mut res); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `dispatch` doesn't need a mutable reference [INFO] [stderr] --> tests/dispatch.rs:103:16 [INFO] [stderr] | [INFO] [stderr] 103 | d.dispatch(&mut res); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `dispatch` doesn't need a mutable reference [INFO] [stderr] --> tests/dispatch.rs:116:16 [INFO] [stderr] | [INFO] [stderr] 116 | d.dispatch(&mut res); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `dispatch` doesn't need a mutable reference [INFO] [stderr] --> tests/dispatch.rs:129:16 [INFO] [stderr] | [INFO] [stderr] 129 | d.dispatch(&mut res); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `dispatch_seq` doesn't need a mutable reference [INFO] [stderr] --> tests/dispatch.rs:142:20 [INFO] [stderr] | [INFO] [stderr] 142 | d.dispatch_seq(&mut res); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `dispatch` doesn't need a mutable reference [INFO] [stderr] --> tests/dispatch.rs:218:16 [INFO] [stderr] | [INFO] [stderr] 218 | d.dispatch(&mut res); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/dispatch/stage.rs:313:24 [INFO] [stderr] | [INFO] [stderr] 313 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 314 | | if check_intersection(new_dep.iter(), ids[stage][group].iter()) { [INFO] [stderr] 315 | | dep_conflict = true; [INFO] [stderr] 316 | | [INFO] [stderr] ... | [INFO] [stderr] 320 | | } [INFO] [stderr] 321 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 313 | } else if check_intersection(new_dep.iter(), ids[stage][group].iter()) { [INFO] [stderr] 314 | dep_conflict = true; [INFO] [stderr] 315 | [INFO] [stderr] 316 | true [INFO] [stderr] 317 | } else { [INFO] [stderr] 318 | false [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/meta.rs:398:38 [INFO] [stderr] | [INFO] [stderr] 398 | table.register(&ImplementorB(111111)); [INFO] [stderr] | ^^^^^^ help: consider: `111_111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/system.rs:225:9 [INFO] [stderr] | [INFO] [stderr] 225 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/dispatch/builder.rs:157:22 [INFO] [stderr] | [INFO] [stderr] 157 | .expect(&format!("No such system registered (\"{}\")", *x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("No such system registered (\"{}\")", *x))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: The function/method `dispatch` doesn't need a mutable reference [INFO] [stderr] --> src/dispatch/dispatcher.rs:213:23 [INFO] [stderr] | [INFO] [stderr] 213 | .dispatch(&mut new_resources()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `dispatch` doesn't need a mutable reference [INFO] [stderr] --> src/dispatch/dispatcher.rs:220:20 [INFO] [stderr] | [INFO] [stderr] 220 | d.dispatch(&mut new_resources()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/dispatch/stage.rs:194:36 [INFO] [stderr] | [INFO] [stderr] 194 | let mut name = map.get(system).unwrap().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map[system]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/dispatch/stage.rs:355:13 [INFO] [stderr] | [INFO] [stderr] 355 | ids.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/dispatch/stage.rs:358:22 [INFO] [stderr] | [INFO] [stderr] 358 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/dispatch/stage.rs:359:44 [INFO] [stderr] | [INFO] [stderr] 359 | .map(|systems| systems.into_iter().map(|id| SystemId(*id)).collect()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/dispatch/stage.rs:367:14 [INFO] [stderr] | [INFO] [stderr] 367 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/dispatch/stage.rs:370:22 [INFO] [stderr] | [INFO] [stderr] 370 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/dispatch/stage.rs:371:34 [INFO] [stderr] | [INFO] [stderr] 371 | .map(|reads| reads.into_iter().map(|id| *id).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `reads.into_iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/dispatch/stage.rs:371:40 [INFO] [stderr] | [INFO] [stderr] 371 | .map(|reads| reads.into_iter().map(|id| *id).collect()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/dispatch/stage.rs:379:14 [INFO] [stderr] | [INFO] [stderr] 379 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/dispatch/stage.rs:382:22 [INFO] [stderr] | [INFO] [stderr] 382 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/dispatch/stage.rs:383:35 [INFO] [stderr] | [INFO] [stderr] 383 | .map(|writes| writes.into_iter().map(|id| *id).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `writes.into_iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/dispatch/stage.rs:383:42 [INFO] [stderr] | [INFO] [stderr] 383 | .map(|writes| writes.into_iter().map(|id| *id).collect()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/dispatch/stage.rs:511:13 [INFO] [stderr] | [INFO] [stderr] 511 | let ref ids = builder.ids[0]; [INFO] [stderr] | ----^^^^^^^------------------ help: try: `let ids = &builder.ids[0];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: The function/method `iter` doesn't need a mutable reference [INFO] [stderr] --> src/meta.rs:401:39 [INFO] [stderr] | [INFO] [stderr] 401 | let mut iter = table.iter(&mut res); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `iter_mut` doesn't need a mutable reference [INFO] [stderr] --> src/meta.rs:407:47 [INFO] [stderr] | [INFO] [stderr] 407 | let mut iter_mut = table.iter_mut(&mut res); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut ()`) to a reference type (`&T`) [INFO] [stderr] --> src/res/mod.rs:82:1 [INFO] [stderr] | [INFO] [stderr] 82 | mopafy!(Resource); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut ()`) to a reference type (`&mut T`) [INFO] [stderr] --> src/res/mod.rs:82:1 [INFO] [stderr] | [INFO] [stderr] 82 | mopafy!(Resource); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "03adb47f540c2b9a78a035312c25f516e03b4b674f26e52b88a5b01a64c477cc"` [INFO] running `"docker" "rm" "-f" "03adb47f540c2b9a78a035312c25f516e03b4b674f26e52b88a5b01a64c477cc"` [INFO] [stdout] 03adb47f540c2b9a78a035312c25f516e03b4b674f26e52b88a5b01a64c477cc