[INFO] crate short-paths 0.1.0 is already in cache [INFO] extracting crate short-paths 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/short-paths/0.1.0 [INFO] extracting crate short-paths 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/short-paths/0.1.0 [INFO] validating manifest of short-paths-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of short-paths-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing short-paths-0.1.0 [INFO] finished frobbing short-paths-0.1.0 [INFO] frobbed toml for short-paths-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/short-paths/0.1.0/Cargo.toml [INFO] started frobbing short-paths-0.1.0 [INFO] finished frobbing short-paths-0.1.0 [INFO] frobbed toml for short-paths-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/short-paths/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting short-paths-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/short-paths/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c0ab6ae7927818e9b0fd036fa4927e000055749795700e3d6a18230a3a34a5fe [INFO] running `"docker" "start" "-a" "c0ab6ae7927818e9b0fd036fa4927e000055749795700e3d6a18230a3a34a5fe"` [INFO] [stderr] Checking short-paths v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> src/scored.rs:44:19 [INFO] [stderr] | [INFO] [stderr] 44 | } else if a != a && b != b { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> src/scored.rs:44:29 [INFO] [stderr] | [INFO] [stderr] 44 | } else if a != a && b != b { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> src/scored.rs:47:19 [INFO] [stderr] | [INFO] [stderr] 47 | } else if a != a { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> src/scored.rs:88:19 [INFO] [stderr] | [INFO] [stderr] 88 | } else if a != a && b != b { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> src/scored.rs:88:29 [INFO] [stderr] | [INFO] [stderr] 88 | } else if a != a && b != b { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> src/scored.rs:91:19 [INFO] [stderr] | [INFO] [stderr] 91 | } else if a != a { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:181:28 [INFO] [stderr] | [INFO] [stderr] 181 | if scored_edges.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!scored_edges.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:212:20 [INFO] [stderr] | [INFO] [stderr] 212 | if scored_edges.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!scored_edges.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:329:8 [INFO] [stderr] | [INFO] [stderr] 329 | if values.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:512:9 [INFO] [stderr] | [INFO] [stderr] 512 | / match path_data { [INFO] [stderr] 513 | | &PathData::Empty => { [INFO] [stderr] 514 | | self.path_graph_root [INFO] [stderr] 515 | | }, [INFO] [stderr] ... | [INFO] [stderr] 518 | | } [INFO] [stderr] 519 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 512 | match *path_data { [INFO] [stderr] 513 | PathData::Empty => { [INFO] [stderr] 514 | self.path_graph_root [INFO] [stderr] 515 | }, [INFO] [stderr] 516 | PathData::Augment(_, edge_idx) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:523:9 [INFO] [stderr] | [INFO] [stderr] 523 | / match path_data { [INFO] [stderr] 524 | | &PathData::Empty => { [INFO] [stderr] 525 | | Vec::new() [INFO] [stderr] 526 | | }, [INFO] [stderr] ... | [INFO] [stderr] 531 | | }, [INFO] [stderr] 532 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 523 | match *path_data { [INFO] [stderr] 524 | PathData::Empty => { [INFO] [stderr] 525 | Vec::new() [INFO] [stderr] 526 | }, [INFO] [stderr] 527 | PathData::Augment(parent_idx, edge_idx) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `short-paths`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> src/scored.rs:44:19 [INFO] [stderr] | [INFO] [stderr] 44 | } else if a != a && b != b { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> src/scored.rs:44:29 [INFO] [stderr] | [INFO] [stderr] 44 | } else if a != a && b != b { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> src/scored.rs:47:19 [INFO] [stderr] | [INFO] [stderr] 47 | } else if a != a { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> src/scored.rs:88:19 [INFO] [stderr] | [INFO] [stderr] 88 | } else if a != a && b != b { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> src/scored.rs:88:29 [INFO] [stderr] | [INFO] [stderr] 88 | } else if a != a && b != b { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> src/scored.rs:91:19 [INFO] [stderr] | [INFO] [stderr] 91 | } else if a != a { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:181:28 [INFO] [stderr] | [INFO] [stderr] 181 | if scored_edges.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!scored_edges.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:212:20 [INFO] [stderr] | [INFO] [stderr] 212 | if scored_edges.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!scored_edges.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:329:8 [INFO] [stderr] | [INFO] [stderr] 329 | if values.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:512:9 [INFO] [stderr] | [INFO] [stderr] 512 | / match path_data { [INFO] [stderr] 513 | | &PathData::Empty => { [INFO] [stderr] 514 | | self.path_graph_root [INFO] [stderr] 515 | | }, [INFO] [stderr] ... | [INFO] [stderr] 518 | | } [INFO] [stderr] 519 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 512 | match *path_data { [INFO] [stderr] 513 | PathData::Empty => { [INFO] [stderr] 514 | self.path_graph_root [INFO] [stderr] 515 | }, [INFO] [stderr] 516 | PathData::Augment(_, edge_idx) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:523:9 [INFO] [stderr] | [INFO] [stderr] 523 | / match path_data { [INFO] [stderr] 524 | | &PathData::Empty => { [INFO] [stderr] 525 | | Vec::new() [INFO] [stderr] 526 | | }, [INFO] [stderr] ... | [INFO] [stderr] 531 | | }, [INFO] [stderr] 532 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 523 | match *path_data { [INFO] [stderr] 524 | PathData::Empty => { [INFO] [stderr] 525 | Vec::new() [INFO] [stderr] 526 | }, [INFO] [stderr] 527 | PathData::Augment(parent_idx, edge_idx) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `short-paths`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c0ab6ae7927818e9b0fd036fa4927e000055749795700e3d6a18230a3a34a5fe"` [INFO] running `"docker" "rm" "-f" "c0ab6ae7927818e9b0fd036fa4927e000055749795700e3d6a18230a3a34a5fe"` [INFO] [stdout] c0ab6ae7927818e9b0fd036fa4927e000055749795700e3d6a18230a3a34a5fe