[INFO] crate shopify 0.1.6 is already in cache [INFO] extracting crate shopify 0.1.6 into work/ex/clippy-test-run/sources/stable/reg/shopify/0.1.6 [INFO] extracting crate shopify 0.1.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shopify/0.1.6 [INFO] validating manifest of shopify-0.1.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shopify-0.1.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shopify-0.1.6 [INFO] finished frobbing shopify-0.1.6 [INFO] frobbed toml for shopify-0.1.6 written to work/ex/clippy-test-run/sources/stable/reg/shopify/0.1.6/Cargo.toml [INFO] started frobbing shopify-0.1.6 [INFO] finished frobbing shopify-0.1.6 [INFO] frobbed toml for shopify-0.1.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shopify/0.1.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shopify-0.1.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/shopify/0.1.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ec8e41a9236c1916276fa763d842f2bbfe6bb4241b73b5e2f03ad5d9d0c5bc3d [INFO] running `"docker" "start" "-a" "ec8e41a9236c1916276fa763d842f2bbfe6bb4241b73b5e2f03ad5d9d0c5bc3d"` [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking shopify v0.1.6 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/mod.rs:143:7 [INFO] [stderr] | [INFO] [stderr] 143 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/order/fulfillment.rs:59:11 [INFO] [stderr] | [INFO] [stderr] 59 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/order/fulfillment.rs:60:11 [INFO] [stderr] | [INFO] [stderr] 60 | quantity: quantity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `quantity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] Checking dotenv v0.10.1 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/mod.rs:143:7 [INFO] [stderr] | [INFO] [stderr] 143 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/order/fulfillment.rs:59:11 [INFO] [stderr] | [INFO] [stderr] 59 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/order/fulfillment.rs:60:11 [INFO] [stderr] | [INFO] [stderr] 60 | quantity: quantity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `quantity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/product/variant/mod.rs:54:7 [INFO] [stderr] | [INFO] [stderr] 54 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/order/mod.rs:150:19 [INFO] [stderr] | [INFO] [stderr] 150 | const TMP_DIR: &'static str = "./tmp/ventray"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Write` [INFO] [stderr] --> src/order/mod.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | use std::io::Write; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `chrono::TimeZone` [INFO] [stderr] --> src/order/mod.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | use chrono::TimeZone; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/order/mod.rs:236:16 [INFO] [stderr] | [INFO] [stderr] 236 | f.add_item(59878440973, Some(1)).tracking_number("7777"); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `59_878_440_973` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/order/mod.rs:237:39 [INFO] [stderr] | [INFO] [stderr] 237 | client.order().create_fulfillment(33673216013, f).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `33_673_216_013` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/order/mod.rs:244:16 [INFO] [stderr] | [INFO] [stderr] 244 | f.add_item(59878440973, Some(1)).tracking_number( [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `59_878_440_973` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/order/mod.rs:249:27 [INFO] [stderr] | [INFO] [stderr] 249 | .update_fulfillment(33673216013, 34429861901, f) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `33_673_216_013` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/order/mod.rs:249:40 [INFO] [stderr] | [INFO] [stderr] 249 | .update_fulfillment(33673216013, 34429861901, f) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `34_429_861_901` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fulfillment_service/mod.rs:118:52 [INFO] [stderr] | [INFO] [stderr] 118 | let service = client.fulfillment_service().get(191681).unwrap(); [INFO] [stderr] | ^^^^^^ help: consider: `191_681` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fulfillment_service/mod.rs:148:15 [INFO] [stderr] | [INFO] [stderr] 148 | .update(13008909, &update) [INFO] [stderr] | ^^^^^^^^ help: consider: `13_008_909` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fulfillment_service/mod.rs:159:15 [INFO] [stderr] | [INFO] [stderr] 159 | .delete(12976141) [INFO] [stderr] | ^^^^^^^^ help: consider: `12_976_141` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/product/variant/mod.rs:54:7 [INFO] [stderr] | [INFO] [stderr] 54 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/product/variant/mod.rs:64:19 [INFO] [stderr] | [INFO] [stderr] 64 | const TMP_DIR: &'static str = "./tmp/variants"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Write` [INFO] [stderr] --> src/product/variant/mod.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | use std::io::Write; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `chrono::TimeZone` [INFO] [stderr] --> src/product/variant/mod.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | use chrono::TimeZone; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::thread::sleep_ms': replaced by `std::thread::sleep` [INFO] [stderr] --> src/order/mod.rs:191:7 [INFO] [stderr] | [INFO] [stderr] 191 | ::std::thread::sleep_ms(500); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::thread::sleep_ms': replaced by `std::thread::sleep` [INFO] [stderr] --> src/product/variant/mod.rs:123:7 [INFO] [stderr] | [INFO] [stderr] 123 | ::std::thread::sleep_ms(500); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `order` [INFO] [stderr] --> src/order/mod.rs:223:13 [INFO] [stderr] | [INFO] [stderr] 223 | let order: Order = serde_json::from_str(&as_str).unwrap(); [INFO] [stderr] | ^^^^^ help: consider using `_order` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `variant` [INFO] [stderr] --> src/product/variant/mod.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | let variant: Variant = serde_json::from_str(&as_str).unwrap(); [INFO] [stderr] | ^^^^^^^ help: consider using `_variant` instead [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/order/mod.rs:190:7 [INFO] [stderr] | [INFO] [stderr] 190 | page = page + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `page += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/order/mod.rs:227:7 [INFO] [stderr] | [INFO] [stderr] 227 | chunk = chunk + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `chunk += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/product/variant/mod.rs:122:7 [INFO] [stderr] | [INFO] [stderr] 122 | page = page + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `page += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/product/variant/mod.rs:159:7 [INFO] [stderr] | [INFO] [stderr] 159 | chunk = chunk + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `chunk += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.23s [INFO] running `"docker" "inspect" "ec8e41a9236c1916276fa763d842f2bbfe6bb4241b73b5e2f03ad5d9d0c5bc3d"` [INFO] running `"docker" "rm" "-f" "ec8e41a9236c1916276fa763d842f2bbfe6bb4241b73b5e2f03ad5d9d0c5bc3d"` [INFO] [stdout] ec8e41a9236c1916276fa763d842f2bbfe6bb4241b73b5e2f03ad5d9d0c5bc3d