[INFO] crate shoop 0.1.1 is already in cache [INFO] extracting crate shoop 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/shoop/0.1.1 [INFO] extracting crate shoop 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shoop/0.1.1 [INFO] validating manifest of shoop-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shoop-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shoop-0.1.1 [INFO] finished frobbing shoop-0.1.1 [INFO] frobbed toml for shoop-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/shoop/0.1.1/Cargo.toml [INFO] started frobbing shoop-0.1.1 [INFO] finished frobbing shoop-0.1.1 [INFO] frobbed toml for shoop-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shoop/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shoop-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/shoop/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 26b451a47fd95e5b26efaf4c77b1dbc7198d2b9a6da78741022a7320802a6d3e [INFO] running `"docker" "start" "-a" "26b451a47fd95e5b26efaf4c77b1dbc7198d2b9a6da78741022a7320802a6d3e"` [INFO] [stderr] Checking unix-daemonize v0.1.2 [INFO] [stderr] Compiling shoop v0.1.1 (/opt/crater/workdir) [INFO] [stderr] Checking udt v0.2.0 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection/mod.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | addr: addr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection/mod.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | sock: sock, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection/mod.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | sock: sock, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection/mod.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | ip_addr: ip_addr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `ip_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection/mod.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | port: port, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection/mod.rs:190:17 [INFO] [stderr] | [INFO] [stderr] 190 | sock: sock, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection/mod.rs:208:17 [INFO] [stderr] | [INFO] [stderr] 208 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection/mod.rs:209:17 [INFO] [stderr] | [INFO] [stderr] 209 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ssh.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | error_type: error_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ssh.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection/mod.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | addr: addr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection/mod.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | sock: sock, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection/mod.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | sock: sock, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection/mod.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | ip_addr: ip_addr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `ip_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection/mod.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | port: port, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection/mod.rs:190:17 [INFO] [stderr] | [INFO] [stderr] 190 | sock: sock, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection/mod.rs:208:17 [INFO] [stderr] | [INFO] [stderr] 208 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection/mod.rs:209:17 [INFO] [stderr] | [INFO] [stderr] 209 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ssh.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | error_type: error_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ssh.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ssh.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | addr: addr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | tx: tx, [INFO] [stderr] | ^^^^^^ help: replace it with: `tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | rx: rx, [INFO] [stderr] | ^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/progress.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | tx: tx, [INFO] [stderr] | ^^^^^^ help: replace it with: `tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:219:13 [INFO] [stderr] | [INFO] [stderr] 219 | finished: finished, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `finished` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:228:13 [INFO] [stderr] | [INFO] [stderr] 228 | finished: finished, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `finished` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:339:21 [INFO] [stderr] | [INFO] [stderr] 339 | ip: ip, [INFO] [stderr] | ^^^^^^ help: replace it with: `ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:340:21 [INFO] [stderr] | [INFO] [stderr] 340 | conn: conn, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:559:13 [INFO] [stderr] | [INFO] [stderr] 559 | port_range: port_range, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `port_range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ssh.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | addr: addr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | tx: tx, [INFO] [stderr] | ^^^^^^ help: replace it with: `tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | rx: rx, [INFO] [stderr] | ^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/progress.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | tx: tx, [INFO] [stderr] | ^^^^^^ help: replace it with: `tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:219:13 [INFO] [stderr] | [INFO] [stderr] 219 | finished: finished, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `finished` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:228:13 [INFO] [stderr] | [INFO] [stderr] 228 | finished: finished, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `finished` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:339:21 [INFO] [stderr] | [INFO] [stderr] 339 | ip: ip, [INFO] [stderr] | ^^^^^^ help: replace it with: `ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:340:21 [INFO] [stderr] | [INFO] [stderr] 340 | conn: conn, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:559:13 [INFO] [stderr] | [INFO] [stderr] 559 | port_range: port_range, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `port_range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/connection/mod.rs:15:27 [INFO] [stderr] | [INFO] [stderr] 15 | const UDT_BUF_SIZE: i32 = 4096000; [INFO] [stderr] | ^^^^^^^ help: consider: `4_096_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/connection/mod.rs:16:37 [INFO] [stderr] | [INFO] [stderr] 16 | pub const MAX_MESSAGE_SIZE: usize = 1024000; [INFO] [stderr] | ^^^^^^^ help: consider: `1_024_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/connection/mod.rs:15:27 [INFO] [stderr] | [INFO] [stderr] 15 | const UDT_BUF_SIZE: i32 = 4096000; [INFO] [stderr] | ^^^^^^^ help: consider: `4_096_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/connection/mod.rs:16:37 [INFO] [stderr] | [INFO] [stderr] 16 | pub const MAX_MESSAGE_SIZE: usize = 1024000; [INFO] [stderr] | ^^^^^^^ help: consider: `1_024_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::distributions::IndependentSample': use Distribution instead [INFO] [stderr] --> src/connection/crypto.rs:195:37 [INFO] [stderr] | [INFO] [stderr] 195 | use ::rand::distributions::{IndependentSample, Range}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `connection::crypto::Nonce` [INFO] [stderr] --> src/connection/crypto.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / pub fn new() -> Nonce { [INFO] [stderr] 44 | | Nonce { counter: 0 } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 38 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/connection/crypto.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / pub fn next(&mut self) -> Result, ()> { [INFO] [stderr] 53 | | if self.counter >= MAX_NONCE { [INFO] [stderr] 54 | | Err(()) [INFO] [stderr] 55 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/connection/crypto.rs:53:12 [INFO] [stderr] | [INFO] [stderr] 53 | if self.counter >= MAX_NONCE { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because MAX_NONCE is the maximum value for this type, the case where the two sides are not equal never occurs, consider using self.counter == MAX_NONCE instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/connection/mod.rs:50:15 [INFO] [stderr] | [INFO] [stderr] 50 | fn send(sock: &UdtSocket, crypto: &mut crypto::Handler, buf: &mut [u8], len: usize) -> Result<(), UdtError> { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `UdtSocket` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/connection/mod.rs:68:15 [INFO] [stderr] | [INFO] [stderr] 68 | fn recv(sock: &UdtSocket, crypto: &mut crypto::Handler, buf: &mut [u8]) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `UdtSocket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/connection/mod.rs:162:33 [INFO] [stderr] | [INFO] [stderr] 162 | pub fn get_open_port(range: &PortRange) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `PortRange` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/connection/mod.rs:164:20 [INFO] [stderr] | [INFO] [stderr] 164 | if let Ok(_) = UdpSocket::bind(&format!("0.0.0.0:{}", p)[..]) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 165 | | return Ok(p); [INFO] [stderr] 166 | | } [INFO] [stderr] | |_____________- help: try this: `if UdpSocket::bind(&format!("0.0.0.0:{}", p)[..]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ssh.rs:73:73 [INFO] [stderr] | [INFO] [stderr] 73 | pub fn new>(hostname: S, path: PathBuf, port_range: &PortRange) -> Connection { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `PortRange` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ssh.rs:90:32 [INFO] [stderr] | [INFO] [stderr] 90 | fn exec(&self, extra_args: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/file.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | Err(_) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/file.rs:113:29 [INFO] [stderr] | [INFO] [stderr] 113 | Err(_) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `progress::Progress` [INFO] [stderr] --> src/progress.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / pub fn new() -> Progress { [INFO] [stderr] 41 | | let (tx, rx) = mpsc::channel(); [INFO] [stderr] 42 | | let builder = thread::Builder::new().name("progress".into()); [INFO] [stderr] 43 | | let t = builder.spawn(move || { [INFO] [stderr] ... | [INFO] [stderr] 88 | | } [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 39 | impl Default for progress::Progress { [INFO] [stderr] 40 | fn default() -> Self { [INFO] [stderr] 41 | Self::new() [INFO] [stderr] 42 | } [INFO] [stderr] 43 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::distributions::IndependentSample::ind_sample': use Distribution instead [INFO] [stderr] --> src/connection/crypto.rs:202:40 [INFO] [stderr] | [INFO] [stderr] 202 | let data_size: usize = between.ind_sample(&mut rng); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:370:24 [INFO] [stderr] | [INFO] [stderr] 370 | if let Err(_) = rx.try_recv() { [INFO] [stderr] | _________________- ^^^^^^ [INFO] [stderr] 371 | | error!("timed out waiting for {}. exiting.", [INFO] [stderr] 372 | | err); [INFO] [stderr] 373 | | std::process::exit(1); [INFO] [stderr] 374 | | } [INFO] [stderr] | |_________________- help: try this: `if rx.try_recv().is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:432:74 [INFO] [stderr] | [INFO] [stderr] 432 | Ok(i) if i < 8 => return Err(Error::new(ErrorKind::Severed, &format!("msg too short"), 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"msg too short".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `shoop`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `connection::crypto::Nonce` [INFO] [stderr] --> src/connection/crypto.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / pub fn new() -> Nonce { [INFO] [stderr] 44 | | Nonce { counter: 0 } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 38 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/connection/crypto.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / pub fn next(&mut self) -> Result, ()> { [INFO] [stderr] 53 | | if self.counter >= MAX_NONCE { [INFO] [stderr] 54 | | Err(()) [INFO] [stderr] 55 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/connection/crypto.rs:53:12 [INFO] [stderr] | [INFO] [stderr] 53 | if self.counter >= MAX_NONCE { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because MAX_NONCE is the maximum value for this type, the case where the two sides are not equal never occurs, consider using self.counter == MAX_NONCE instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/connection/crypto.rs:157:16 [INFO] [stderr] | [INFO] [stderr] 157 | if let Err(_) = nonce.next() { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 158 | | panic!("2^96 - 1 should be a valid nonce"); [INFO] [stderr] 159 | | } [INFO] [stderr] | |_________- help: try this: `if nonce.next().is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/connection/crypto.rs:160:16 [INFO] [stderr] | [INFO] [stderr] 160 | if let Ok(_) = nonce.next() { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 161 | | panic!("2^96 is not a valid nonce, it should overflow and fail."); [INFO] [stderr] 162 | | } [INFO] [stderr] | |_________- help: try this: `if nonce.next().is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `data`. [INFO] [stderr] --> src/connection/crypto.rs:204:18 [INFO] [stderr] | [INFO] [stderr] 204 | for i in 0..data_size { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 204 | for in data.iter_mut().take(data_size) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/connection/mod.rs:50:15 [INFO] [stderr] | [INFO] [stderr] 50 | fn send(sock: &UdtSocket, crypto: &mut crypto::Handler, buf: &mut [u8], len: usize) -> Result<(), UdtError> { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `UdtSocket` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/connection/mod.rs:68:15 [INFO] [stderr] | [INFO] [stderr] 68 | fn recv(sock: &UdtSocket, crypto: &mut crypto::Handler, buf: &mut [u8]) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `UdtSocket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/connection/mod.rs:162:33 [INFO] [stderr] | [INFO] [stderr] 162 | pub fn get_open_port(range: &PortRange) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `PortRange` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/connection/mod.rs:164:20 [INFO] [stderr] | [INFO] [stderr] 164 | if let Ok(_) = UdpSocket::bind(&format!("0.0.0.0:{}", p)[..]) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 165 | | return Ok(p); [INFO] [stderr] 166 | | } [INFO] [stderr] | |_____________- help: try this: `if UdpSocket::bind(&format!("0.0.0.0:{}", p)[..]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ssh.rs:73:73 [INFO] [stderr] | [INFO] [stderr] 73 | pub fn new>(hostname: S, path: PathBuf, port_range: &PortRange) -> Connection { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `PortRange` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ssh.rs:90:32 [INFO] [stderr] | [INFO] [stderr] 90 | fn exec(&self, extra_args: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/file.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | Err(_) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/file.rs:113:29 [INFO] [stderr] | [INFO] [stderr] 113 | Err(_) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `progress::Progress` [INFO] [stderr] --> src/progress.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / pub fn new() -> Progress { [INFO] [stderr] 41 | | let (tx, rx) = mpsc::channel(); [INFO] [stderr] 42 | | let builder = thread::Builder::new().name("progress".into()); [INFO] [stderr] 43 | | let t = builder.spawn(move || { [INFO] [stderr] ... | [INFO] [stderr] 88 | | } [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 39 | impl Default for progress::Progress { [INFO] [stderr] 40 | fn default() -> Self { [INFO] [stderr] 41 | Self::new() [INFO] [stderr] 42 | } [INFO] [stderr] 43 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:370:24 [INFO] [stderr] | [INFO] [stderr] 370 | if let Err(_) = rx.try_recv() { [INFO] [stderr] | _________________- ^^^^^^ [INFO] [stderr] 371 | | error!("timed out waiting for {}. exiting.", [INFO] [stderr] 372 | | err); [INFO] [stderr] 373 | | std::process::exit(1); [INFO] [stderr] 374 | | } [INFO] [stderr] | |_________________- help: try this: `if rx.try_recv().is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:432:74 [INFO] [stderr] | [INFO] [stderr] 432 | Ok(i) if i < 8 => return Err(Error::new(ErrorKind::Severed, &format!("msg too short"), 0)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"msg too short".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `shoop`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "26b451a47fd95e5b26efaf4c77b1dbc7198d2b9a6da78741022a7320802a6d3e"` [INFO] running `"docker" "rm" "-f" "26b451a47fd95e5b26efaf4c77b1dbc7198d2b9a6da78741022a7320802a6d3e"` [INFO] [stdout] 26b451a47fd95e5b26efaf4c77b1dbc7198d2b9a6da78741022a7320802a6d3e