[INFO] crate shodan 0.1.0 is already in cache [INFO] extracting crate shodan 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/shodan/0.1.0 [INFO] extracting crate shodan 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shodan/0.1.0 [INFO] validating manifest of shodan-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shodan-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shodan-0.1.0 [INFO] finished frobbing shodan-0.1.0 [INFO] frobbed toml for shodan-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/shodan/0.1.0/Cargo.toml [INFO] started frobbing shodan-0.1.0 [INFO] finished frobbing shodan-0.1.0 [INFO] frobbed toml for shodan-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shodan/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shodan-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/shodan/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3ce64c2bc3cf47c5d905b1f767b4eb7bcc46c928c937921452b6ac2664b3fe55 [INFO] running `"docker" "start" "-a" "3ce64c2bc3cf47c5d905b1f767b4eb7bcc46c928c937921452b6ac2664b3fe55"` [INFO] [stderr] Checking shodan v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:58:28 [INFO] [stderr] | [INFO] [stderr] 58 | ShodanClient { api_key: api_key } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `api_key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:58:28 [INFO] [stderr] | [INFO] [stderr] 58 | ShodanClient { api_key: api_key } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `api_key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:13:22 [INFO] [stderr] | [INFO] [stderr] 13 | const BASE_URL: &'static str = "https://api.shodan.io"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | client [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:24:26 [INFO] [stderr] | [INFO] [stderr] 24 | let client = Client::with_connector(connector); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | response [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:31:28 [INFO] [stderr] | [INFO] [stderr] 31 | let response = match api_method { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 32 | | "GET" => { [INFO] [stderr] 33 | | client.get(&*url) [INFO] [stderr] 34 | | .send() [INFO] [stderr] ... | [INFO] [stderr] 37 | | _ => panic!("Invalid HTTP Verb."), [INFO] [stderr] 38 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:13:22 [INFO] [stderr] | [INFO] [stderr] 13 | const BASE_URL: &'static str = "https://api.shodan.io"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | client [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:24:26 [INFO] [stderr] | [INFO] [stderr] 24 | let client = Client::with_connector(connector); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | response [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:31:28 [INFO] [stderr] | [INFO] [stderr] 31 | let response = match api_method { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 32 | | "GET" => { [INFO] [stderr] 33 | | client.get(&*url) [INFO] [stderr] 34 | | .send() [INFO] [stderr] ... | [INFO] [stderr] 37 | | _ => panic!("Invalid HTTP Verb."), [INFO] [stderr] 38 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.92s [INFO] running `"docker" "inspect" "3ce64c2bc3cf47c5d905b1f767b4eb7bcc46c928c937921452b6ac2664b3fe55"` [INFO] running `"docker" "rm" "-f" "3ce64c2bc3cf47c5d905b1f767b4eb7bcc46c928c937921452b6ac2664b3fe55"` [INFO] [stdout] 3ce64c2bc3cf47c5d905b1f767b4eb7bcc46c928c937921452b6ac2664b3fe55