[INFO] crate shippai_derive 0.3.2 is already in cache [INFO] extracting crate shippai_derive 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/shippai_derive/0.3.2 [INFO] extracting crate shippai_derive 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shippai_derive/0.3.2 [INFO] validating manifest of shippai_derive-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shippai_derive-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shippai_derive-0.3.2 [INFO] finished frobbing shippai_derive-0.3.2 [INFO] frobbed toml for shippai_derive-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/shippai_derive/0.3.2/Cargo.toml [INFO] started frobbing shippai_derive-0.3.2 [INFO] finished frobbing shippai_derive-0.3.2 [INFO] frobbed toml for shippai_derive-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shippai_derive/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shippai_derive-0.3.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/shippai_derive/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cfb104d8316e7649fa680397887a3b9c25a006ca47991124a83a1cfd80b59b09 [INFO] running `"docker" "start" "-a" "cfb104d8316e7649fa680397887a3b9c25a006ca47991124a83a1cfd80b59b09"` [INFO] [stderr] Checking quote v0.5.2 [INFO] [stderr] Checking syn v0.13.11 [INFO] [stderr] Checking synstructure v0.8.1 [INFO] [stderr] Checking shippai_derive v0.3.2 (/opt/crater/workdir) [INFO] [stderr] error: for loop over `$ single`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/lib.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / quote! { [INFO] [stderr] 23 | | #[no_mangle] [INFO] [stderr] 24 | | pub unsafe extern "C" fn #fn_name(t: *const ShippaiError) -> *const #error_name { [INFO] [stderr] 25 | | (*t).error [INFO] [stderr] ... | [INFO] [stderr] 31 | | #( #variant_helpers )* [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::for_loop_over_option)] on by default [INFO] [stderr] = help: consider replacing `for $ first in $ single` with `if let Some($ first) = $ single` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:35:27 [INFO] [stderr] | [INFO] [stderr] 35 | fn impl_enums(error_name: &syn::Ident, ast: &syn::DeriveInput) -> Option { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `syn::Ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:53:19 [INFO] [stderr] | [INFO] [stderr] 53 | let indices = (1 .. (exported_discriminants.len() + 1)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=exported_discriminants.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `shippai_derive`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: for loop over `$ single`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/lib.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / quote! { [INFO] [stderr] 23 | | #[no_mangle] [INFO] [stderr] 24 | | pub unsafe extern "C" fn #fn_name(t: *const ShippaiError) -> *const #error_name { [INFO] [stderr] 25 | | (*t).error [INFO] [stderr] ... | [INFO] [stderr] 31 | | #( #variant_helpers )* [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::for_loop_over_option)] on by default [INFO] [stderr] = help: consider replacing `for $ first in $ single` with `if let Some($ first) = $ single` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:35:27 [INFO] [stderr] | [INFO] [stderr] 35 | fn impl_enums(error_name: &syn::Ident, ast: &syn::DeriveInput) -> Option { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `syn::Ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:53:19 [INFO] [stderr] | [INFO] [stderr] 53 | let indices = (1 .. (exported_discriminants.len() + 1)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=exported_discriminants.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `shippai_derive`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "cfb104d8316e7649fa680397887a3b9c25a006ca47991124a83a1cfd80b59b09"` [INFO] running `"docker" "rm" "-f" "cfb104d8316e7649fa680397887a3b9c25a006ca47991124a83a1cfd80b59b09"` [INFO] [stdout] cfb104d8316e7649fa680397887a3b9c25a006ca47991124a83a1cfd80b59b09