[INFO] crate shasum 0.6.1 is already in cache [INFO] extracting crate shasum 0.6.1 into work/ex/clippy-test-run/sources/stable/reg/shasum/0.6.1 [INFO] extracting crate shasum 0.6.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shasum/0.6.1 [INFO] validating manifest of shasum-0.6.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shasum-0.6.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shasum-0.6.1 [INFO] finished frobbing shasum-0.6.1 [INFO] frobbed toml for shasum-0.6.1 written to work/ex/clippy-test-run/sources/stable/reg/shasum/0.6.1/Cargo.toml [INFO] started frobbing shasum-0.6.1 [INFO] finished frobbing shasum-0.6.1 [INFO] frobbed toml for shasum-0.6.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shasum/0.6.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shasum-0.6.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/shasum/0.6.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fa4448657a91caebe9f8093661bbd0a5a2f2eac914733b326946ba318aab1d43 [INFO] running `"docker" "start" "-a" "fa4448657a91caebe9f8093661bbd0a5a2f2eac914733b326946ba318aab1d43"` [INFO] [stderr] Checking block-buffer v0.7.2 [INFO] [stderr] Checking sha2 v0.8.0 [INFO] [stderr] Checking sha-1 v0.8.1 [INFO] [stderr] Checking shasum v0.6.1 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | 512224 => format!("{:x}", sha2::Sha512Trunc224::digest(&data)), [INFO] [stderr] | ^^^^^^ help: consider: `512_224` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | 512256 => format!("{:x}", sha2::Sha512Trunc256::digest(&data)), [INFO] [stderr] | ^^^^^^ help: consider: `512_256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | return results.join("\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `results.join("\n")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:40:12 [INFO] [stderr] | [INFO] [stderr] 40 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 41 | | if let Ok(mut file) = fs::File::open(&path) { [INFO] [stderr] 42 | | let mut data = Vec::new(); [INFO] [stderr] 43 | | file.read_to_end(&mut data).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 40 | } else if let Ok(mut file) = fs::File::open(&path) { [INFO] [stderr] 41 | let mut data = Vec::new(); [INFO] [stderr] 42 | file.read_to_end(&mut data).unwrap(); [INFO] [stderr] 43 | let strout = calculate_hash(&mut data, sha); [INFO] [stderr] 44 | results.push(strout + " " + path.to_str().unwrap()) [INFO] [stderr] 45 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:80:52 [INFO] [stderr] | [INFO] [stderr] 80 | "512224" => println!("{}", read_data(path, 512224)), [INFO] [stderr] | ^^^^^^ help: consider: `512_224` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:81:52 [INFO] [stderr] | [INFO] [stderr] 81 | "512256" => println!("{}", read_data(path, 512256)), [INFO] [stderr] | ^^^^^^ help: consider: `512_256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | 512224 => format!("{:x}", sha2::Sha512Trunc224::digest(&data)), [INFO] [stderr] | ^^^^^^ help: consider: `512_224` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | 512256 => format!("{:x}", sha2::Sha512Trunc256::digest(&data)), [INFO] [stderr] | ^^^^^^ help: consider: `512_256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | return results.join("\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `results.join("\n")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:40:12 [INFO] [stderr] | [INFO] [stderr] 40 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 41 | | if let Ok(mut file) = fs::File::open(&path) { [INFO] [stderr] 42 | | let mut data = Vec::new(); [INFO] [stderr] 43 | | file.read_to_end(&mut data).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 40 | } else if let Ok(mut file) = fs::File::open(&path) { [INFO] [stderr] 41 | let mut data = Vec::new(); [INFO] [stderr] 42 | file.read_to_end(&mut data).unwrap(); [INFO] [stderr] 43 | let strout = calculate_hash(&mut data, sha); [INFO] [stderr] 44 | results.push(strout + " " + path.to_str().unwrap()) [INFO] [stderr] 45 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:80:52 [INFO] [stderr] | [INFO] [stderr] 80 | "512224" => println!("{}", read_data(path, 512224)), [INFO] [stderr] | ^^^^^^ help: consider: `512_224` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:81:52 [INFO] [stderr] | [INFO] [stderr] 81 | "512256" => println!("{}", read_data(path, 512256)), [INFO] [stderr] | ^^^^^^ help: consider: `512_256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.76s [INFO] running `"docker" "inspect" "fa4448657a91caebe9f8093661bbd0a5a2f2eac914733b326946ba318aab1d43"` [INFO] running `"docker" "rm" "-f" "fa4448657a91caebe9f8093661bbd0a5a2f2eac914733b326946ba318aab1d43"` [INFO] [stdout] fa4448657a91caebe9f8093661bbd0a5a2f2eac914733b326946ba318aab1d43