[INFO] crate sharepoint 0.3.0 is already in cache [INFO] extracting crate sharepoint 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/sharepoint/0.3.0 [INFO] extracting crate sharepoint 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sharepoint/0.3.0 [INFO] validating manifest of sharepoint-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sharepoint-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sharepoint-0.3.0 [INFO] finished frobbing sharepoint-0.3.0 [INFO] frobbed toml for sharepoint-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/sharepoint/0.3.0/Cargo.toml [INFO] started frobbing sharepoint-0.3.0 [INFO] finished frobbing sharepoint-0.3.0 [INFO] frobbed toml for sharepoint-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sharepoint/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sharepoint-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sharepoint/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0442a5f1d49c7109ec37ee6d49576f62209fb656253d5194f65311eda2ca91ab [INFO] running `"docker" "start" "-a" "0442a5f1d49c7109ec37ee6d49576f62209fb656253d5194f65311eda2ca91ab"` [INFO] [stderr] Checking serde-xml-rs v0.2.1 [INFO] [stderr] Checking uuid v0.5.1 [INFO] [stderr] Checking sharepoint v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/list.rs:123:3 [INFO] [stderr] | [INFO] [stderr] 123 | ) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/list.rs:123:3 [INFO] [stderr] | [INFO] [stderr] 123 | ) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused variable: `body` [INFO] [stderr] --> src/data.rs:135:20 [INFO] [stderr] | [INFO] [stderr] 135 | fn do_not_parse(body: String, _: Vec, _: Vec) -> Option [INFO] [stderr] | ^^^^ help: consider using `_body` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `list_item_type` [INFO] [stderr] --> src/data.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | list_item_type: String, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_list_item_type` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/data.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | let mut v: Value = serde_json::from_str(&body).unwrap(); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/data.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn process<'a, T>( [INFO] [stderr] 32 | | url: String, [INFO] [stderr] 33 | | body: String, [INFO] [stderr] 34 | | access_token_cookies: Option, [INFO] [stderr] ... | [INFO] [stderr] 123 | | result [INFO] [stderr] 124 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/auth.rs:156:37 [INFO] [stderr] | [INFO] [stderr] 156 | .map(|x| x.to_owned().split(";").next().unwrap().to_string()) [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused variable: `body` [INFO] [stderr] --> src/data.rs:135:20 [INFO] [stderr] | [INFO] [stderr] 135 | fn do_not_parse(body: String, _: Vec, _: Vec) -> Option [INFO] [stderr] | ^^^^ help: consider using `_body` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `list_item_type` [INFO] [stderr] --> src/data.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | list_item_type: String, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_list_item_type` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/data.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | let mut v: Value = serde_json::from_str(&body).unwrap(); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/data.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn process<'a, T>( [INFO] [stderr] 32 | | url: String, [INFO] [stderr] 33 | | body: String, [INFO] [stderr] 34 | | access_token_cookies: Option, [INFO] [stderr] ... | [INFO] [stderr] 123 | | result [INFO] [stderr] 124 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/auth.rs:156:37 [INFO] [stderr] | [INFO] [stderr] 156 | .map(|x| x.to_owned().split(";").next().unwrap().to_string()) [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/auth.rs:276:17 [INFO] [stderr] | [INFO] [stderr] 276 | assert!(digest.content.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!digest.content.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/list.rs:199:17 [INFO] [stderr] | [INFO] [stderr] 199 | assert!(items.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!items.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/list.rs:207:44 [INFO] [stderr] | [INFO] [stderr] 207 | since_the_epoch.as_secs() * 1000 + since_the_epoch.subsec_nanos() as u64 / 1_000_000 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(since_the_epoch.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.89s [INFO] running `"docker" "inspect" "0442a5f1d49c7109ec37ee6d49576f62209fb656253d5194f65311eda2ca91ab"` [INFO] running `"docker" "rm" "-f" "0442a5f1d49c7109ec37ee6d49576f62209fb656253d5194f65311eda2ca91ab"` [INFO] [stdout] 0442a5f1d49c7109ec37ee6d49576f62209fb656253d5194f65311eda2ca91ab