[INFO] crate sharedmem 0.1.1 is already in cache [INFO] extracting crate sharedmem 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/sharedmem/0.1.1 [INFO] extracting crate sharedmem 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sharedmem/0.1.1 [INFO] validating manifest of sharedmem-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sharedmem-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sharedmem-0.1.1 [INFO] finished frobbing sharedmem-0.1.1 [INFO] frobbed toml for sharedmem-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/sharedmem/0.1.1/Cargo.toml [INFO] started frobbing sharedmem-0.1.1 [INFO] finished frobbing sharedmem-0.1.1 [INFO] frobbed toml for sharedmem-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sharedmem/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sharedmem-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sharedmem/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 74b60abf12cb0a5ca37f75bed2d1818bf09b22610784e96c986661d8f90337e7 [INFO] running `"docker" "start" "-a" "74b60abf12cb0a5ca37f75bed2d1818bf09b22610784e96c986661d8f90337e7"` [INFO] [stderr] Checking memmap v0.5.2 [INFO] [stderr] Checking sharedmem v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync.rs:14:7 [INFO] [stderr] | [INFO] [stderr] 14 | num_thrs: num_thrs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `num_thrs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync.rs:44:7 [INFO] [stderr] | [INFO] [stderr] 44 | num_thrs: num_thrs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `num_thrs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:30:7 [INFO] [stderr] | [INFO] [stderr] 30 | map: map, [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:91:11 [INFO] [stderr] | [INFO] [stderr] 91 | RwMem{buf: buf} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:137:15 [INFO] [stderr] | [INFO] [stderr] 137 | SharedMem{buf: buf} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync.rs:14:7 [INFO] [stderr] | [INFO] [stderr] 14 | num_thrs: num_thrs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `num_thrs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync.rs:44:7 [INFO] [stderr] | [INFO] [stderr] 44 | num_thrs: num_thrs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `num_thrs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:30:7 [INFO] [stderr] | [INFO] [stderr] 30 | map: map, [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:91:11 [INFO] [stderr] | [INFO] [stderr] 91 | RwMem{buf: buf} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:137:15 [INFO] [stderr] | [INFO] [stderr] 137 | SharedMem{buf: buf} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | let mut raw_s = unsafe { self.map.as_mut_slice() }; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:120:3 [INFO] [stderr] | [INFO] [stderr] 120 | / pub fn borrow<'a>(&'a self) -> Ref<'a, [T]> { [INFO] [stderr] 121 | | Ref::map(self.buf.borrow(), |s| &s[self.from .. self.to]) [INFO] [stderr] 122 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | let mut raw_s = unsafe { self.map.as_mut_slice() }; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:120:3 [INFO] [stderr] | [INFO] [stderr] 120 | / pub fn borrow<'a>(&'a self) -> Ref<'a, [T]> { [INFO] [stderr] 121 | | Ref::map(self.buf.borrow(), |s| &s[self.from .. self.to]) [INFO] [stderr] 122 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.68s [INFO] running `"docker" "inspect" "74b60abf12cb0a5ca37f75bed2d1818bf09b22610784e96c986661d8f90337e7"` [INFO] running `"docker" "rm" "-f" "74b60abf12cb0a5ca37f75bed2d1818bf09b22610784e96c986661d8f90337e7"` [INFO] [stdout] 74b60abf12cb0a5ca37f75bed2d1818bf09b22610784e96c986661d8f90337e7