[INFO] crate sharedlib 7.0.0 is already in cache [INFO] extracting crate sharedlib 7.0.0 into work/ex/clippy-test-run/sources/stable/reg/sharedlib/7.0.0 [INFO] extracting crate sharedlib 7.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sharedlib/7.0.0 [INFO] validating manifest of sharedlib-7.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sharedlib-7.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sharedlib-7.0.0 [INFO] finished frobbing sharedlib-7.0.0 [INFO] frobbed toml for sharedlib-7.0.0 written to work/ex/clippy-test-run/sources/stable/reg/sharedlib/7.0.0/Cargo.toml [INFO] started frobbing sharedlib-7.0.0 [INFO] finished frobbing sharedlib-7.0.0 [INFO] frobbed toml for sharedlib-7.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sharedlib/7.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sharedlib-7.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sharedlib/7.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fbbd8ab8ceeaefdc695772c74fad3f45d8cefbbc386eadecb4830aac683389ad [INFO] running `"docker" "start" "-a" "fbbd8ab8ceeaefdc695772c74fad3f45d8cefbbc386eadecb4830aac683389ad"` [INFO] [stderr] warning: Pattern matching for Cargo's include/exclude fields is changing and file `gradle/wrapper/gradle-wrapper.jar` WILL be excluded in a future Cargo version. [INFO] [stderr] See https://github.com/rust-lang/cargo/issues/4268 for more info [INFO] [stderr] warning: Pattern matching for Cargo's include/exclude fields is changing and file `gradle/wrapper/gradle-wrapper.properties` WILL be excluded in a future Cargo version. [INFO] [stderr] See https://github.com/rust-lang/cargo/issues/4268 for more info [INFO] [stderr] warning: Pattern matching for Cargo's include/exclude fields is changing and file `src/test/examplelib.rs` WILL be excluded in a future Cargo version. [INFO] [stderr] See https://github.com/rust-lang/cargo/issues/4268 for more info [INFO] [stderr] warning: Pattern matching for Cargo's include/exclude fields is changing and file `src/test/mod.rs` WILL be excluded in a future Cargo version. [INFO] [stderr] See https://github.com/rust-lang/cargo/issues/4268 for more info [INFO] [stderr] warning: Pattern matching for Cargo's include/exclude fields is changing and file `src/test/shared.rs` WILL be excluded in a future Cargo version. [INFO] [stderr] See https://github.com/rust-lang/cargo/issues/4268 for more info [INFO] [stderr] warning: Pattern matching for Cargo's include/exclude fields is changing and file `src/test/unix/libm.rs` WILL be excluded in a future Cargo version. [INFO] [stderr] See https://github.com/rust-lang/cargo/issues/4268 for more info [INFO] [stderr] warning: Pattern matching for Cargo's include/exclude fields is changing and file `src/test/unix/mod.rs` WILL be excluded in a future Cargo version. [INFO] [stderr] See https://github.com/rust-lang/cargo/issues/4268 for more info [INFO] [stderr] warning: Pattern matching for Cargo's include/exclude fields is changing and file `src/test/unix/shared.rs` WILL be excluded in a future Cargo version. [INFO] [stderr] See https://github.com/rust-lang/cargo/issues/4268 for more info [INFO] [stderr] warning: Pattern matching for Cargo's include/exclude fields is changing and file `src/test/windows.rs` WILL be excluded in a future Cargo version. [INFO] [stderr] See https://github.com/rust-lang/cargo/issues/4268 for more info [INFO] [stderr] warning: Pattern matching for Cargo's include/exclude fields is changing and file `test/build.gradle` WILL be excluded in a future Cargo version. [INFO] [stderr] See https://github.com/rust-lang/cargo/issues/4268 for more info [INFO] [stderr] warning: Pattern matching for Cargo's include/exclude fields is changing and file `test/settings.gradle` WILL be excluded in a future Cargo version. [INFO] [stderr] See https://github.com/rust-lang/cargo/issues/4268 for more info [INFO] [stderr] Compiling sharedlib v7.0.0 (/opt/crater/workdir) [INFO] [stderr] Checking error-chain v0.9.0 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib_impl/lib.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib_impl/lib_tracked.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | inner: inner [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib_impl/lib_unsafe.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol/data.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol/data_tracked.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol/func.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | func: func, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `func` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol/func_tracked.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | func: func, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `func` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib_impl/lib.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib_impl/lib_tracked.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | inner: inner [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib_impl/lib_unsafe.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol/data.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol/data_tracked.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol/func.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | func: func, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `func` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol/func_tracked.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | func: func, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `func` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/symbol/mod.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | pub mod symbol; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/symbol/mod.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | pub mod symbol; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/test/examplelib.rs:2:24 [INFO] [stderr] | [INFO] [stderr] 2 | pub const EXAMPLELIB: &'static str = "test/.build/libexamplelib.so"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/test/unix/libm.rs:2:18 [INFO] [stderr] | [INFO] [stderr] 2 | pub const LIBM: &'static str = "libm.so.6"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/os/unix/lib.rs:57:26 [INFO] [stderr] | [INFO] [stderr] 57 | Some(mem::transmute(symbol)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `symbol as *const T` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&'a T`) [INFO] [stderr] --> src/lib_impl/lib.rs:84:26 [INFO] [stderr] | [INFO] [stderr] 84 | let symbol_ref = mem::transmute(symbol_ptr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*symbol_ptr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&'a T`) [INFO] [stderr] --> src/symbol/data_unsafe.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | mem::transmute(*self) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(*self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/symbol/func_unsafe.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | self.clone() [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/os/unix/lib.rs:57:26 [INFO] [stderr] | [INFO] [stderr] 57 | Some(mem::transmute(symbol)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `symbol as *const T` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&'a T`) [INFO] [stderr] --> src/lib_impl/lib.rs:84:26 [INFO] [stderr] | [INFO] [stderr] 84 | let symbol_ref = mem::transmute(symbol_ptr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*symbol_ptr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const T`) to a reference type (`&'a T`) [INFO] [stderr] --> src/symbol/data_unsafe.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | mem::transmute(*self) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(*self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/symbol/func_unsafe.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | self.clone() [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/test/unix/shared.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | assert_eq!(ceil.get()(0.45), 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/test/unix/shared.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | assert_eq!(ceil.get()(0.45), 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/test/unix/shared.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | assert_eq!(ceil.get()(0.45), 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/test/unix/shared.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | assert_eq!(ceil.get()(0.45), 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sharedlib`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "fbbd8ab8ceeaefdc695772c74fad3f45d8cefbbc386eadecb4830aac683389ad"` [INFO] running `"docker" "rm" "-f" "fbbd8ab8ceeaefdc695772c74fad3f45d8cefbbc386eadecb4830aac683389ad"` [INFO] [stdout] fbbd8ab8ceeaefdc695772c74fad3f45d8cefbbc386eadecb4830aac683389ad