[INFO] crate shared_memory 0.8.1 is already in cache [INFO] extracting crate shared_memory 0.8.1 into work/ex/clippy-test-run/sources/stable/reg/shared_memory/0.8.1 [INFO] extracting crate shared_memory 0.8.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shared_memory/0.8.1 [INFO] validating manifest of shared_memory-0.8.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shared_memory-0.8.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shared_memory-0.8.1 [INFO] finished frobbing shared_memory-0.8.1 [INFO] frobbed toml for shared_memory-0.8.1 written to work/ex/clippy-test-run/sources/stable/reg/shared_memory/0.8.1/Cargo.toml [INFO] started frobbing shared_memory-0.8.1 [INFO] finished frobbing shared_memory-0.8.1 [INFO] frobbed toml for shared_memory-0.8.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shared_memory/0.8.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shared_memory-0.8.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/shared_memory/0.8.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e87a93df6900ea960fb4dd1a5cc985f7dd75c0b3adfcbc60d98b02803f70d463 [INFO] running `"docker" "start" "-a" "e87a93df6900ea960fb4dd1a5cc985f7dd75c0b3adfcbc60d98b02803f70d463"` [INFO] [stderr] Checking memrange v0.1.3 [INFO] [stderr] Checking theban_interval_tree v0.7.1 [INFO] [stderr] Checking shared_memory v0.8.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/conf.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/conf.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/conf.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/conf.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/locks.rs:109:24 [INFO] [stderr] | [INFO] [stderr] 109 | fn drop(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/locks.rs:138:24 [INFO] [stderr] | [INFO] [stderr] 138 | fn drop(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/locks.rs:167:24 [INFO] [stderr] | [INFO] [stderr] 167 | fn drop(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/locks.rs:201:24 [INFO] [stderr] | [INFO] [stderr] 201 | fn drop(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/events.rs:111:38 [INFO] [stderr] | [INFO] [stderr] 111 | Timeout::Nano(t) => (t / 1000000) as u64, [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nix/linux.rs:85:38 [INFO] [stderr] | [INFO] [stderr] 85 | Timeout::Nano(t) => (t / 1000000) as isize, [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nix/linux.rs:193:38 [INFO] [stderr] | [INFO] [stderr] 193 | Timeout::Nano(t) => (t / 1000000) as isize, [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/nix/mod.rs:371:46 [INFO] [stderr] | [INFO] [stderr] 371 | fn runlock(&self, lock_ptr: *mut c_void) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/nix/mod.rs:374:46 [INFO] [stderr] | [INFO] [stderr] 374 | fn wunlock(&self, lock_ptr: *mut c_void) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/nix/mod.rs:415:46 [INFO] [stderr] | [INFO] [stderr] 415 | fn runlock(&self, lock_ptr: *mut c_void) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/nix/mod.rs:420:46 [INFO] [stderr] | [INFO] [stderr] 420 | fn wunlock(&self, lock_ptr: *mut c_void) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/conf.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/conf.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/conf.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/conf.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/raw.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return &(*(self.os_data.map_ptr as *const D)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&(*(self.os_data.map_ptr as *const D))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/raw.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | return slice::from_raw_parts(self.os_data.map_ptr as *const D, num_items); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `slice::from_raw_parts(self.os_data.map_ptr as *const D, num_items)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/raw.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | return &mut (*(self.os_data.map_ptr as *mut D)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&mut (*(self.os_data.map_ptr as *mut D))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/raw.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | return slice::from_raw_parts_mut(self.os_data.map_ptr as *mut D, num_items); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `slice::from_raw_parts_mut(self.os_data.map_ptr as *mut D, num_items)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:298:9 [INFO] [stderr] | [INFO] [stderr] 298 | return &(*(user_data as *const D)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&(*(user_data as *const D))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:310:9 [INFO] [stderr] | [INFO] [stderr] 310 | return slice::from_raw_parts(user_data as *const D, num_items); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `slice::from_raw_parts(user_data as *const D, num_items)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:316:9 [INFO] [stderr] | [INFO] [stderr] 316 | return &mut (*(user_data as *mut D)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&mut (*(user_data as *mut D))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:327:9 [INFO] [stderr] | [INFO] [stderr] 327 | return slice::from_raw_parts_mut(user_data as *mut D, num_items); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `slice::from_raw_parts_mut(user_data as *mut D, num_items)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/locks.rs:109:24 [INFO] [stderr] | [INFO] [stderr] 109 | fn drop(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/locks.rs:138:24 [INFO] [stderr] | [INFO] [stderr] 138 | fn drop(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/locks.rs:167:24 [INFO] [stderr] | [INFO] [stderr] 167 | fn drop(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/locks.rs:201:24 [INFO] [stderr] | [INFO] [stderr] 201 | fn drop(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/events.rs:111:38 [INFO] [stderr] | [INFO] [stderr] 111 | Timeout::Nano(t) => (t / 1000000) as u64, [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nix/linux.rs:85:38 [INFO] [stderr] | [INFO] [stderr] 85 | Timeout::Nano(t) => (t / 1000000) as isize, [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nix/linux.rs:193:38 [INFO] [stderr] | [INFO] [stderr] 193 | Timeout::Nano(t) => (t / 1000000) as isize, [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/nix/mod.rs:371:46 [INFO] [stderr] | [INFO] [stderr] 371 | fn runlock(&self, lock_ptr: *mut c_void) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/nix/mod.rs:374:46 [INFO] [stderr] | [INFO] [stderr] 374 | fn wunlock(&self, lock_ptr: *mut c_void) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/nix/mod.rs:415:46 [INFO] [stderr] | [INFO] [stderr] 415 | fn runlock(&self, lock_ptr: *mut c_void) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/nix/mod.rs:420:46 [INFO] [stderr] | [INFO] [stderr] 420 | fn wunlock(&self, lock_ptr: *mut c_void) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/conf.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/conf.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/conf.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/conf.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/raw.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return &(*(self.os_data.map_ptr as *const D)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&(*(self.os_data.map_ptr as *const D))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/raw.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | return slice::from_raw_parts(self.os_data.map_ptr as *const D, num_items); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `slice::from_raw_parts(self.os_data.map_ptr as *const D, num_items)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/raw.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | return &mut (*(self.os_data.map_ptr as *mut D)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&mut (*(self.os_data.map_ptr as *mut D))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/raw.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | return slice::from_raw_parts_mut(self.os_data.map_ptr as *mut D, num_items); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `slice::from_raw_parts_mut(self.os_data.map_ptr as *mut D, num_items)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:298:9 [INFO] [stderr] | [INFO] [stderr] 298 | return &(*(user_data as *const D)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&(*(user_data as *const D))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:310:9 [INFO] [stderr] | [INFO] [stderr] 310 | return slice::from_raw_parts(user_data as *const D, num_items); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `slice::from_raw_parts(user_data as *const D, num_items)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:316:9 [INFO] [stderr] | [INFO] [stderr] 316 | return &mut (*(user_data as *mut D)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&mut (*(user_data as *mut D))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:327:9 [INFO] [stderr] | [INFO] [stderr] 327 | return slice::from_raw_parts_mut(user_data as *mut D, num_items); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `slice::from_raw_parts_mut(user_data as *mut D, num_items)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/events.rs:146:23 [INFO] [stderr] | [INFO] [stderr] 146 | while !signal.compare_exchange(true, false, Ordering::Relaxed, Ordering::Relaxed).is_ok() {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `signal.compare_exchange(true, false, Ordering::Relaxed, Ordering::Relaxed).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/events.rs:157:15 [INFO] [stderr] | [INFO] [stderr] 157 | while !signal.compare_exchange(true, false, Ordering::Relaxed, Ordering::Relaxed).is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `signal.compare_exchange(true, false, Ordering::Relaxed, Ordering::Relaxed).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: The function/method `nix::unistd::write` doesn't need a mutable reference [INFO] [stderr] --> src/nix/linux.rs:134:52 [INFO] [stderr] | [INFO] [stderr] 134 | nix::unistd::write(my_data.evt_fd, &mut unsafe {std::mem::transmute::(1)})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `nix::unistd::write` doesn't need a mutable reference [INFO] [stderr] --> src/nix/linux.rs:222:52 [INFO] [stderr] | [INFO] [stderr] 222 | nix::unistd::write(my_data.evt_fd, &mut unsafe {std::mem::transmute::(1)})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/nix/mod.rs:243:38 [INFO] [stderr] | [INFO] [stderr] 243 | pub fn lockimpl_from_type(lock_type: &LockType) -> &'static LockImpl { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `LockType` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/nix/mod.rs:244:5 [INFO] [stderr] | [INFO] [stderr] 244 | / match lock_type { [INFO] [stderr] 245 | | &LockType::Mutex => &Mutex{}, [INFO] [stderr] 246 | | &LockType::RwLock => &RwLock{}, [INFO] [stderr] 247 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 244 | match *lock_type { [INFO] [stderr] 245 | LockType::Mutex => &Mutex{}, [INFO] [stderr] 246 | LockType::RwLock => &RwLock{}, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/nix/mod.rs:251:40 [INFO] [stderr] | [INFO] [stderr] 251 | pub fn eventimpl_from_type(event_type: &EventType) -> &'static EventImpl { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `EventType` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/nix/mod.rs:252:5 [INFO] [stderr] | [INFO] [stderr] 252 | / match event_type { [INFO] [stderr] 253 | | &EventType::AutoBusy => &AutoBusy{}, [INFO] [stderr] 254 | | &EventType::ManualBusy => &ManualBusy{}, [INFO] [stderr] 255 | | &EventType::Manual => &ManualGeneric{}, [INFO] [stderr] ... | [INFO] [stderr] 260 | | &EventType::ManualEventFd => &ManualEventFd{}, [INFO] [stderr] 261 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 252 | match *event_type { [INFO] [stderr] 253 | EventType::AutoBusy => &AutoBusy{}, [INFO] [stderr] 254 | EventType::ManualBusy => &ManualBusy{}, [INFO] [stderr] 255 | EventType::Manual => &ManualGeneric{}, [INFO] [stderr] 256 | EventType::Auto => &AutoGeneric{}, [INFO] [stderr] 257 | #[cfg(target_os="linux")] [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut nix::libc::pthread_mutexattr_t`) [INFO] [stderr] --> src/nix/mod.rs:299:41 [INFO] [stderr] | [INFO] [stderr] 299 | res = unsafe{pthread_mutexattr_init(lock_attr.as_mut_ptr() as *mut pthread_mutexattr_t)}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut nix::libc::pthread_mutexattr_t`) [INFO] [stderr] --> src/nix/mod.rs:303:47 [INFO] [stderr] | [INFO] [stderr] 303 | res = unsafe{pthread_mutexattr_setpshared(lock_attr.as_mut_ptr() as *mut pthread_mutexattr_t, PTHREAD_PROCESS_SHARED)}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut nix::libc::pthread_mutexattr_t`) [INFO] [stderr] --> src/nix/mod.rs:308:44 [INFO] [stderr] | [INFO] [stderr] 308 | res = unsafe{pthread_mutex_init(mutex, lock_attr.as_mut_ptr() as *mut pthread_mutexattr_t)}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut nix::libc::pthread_rwlockattr_t`) [INFO] [stderr] --> src/nix/mod.rs:395:35 [INFO] [stderr] | [INFO] [stderr] 395 | pthread_rwlockattr_init(lock_attr.as_mut_ptr() as *mut pthread_rwlockattr_t); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut nix::libc::pthread_rwlockattr_t`) [INFO] [stderr] --> src/nix/mod.rs:396:41 [INFO] [stderr] | [INFO] [stderr] 396 | pthread_rwlockattr_setpshared(lock_attr.as_mut_ptr() as *mut pthread_rwlockattr_t, PTHREAD_PROCESS_SHARED); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut nix::libc::pthread_rwlockattr_t`) [INFO] [stderr] --> src/nix/mod.rs:398:76 [INFO] [stderr] | [INFO] [stderr] 398 | pthread_rwlock_init(lock_info.lock_ptr as *mut pthread_rwlock_t, lock_attr.as_mut_ptr() as *mut pthread_rwlockattr_t); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut nix::libc::pthread_condattr_t`) [INFO] [stderr] --> src/nix/mod.rs:438:41 [INFO] [stderr] | [INFO] [stderr] 438 | res = unsafe {pthread_condattr_init(cond_attr.as_mut_ptr() as *mut pthread_condattr_t)}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut nix::libc::pthread_condattr_t`) [INFO] [stderr] --> src/nix/mod.rs:442:47 [INFO] [stderr] | [INFO] [stderr] 442 | res = unsafe {pthread_condattr_setpshared(cond_attr.as_mut_ptr() as *mut pthread_condattr_t, PTHREAD_PROCESS_SHARED)}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut nix::libc::pthread_condattr_t`) [INFO] [stderr] --> src/nix/mod.rs:447:54 [INFO] [stderr] | [INFO] [stderr] 447 | res = unsafe {pthread_cond_init(&mut event.cond, cond_attr.as_mut_ptr() as *mut pthread_condattr_t)}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `conf::SharedMemConf<'a>` [INFO] [stderr] --> src/conf.rs:163:5 [INFO] [stderr] | [INFO] [stderr] 163 | / pub fn new() -> SharedMemConf<'a> { [INFO] [stderr] 164 | | SharedMemConf { [INFO] [stderr] 165 | | owner: false, [INFO] [stderr] 166 | | link_path: None, [INFO] [stderr] ... | [INFO] [stderr] 174 | | } [INFO] [stderr] 175 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 59 | impl Default for conf::SharedMemConf<'a> { [INFO] [stderr] 60 | fn default() -> Self { [INFO] [stderr] 61 | Self::new() [INFO] [stderr] 62 | } [INFO] [stderr] 63 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/conf.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | / if offset != 0 { [INFO] [stderr] 67 | | return false; [INFO] [stderr] 68 | | } else { [INFO] [stderr] 69 | | return true; [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____________^ help: you can reduce it to: `return !(offset != 0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/conf.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | for ref lock in &self.lock_data { [INFO] [stderr] | ^^^^^^^^ --------------- help: try: `let lock = &&self.lock_data;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/conf.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | for ref event in &self.event_data { [INFO] [stderr] | ^^^^^^^^^ ---------------- help: try: `let event = &&self.event_data;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/events.rs:146:23 [INFO] [stderr] | [INFO] [stderr] 146 | while !signal.compare_exchange(true, false, Ordering::Relaxed, Ordering::Relaxed).is_ok() {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `signal.compare_exchange(true, false, Ordering::Relaxed, Ordering::Relaxed).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/events.rs:157:15 [INFO] [stderr] | [INFO] [stderr] 157 | while !signal.compare_exchange(true, false, Ordering::Relaxed, Ordering::Relaxed).is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `signal.compare_exchange(true, false, Ordering::Relaxed, Ordering::Relaxed).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: The function/method `nix::unistd::write` doesn't need a mutable reference [INFO] [stderr] --> src/nix/linux.rs:134:52 [INFO] [stderr] | [INFO] [stderr] 134 | nix::unistd::write(my_data.evt_fd, &mut unsafe {std::mem::transmute::(1)})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `nix::unistd::write` doesn't need a mutable reference [INFO] [stderr] --> src/nix/linux.rs:222:52 [INFO] [stderr] | [INFO] [stderr] 222 | nix::unistd::write(my_data.evt_fd, &mut unsafe {std::mem::transmute::(1)})?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/lib.rs:153:9 [INFO] [stderr] | [INFO] [stderr] 153 | drop(&self.link_file); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_ref)] on by default [INFO] [stderr] note: argument has type &enum_primitive::Option [INFO] [stderr] --> src/lib.rs:153:14 [INFO] [stderr] | [INFO] [stderr] 153 | drop(&self.link_file); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `lock.data_ptr as usize` [INFO] [stderr] --> src/lib.rs:287:47 [INFO] [stderr] | [INFO] [stderr] 287 | slice::from_raw_parts_mut((lock.data_ptr as usize + 0) as *mut D, num_items), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/nix/mod.rs:243:38 [INFO] [stderr] | [INFO] [stderr] 243 | pub fn lockimpl_from_type(lock_type: &LockType) -> &'static LockImpl { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `LockType` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/nix/mod.rs:244:5 [INFO] [stderr] | [INFO] [stderr] 244 | / match lock_type { [INFO] [stderr] 245 | | &LockType::Mutex => &Mutex{}, [INFO] [stderr] 246 | | &LockType::RwLock => &RwLock{}, [INFO] [stderr] 247 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 244 | match *lock_type { [INFO] [stderr] 245 | LockType::Mutex => &Mutex{}, [INFO] [stderr] 246 | LockType::RwLock => &RwLock{}, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/nix/mod.rs:251:40 [INFO] [stderr] | [INFO] [stderr] 251 | pub fn eventimpl_from_type(event_type: &EventType) -> &'static EventImpl { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `EventType` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/nix/mod.rs:252:5 [INFO] [stderr] | [INFO] [stderr] 252 | / match event_type { [INFO] [stderr] 253 | | &EventType::AutoBusy => &AutoBusy{}, [INFO] [stderr] 254 | | &EventType::ManualBusy => &ManualBusy{}, [INFO] [stderr] 255 | | &EventType::Manual => &ManualGeneric{}, [INFO] [stderr] ... | [INFO] [stderr] 260 | | &EventType::ManualEventFd => &ManualEventFd{}, [INFO] [stderr] 261 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 252 | match *event_type { [INFO] [stderr] 253 | EventType::AutoBusy => &AutoBusy{}, [INFO] [stderr] 254 | EventType::ManualBusy => &ManualBusy{}, [INFO] [stderr] 255 | EventType::Manual => &ManualGeneric{}, [INFO] [stderr] 256 | EventType::Auto => &AutoGeneric{}, [INFO] [stderr] 257 | #[cfg(target_os="linux")] [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut nix::libc::pthread_mutexattr_t`) [INFO] [stderr] --> src/nix/mod.rs:299:41 [INFO] [stderr] | [INFO] [stderr] 299 | res = unsafe{pthread_mutexattr_init(lock_attr.as_mut_ptr() as *mut pthread_mutexattr_t)}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut nix::libc::pthread_mutexattr_t`) [INFO] [stderr] --> src/nix/mod.rs:303:47 [INFO] [stderr] | [INFO] [stderr] 303 | res = unsafe{pthread_mutexattr_setpshared(lock_attr.as_mut_ptr() as *mut pthread_mutexattr_t, PTHREAD_PROCESS_SHARED)}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut nix::libc::pthread_mutexattr_t`) [INFO] [stderr] --> src/nix/mod.rs:308:44 [INFO] [stderr] | [INFO] [stderr] 308 | res = unsafe{pthread_mutex_init(mutex, lock_attr.as_mut_ptr() as *mut pthread_mutexattr_t)}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut nix::libc::pthread_rwlockattr_t`) [INFO] [stderr] --> src/nix/mod.rs:395:35 [INFO] [stderr] | [INFO] [stderr] 395 | pthread_rwlockattr_init(lock_attr.as_mut_ptr() as *mut pthread_rwlockattr_t); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut nix::libc::pthread_rwlockattr_t`) [INFO] [stderr] --> src/nix/mod.rs:396:41 [INFO] [stderr] | [INFO] [stderr] 396 | pthread_rwlockattr_setpshared(lock_attr.as_mut_ptr() as *mut pthread_rwlockattr_t, PTHREAD_PROCESS_SHARED); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut nix::libc::pthread_rwlockattr_t`) [INFO] [stderr] --> src/nix/mod.rs:398:76 [INFO] [stderr] | [INFO] [stderr] 398 | pthread_rwlock_init(lock_info.lock_ptr as *mut pthread_rwlock_t, lock_attr.as_mut_ptr() as *mut pthread_rwlockattr_t); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: aborting due to 10 previous errors [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut nix::libc::pthread_condattr_t`) [INFO] [stderr] --> src/nix/mod.rs:438:41 [INFO] [stderr] | [INFO] [stderr] 438 | res = unsafe {pthread_condattr_init(cond_attr.as_mut_ptr() as *mut pthread_condattr_t)}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut nix::libc::pthread_condattr_t`) [INFO] [stderr] --> src/nix/mod.rs:442:47 [INFO] [stderr] | [INFO] [stderr] 442 | res = unsafe {pthread_condattr_setpshared(cond_attr.as_mut_ptr() as *mut pthread_condattr_t, PTHREAD_PROCESS_SHARED)}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut nix::libc::pthread_condattr_t`) [INFO] [stderr] --> src/nix/mod.rs:447:54 [INFO] [stderr] | [INFO] [stderr] 447 | res = unsafe {pthread_cond_init(&mut event.cond, cond_attr.as_mut_ptr() as *mut pthread_condattr_t)}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: Could not compile `shared_memory`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you should consider adding a `Default` implementation for `conf::SharedMemConf<'a>` [INFO] [stderr] --> src/conf.rs:163:5 [INFO] [stderr] | [INFO] [stderr] 163 | / pub fn new() -> SharedMemConf<'a> { [INFO] [stderr] 164 | | SharedMemConf { [INFO] [stderr] 165 | | owner: false, [INFO] [stderr] 166 | | link_path: None, [INFO] [stderr] ... | [INFO] [stderr] 174 | | } [INFO] [stderr] 175 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 59 | impl Default for conf::SharedMemConf<'a> { [INFO] [stderr] 60 | fn default() -> Self { [INFO] [stderr] 61 | Self::new() [INFO] [stderr] 62 | } [INFO] [stderr] 63 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/conf.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | / if offset != 0 { [INFO] [stderr] 67 | | return false; [INFO] [stderr] 68 | | } else { [INFO] [stderr] 69 | | return true; [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____________^ help: you can reduce it to: `return !(offset != 0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/conf.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | for ref lock in &self.lock_data { [INFO] [stderr] | ^^^^^^^^ --------------- help: try: `let lock = &&self.lock_data;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/conf.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | for ref event in &self.event_data { [INFO] [stderr] | ^^^^^^^^^ ---------------- help: try: `let event = &&self.event_data;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/lib.rs:153:9 [INFO] [stderr] | [INFO] [stderr] 153 | drop(&self.link_file); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_ref)] on by default [INFO] [stderr] note: argument has type &enum_primitive::Option [INFO] [stderr] --> src/lib.rs:153:14 [INFO] [stderr] | [INFO] [stderr] 153 | drop(&self.link_file); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `lock.data_ptr as usize` [INFO] [stderr] --> src/lib.rs:287:47 [INFO] [stderr] | [INFO] [stderr] 287 | slice::from_raw_parts_mut((lock.data_ptr as usize + 0) as *mut D, num_items), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: aborting due to 10 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `shared_memory`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e87a93df6900ea960fb4dd1a5cc985f7dd75c0b3adfcbc60d98b02803f70d463"` [INFO] running `"docker" "rm" "-f" "e87a93df6900ea960fb4dd1a5cc985f7dd75c0b3adfcbc60d98b02803f70d463"` [INFO] [stdout] e87a93df6900ea960fb4dd1a5cc985f7dd75c0b3adfcbc60d98b02803f70d463