[INFO] crate shared_library 0.1.9 is already in cache [INFO] extracting crate shared_library 0.1.9 into work/ex/clippy-test-run/sources/stable/reg/shared_library/0.1.9 [INFO] extracting crate shared_library 0.1.9 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shared_library/0.1.9 [INFO] validating manifest of shared_library-0.1.9 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shared_library-0.1.9 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shared_library-0.1.9 [INFO] finished frobbing shared_library-0.1.9 [INFO] frobbed toml for shared_library-0.1.9 written to work/ex/clippy-test-run/sources/stable/reg/shared_library/0.1.9/Cargo.toml [INFO] started frobbing shared_library-0.1.9 [INFO] finished frobbing shared_library-0.1.9 [INFO] frobbed toml for shared_library-0.1.9 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shared_library/0.1.9/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shared_library-0.1.9 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/shared_library/0.1.9:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4616dc609c0fc661831e6f20cc1ffa555463b1103d01e9175375cfcf7cde67b1 [INFO] running `"docker" "start" "-a" "4616dc609c0fc661831e6f20cc1ffa555463b1103d01e9175375cfcf7cde67b1"` [INFO] [stderr] Checking shared_library v0.1.9 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/dynamic_library.rs:277:13 [INFO] [stderr] | [INFO] [stderr] 277 | ret [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/dynamic_library.rs:270:23 [INFO] [stderr] | [INFO] [stderr] 270 | let ret = if ptr::null() == last_error { [INFO] [stderr] | _______________________^ [INFO] [stderr] 271 | | Ok(result) [INFO] [stderr] 272 | | } else { [INFO] [stderr] 273 | | let s = CStr::from_ptr(last_error).to_bytes(); [INFO] [stderr] 274 | | Err(str::from_utf8(s).unwrap().to_string()) [INFO] [stderr] 275 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/dynamic_library.rs:289:47 [INFO] [stderr] | [INFO] [stderr] 289 | dlclose(handle as *mut libc::c_void); () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/dynamic_library.rs:131:24 [INFO] [stderr] | [INFO] [stderr] 131 | .map(|sym| mem::transmute(sym)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `sym as *mut T` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from an integer to a pointer [INFO] [stderr] --> src/dynamic_library.rs:146:37 [INFO] [stderr] | [INFO] [stderr] 146 | SpecialHandles::Next => mem::transmute::(-1), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `-1 as *mut libc::c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/dynamic_library.rs:156:24 [INFO] [stderr] | [INFO] [stderr] 156 | .map(|sym| mem::transmute(sym)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `sym as *mut T` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/dynamic_library.rs:270:26 [INFO] [stderr] | [INFO] [stderr] 270 | let ret = if ptr::null() == last_error { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_null)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/dynamic_library.rs:277:13 [INFO] [stderr] | [INFO] [stderr] 277 | ret [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/dynamic_library.rs:270:23 [INFO] [stderr] | [INFO] [stderr] 270 | let ret = if ptr::null() == last_error { [INFO] [stderr] | _______________________^ [INFO] [stderr] 271 | | Ok(result) [INFO] [stderr] 272 | | } else { [INFO] [stderr] 273 | | let s = CStr::from_ptr(last_error).to_bytes(); [INFO] [stderr] 274 | | Err(str::from_utf8(s).unwrap().to_string()) [INFO] [stderr] 275 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/dynamic_library.rs:289:47 [INFO] [stderr] | [INFO] [stderr] 289 | dlclose(handle as *mut libc::c_void); () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/dynamic_library.rs:131:24 [INFO] [stderr] | [INFO] [stderr] 131 | .map(|sym| mem::transmute(sym)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `sym as *mut T` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from an integer to a pointer [INFO] [stderr] --> src/dynamic_library.rs:146:37 [INFO] [stderr] | [INFO] [stderr] 146 | SpecialHandles::Next => mem::transmute::(-1), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `-1 as *mut libc::c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/dynamic_library.rs:156:24 [INFO] [stderr] | [INFO] [stderr] 156 | .map(|sym| mem::transmute(sym)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `sym as *mut T` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/dynamic_library.rs:186:12 [INFO] [stderr] | [INFO] [stderr] 186 | if result != expected_result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result - expected_result).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/dynamic_library.rs:186:12 [INFO] [stderr] | [INFO] [stderr] 186 | if result != expected_result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/dynamic_library.rs:270:26 [INFO] [stderr] | [INFO] [stderr] 270 | let ret = if ptr::null() == last_error { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_null)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `shared_library`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4616dc609c0fc661831e6f20cc1ffa555463b1103d01e9175375cfcf7cde67b1"` [INFO] running `"docker" "rm" "-f" "4616dc609c0fc661831e6f20cc1ffa555463b1103d01e9175375cfcf7cde67b1"` [INFO] [stdout] 4616dc609c0fc661831e6f20cc1ffa555463b1103d01e9175375cfcf7cde67b1