[INFO] crate shard 0.1.2 is already in cache [INFO] extracting crate shard 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/shard/0.1.2 [INFO] extracting crate shard 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shard/0.1.2 [INFO] validating manifest of shard-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shard-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shard-0.1.2 [INFO] finished frobbing shard-0.1.2 [INFO] frobbed toml for shard-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/shard/0.1.2/Cargo.toml [INFO] started frobbing shard-0.1.2 [INFO] finished frobbing shard-0.1.2 [INFO] frobbed toml for shard-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shard/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shard-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/shard/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 822430b7a6a774155e35e927a8586720c4bd447a2a653846970502c089c95f04 [INFO] running `"docker" "start" "-a" "822430b7a6a774155e35e927a8586720c4bd447a2a653846970502c089c95f04"` [INFO] [stderr] Checking shard v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `ParserError` [INFO] [stderr] --> src/syntax/ast/mod.rs:1:29 [INFO] [stderr] | [INFO] [stderr] 1 | use super::parser::{Parser, ParserError, ParserResult}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `ParserError` [INFO] [stderr] --> src/syntax/ast/mod.rs:1:29 [INFO] [stderr] | [INFO] [stderr] 1 | use super::parser::{Parser, ParserError, ParserResult}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/syntax/lexer.rs:54:12 [INFO] [stderr] | [INFO] [stderr] 54 | if self.tokens.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/syntax/lexer.rs:123:62 [INFO] [stderr] | [INFO] [stderr] 123 | self.tokens.push(Token::from_char(c).expect(&format!( [INFO] [stderr] | ______________________________________________________________^ [INFO] [stderr] 124 | | "Illegal character `{}` encountered on line {},\ [INFO] [stderr] 125 | | column {} during lexical analysis. Expected valid operator", [INFO] [stderr] 126 | | c, [INFO] [stderr] 127 | | self.line, [INFO] [stderr] 128 | | self.column [INFO] [stderr] 129 | | ))); [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 123 | self.tokens.push(Token::from_char(c).unwrap_or_else(|| panic!("Illegal character `{}` encountered on line {},\ [INFO] [stderr] 124 | column {} during lexical analysis. Expected valid operator", c))); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/syntax/token.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | / pub fn from_str(s: &str) -> Token { [INFO] [stderr] 89 | | let word: String = s.chars().flat_map(|c| c.to_lowercase()).collect(); [INFO] [stderr] 90 | | match word.as_ref() { [INFO] [stderr] 91 | | "select" => SELECT, [INFO] [stderr] ... | [INFO] [stderr] 113 | | } [INFO] [stderr] 114 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/syntax/lexer.rs:54:12 [INFO] [stderr] | [INFO] [stderr] 54 | if self.tokens.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/syntax/lexer.rs:123:62 [INFO] [stderr] | [INFO] [stderr] 123 | self.tokens.push(Token::from_char(c).expect(&format!( [INFO] [stderr] | ______________________________________________________________^ [INFO] [stderr] 124 | | "Illegal character `{}` encountered on line {},\ [INFO] [stderr] 125 | | column {} during lexical analysis. Expected valid operator", [INFO] [stderr] 126 | | c, [INFO] [stderr] 127 | | self.line, [INFO] [stderr] 128 | | self.column [INFO] [stderr] 129 | | ))); [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 123 | self.tokens.push(Token::from_char(c).unwrap_or_else(|| panic!("Illegal character `{}` encountered on line {},\ [INFO] [stderr] 124 | column {} during lexical analysis. Expected valid operator", c))); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/syntax/token.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | / pub fn from_str(s: &str) -> Token { [INFO] [stderr] 89 | | let word: String = s.chars().flat_map(|c| c.to_lowercase()).collect(); [INFO] [stderr] 90 | | match word.as_ref() { [INFO] [stderr] 91 | | "select" => SELECT, [INFO] [stderr] ... | [INFO] [stderr] 113 | | } [INFO] [stderr] 114 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.31s [INFO] running `"docker" "inspect" "822430b7a6a774155e35e927a8586720c4bd447a2a653846970502c089c95f04"` [INFO] running `"docker" "rm" "-f" "822430b7a6a774155e35e927a8586720c4bd447a2a653846970502c089c95f04"` [INFO] [stdout] 822430b7a6a774155e35e927a8586720c4bd447a2a653846970502c089c95f04