[INFO] crate shannon 0.2.0 is already in cache [INFO] extracting crate shannon 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/shannon/0.2.0 [INFO] extracting crate shannon 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shannon/0.2.0 [INFO] validating manifest of shannon-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shannon-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shannon-0.2.0 [INFO] finished frobbing shannon-0.2.0 [INFO] frobbed toml for shannon-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/shannon/0.2.0/Cargo.toml [INFO] started frobbing shannon-0.2.0 [INFO] finished frobbing shannon-0.2.0 [INFO] frobbed toml for shannon-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shannon/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shannon-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/shannon/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c39c8420c1a1479fff46de1d3501c499868514ca745ae9df901009ba5e1a7b81 [INFO] running `"docker" "start" "-a" "c39c8420c1a1479fff46de1d3501c499868514ca745ae9df901009ba5e1a7b81"` [INFO] [stderr] Checking shannon v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:10:24 [INFO] [stderr] | [INFO] [stderr] 10 | const INITKONST: u32 = 0x6996c53ai32 as (u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6996_c53ai32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | w = w ^ (w << 5i32 | w >> 32i32 - 5i32 | (w << 7i32 | w >> 32i32 - 7i32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `w >> (32i32 - 5i32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:25:59 [INFO] [stderr] | [INFO] [stderr] 25 | w = w ^ (w << 5i32 | w >> 32i32 - 5i32 | (w << 7i32 | w >> 32i32 - 7i32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `w >> (32i32 - 7i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:26:27 [INFO] [stderr] | [INFO] [stderr] 26 | w = w ^ (w << 19i32 | w >> 32i32 - 19i32 | (w << 22i32 | w >> 32i32 - 22i32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `w >> (32i32 - 19i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:26:62 [INFO] [stderr] | [INFO] [stderr] 26 | w = w ^ (w << 19i32 | w >> 32i32 - 19i32 | (w << 22i32 | w >> 32i32 - 22i32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `w >> (32i32 - 22i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:31:26 [INFO] [stderr] | [INFO] [stderr] 31 | w = w ^ (w << 7i32 | w >> 32i32 - 7i32 | (w << 22i32 | w >> 32i32 - 22i32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `w >> (32i32 - 7i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:31:60 [INFO] [stderr] | [INFO] [stderr] 31 | w = w ^ (w << 7i32 | w >> 32i32 - 7i32 | (w << 22i32 | w >> 32i32 - 22i32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `w >> (32i32 - 22i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:32:26 [INFO] [stderr] | [INFO] [stderr] 32 | w = w ^ (w << 5i32 | w >> 32i32 - 5i32 | (w << 19i32 | w >> 32i32 - 19i32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `w >> (32i32 - 5i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:32:60 [INFO] [stderr] | [INFO] [stderr] 32 | w = w ^ (w << 5i32 | w >> 32i32 - 5i32 | (w << 19i32 | w >> 32i32 - 19i32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `w >> (32i32 - 19i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:116:26 [INFO] [stderr] | [INFO] [stderr] 116 | for i in 0..word.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try replacing the loop by: `xtra[..word.len()].clone_from_slice(&word[..])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the slice [INFO] [stderr] --> src/lib.rs:170:27 [INFO] [stderr] | [INFO] [stderr] 170 | let mut buf = buf.into_iter(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:200:12 [INFO] [stderr] | [INFO] [stderr] 200 | if extra.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!extra.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the slice [INFO] [stderr] --> src/lib.rs:204:28 [INFO] [stderr] | [INFO] [stderr] 204 | for b in extra.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:220:38 [INFO] [stderr] | [INFO] [stderr] 220 | ctx.mbuf ^= (*b as u32) << (32 - ctx.nbuf); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(*b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:235:38 [INFO] [stderr] | [INFO] [stderr] 235 | ctx.mbuf ^= (*b as u32) << (32 - ctx.nbuf); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(*b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the slice [INFO] [stderr] --> src/lib.rs:270:36 [INFO] [stderr] | [INFO] [stderr] 270 | for (b, i) in word.into_iter().zip(0..) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:10:24 [INFO] [stderr] | [INFO] [stderr] 10 | const INITKONST: u32 = 0x6996c53ai32 as (u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6996_c53ai32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | w = w ^ (w << 5i32 | w >> 32i32 - 5i32 | (w << 7i32 | w >> 32i32 - 7i32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `w >> (32i32 - 5i32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:25:59 [INFO] [stderr] | [INFO] [stderr] 25 | w = w ^ (w << 5i32 | w >> 32i32 - 5i32 | (w << 7i32 | w >> 32i32 - 7i32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `w >> (32i32 - 7i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:26:27 [INFO] [stderr] | [INFO] [stderr] 26 | w = w ^ (w << 19i32 | w >> 32i32 - 19i32 | (w << 22i32 | w >> 32i32 - 22i32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `w >> (32i32 - 19i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:26:62 [INFO] [stderr] | [INFO] [stderr] 26 | w = w ^ (w << 19i32 | w >> 32i32 - 19i32 | (w << 22i32 | w >> 32i32 - 22i32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `w >> (32i32 - 22i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:31:26 [INFO] [stderr] | [INFO] [stderr] 31 | w = w ^ (w << 7i32 | w >> 32i32 - 7i32 | (w << 22i32 | w >> 32i32 - 22i32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `w >> (32i32 - 7i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:31:60 [INFO] [stderr] | [INFO] [stderr] 31 | w = w ^ (w << 7i32 | w >> 32i32 - 7i32 | (w << 22i32 | w >> 32i32 - 22i32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `w >> (32i32 - 22i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:32:26 [INFO] [stderr] | [INFO] [stderr] 32 | w = w ^ (w << 5i32 | w >> 32i32 - 5i32 | (w << 19i32 | w >> 32i32 - 19i32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `w >> (32i32 - 5i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:32:60 [INFO] [stderr] | [INFO] [stderr] 32 | w = w ^ (w << 5i32 | w >> 32i32 - 5i32 | (w << 19i32 | w >> 32i32 - 19i32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `w >> (32i32 - 19i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:116:26 [INFO] [stderr] | [INFO] [stderr] 116 | for i in 0..word.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try replacing the loop by: `xtra[..word.len()].clone_from_slice(&word[..])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the slice [INFO] [stderr] --> src/lib.rs:170:27 [INFO] [stderr] | [INFO] [stderr] 170 | let mut buf = buf.into_iter(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:200:12 [INFO] [stderr] | [INFO] [stderr] 200 | if extra.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!extra.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the slice [INFO] [stderr] --> src/lib.rs:204:28 [INFO] [stderr] | [INFO] [stderr] 204 | for b in extra.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:220:38 [INFO] [stderr] | [INFO] [stderr] 220 | ctx.mbuf ^= (*b as u32) << (32 - ctx.nbuf); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(*b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:235:38 [INFO] [stderr] | [INFO] [stderr] 235 | ctx.mbuf ^= (*b as u32) << (32 - ctx.nbuf); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(*b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the slice [INFO] [stderr] --> src/lib.rs:270:36 [INFO] [stderr] | [INFO] [stderr] 270 | for (b, i) in word.into_iter().zip(0..) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.70s [INFO] running `"docker" "inspect" "c39c8420c1a1479fff46de1d3501c499868514ca745ae9df901009ba5e1a7b81"` [INFO] running `"docker" "rm" "-f" "c39c8420c1a1479fff46de1d3501c499868514ca745ae9df901009ba5e1a7b81"` [INFO] [stdout] c39c8420c1a1479fff46de1d3501c499868514ca745ae9df901009ba5e1a7b81