[INFO] crate shadowcast 0.4.0 is already in cache [INFO] extracting crate shadowcast 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/shadowcast/0.4.0 [INFO] extracting crate shadowcast 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shadowcast/0.4.0 [INFO] validating manifest of shadowcast-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shadowcast-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shadowcast-0.4.0 [INFO] finished frobbing shadowcast-0.4.0 [INFO] frobbed toml for shadowcast-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/shadowcast/0.4.0/Cargo.toml [INFO] started frobbing shadowcast-0.4.0 [INFO] finished frobbing shadowcast-0.4.0 [INFO] frobbed toml for shadowcast-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shadowcast/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shadowcast-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/shadowcast/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1fb2bc59a8d3c2a37d0c44e0ab4a4f53474fcc2a744ac5eeb298e7ea3a4d45dc [INFO] running `"docker" "start" "-a" "1fb2bc59a8d3c2a37d0c44e0ab4a4f53474fcc2a744ac5eeb298e7ea3a4d45dc"` [INFO] [stderr] Checking coord_2d v0.2.4 [INFO] [stderr] Checking direction v0.17.6 [INFO] [stderr] Checking shadowcast v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/shadowcast.rs:235:26 [INFO] [stderr] | [INFO] [stderr] 235 | for lateral_index in lateral_min..(lateral_max + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `lateral_min..=lateral_max` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `shadowcast::ShadowcastContext` [INFO] [stderr] --> src/shadowcast.rs:347:5 [INFO] [stderr] | [INFO] [stderr] 347 | / pub fn new() -> Self { [INFO] [stderr] 348 | | Self { [INFO] [stderr] 349 | | queue_a: Vec::new(), [INFO] [stderr] 350 | | queue_a_swap: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 353 | | } [INFO] [stderr] 354 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 339 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/shadowcast.rs:235:26 [INFO] [stderr] | [INFO] [stderr] 235 | for lateral_index in lateral_min..(lateral_max + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `lateral_min..=lateral_max` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `shadowcast::ShadowcastContext` [INFO] [stderr] --> src/shadowcast.rs:347:5 [INFO] [stderr] | [INFO] [stderr] 347 | / pub fn new() -> Self { [INFO] [stderr] 348 | | Self { [INFO] [stderr] 349 | | queue_a: Vec::new(), [INFO] [stderr] 350 | | queue_a_swap: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 353 | | } [INFO] [stderr] 354 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 339 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.74s [INFO] running `"docker" "inspect" "1fb2bc59a8d3c2a37d0c44e0ab4a4f53474fcc2a744ac5eeb298e7ea3a4d45dc"` [INFO] running `"docker" "rm" "-f" "1fb2bc59a8d3c2a37d0c44e0ab4a4f53474fcc2a744ac5eeb298e7ea3a4d45dc"` [INFO] [stdout] 1fb2bc59a8d3c2a37d0c44e0ab4a4f53474fcc2a744ac5eeb298e7ea3a4d45dc