[INFO] crate shader-prepper 0.1.2 is already in cache [INFO] extracting crate shader-prepper 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/shader-prepper/0.1.2 [INFO] extracting crate shader-prepper 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shader-prepper/0.1.2 [INFO] validating manifest of shader-prepper-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shader-prepper-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shader-prepper-0.1.2 [INFO] finished frobbing shader-prepper-0.1.2 [INFO] frobbed toml for shader-prepper-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/shader-prepper/0.1.2/Cargo.toml [INFO] started frobbing shader-prepper-0.1.2 [INFO] finished frobbing shader-prepper-0.1.2 [INFO] frobbed toml for shader-prepper-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shader-prepper/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shader-prepper-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/shader-prepper/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0707b12db721ea190085b513fcf3d1d024f819fb964f09df9164a1882e60f131 [INFO] running `"docker" "start" "-a" "0707b12db721ea190085b513fcf3d1d024f819fb964f09df9164a1882e60f131"` [INFO] [stderr] Checking shader-prepper v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lib.rs:537:51 [INFO] [stderr] | [INFO] [stderr] 537 | Err(crate::PrepperError::ParseError { file: _, line: 1 }) => (), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `ParseError { line: 1, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lib.rs:606:51 [INFO] [stderr] | [INFO] [stderr] 606 | Err(crate::PrepperError::ParseError { file: _, line: 1 }) => (), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ParseError { line: 1, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lib.rs:611:51 [INFO] [stderr] | [INFO] [stderr] 611 | Err(crate::PrepperError::ParseError { file: _, line: 1 }) => (), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ParseError { line: 1, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lib.rs:616:51 [INFO] [stderr] | [INFO] [stderr] 616 | Err(crate::PrepperError::ParseError { file: _, line: 1 }) => (), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ParseError { line: 1, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:456:16 [INFO] [stderr] | [INFO] [stderr] 456 | Ok(self.0.get(path).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.0[path]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the `val @ _` pattern can be written as just `val` [INFO] [stderr] --> src/lib.rs:478:13 [INFO] [stderr] | [INFO] [stderr] 478 | val @ _ => panic!("{:?}", val), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `val @ _` pattern can be written as just `val` [INFO] [stderr] --> src/lib.rs:607:13 [INFO] [stderr] | [INFO] [stderr] 607 | val @ _ => panic!("{:?}", val), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `val @ _` pattern can be written as just `val` [INFO] [stderr] --> src/lib.rs:612:13 [INFO] [stderr] | [INFO] [stderr] 612 | val @ _ => panic!("{:?}", val), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `val @ _` pattern can be written as just `val` [INFO] [stderr] --> src/lib.rs:617:13 [INFO] [stderr] | [INFO] [stderr] 617 | val @ _ => panic!("{:?}", val), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `fname @ _` pattern can be written as just `fname` [INFO] [stderr] --> src/lib.rs:633:23 [INFO] [stderr] | [INFO] [stderr] 633 | file: fname @ _, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `fsrc @ _` pattern can be written as just `fsrc` [INFO] [stderr] --> src/lib.rs:634:23 [INFO] [stderr] | [INFO] [stderr] 634 | from: fsrc @ _, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `val @ _` pattern can be written as just `val` [INFO] [stderr] --> src/lib.rs:637:13 [INFO] [stderr] | [INFO] [stderr] 637 | val @ _ => panic!("{:?}", val), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.13s [INFO] running `"docker" "inspect" "0707b12db721ea190085b513fcf3d1d024f819fb964f09df9164a1882e60f131"` [INFO] running `"docker" "rm" "-f" "0707b12db721ea190085b513fcf3d1d024f819fb964f09df9164a1882e60f131"` [INFO] [stdout] 0707b12db721ea190085b513fcf3d1d024f819fb964f09df9164a1882e60f131