[INFO] crate sfz 0.0.3 is already in cache [INFO] extracting crate sfz 0.0.3 into work/ex/clippy-test-run/sources/stable/reg/sfz/0.0.3 [INFO] extracting crate sfz 0.0.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sfz/0.0.3 [INFO] validating manifest of sfz-0.0.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sfz-0.0.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sfz-0.0.3 [INFO] finished frobbing sfz-0.0.3 [INFO] frobbed toml for sfz-0.0.3 written to work/ex/clippy-test-run/sources/stable/reg/sfz/0.0.3/Cargo.toml [INFO] started frobbing sfz-0.0.3 [INFO] finished frobbing sfz-0.0.3 [INFO] frobbed toml for sfz-0.0.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sfz/0.0.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sfz-0.0.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sfz/0.0.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 26ab07f83208affb860b9ae795cc217936f979ec0696f4893d0b61c01163998a [INFO] running `"docker" "start" "-a" "26ab07f83208affb860b9ae795cc217936f979ec0696f4893d0b61c01163998a"` [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling autocfg v0.1.2 [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Checking rand_core v0.4.0 [INFO] [stderr] Compiling arrayvec v0.4.10 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking cfg-if v0.1.6 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Checking lazy_static v1.2.0 [INFO] [stderr] Checking stable_deref_trait v1.1.1 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Checking memoffset v0.2.1 [INFO] [stderr] Compiling proc-macro2 v0.4.26 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling cc v1.0.28 [INFO] [stderr] Checking lazycell v1.2.1 [INFO] [stderr] Compiling memchr v2.1.3 [INFO] [stderr] Compiling siphasher v0.2.3 [INFO] [stderr] Checking futures v0.1.25 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling ucd-trie v0.1.1 [INFO] [stderr] Compiling build_const v0.2.1 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Compiling serde v1.0.85 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Checking unic-common v0.7.0 [INFO] [stderr] Checking unic-char-range v0.7.0 [INFO] [stderr] Compiling regex v1.1.0 [INFO] [stderr] Compiling maplit v1.0.1 [INFO] [stderr] Checking ucd-util v0.1.3 [INFO] [stderr] Compiling ryu v0.2.7 [INFO] [stderr] Checking adler32 v1.0.3 [INFO] [stderr] Checking utf8-ranges v1.0.2 [INFO] [stderr] Checking rustc-demangle v0.1.13 [INFO] [stderr] Compiling crc32fast v1.1.2 [INFO] [stderr] Compiling httparse v1.3.3 [INFO] [stderr] Checking safemem v0.3.0 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Checking deunicode v0.4.3 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking same-file v1.0.4 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Checking scoped-tls v0.1.2 [INFO] [stderr] Checking itoa v0.4.3 [INFO] [stderr] Checking alloc-no-stdlib v1.2.0 [INFO] [stderr] Checking try-lock v0.1.0 [INFO] [stderr] Checking glob v0.2.11 [INFO] [stderr] Checking language-tags v0.2.2 [INFO] [stderr] Checking remove_dir_all v0.5.1 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking bitflags v1.0.4 [INFO] [stderr] Checking humansize v1.1.0 [INFO] [stderr] Checking strsim v0.7.0 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking rand_jitter v0.1.0 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling backtrace v0.3.13 [INFO] [stderr] Checking crossbeam-utils v0.6.5 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Compiling unicase v1.4.2 [INFO] [stderr] Compiling unicase v2.2.0 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking owning_ref v0.4.0 [INFO] [stderr] Compiling pest v2.1.0 [INFO] [stderr] Checking unic-ucd-version v0.7.0 [INFO] [stderr] Compiling crc v1.8.1 [INFO] [stderr] Checking unicode-bidi v0.3.4 [INFO] [stderr] Checking unic-char-property v0.7.0 [INFO] [stderr] Checking regex-syntax v0.6.5 [INFO] [stderr] Checking miniz_oxide v0.2.1 [INFO] [stderr] Compiling backtrace-sys v0.1.28 [INFO] [stderr] Compiling miniz_oxide_c_api v0.2.1 [INFO] [stderr] Checking slug v0.1.4 [INFO] [stderr] Checking textwrap v0.10.0 [INFO] [stderr] Checking tokio-sync v0.1.0 [INFO] [stderr] Checking tokio-service v0.1.0 [INFO] [stderr] Checking relay v0.1.1 [INFO] [stderr] Checking walkdir v2.2.7 [INFO] [stderr] Checking brotli-decompressor v1.2.1 [INFO] [stderr] Checking smallvec v0.6.8 [INFO] [stderr] Checking want v0.0.4 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking lock_api v0.1.5 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking unic-ucd-segment v0.7.0 [INFO] [stderr] Checking tokio-executor v0.1.6 [INFO] [stderr] Compiling pest_meta v2.1.0 [INFO] [stderr] Checking crossbeam-channel v0.3.7 [INFO] [stderr] Checking unicode-normalization v0.1.8 [INFO] [stderr] Checking rand_os v0.1.1 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking num_cpus v1.9.0 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking crossbeam-epoch v0.7.1 [INFO] [stderr] Checking base64 v0.9.3 [INFO] [stderr] Checking brotli v1.2.0 [INFO] [stderr] Compiling quote v0.6.11 [INFO] [stderr] Compiling rand_pcg v0.1.1 [INFO] [stderr] Compiling parking_lot_core v0.4.0 [INFO] [stderr] Checking unic-segment v0.7.0 [INFO] [stderr] Checking tokio-current-thread v0.1.4 [INFO] [stderr] Checking tokio-timer v0.2.9 [INFO] [stderr] Checking bytes v0.4.11 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking aho-corasick v0.6.9 [INFO] [stderr] Compiling phf_shared v0.7.24 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking crossbeam-deque v0.6.3 [INFO] [stderr] Checking mime v0.3.13 [INFO] [stderr] Compiling syn v0.15.26 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking tokio-io v0.1.11 [INFO] [stderr] Checking phf v0.7.24 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking flate2 v1.0.6 [INFO] [stderr] Checking error-chain v0.12.0 [INFO] [stderr] Checking serde_json v1.0.37 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking globset v0.4.2 [INFO] [stderr] Compiling pest_generator v2.1.0 [INFO] [stderr] Compiling serde_derive v1.0.85 [INFO] [stderr] Checking ignore v0.4.6 [INFO] [stderr] Compiling phf_generator v0.7.24 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Compiling phf_codegen v0.7.24 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking crossbeam v0.6.0 [INFO] [stderr] Checking tokio-reactor v0.1.8 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking tokio-threadpool v0.1.11 [INFO] [stderr] Checking tokio-uds v0.2.5 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking tera v0.11.20 [INFO] [stderr] Checking tokio-fs v0.1.5 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking sfz v0.0.3 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/extensions.rs:80:20 [INFO] [stderr] | [INFO] [stderr] 80 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 81 | | if self.is_dir() { [INFO] [stderr] 82 | | PathType::Dir [INFO] [stderr] 83 | | } else { [INFO] [stderr] 84 | | PathType::File [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 80 | } else if self.is_dir() { [INFO] [stderr] 81 | PathType::Dir [INFO] [stderr] 82 | } else { [INFO] [stderr] 83 | PathType::File [INFO] [stderr] 84 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tera::Context::add': Use `insert` instead to keep consistency with std collections [INFO] [stderr] --> src/server/send.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | ctx.add("files", &files); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tera::Context::add': Use `insert` instead to keep consistency with std collections [INFO] [stderr] --> src/server/send.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | ctx.add("dir_name", &dir_name); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tera::Context::add': Use `insert` instead to keep consistency with std collections [INFO] [stderr] --> src/server/send.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | ctx.add("paths", &paths); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tera::Context::add': Use `insert` instead to keep consistency with std collections [INFO] [stderr] --> src/server/send.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | ctx.add("style", include_str!("style.css")); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/extensions.rs:80:20 [INFO] [stderr] | [INFO] [stderr] 80 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 81 | | if self.is_dir() { [INFO] [stderr] 82 | | PathType::Dir [INFO] [stderr] 83 | | } else { [INFO] [stderr] 84 | | PathType::File [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 80 | } else if self.is_dir() { [INFO] [stderr] 81 | PathType::Dir [INFO] [stderr] 82 | } else { [INFO] [stderr] 83 | PathType::File [INFO] [stderr] 84 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/server/mod.rs:238:9 [INFO] [stderr] | [INFO] [stderr] 238 | / let mut body: io::Result> = Ok(Vec::new()); [INFO] [stderr] 239 | | [INFO] [stderr] 240 | | // Extra process for serving files. [INFO] [stderr] 241 | | if path.is_dir() { [INFO] [stderr] ... | [INFO] [stderr] 298 | | res.headers_mut().set(etag); [INFO] [stderr] 299 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 238 | let body = if path.is_dir() { send_dir( [INFO] [stderr] 239 | path, [INFO] [stderr] 240 | &self.args.path, [INFO] [stderr] 241 | self.args.all, [INFO] [stderr] 242 | self.args.ignore, [INFO] [stderr] 243 | ) } else { ..; Ok(Vec::new()) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server/mod.rs:276:17 [INFO] [stderr] | [INFO] [stderr] 276 | / match ( [INFO] [stderr] 277 | | is_range_fresh(&req, &etag, &last_modified), [INFO] [stderr] 278 | | is_satisfiable_range(range, size as u64) [INFO] [stderr] 279 | | ) { [INFO] [stderr] ... | [INFO] [stderr] 290 | | _ => (), [INFO] [stderr] 291 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 276 | if let (true, Some(content_range)) = ( [INFO] [stderr] 277 | is_range_fresh(&req, &etag, &last_modified), [INFO] [stderr] 278 | is_satisfiable_range(range, size as u64) [INFO] [stderr] 279 | ) { [INFO] [stderr] 280 | // 206 Partial Content. [INFO] [stderr] 281 | if let Some(range) = extract_range(&content_range) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/http/conditional_requests.rs:101:20 [INFO] [stderr] | [INFO] [stderr] 101 | if let Some(_) = req.headers().get::() { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 102 | | if !is_method_get_head(req.method()) { [INFO] [stderr] 103 | | return true [INFO] [stderr] 104 | | } [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____________- help: try this: `if req.headers().get::().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/http/conditional_requests.rs:116:20 [INFO] [stderr] | [INFO] [stderr] 116 | if let Some(_) = req.headers().get::() { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 117 | | if !is_method_get_head(req.method()) { [INFO] [stderr] 118 | | return true [INFO] [stderr] 119 | | } [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____________- help: try this: `if req.headers().get::().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/http/conditional_requests.rs:127:12 [INFO] [stderr] | [INFO] [stderr] 127 | if let Some(_) = req.headers().get::() { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 128 | | if !is_method_get_head(req.method()) { [INFO] [stderr] 129 | | return true [INFO] [stderr] 130 | | } [INFO] [stderr] 131 | | } [INFO] [stderr] | |_____- help: try this: `if req.headers().get::().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/http/content_encoding.rs:27:8 [INFO] [stderr] | [INFO] [stderr] 27 | a: &&QualityItem, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `&QualityItem` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/http/content_encoding.rs:28:8 [INFO] [stderr] | [INFO] [stderr] 28 | b: &&QualityItem, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `&QualityItem` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/extensions.rs:46:36 [INFO] [stderr] | [INFO] [stderr] 46 | .map(|s| s.starts_with(".")) [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/server/mod.rs:436:52 [INFO] [stderr] | [INFO] [stderr] 436 | let mime_type = MyService::guess_path_mime(env::home_dir().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tera::Context::add': Use `insert` instead to keep consistency with std collections [INFO] [stderr] --> src/server/send.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | ctx.add("files", &files); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tera::Context::add': Use `insert` instead to keep consistency with std collections [INFO] [stderr] --> src/server/send.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | ctx.add("dir_name", &dir_name); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tera::Context::add': Use `insert` instead to keep consistency with std collections [INFO] [stderr] --> src/server/send.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | ctx.add("paths", &paths); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tera::Context::add': Use `insert` instead to keep consistency with std collections [INFO] [stderr] --> src/server/send.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | ctx.add("style", include_str!("style.css")); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/server/mod.rs:238:9 [INFO] [stderr] | [INFO] [stderr] 238 | / let mut body: io::Result> = Ok(Vec::new()); [INFO] [stderr] 239 | | [INFO] [stderr] 240 | | // Extra process for serving files. [INFO] [stderr] 241 | | if path.is_dir() { [INFO] [stderr] ... | [INFO] [stderr] 298 | | res.headers_mut().set(etag); [INFO] [stderr] 299 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 238 | let body = if path.is_dir() { send_dir( [INFO] [stderr] 239 | path, [INFO] [stderr] 240 | &self.args.path, [INFO] [stderr] 241 | self.args.all, [INFO] [stderr] 242 | self.args.ignore, [INFO] [stderr] 243 | ) } else { ..; Ok(Vec::new()) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server/mod.rs:276:17 [INFO] [stderr] | [INFO] [stderr] 276 | / match ( [INFO] [stderr] 277 | | is_range_fresh(&req, &etag, &last_modified), [INFO] [stderr] 278 | | is_satisfiable_range(range, size as u64) [INFO] [stderr] 279 | | ) { [INFO] [stderr] ... | [INFO] [stderr] 290 | | _ => (), [INFO] [stderr] 291 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 276 | if let (true, Some(content_range)) = ( [INFO] [stderr] 277 | is_range_fresh(&req, &etag, &last_modified), [INFO] [stderr] 278 | is_satisfiable_range(range, size as u64) [INFO] [stderr] 279 | ) { [INFO] [stderr] 280 | // 206 Partial Content. [INFO] [stderr] 281 | if let Some(range) = extract_range(&content_range) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/http/conditional_requests.rs:101:20 [INFO] [stderr] | [INFO] [stderr] 101 | if let Some(_) = req.headers().get::() { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 102 | | if !is_method_get_head(req.method()) { [INFO] [stderr] 103 | | return true [INFO] [stderr] 104 | | } [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____________- help: try this: `if req.headers().get::().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/http/conditional_requests.rs:116:20 [INFO] [stderr] | [INFO] [stderr] 116 | if let Some(_) = req.headers().get::() { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 117 | | if !is_method_get_head(req.method()) { [INFO] [stderr] 118 | | return true [INFO] [stderr] 119 | | } [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____________- help: try this: `if req.headers().get::().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/http/conditional_requests.rs:127:12 [INFO] [stderr] | [INFO] [stderr] 127 | if let Some(_) = req.headers().get::() { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 128 | | if !is_method_get_head(req.method()) { [INFO] [stderr] 129 | | return true [INFO] [stderr] 130 | | } [INFO] [stderr] 131 | | } [INFO] [stderr] | |_____- help: try this: `if req.headers().get::().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/http/content_encoding.rs:27:8 [INFO] [stderr] | [INFO] [stderr] 27 | a: &&QualityItem, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `&QualityItem` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/http/content_encoding.rs:28:8 [INFO] [stderr] | [INFO] [stderr] 28 | b: &&QualityItem, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `&QualityItem` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/extensions.rs:46:36 [INFO] [stderr] | [INFO] [stderr] 46 | .map(|s| s.starts_with(".")) [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 16s [INFO] running `"docker" "inspect" "26ab07f83208affb860b9ae795cc217936f979ec0696f4893d0b61c01163998a"` [INFO] running `"docker" "rm" "-f" "26ab07f83208affb860b9ae795cc217936f979ec0696f4893d0b61c01163998a"` [INFO] [stdout] 26ab07f83208affb860b9ae795cc217936f979ec0696f4893d0b61c01163998a