[INFO] crate sflow 0.0.1 is already in cache [INFO] extracting crate sflow 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/sflow/0.0.1 [INFO] extracting crate sflow 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sflow/0.0.1 [INFO] validating manifest of sflow-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sflow-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sflow-0.0.1 [INFO] finished frobbing sflow-0.0.1 [INFO] frobbed toml for sflow-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/sflow/0.0.1/Cargo.toml [INFO] started frobbing sflow-0.0.1 [INFO] finished frobbing sflow-0.0.1 [INFO] frobbed toml for sflow-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sflow/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sflow-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sflow/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8eee62fc34267b78a3ccc59fce2bc6bb1cc201f0024b0ad575bcc465a8f6f482 [INFO] running `"docker" "start" "-a" "8eee62fc34267b78a3ccc59fce2bc6bb1cc201f0024b0ad575bcc465a8f6f482"` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] Checking sflow v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | return self.read_u32::(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.read_u32::()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | return self.read_u16::(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.read_u16::()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return self.read_i32::(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.read_i32::()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | return self.read_i16::(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.read_i16::()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flow_records.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | return Ok(FlowRecord::SampledHeader(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(FlowRecord::SampledHeader(e))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flow_records.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | return Ok(FlowRecord::SampledIpv4(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(FlowRecord::SampledIpv4(e))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flow_records.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | return Ok(FlowRecord::ExtendedSwitch(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(FlowRecord::ExtendedSwitch(e))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flow_records.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | return Ok(FlowRecord::ExtendedRouter(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(FlowRecord::ExtendedRouter(e))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flow_records.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | return Ok(FlowRecord::ExtendedGateway(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(FlowRecord::ExtendedGateway(e))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flow_records.rs:52:17 [INFO] [stderr] | [INFO] [stderr] 52 | return Ok(FlowRecord::ExtendedUrl(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(FlowRecord::ExtendedUrl(e))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flow_records.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | return Ok(FlowRecord::ExtendedMpls(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(FlowRecord::ExtendedMpls(e))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flow_records.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | return Ok(FlowRecord::ExtendedMplsTunnel(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(FlowRecord::ExtendedMplsTunnel(e))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flow_records.rs:67:17 [INFO] [stderr] | [INFO] [stderr] 67 | / return Err(error::Error::UnknownType(format!("Unknown FlowRecord type {0} \ [INFO] [stderr] 68 | | skipping {1} bytes.", [INFO] [stderr] 69 | | format, [INFO] [stderr] 70 | | length))); [INFO] [stderr] | |_______________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 67 | Err(error::Error::UnknownType(format!("Unknown FlowRecord type {0} \ [INFO] [stderr] 68 | skipping {1} bytes.", [INFO] [stderr] 69 | format, [INFO] [stderr] 70 | length))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | return self.read_u32::(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.read_u32::()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | return self.read_u16::(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.read_u16::()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return self.read_i32::(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.read_i32::()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | return self.read_i16::(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.read_i16::()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flow_records.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | return Ok(FlowRecord::SampledHeader(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(FlowRecord::SampledHeader(e))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flow_records.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | return Ok(FlowRecord::SampledIpv4(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(FlowRecord::SampledIpv4(e))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flow_records.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | return Ok(FlowRecord::ExtendedSwitch(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(FlowRecord::ExtendedSwitch(e))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flow_records.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | return Ok(FlowRecord::ExtendedRouter(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(FlowRecord::ExtendedRouter(e))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flow_records.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | return Ok(FlowRecord::ExtendedGateway(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(FlowRecord::ExtendedGateway(e))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flow_records.rs:52:17 [INFO] [stderr] | [INFO] [stderr] 52 | return Ok(FlowRecord::ExtendedUrl(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(FlowRecord::ExtendedUrl(e))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flow_records.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | return Ok(FlowRecord::ExtendedMpls(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(FlowRecord::ExtendedMpls(e))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flow_records.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | return Ok(FlowRecord::ExtendedMplsTunnel(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(FlowRecord::ExtendedMplsTunnel(e))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flow_records.rs:67:17 [INFO] [stderr] | [INFO] [stderr] 67 | / return Err(error::Error::UnknownType(format!("Unknown FlowRecord type {0} \ [INFO] [stderr] 68 | | skipping {1} bytes.", [INFO] [stderr] 69 | | format, [INFO] [stderr] 70 | | length))); [INFO] [stderr] | |_______________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 67 | Err(error::Error::UnknownType(format!("Unknown FlowRecord type {0} \ [INFO] [stderr] 68 | skipping {1} bytes.", [INFO] [stderr] 69 | format, [INFO] [stderr] 70 | length))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `datagram::Datagram` [INFO] [stderr] --> src/test.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use datagram::Datagram; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `ByteOrder` [INFO] [stderr] --> src/utils.rs:1:23 [INFO] [stderr] | [INFO] [stderr] 1 | use byteorder::{self, ByteOrder, BigEndian, ReadBytesExt}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Read` [INFO] [stderr] --> src/utils.rs:5:31 [INFO] [stderr] | [INFO] [stderr] 5 | use std::io::{self, SeekFrom, Read}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `ByteOrder` [INFO] [stderr] --> src/utils.rs:1:23 [INFO] [stderr] | [INFO] [stderr] 1 | use byteorder::{self, ByteOrder, BigEndian, ReadBytesExt}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Read` [INFO] [stderr] --> src/utils.rs:5:31 [INFO] [stderr] | [INFO] [stderr] 5 | use std::io::{self, SeekFrom, Read}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:69:56 [INFO] [stderr] | [INFO] [stderr] 69 | try!(stream.seek(SeekFrom::Current(length as i64))); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(length)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/flow_records.rs:66:52 [INFO] [stderr] | [INFO] [stderr] 66 | try!(stream.seek(SeekFrom::Current(length as i64))); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `b`. [INFO] [stderr] --> src/ipaddress.rs:46:14 [INFO] [stderr] | [INFO] [stderr] 46 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 46 | for in &mut b { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `b`. [INFO] [stderr] --> src/ipaddress.rs:55:14 [INFO] [stderr] | [INFO] [stderr] 55 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 55 | for in &mut b { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/community.rs:28:18 [INFO] [stderr] | [INFO] [stderr] 28 | asn: try!(stream.be_read_u16()) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 28 | asn: u32::from(match $ expr { [INFO] [stderr] 29 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 30 | :: Err ( err ) => { [INFO] [stderr] 31 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 32 | $ crate :: convert :: From :: from ( err ) ) } }), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/sample.rs:69:56 [INFO] [stderr] | [INFO] [stderr] 69 | try!(stream.seek(SeekFrom::Current(length as i64))); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(length)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/flow_records.rs:66:52 [INFO] [stderr] | [INFO] [stderr] 66 | try!(stream.seek(SeekFrom::Current(length as i64))); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `b`. [INFO] [stderr] --> src/ipaddress.rs:46:14 [INFO] [stderr] | [INFO] [stderr] 46 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 46 | for in &mut b { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `b`. [INFO] [stderr] --> src/ipaddress.rs:55:14 [INFO] [stderr] | [INFO] [stderr] 55 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 55 | for in &mut b { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/community.rs:28:18 [INFO] [stderr] | [INFO] [stderr] 28 | asn: try!(stream.be_read_u16()) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 28 | asn: u32::from(match $ expr { [INFO] [stderr] 29 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 30 | :: Err ( err ) => { [INFO] [stderr] 31 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 32 | $ crate :: convert :: From :: from ( err ) ) } }), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/test.rs:36:36 [INFO] [stderr] | [INFO] [stderr] 36 | let mut data = Cursor::new(case.raw_test_data.clone().from_hex().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 36 | let mut data = Cursor::new(&(*case.raw_test_data).clone().from_hex().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 36 | let mut data = Cursor::new(&str::clone(case.raw_test_data).from_hex().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `sflow`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "8eee62fc34267b78a3ccc59fce2bc6bb1cc201f0024b0ad575bcc465a8f6f482"` [INFO] running `"docker" "rm" "-f" "8eee62fc34267b78a3ccc59fce2bc6bb1cc201f0024b0ad575bcc465a8f6f482"` [INFO] [stdout] 8eee62fc34267b78a3ccc59fce2bc6bb1cc201f0024b0ad575bcc465a8f6f482