[INFO] crate setenv 0.1.2 is already in cache [INFO] extracting crate setenv 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/setenv/0.1.2 [INFO] extracting crate setenv 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/setenv/0.1.2 [INFO] validating manifest of setenv-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of setenv-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing setenv-0.1.2 [INFO] finished frobbing setenv-0.1.2 [INFO] frobbed toml for setenv-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/setenv/0.1.2/Cargo.toml [INFO] started frobbing setenv-0.1.2 [INFO] finished frobbing setenv-0.1.2 [INFO] frobbed toml for setenv-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/setenv/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting setenv-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/setenv/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 98449573c4cc1647bdd14472beddac15c2375a8859c9265d33eb1bbbbcdef1ee [INFO] running `"docker" "start" "-a" "98449573c4cc1647bdd14472beddac15c2375a8859c9265d33eb1bbbbcdef1ee"` [INFO] [stderr] Checking setenv v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | / return match var_os("SHELL") { [INFO] [stderr] 117 | | None => Shell::Bash, [INFO] [stderr] 118 | | Some(oss) => { [INFO] [stderr] 119 | | if oss.to_string_lossy().ends_with("/bash") { [INFO] [stderr] ... | [INFO] [stderr] 130 | | } [INFO] [stderr] 131 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 116 | match var_os("SHELL") { [INFO] [stderr] 117 | None => Shell::Bash, [INFO] [stderr] 118 | Some(oss) => { [INFO] [stderr] 119 | if oss.to_string_lossy().ends_with("/bash") { [INFO] [stderr] 120 | Shell::Bash [INFO] [stderr] 121 | } else if oss.to_string_lossy().ends_with("/ksh") { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | / return match var_os("SHELL") { [INFO] [stderr] 117 | | None => Shell::Bash, [INFO] [stderr] 118 | | Some(oss) => { [INFO] [stderr] 119 | | if oss.to_string_lossy().ends_with("/bash") { [INFO] [stderr] ... | [INFO] [stderr] 130 | | } [INFO] [stderr] 131 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 116 | match var_os("SHELL") { [INFO] [stderr] 117 | None => Shell::Bash, [INFO] [stderr] 118 | Some(oss) => { [INFO] [stderr] 119 | if oss.to_string_lossy().ends_with("/bash") { [INFO] [stderr] 120 | Shell::Bash [INFO] [stderr] 121 | } else if oss.to_string_lossy().ends_with("/ksh") { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused import: `Write` [INFO] [stderr] --> examples/test_cd.rs:9:15 [INFO] [stderr] | [INFO] [stderr] 9 | use std::io::{Write}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.03s [INFO] running `"docker" "inspect" "98449573c4cc1647bdd14472beddac15c2375a8859c9265d33eb1bbbbcdef1ee"` [INFO] running `"docker" "rm" "-f" "98449573c4cc1647bdd14472beddac15c2375a8859c9265d33eb1bbbbcdef1ee"` [INFO] [stdout] 98449573c4cc1647bdd14472beddac15c2375a8859c9265d33eb1bbbbcdef1ee