[INFO] crate sesame_rs 0.1.3 is already in cache [INFO] extracting crate sesame_rs 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/sesame_rs/0.1.3 [INFO] extracting crate sesame_rs 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sesame_rs/0.1.3 [INFO] validating manifest of sesame_rs-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sesame_rs-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sesame_rs-0.1.3 [INFO] finished frobbing sesame_rs-0.1.3 [INFO] frobbed toml for sesame_rs-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/sesame_rs/0.1.3/Cargo.toml [INFO] started frobbing sesame_rs-0.1.3 [INFO] finished frobbing sesame_rs-0.1.3 [INFO] frobbed toml for sesame_rs-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sesame_rs/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sesame_rs-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sesame_rs/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7684fb3783e994752ef93450d85568cf34cdef6f8a54ca3bb0eb63f8b6f74c35 [INFO] running `"docker" "start" "-a" "7684fb3783e994752ef93450d85568cf34cdef6f8a54ca3bb0eb63f8b6f74c35"` [INFO] [stderr] Checking sesame_rs v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:42:21 [INFO] [stderr] | [INFO] [stderr] 42 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:43:21 [INFO] [stderr] | [INFO] [stderr] 43 | core: core, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `core` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sesame.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sesame.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | device_id: device_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `device_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sesame.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | nickname: nickname, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `nickname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sesame.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | is_unlocked: is_unlocked, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_unlocked` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sesame.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | api_enabled: api_enabled, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `api_enabled` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sesame.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | battery: battery, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `battery` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:42:21 [INFO] [stderr] | [INFO] [stderr] 42 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:43:21 [INFO] [stderr] | [INFO] [stderr] 43 | core: core, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `core` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sesame.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sesame.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | device_id: device_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `device_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sesame.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | nickname: nickname, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `nickname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sesame.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | is_unlocked: is_unlocked, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_unlocked` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sesame.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | api_enabled: api_enabled, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `api_enabled` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sesame.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | battery: battery, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `battery` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/utility.rs:1:20 [INFO] [stderr] | [INFO] [stderr] 1 | pub const PREFIX: &'static str = "https://api.candyhouse.co/v1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/utility.rs:2:28 [INFO] [stderr] | [INFO] [stderr] 2 | pub const LOGIN_ENDPOINT: &'static str = "/accounts/login"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/utility.rs:3:29 [INFO] [stderr] | [INFO] [stderr] 3 | pub const SESAME_ENDPOINT: &'static str = "/sesames"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/utility.rs:4:30 [INFO] [stderr] | [INFO] [stderr] 4 | pub const CONTROL_ENDPOINT: &'static str = "/control"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/utility.rs:1:20 [INFO] [stderr] | [INFO] [stderr] 1 | pub const PREFIX: &'static str = "https://api.candyhouse.co/v1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/utility.rs:2:28 [INFO] [stderr] | [INFO] [stderr] 2 | pub const LOGIN_ENDPOINT: &'static str = "/accounts/login"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/utility.rs:3:29 [INFO] [stderr] | [INFO] [stderr] 3 | pub const SESAME_ENDPOINT: &'static str = "/sesames"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/utility.rs:4:30 [INFO] [stderr] | [INFO] [stderr] 4 | pub const CONTROL_ENDPOINT: &'static str = "/control"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `client::SesameClient` [INFO] [stderr] --> src/client.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / pub fn new() -> Self { [INFO] [stderr] 31 | | let core = Core::new().unwrap(); [INFO] [stderr] 32 | | let handle = core.handle(); [INFO] [stderr] 33 | | [INFO] [stderr] ... | [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 29 | impl Default for client::SesameClient { [INFO] [stderr] 30 | fn default() -> Self { [INFO] [stderr] 31 | Self::new() [INFO] [stderr] 32 | } [INFO] [stderr] 33 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `client::SesameClient` [INFO] [stderr] --> src/client.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / pub fn new() -> Self { [INFO] [stderr] 31 | | let core = Core::new().unwrap(); [INFO] [stderr] 32 | | let handle = core.handle(); [INFO] [stderr] 33 | | [INFO] [stderr] ... | [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 29 | impl Default for client::SesameClient { [INFO] [stderr] 30 | fn default() -> Self { [INFO] [stderr] 31 | Self::new() [INFO] [stderr] 32 | } [INFO] [stderr] 33 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/sesame.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | / match self { [INFO] [stderr] 33 | | &ControlType::Lock => write!(f, "lock"), [INFO] [stderr] 34 | | &ControlType::Unlock => write!(f, "unlock") [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | match *self { [INFO] [stderr] 33 | ControlType::Lock => write!(f, "lock"), [INFO] [stderr] 34 | ControlType::Unlock => write!(f, "unlock") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/sesame.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | / match self { [INFO] [stderr] 33 | | &ControlType::Lock => write!(f, "lock"), [INFO] [stderr] 34 | | &ControlType::Unlock => write!(f, "unlock") [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | match *self { [INFO] [stderr] 33 | ControlType::Lock => write!(f, "lock"), [INFO] [stderr] 34 | ControlType::Unlock => write!(f, "unlock") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.67s [INFO] running `"docker" "inspect" "7684fb3783e994752ef93450d85568cf34cdef6f8a54ca3bb0eb63f8b6f74c35"` [INFO] running `"docker" "rm" "-f" "7684fb3783e994752ef93450d85568cf34cdef6f8a54ca3bb0eb63f8b6f74c35"` [INFO] [stdout] 7684fb3783e994752ef93450d85568cf34cdef6f8a54ca3bb0eb63f8b6f74c35