[INFO] crate series 0.2.0 is already in cache [INFO] extracting crate series 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/series/0.2.0 [INFO] extracting crate series 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/series/0.2.0 [INFO] validating manifest of series-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of series-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing series-0.2.0 [INFO] finished frobbing series-0.2.0 [INFO] frobbed toml for series-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/series/0.2.0/Cargo.toml [INFO] started frobbing series-0.2.0 [INFO] finished frobbing series-0.2.0 [INFO] frobbed toml for series-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/series/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting series-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/series/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f9d7b8b5612de5c90ad0eb6b22482051494ad5f479cc0376510bb770bed4caa8 [INFO] running `"docker" "start" "-a" "f9d7b8b5612de5c90ad0eb6b22482051494ad5f479cc0376510bb770bed4caa8"` [INFO] [stderr] Checking series v0.2.0 (/opt/crater/workdir) [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:809:46 [INFO] [stderr] | [INFO] [stderr] 809 | let product_min_pow = self.min_pow() + other.min_pow(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:1002:22 [INFO] [stderr] | [INFO] [stderr] 1002 | for i in 1..n+1 { [INFO] [stderr] | ^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `series`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:809:46 [INFO] [stderr] | [INFO] [stderr] 809 | let product_min_pow = self.min_pow() + other.min_pow(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:1002:22 [INFO] [stderr] | [INFO] [stderr] 1002 | for i in 1..n+1 { [INFO] [stderr] | ^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/lib.rs:1292:5 [INFO] [stderr] | [INFO] [stderr] 1292 | / fn tst_add() { [INFO] [stderr] 1293 | | let s = Series::new("x", -3, vec!(1.,0.,-3.)); [INFO] [stderr] 1294 | | let res = Series::new("x", -3, vec!(2.,0.,-6.)); [INFO] [stderr] 1295 | | assert_eq!(res, &s + &s); [INFO] [stderr] ... | [INFO] [stderr] 1333 | | assert_eq!(res, t.clone() + s.clone()); [INFO] [stderr] 1334 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `-` [INFO] [stderr] --> src/lib.rs:1379:25 [INFO] [stderr] | [INFO] [stderr] 1379 | assert_eq!(res, &s - &s); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `/` [INFO] [stderr] --> src/lib.rs:1490:25 [INFO] [stderr] | [INFO] [stderr] 1490 | assert_eq!(res, &s / &s); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:1618:13 [INFO] [stderr] | [INFO] [stderr] 1618 | / assert_eq!( [INFO] [stderr] 1619 | | res.coeff(i).unwrap().round(), [INFO] [stderr] 1620 | | test.coeff(i).unwrap().round() [INFO] [stderr] 1621 | | ); [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:1618:13 [INFO] [stderr] | [INFO] [stderr] 1618 | / assert_eq!( [INFO] [stderr] 1619 | | res.coeff(i).unwrap().round(), [INFO] [stderr] 1620 | | test.coeff(i).unwrap().round() [INFO] [stderr] 1621 | | ); [INFO] [stderr] | |______________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `series`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "f9d7b8b5612de5c90ad0eb6b22482051494ad5f479cc0376510bb770bed4caa8"` [INFO] running `"docker" "rm" "-f" "f9d7b8b5612de5c90ad0eb6b22482051494ad5f479cc0376510bb770bed4caa8"` [INFO] [stdout] f9d7b8b5612de5c90ad0eb6b22482051494ad5f479cc0376510bb770bed4caa8