[INFO] crate serialport 3.1.0 is already in cache [INFO] extracting crate serialport 3.1.0 into work/ex/clippy-test-run/sources/stable/reg/serialport/3.1.0 [INFO] extracting crate serialport 3.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serialport/3.1.0 [INFO] validating manifest of serialport-3.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of serialport-3.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing serialport-3.1.0 [INFO] finished frobbing serialport-3.1.0 [INFO] frobbed toml for serialport-3.1.0 written to work/ex/clippy-test-run/sources/stable/reg/serialport/3.1.0/Cargo.toml [INFO] started frobbing serialport-3.1.0 [INFO] finished frobbing serialport-3.1.0 [INFO] frobbed toml for serialport-3.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serialport/3.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting serialport-3.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/serialport/3.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ac501604486993575ead264d3eba782eb45e03a549f99f2f93797dea54515ce7 [INFO] running `"docker" "start" "-a" "ac501604486993575ead264d3eba782eb45e03a549f99f2f93797dea54515ce7"` [INFO] [stderr] Checking serialport v3.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/posix/tty.rs:368:25 [INFO] [stderr] | [INFO] [stderr] 368 | let exclusive = match ioctl::tiocexcl(fd) { [INFO] [stderr] | _________________________^ [INFO] [stderr] 369 | | Ok(_) => true, [INFO] [stderr] 370 | | Err(_) => false, [INFO] [stderr] 371 | | }; [INFO] [stderr] | |_________^ help: try this: `ioctl::tiocexcl(fd).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/posix/tty.rs:368:25 [INFO] [stderr] | [INFO] [stderr] 368 | let exclusive = match ioctl::tiocexcl(fd) { [INFO] [stderr] | _________________________^ [INFO] [stderr] 369 | | Ok(_) => true, [INFO] [stderr] 370 | | Err(_) => false, [INFO] [stderr] 371 | | }; [INFO] [stderr] | |_________^ help: try this: `ioctl::tiocexcl(fd).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> examples/receive_data.rs:28:30 [INFO] [stderr] | [INFO] [stderr] 28 | settings.baud_rate = rate.into(); [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `rate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 45 [INFO] [stderr] --> examples/hardware_check.rs:194:1 [INFO] [stderr] | [INFO] [stderr] 194 | / fn test_single_port(port: &mut serialport::SerialPort, loopback: bool) { [INFO] [stderr] 195 | | println!("Testing '{}':", port.name().unwrap()); [INFO] [stderr] 196 | | [INFO] [stderr] 197 | | // Test setting standard baud rates [INFO] [stderr] ... | [INFO] [stderr] 269 | | } [INFO] [stderr] 270 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> examples/duplex.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | / clone [INFO] [stderr] 33 | | .write(&[5, 6, 7, 8]) [INFO] [stderr] 34 | | .expect("Failed to write to serial port"); [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> examples/heartbeat.rs:28:30 [INFO] [stderr] | [INFO] [stderr] 28 | settings.baud_rate = rate.into(); [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `rate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> examples/heartbeat.rs:38:34 [INFO] [stderr] | [INFO] [stderr] 38 | match port.write(".".as_bytes()) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"."` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `serialport`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> tests/test_try_clone.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | clone.write(&bytes).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> tests/test_try_clone.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | clone.write(&bytes).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> tests/test_try_clone.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | clone.write(&bytes).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `serialport`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> examples/clear_input_buffer.rs:84:26 [INFO] [stderr] | [INFO] [stderr] 84 | settings.baud_rate = rate.into(); [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `rate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> examples/clear_output_buffer.rs:74:26 [INFO] [stderr] | [INFO] [stderr] 74 | settings.baud_rate = rate.into(); [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `rate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test_tty.rs:107:25 [INFO] [stderr] | [INFO] [stderr] 107 | slave.set_baud_rate(115200).unwrap(); [INFO] [stderr] | ^^^^^^ help: consider: `115_200` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test_tty.rs:108:44 [INFO] [stderr] | [INFO] [stderr] 108 | assert_eq!(slave.baud_rate().unwrap(), 115200); [INFO] [stderr] | ^^^^^^ help: consider: `115_200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test_tty.rs:126:25 [INFO] [stderr] | [INFO] [stderr] 126 | slave.set_baud_rate(1200000).unwrap(); [INFO] [stderr] | ^^^^^^^ help: consider: `1_200_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test_tty.rs:127:44 [INFO] [stderr] | [INFO] [stderr] 127 | assert_eq!(slave.baud_rate().unwrap(), 1200000); [INFO] [stderr] | ^^^^^^^ help: consider: `1_200_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "ac501604486993575ead264d3eba782eb45e03a549f99f2f93797dea54515ce7"` [INFO] running `"docker" "rm" "-f" "ac501604486993575ead264d3eba782eb45e03a549f99f2f93797dea54515ce7"` [INFO] [stdout] ac501604486993575ead264d3eba782eb45e03a549f99f2f93797dea54515ce7