[INFO] crate serial-key 2.0.0 is already in cache [INFO] extracting crate serial-key 2.0.0 into work/ex/clippy-test-run/sources/stable/reg/serial-key/2.0.0 [INFO] extracting crate serial-key 2.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serial-key/2.0.0 [INFO] validating manifest of serial-key-2.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of serial-key-2.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing serial-key-2.0.0 [INFO] finished frobbing serial-key-2.0.0 [INFO] frobbed toml for serial-key-2.0.0 written to work/ex/clippy-test-run/sources/stable/reg/serial-key/2.0.0/Cargo.toml [INFO] started frobbing serial-key-2.0.0 [INFO] finished frobbing serial-key-2.0.0 [INFO] frobbed toml for serial-key-2.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serial-key/2.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting serial-key-2.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/serial-key/2.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] be51d43ddc7dfdcbef921b4b8d76fc4c32263379bd4e8bb9d14d671dd84c27c4 [INFO] running `"docker" "start" "-a" "be51d43ddc7dfdcbef921b4b8d76fc4c32263379bd4e8bb9d14d671dd84c27c4"` [INFO] [stderr] Checking serial-key v2.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:22:39 [INFO] [stderr] | [INFO] [stderr] 22 | result = ((seed >> a_shift) & 0x000000FF) ^ ((seed >> b_shift) | c as i64); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:24:39 [INFO] [stderr] | [INFO] [stderr] 24 | result = ((seed >> a_shift) & 0x000000FF) ^ ((seed >> b_shift) & c as i64); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:22:39 [INFO] [stderr] | [INFO] [stderr] 22 | result = ((seed >> a_shift) & 0x000000FF) ^ ((seed >> b_shift) | c as i64); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:24:39 [INFO] [stderr] | [INFO] [stderr] 24 | result = ((seed >> a_shift) & 0x000000FF) ^ ((seed >> b_shift) & c as i64); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:208:20 [INFO] [stderr] | [INFO] [stderr] 208 | let seed = 0xA2791717; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xA279_1717` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:226:20 [INFO] [stderr] | [INFO] [stderr] 226 | let seed = 0x3abc9099; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3abc_9099` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:16:23 [INFO] [stderr] | [INFO] [stderr] 16 | fn get_key_byte(seed: &i64, a: i16, b: i16, c: i16) -> String { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / let mut result; [INFO] [stderr] 20 | | [INFO] [stderr] 21 | | if a_shift % 2 == 0 { [INFO] [stderr] 22 | | result = ((seed >> a_shift) & 0x000000FF) ^ ((seed >> b_shift) | c as i64); [INFO] [stderr] 23 | | } else { [INFO] [stderr] 24 | | result = ((seed >> a_shift) & 0x000000FF) ^ ((seed >> b_shift) & c as i64); [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let result = if a_shift % 2 == 0 { ((seed >> a_shift) & 0x000000FF) ^ ((seed >> b_shift) | c as i64) } else { ((seed >> a_shift) & 0x000000FF) ^ ((seed >> b_shift) & c as i64) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:22:74 [INFO] [stderr] | [INFO] [stderr] 22 | result = ((seed >> a_shift) & 0x000000FF) ^ ((seed >> b_shift) | c as i64); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(c)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:24:74 [INFO] [stderr] | [INFO] [stderr] 24 | result = ((seed >> a_shift) & 0x000000FF) ^ ((seed >> b_shift) & c as i64); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | result = result & 0xFF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result &= 0xFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:56:58 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn make_key(seed: &i64, num_bytes: &i8, byte_shifts: &Vec<(i16, i16, i16)>) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(i16, i16, i16)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:56:23 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn make_key(seed: &i64, num_bytes: &i8, byte_shifts: &Vec<(i16, i16, i16)>) -> String { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:56:40 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn make_key(seed: &i64, num_bytes: &i8, byte_shifts: &Vec<(i16, i16, i16)>) -> String { [INFO] [stderr] | ^^^ help: consider passing by value instead: `i8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:73:55 [INFO] [stderr] | [INFO] [stderr] 73 | let subs: Vec<&str> = result.split("").filter(|s| s.len() > 0).collect(); [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:82:49 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn check_key_checksum(key: &str, num_bytes: &i8) -> bool { [INFO] [stderr] | ^^^ help: consider passing by value instead: `i8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:97:38 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn check_key(s: &str, blacklist: &Vec, num_bytes: &i8, byte_shifts: &Vec<(i16, i16, i16)>, positions: Option>) -> Status { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:97:81 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn check_key(s: &str, blacklist: &Vec, num_bytes: &i8, byte_shifts: &Vec<(i16, i16, i16)>, positions: Option>) -> Status { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(i16, i16, i16)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:97:63 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn check_key(s: &str, blacklist: &Vec, num_bytes: &i8, byte_shifts: &Vec<(i16, i16, i16)>, positions: Option>) -> Status { [INFO] [stderr] | ^^^ help: consider passing by value instead: `i8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:137:57 [INFO] [stderr] | [INFO] [stderr] 137 | fn check_bytes(key: String, seed_num: i64, byte_shifts: &Vec<(i16, i16, i16)>, positions: Vec) -> Status { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(i16, i16, i16)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:166:80 [INFO] [stderr] | [INFO] [stderr] 166 | fn check_random_bytes(key: String, seed_num: i64, num_bytes: &i8, byte_shifts: &Vec<(i16, i16, i16)>) -> Status { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(i16, i16, i16)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:166:62 [INFO] [stderr] | [INFO] [stderr] 166 | fn check_random_bytes(key: String, seed_num: i64, num_bytes: &i8, byte_shifts: &Vec<(i16, i16, i16)>) -> Status { [INFO] [stderr] | ^^^ help: consider passing by value instead: `i8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | / let mut bytes_to_check = 3; [INFO] [stderr] 168 | | if *num_bytes > 5 { [INFO] [stderr] 169 | | bytes_to_check = num_bytes / 2; [INFO] [stderr] 170 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let bytes_to_check = if *num_bytes > 5 { num_bytes / 2 } else { 3 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:16:23 [INFO] [stderr] | [INFO] [stderr] 16 | fn get_key_byte(seed: &i64, a: i16, b: i16, c: i16) -> String { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / let mut result; [INFO] [stderr] 20 | | [INFO] [stderr] 21 | | if a_shift % 2 == 0 { [INFO] [stderr] 22 | | result = ((seed >> a_shift) & 0x000000FF) ^ ((seed >> b_shift) | c as i64); [INFO] [stderr] 23 | | } else { [INFO] [stderr] 24 | | result = ((seed >> a_shift) & 0x000000FF) ^ ((seed >> b_shift) & c as i64); [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let result = if a_shift % 2 == 0 { ((seed >> a_shift) & 0x000000FF) ^ ((seed >> b_shift) | c as i64) } else { ((seed >> a_shift) & 0x000000FF) ^ ((seed >> b_shift) & c as i64) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:22:74 [INFO] [stderr] | [INFO] [stderr] 22 | result = ((seed >> a_shift) & 0x000000FF) ^ ((seed >> b_shift) | c as i64); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(c)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:24:74 [INFO] [stderr] | [INFO] [stderr] 24 | result = ((seed >> a_shift) & 0x000000FF) ^ ((seed >> b_shift) & c as i64); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | result = result & 0xFF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result &= 0xFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:56:58 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn make_key(seed: &i64, num_bytes: &i8, byte_shifts: &Vec<(i16, i16, i16)>) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(i16, i16, i16)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:56:23 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn make_key(seed: &i64, num_bytes: &i8, byte_shifts: &Vec<(i16, i16, i16)>) -> String { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:56:40 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn make_key(seed: &i64, num_bytes: &i8, byte_shifts: &Vec<(i16, i16, i16)>) -> String { [INFO] [stderr] | ^^^ help: consider passing by value instead: `i8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:73:55 [INFO] [stderr] | [INFO] [stderr] 73 | let subs: Vec<&str> = result.split("").filter(|s| s.len() > 0).collect(); [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:82:49 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn check_key_checksum(key: &str, num_bytes: &i8) -> bool { [INFO] [stderr] | ^^^ help: consider passing by value instead: `i8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:97:38 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn check_key(s: &str, blacklist: &Vec, num_bytes: &i8, byte_shifts: &Vec<(i16, i16, i16)>, positions: Option>) -> Status { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:97:81 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn check_key(s: &str, blacklist: &Vec, num_bytes: &i8, byte_shifts: &Vec<(i16, i16, i16)>, positions: Option>) -> Status { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(i16, i16, i16)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:97:63 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn check_key(s: &str, blacklist: &Vec, num_bytes: &i8, byte_shifts: &Vec<(i16, i16, i16)>, positions: Option>) -> Status { [INFO] [stderr] | ^^^ help: consider passing by value instead: `i8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:137:57 [INFO] [stderr] | [INFO] [stderr] 137 | fn check_bytes(key: String, seed_num: i64, byte_shifts: &Vec<(i16, i16, i16)>, positions: Vec) -> Status { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(i16, i16, i16)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:166:80 [INFO] [stderr] | [INFO] [stderr] 166 | fn check_random_bytes(key: String, seed_num: i64, num_bytes: &i8, byte_shifts: &Vec<(i16, i16, i16)>) -> Status { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(i16, i16, i16)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:166:62 [INFO] [stderr] | [INFO] [stderr] 166 | fn check_random_bytes(key: String, seed_num: i64, num_bytes: &i8, byte_shifts: &Vec<(i16, i16, i16)>) -> Status { [INFO] [stderr] | ^^^ help: consider passing by value instead: `i8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | / let mut bytes_to_check = 3; [INFO] [stderr] 168 | | if *num_bytes > 5 { [INFO] [stderr] 169 | | bytes_to_check = num_bytes / 2; [INFO] [stderr] 170 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let bytes_to_check = if *num_bytes > 5 { num_bytes / 2 } else { 3 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.86s [INFO] running `"docker" "inspect" "be51d43ddc7dfdcbef921b4b8d76fc4c32263379bd4e8bb9d14d671dd84c27c4"` [INFO] running `"docker" "rm" "-f" "be51d43ddc7dfdcbef921b4b8d76fc4c32263379bd4e8bb9d14d671dd84c27c4"` [INFO] [stdout] be51d43ddc7dfdcbef921b4b8d76fc4c32263379bd4e8bb9d14d671dd84c27c4