[INFO] crate serenity 0.5.11 is already in cache [INFO] extracting crate serenity 0.5.11 into work/ex/clippy-test-run/sources/stable/reg/serenity/0.5.11 [INFO] extracting crate serenity 0.5.11 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serenity/0.5.11 [INFO] validating manifest of serenity-0.5.11 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of serenity-0.5.11 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing serenity-0.5.11 [INFO] finished frobbing serenity-0.5.11 [INFO] frobbed toml for serenity-0.5.11 written to work/ex/clippy-test-run/sources/stable/reg/serenity/0.5.11/Cargo.toml [INFO] started frobbing serenity-0.5.11 [INFO] finished frobbing serenity-0.5.11 [INFO] frobbed toml for serenity-0.5.11 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serenity/0.5.11/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting serenity-0.5.11 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/serenity/0.5.11:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9a6e546981d8ea0560334e997b869a163d8457dbabc5bef1a4780c1a900342f6 [INFO] running `"docker" "start" "-a" "9a6e546981d8ea0560334e997b869a163d8457dbabc5bef1a4780c1a900342f6"` [INFO] [stderr] Checking base64 v0.8.0 [INFO] [stderr] Checking multipart v0.13.6 [INFO] [stderr] Checking evzht9h3nznqzwl v0.0.3 [INFO] [stderr] Checking serenity v0.5.11 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:108:10 [INFO] [stderr] | [INFO] [stderr] 108 | #![allow(doc_markdown, inline_always)] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `inline_always` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:108:24 [INFO] [stderr] | [INFO] [stderr] 108 | #![allow(doc_markdown, inline_always)] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::inline_always` [INFO] [stderr] [INFO] [stderr] warning: lint name `enum_glob_use` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | #![warn(enum_glob_use, if_not_else)] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::enum_glob_use` [INFO] [stderr] [INFO] [stderr] warning: lint name `if_not_else` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:109:24 [INFO] [stderr] | [INFO] [stderr] 109 | #![warn(enum_glob_use, if_not_else)] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::if_not_else` [INFO] [stderr] [INFO] [stderr] warning: lint name `large_enum_variant` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/model/event.rs:1250:9 [INFO] [stderr] | [INFO] [stderr] 1250 | #[allow(large_enum_variant)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::large_enum_variant` [INFO] [stderr] [INFO] [stderr] warning: lint name `large_enum_variant` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/model/event.rs:1330:9 [INFO] [stderr] | [INFO] [stderr] 1330 | #[allow(large_enum_variant)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::large_enum_variant` [INFO] [stderr] [INFO] [stderr] warning: lint name `large_enum_variant` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/model/guild/mod.rs:1736:9 [INFO] [stderr] | [INFO] [stderr] 1736 | #[allow(large_enum_variant)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::large_enum_variant` [INFO] [stderr] [INFO] [stderr] warning: lint name `large_enum_variant` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/model/guild/mod.rs:1826:9 [INFO] [stderr] | [INFO] [stderr] 1826 | #[allow(large_enum_variant)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::large_enum_variant` [INFO] [stderr] [INFO] [stderr] warning: lint name `derive_hash_xor_eq` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/model/id.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | #[allow(derive_hash_xor_eq)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::derive_hash_xor_eq` [INFO] [stderr] [INFO] [stderr] warning: lint name `derive_hash_xor_eq` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/model/id.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | #[allow(derive_hash_xor_eq)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::derive_hash_xor_eq` [INFO] [stderr] [INFO] [stderr] warning: lint name `derive_hash_xor_eq` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/model/id.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | #[allow(derive_hash_xor_eq)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::derive_hash_xor_eq` [INFO] [stderr] [INFO] [stderr] warning: lint name `derive_hash_xor_eq` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/model/id.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | #[allow(derive_hash_xor_eq)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::derive_hash_xor_eq` [INFO] [stderr] [INFO] [stderr] warning: lint name `derive_hash_xor_eq` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/model/id.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | #[allow(derive_hash_xor_eq)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::derive_hash_xor_eq` [INFO] [stderr] [INFO] [stderr] warning: lint name `derive_hash_xor_eq` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/model/id.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | #[allow(derive_hash_xor_eq)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::derive_hash_xor_eq` [INFO] [stderr] [INFO] [stderr] warning: lint name `derive_hash_xor_eq` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/model/id.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | #[allow(derive_hash_xor_eq)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::derive_hash_xor_eq` [INFO] [stderr] [INFO] [stderr] warning: lint name `derive_hash_xor_eq` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/model/id.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | #[allow(derive_hash_xor_eq)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::derive_hash_xor_eq` [INFO] [stderr] [INFO] [stderr] warning: lint name `derive_hash_xor_eq` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/model/id.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | #[allow(derive_hash_xor_eq)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::derive_hash_xor_eq` [INFO] [stderr] [INFO] [stderr] warning: lint name `derive_hash_xor_eq` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/model/id.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | #[allow(derive_hash_xor_eq)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::derive_hash_xor_eq` [INFO] [stderr] [INFO] [stderr] warning: lint name `let_and_return` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/model/user.rs:480:13 [INFO] [stderr] | [INFO] [stderr] 480 | #[allow(let_and_return)] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::let_and_return` [INFO] [stderr] [INFO] [stderr] warning: lint name `zero_ptr` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/client/mod.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | #![allow(zero_ptr)] [INFO] [stderr] | ^^^^^^^^ help: change it to: `clippy::zero_ptr` [INFO] [stderr] [INFO] [stderr] warning: lint name `cyclomatic_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/client/dispatch.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | #[allow(cyclomatic_complexity, unused_assignments, unused_mut)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cyclomatic_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `enum_variant_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/client/error.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | #[allow(enum_variant_names)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::enum_variant_names` [INFO] [stderr] [INFO] [stderr] warning: 3th binding whose name is just one char [INFO] [stderr] --> src/framework/standard/command.rs:55:110 [INFO] [stderr] | [INFO] [stderr] 55 | fn execute(&self, c: &mut Context, m: &Message, ho: &HelpOptions,hm: HashMap>, a: &Args) -> Result<(), Error> { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 3th binding whose name is just one char [INFO] [stderr] --> src/framework/standard/command.rs:239:111 [INFO] [stderr] | [INFO] [stderr] 239 | fn execute(&self, c: &mut Context, m: &Message, ho: &HelpOptions, hm: HashMap>, a: &Args) -> Result<(), Error> { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 3th binding whose name is just one char [INFO] [stderr] --> src/framework/standard/command.rs:298:53 [INFO] [stderr] | [INFO] [stderr] 298 | fn execute(&self, c: &mut Context, m: &Message, a: Args) -> Result<(), Error> { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 3th binding whose name is just one char [INFO] [stderr] --> src/framework/standard/command.rs:324:53 [INFO] [stderr] | [INFO] [stderr] 324 | fn execute(&self, c: &mut Context, m: &Message, a: Args) -> Result<(), Error> { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 3th binding whose name is just one char [INFO] [stderr] --> src/framework/standard/create_command.rs:278:61 [INFO] [stderr] | [INFO] [stderr] 278 | fn execute(&self, c: &mut Context, m: &Message, a: Args) -> Result<(), CommandError> { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/framework/standard/mod.rs:500:13 [INFO] [stderr] | [INFO] [stderr] 500 | #[allow(too_many_arguments)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] [INFO] [stderr] warning: lint name `cyclomatic_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/gateway/shard.rs:364:13 [INFO] [stderr] | [INFO] [stderr] 364 | #[allow(cyclomatic_complexity)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cyclomatic_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `zero_ptr` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/http/ratelimiting.rs:41:10 [INFO] [stderr] | [INFO] [stderr] 41 | #![allow(zero_ptr)] [INFO] [stderr] | ^^^^^^^^ help: change it to: `clippy::zero_ptr` [INFO] [stderr] [INFO] [stderr] warning: lint name `unreadable_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/utils/colour.rs:2:10 [INFO] [stderr] | [INFO] [stderr] 2 | #![allow(unreadable_literal)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unreadable_literal` [INFO] [stderr] [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:108:10 [INFO] [stderr] | [INFO] [stderr] 108 | #![allow(doc_markdown, inline_always)] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `inline_always` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:108:24 [INFO] [stderr] | [INFO] [stderr] 108 | #![allow(doc_markdown, inline_always)] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::inline_always` [INFO] [stderr] [INFO] [stderr] warning: lint name `enum_glob_use` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | #![warn(enum_glob_use, if_not_else)] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::enum_glob_use` [INFO] [stderr] [INFO] [stderr] warning: lint name `if_not_else` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:109:24 [INFO] [stderr] | [INFO] [stderr] 109 | #![warn(enum_glob_use, if_not_else)] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::if_not_else` [INFO] [stderr] [INFO] [stderr] warning: lint name `large_enum_variant` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/model/event.rs:1250:9 [INFO] [stderr] | [INFO] [stderr] 1250 | #[allow(large_enum_variant)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::large_enum_variant` [INFO] [stderr] [INFO] [stderr] warning: lint name `large_enum_variant` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/model/event.rs:1330:9 [INFO] [stderr] | [INFO] [stderr] 1330 | #[allow(large_enum_variant)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::large_enum_variant` [INFO] [stderr] [INFO] [stderr] warning: lint name `large_enum_variant` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/model/guild/mod.rs:1736:9 [INFO] [stderr] | [INFO] [stderr] 1736 | #[allow(large_enum_variant)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::large_enum_variant` [INFO] [stderr] [INFO] [stderr] warning: lint name `large_enum_variant` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/model/guild/mod.rs:1826:9 [INFO] [stderr] | [INFO] [stderr] 1826 | #[allow(large_enum_variant)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::large_enum_variant` [INFO] [stderr] [INFO] [stderr] warning: lint name `derive_hash_xor_eq` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/model/id.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | #[allow(derive_hash_xor_eq)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::derive_hash_xor_eq` [INFO] [stderr] [INFO] [stderr] warning: lint name `derive_hash_xor_eq` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/model/id.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | #[allow(derive_hash_xor_eq)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::derive_hash_xor_eq` [INFO] [stderr] [INFO] [stderr] warning: lint name `derive_hash_xor_eq` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/model/id.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | #[allow(derive_hash_xor_eq)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::derive_hash_xor_eq` [INFO] [stderr] [INFO] [stderr] warning: lint name `derive_hash_xor_eq` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/model/id.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | #[allow(derive_hash_xor_eq)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::derive_hash_xor_eq` [INFO] [stderr] [INFO] [stderr] warning: lint name `derive_hash_xor_eq` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/model/id.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | #[allow(derive_hash_xor_eq)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::derive_hash_xor_eq` [INFO] [stderr] [INFO] [stderr] warning: lint name `derive_hash_xor_eq` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/model/id.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | #[allow(derive_hash_xor_eq)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::derive_hash_xor_eq` [INFO] [stderr] [INFO] [stderr] warning: lint name `derive_hash_xor_eq` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/model/id.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | #[allow(derive_hash_xor_eq)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::derive_hash_xor_eq` [INFO] [stderr] [INFO] [stderr] warning: lint name `derive_hash_xor_eq` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/model/id.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | #[allow(derive_hash_xor_eq)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::derive_hash_xor_eq` [INFO] [stderr] [INFO] [stderr] warning: lint name `derive_hash_xor_eq` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/model/id.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | #[allow(derive_hash_xor_eq)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::derive_hash_xor_eq` [INFO] [stderr] [INFO] [stderr] warning: lint name `derive_hash_xor_eq` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/model/id.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | #[allow(derive_hash_xor_eq)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::derive_hash_xor_eq` [INFO] [stderr] [INFO] [stderr] warning: lint name `let_and_return` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/model/user.rs:480:13 [INFO] [stderr] | [INFO] [stderr] 480 | #[allow(let_and_return)] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::let_and_return` [INFO] [stderr] [INFO] [stderr] warning: lint name `zero_ptr` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/client/mod.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | #![allow(zero_ptr)] [INFO] [stderr] | ^^^^^^^^ help: change it to: `clippy::zero_ptr` [INFO] [stderr] [INFO] [stderr] warning: lint name `cyclomatic_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/client/dispatch.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | #[allow(cyclomatic_complexity, unused_assignments, unused_mut)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cyclomatic_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `enum_variant_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/client/error.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | #[allow(enum_variant_names)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::enum_variant_names` [INFO] [stderr] [INFO] [stderr] warning: 3th binding whose name is just one char [INFO] [stderr] --> src/framework/standard/command.rs:55:110 [INFO] [stderr] | [INFO] [stderr] 55 | fn execute(&self, c: &mut Context, m: &Message, ho: &HelpOptions,hm: HashMap>, a: &Args) -> Result<(), Error> { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 3th binding whose name is just one char [INFO] [stderr] --> src/framework/standard/command.rs:239:111 [INFO] [stderr] | [INFO] [stderr] 239 | fn execute(&self, c: &mut Context, m: &Message, ho: &HelpOptions, hm: HashMap>, a: &Args) -> Result<(), Error> { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 3th binding whose name is just one char [INFO] [stderr] --> src/framework/standard/command.rs:298:53 [INFO] [stderr] | [INFO] [stderr] 298 | fn execute(&self, c: &mut Context, m: &Message, a: Args) -> Result<(), Error> { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 3th binding whose name is just one char [INFO] [stderr] --> src/framework/standard/command.rs:324:53 [INFO] [stderr] | [INFO] [stderr] 324 | fn execute(&self, c: &mut Context, m: &Message, a: Args) -> Result<(), Error> { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 3th binding whose name is just one char [INFO] [stderr] --> src/framework/standard/create_command.rs:278:61 [INFO] [stderr] | [INFO] [stderr] 278 | fn execute(&self, c: &mut Context, m: &Message, a: Args) -> Result<(), CommandError> { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/framework/standard/mod.rs:500:13 [INFO] [stderr] | [INFO] [stderr] 500 | #[allow(too_many_arguments)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] [INFO] [stderr] warning: lint name `cyclomatic_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/gateway/shard.rs:364:13 [INFO] [stderr] | [INFO] [stderr] 364 | #[allow(cyclomatic_complexity)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cyclomatic_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `zero_ptr` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/http/ratelimiting.rs:41:10 [INFO] [stderr] | [INFO] [stderr] 41 | #![allow(zero_ptr)] [INFO] [stderr] | ^^^^^^^^ help: change it to: `clippy::zero_ptr` [INFO] [stderr] [INFO] [stderr] warning: lint name `unreadable_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/utils/colour.rs:2:10 [INFO] [stderr] | [INFO] [stderr] 2 | #![allow(unreadable_literal)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unreadable_literal` [INFO] [stderr] [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:108:10 [INFO] [stderr] | [INFO] [stderr] 108 | #![allow(doc_markdown, inline_always)] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/model/channel/channel_category.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/model/user.rs:667:13 [INFO] [stderr] | [INFO] [stderr] 667 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `ShardStage` [INFO] [stderr] --> src/client/bridge/gateway/event.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / pub(crate) enum ClientEvent { [INFO] [stderr] 9 | | ShardStageUpdate(ShardStageUpdateEvent), [INFO] [stderr] 10 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/client/dispatch.rs:73:44 [INFO] [stderr] | [INFO] [stderr] 73 | #[cfg_attr(feature = "cargo-clippy", allow(too_many_arguments))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/framework/standard/help_commands.rs:607:5 [INFO] [stderr] | [INFO] [stderr] 607 | / return if listed_groups.is_empty() { [INFO] [stderr] 608 | | CustomisedHelpData::NoCommandFound { [INFO] [stderr] 609 | | help_error_message: &help_options.no_help_available_text, [INFO] [stderr] 610 | | } [INFO] [stderr] ... | [INFO] [stderr] 615 | | } [INFO] [stderr] 616 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 607 | if listed_groups.is_empty() { [INFO] [stderr] 608 | CustomisedHelpData::NoCommandFound { [INFO] [stderr] 609 | help_error_message: &help_options.no_help_available_text, [INFO] [stderr] 610 | } [INFO] [stderr] 611 | } else { [INFO] [stderr] 612 | CustomisedHelpData::GroupedCommands { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: lint name `cyclomatic_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/framework/standard/mod.rs:501:48 [INFO] [stderr] | [INFO] [stderr] 501 | #[cfg_attr(feature = "cargo-clippy", allow(cyclomatic_complexity))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cyclomatic_complexity` [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/framework/standard/mod.rs:1317:12 [INFO] [stderr] | [INFO] [stderr] 1317 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 1318 | | if let Some(guild) = message.guild() { [INFO] [stderr] 1319 | | let perms = guild [INFO] [stderr] 1320 | | .with(|g| g.permissions_in(message.channel_id, message.author.id)); [INFO] [stderr] ... | [INFO] [stderr] 1325 | | } [INFO] [stderr] 1326 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1317 | } else if let Some(guild) = message.guild() { [INFO] [stderr] 1318 | let perms = guild [INFO] [stderr] 1319 | .with(|g| g.permissions_in(message.channel_id, message.author.id)); [INFO] [stderr] 1320 | [INFO] [stderr] 1321 | perms.contains(command.required_permissions) [INFO] [stderr] 1322 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:108:10 [INFO] [stderr] | [INFO] [stderr] 108 | #![allow(doc_markdown, inline_always)] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/model/channel/channel_category.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/model/guild/mod.rs:2037:32 [INFO] [stderr] | [INFO] [stderr] 2037 | .ymd(2016, 11, 08) [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 2037 | .ymd(2016, 11, 8) [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 2037 | .ymd(2016, 11, 0o8) [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/model/guild/mod.rs:2061:32 [INFO] [stderr] | [INFO] [stderr] 2061 | .ymd(2016, 11, 08) [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 2061 | .ymd(2016, 11, 8) [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 2061 | .ymd(2016, 11, 0o8) [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/model/user.rs:667:13 [INFO] [stderr] | [INFO] [stderr] 667 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/builder/create_embed.rs:530:33 [INFO] [stderr] | [INFO] [stderr] 530 | colour: Colour::new(0xFF0011), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_0011` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/builder/create_embed.rs:569:21 [INFO] [stderr] | [INFO] [stderr] 569 | .colour(0xFF0011) [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/builder/create_embed.rs:578:22 [INFO] [stderr] | [INFO] [stderr] 578 | "color": 0xFF0011, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `ShardStage` [INFO] [stderr] --> src/client/bridge/gateway/event.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / pub(crate) enum ClientEvent { [INFO] [stderr] 9 | | ShardStageUpdate(ShardStageUpdateEvent), [INFO] [stderr] 10 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/client/dispatch.rs:73:44 [INFO] [stderr] | [INFO] [stderr] 73 | #[cfg_attr(feature = "cargo-clippy", allow(too_many_arguments))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/framework/standard/help_commands.rs:607:5 [INFO] [stderr] | [INFO] [stderr] 607 | / return if listed_groups.is_empty() { [INFO] [stderr] 608 | | CustomisedHelpData::NoCommandFound { [INFO] [stderr] 609 | | help_error_message: &help_options.no_help_available_text, [INFO] [stderr] 610 | | } [INFO] [stderr] ... | [INFO] [stderr] 615 | | } [INFO] [stderr] 616 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 607 | if listed_groups.is_empty() { [INFO] [stderr] 608 | CustomisedHelpData::NoCommandFound { [INFO] [stderr] 609 | help_error_message: &help_options.no_help_available_text, [INFO] [stderr] 610 | } [INFO] [stderr] 611 | } else { [INFO] [stderr] 612 | CustomisedHelpData::GroupedCommands { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: lint name `cyclomatic_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/framework/standard/mod.rs:501:48 [INFO] [stderr] | [INFO] [stderr] 501 | #[cfg_attr(feature = "cargo-clippy", allow(cyclomatic_complexity))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cyclomatic_complexity` [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/framework/standard/mod.rs:1317:12 [INFO] [stderr] | [INFO] [stderr] 1317 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 1318 | | if let Some(guild) = message.guild() { [INFO] [stderr] 1319 | | let perms = guild [INFO] [stderr] 1320 | | .with(|g| g.permissions_in(message.channel_id, message.author.id)); [INFO] [stderr] ... | [INFO] [stderr] 1325 | | } [INFO] [stderr] 1326 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1317 | } else if let Some(guild) = message.guild() { [INFO] [stderr] 1318 | let perms = guild [INFO] [stderr] 1319 | .with(|g| g.permissions_in(message.channel_id, message.author.id)); [INFO] [stderr] 1320 | [INFO] [stderr] 1321 | perms.contains(command.required_permissions) [INFO] [stderr] 1322 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils/mod.rs:928:24 [INFO] [stderr] | [INFO] [stderr] 928 | id: UserId(100000000000000000), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `100_000_000_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils/mod.rs:945:25 [INFO] [stderr] | [INFO] [stderr] 945 | id: GuildId(381880193251409931), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `381_880_193_251_409_931` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils/mod.rs:954:30 [INFO] [stderr] | [INFO] [stderr] 954 | owner_id: UserId(114941315417899012), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `114_941_315_417_899_012` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils/mod.rs:975:24 [INFO] [stderr] | [INFO] [stderr] 975 | id: RoleId(333333333333333333), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `333_333_333_333_333_333` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils/mod.rs:986:27 [INFO] [stderr] | [INFO] [stderr] 986 | id: ChannelId(111880193700067777), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `111_880_193_700_067_777` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/constants.rs:113:16 [INFO] [stderr] | [INFO] [stderr] 113 | pub fn num(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/constants.rs:164:16 [INFO] [stderr] | [INFO] [stderr] 164 | pub fn num(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:47:29 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn broadcast_typing(&self) -> Result<()> { http::broadcast_typing(self.0) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:62:30 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn create_permission(&self, target: &PermissionOverwrite) -> Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:91:34 [INFO] [stderr] | [INFO] [stderr] 91 | pub fn create_reaction(&self, message_id: M, reaction_type: R) -> Result<()> [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:106:19 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn delete(&self) -> Result { http::delete_channel(self.0) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:119:47 [INFO] [stderr] | [INFO] [stderr] 119 | pub fn delete_message>(&self, message_id: M) -> Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:145:75 [INFO] [stderr] | [INFO] [stderr] 145 | pub fn delete_messages, It: IntoIterator>(&self, message_ids: It) -> Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:173:30 [INFO] [stderr] | [INFO] [stderr] 173 | pub fn delete_permission(&self, permission_type: PermissionOverwriteType) -> Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:191:34 [INFO] [stderr] | [INFO] [stderr] 191 | pub fn delete_reaction(&self, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:239:56 [INFO] [stderr] | [INFO] [stderr] 239 | pub fn edit EditChannel>(&self, f: F) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:266:31 [INFO] [stderr] | [INFO] [stderr] 266 | pub fn edit_message(&self, message_id: M, f: F) -> Result [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:291:17 [INFO] [stderr] | [INFO] [stderr] 291 | pub fn find(&self) -> Option { self.to_channel_cached() } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:313:16 [INFO] [stderr] | [INFO] [stderr] 313 | pub fn get(&self) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:342:20 [INFO] [stderr] | [INFO] [stderr] 342 | pub fn invites(&self) -> Result> { http::get_channel_invites(self.0) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:350:40 [INFO] [stderr] | [INFO] [stderr] 350 | pub fn message>(&self, message_id: M) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:370:24 [INFO] [stderr] | [INFO] [stderr] 370 | pub fn messages(&self, f: F) -> Result> [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:396:17 [INFO] [stderr] | [INFO] [stderr] 396 | pub fn name(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:426:36 [INFO] [stderr] | [INFO] [stderr] 426 | pub fn pin>(&self, message_id: M) -> Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:438:17 [INFO] [stderr] | [INFO] [stderr] 438 | pub fn pins(&self) -> Result> { http::get_pins(self.0) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:452:36 [INFO] [stderr] | [INFO] [stderr] 452 | pub fn reaction_users(&self, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:497:40 [INFO] [stderr] | [INFO] [stderr] 497 | pub fn say(&self, content: D) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:558:59 [INFO] [stderr] | [INFO] [stderr] 558 | pub fn send_files<'a, F, T, It: IntoIterator>(&self, files: It, f: F) -> Result [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:598:28 [INFO] [stderr] | [INFO] [stderr] 598 | pub fn send_message(&self, f: F) -> Result [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:624:38 [INFO] [stderr] | [INFO] [stderr] 624 | pub fn unpin>(&self, message_id: M) -> Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:638:21 [INFO] [stderr] | [INFO] [stderr] 638 | pub fn webhooks(&self) -> Result> { http::get_channel_webhooks(self.0) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/message.rs:692:16 [INFO] [stderr] | [INFO] [stderr] 692 | pub fn num(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/mod.rs:633:16 [INFO] [stderr] | [INFO] [stderr] 633 | pub fn num(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/model/event.rs:309:17 [INFO] [stderr] | [INFO] [stderr] 309 | / cache [INFO] [stderr] 310 | | .categories [INFO] [stderr] 311 | | .get_mut(&category.read().id) [INFO] [stderr] 312 | | .map(|c| c.clone_from(category)); [INFO] [stderr] | |____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 309 | if let Some(c) = cache [INFO] [stderr] 310 | .categories [INFO] [stderr] 311 | .get_mut(&category.read().id) { c.clone_from(category) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/gateway.rs:241:16 [INFO] [stderr] | [INFO] [stderr] 241 | pub fn num(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:21:26 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn as_channel_id(&self) -> ChannelId { ChannelId(self.0) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:51:23 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn ban(&self, user: U, ban_options: &BO) -> Result<()> [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn bans(&self) -> Result> { http::get_bans(self.0) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:80:23 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn audit_logs(&self, action_type: Option, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:90:21 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn channels(&self) -> Result> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:120:30 [INFO] [stderr] | [INFO] [stderr] 120 | pub fn create_channel(&self, name: &str, kind: ChannelType, category: C) -> Result [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:158:25 [INFO] [stderr] | [INFO] [stderr] 158 | pub fn create_emoji(&self, name: &str, image: &str) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:173:34 [INFO] [stderr] | [INFO] [stderr] 173 | pub fn create_integration(&self, integration_id: I, kind: &str) -> Result<()> [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:200:57 [INFO] [stderr] | [INFO] [stderr] 200 | pub fn create_role EditRole>(&self, f: F) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:221:19 [INFO] [stderr] | [INFO] [stderr] 221 | pub fn delete(&self) -> Result { http::delete_guild(self.0) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:230:43 [INFO] [stderr] | [INFO] [stderr] 230 | pub fn delete_emoji>(&self, emoji_id: E) -> Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:244:55 [INFO] [stderr] | [INFO] [stderr] 244 | pub fn delete_integration>(&self, integration_id: I) -> Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:263:41 [INFO] [stderr] | [INFO] [stderr] 263 | pub fn delete_role>(&self, role_id: R) -> Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:298:41 [INFO] [stderr] | [INFO] [stderr] 298 | pub fn edit_emoji>(&self, emoji_id: E, name: &str) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:324:30 [INFO] [stderr] | [INFO] [stderr] 324 | pub fn edit_member(&self, user_id: U, f: F) -> Result<()> [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:344:26 [INFO] [stderr] | [INFO] [stderr] 344 | pub fn edit_nickname(&self, new_nickname: Option<&str>) -> Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:365:28 [INFO] [stderr] | [INFO] [stderr] 365 | pub fn edit_role(&self, role_id: R, f: F) -> Result [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:392:34 [INFO] [stderr] | [INFO] [stderr] 392 | pub fn edit_role_position(&self, role_id: R, position: u64) -> Result> [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:398:9 [INFO] [stderr] | [INFO] [stderr] 398 | &self, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:408:17 [INFO] [stderr] | [INFO] [stderr] 408 | pub fn find(&self) -> Option>> { self.to_guild_cached() } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:423:16 [INFO] [stderr] | [INFO] [stderr] 423 | pub fn get(&self) -> Result { self.to_partial_guild() } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:439:25 [INFO] [stderr] | [INFO] [stderr] 439 | pub fn integrations(&self) -> Result> { http::get_guild_integrations(self.0) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:447:20 [INFO] [stderr] | [INFO] [stderr] 447 | pub fn invites(&self) -> Result> { http::get_guild_invites(self.0) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:456:34 [INFO] [stderr] | [INFO] [stderr] 456 | pub fn kick>(&self, user_id: U) -> Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:462:18 [INFO] [stderr] | [INFO] [stderr] 462 | pub fn leave(&self) -> Result<()> { http::leave_guild(self.0) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:472:36 [INFO] [stderr] | [INFO] [stderr] 472 | pub fn member>(&self, user_id: U) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:476:16 [INFO] [stderr] | [INFO] [stderr] 476 | fn _member(&self, user_id: UserId) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:495:23 [INFO] [stderr] | [INFO] [stderr] 495 | pub fn members(&self, limit: Option, after: Option) -> Result> [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:500:17 [INFO] [stderr] | [INFO] [stderr] 500 | fn _members(&self, limit: Option, after: Option) -> Result> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:510:30 [INFO] [stderr] | [INFO] [stderr] 510 | pub fn move_member(&self, user_id: U, channel_id: C) -> Result<()> [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:516:9 [INFO] [stderr] | [INFO] [stderr] 516 | &self, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:536:24 [INFO] [stderr] | [INFO] [stderr] 536 | pub fn prune_count(&self, days: u16) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:553:33 [INFO] [stderr] | [INFO] [stderr] 553 | pub fn reorder_channels(&self, channels: It) -> Result<()> [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:558:26 [INFO] [stderr] | [INFO] [stderr] 558 | fn _reorder_channels(&self, channels: Vec<(ChannelId, u64)>) -> Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:579:21 [INFO] [stderr] | [INFO] [stderr] 579 | pub fn shard_id(&self) -> u64 { ::utils::shard_id(self.0, CACHE.read().shard_count) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:612:59 [INFO] [stderr] | [INFO] [stderr] 612 | pub fn start_integration_sync>(&self, integration_id: I) -> Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:617:9 [INFO] [stderr] | [INFO] [stderr] 617 | &self, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:633:24 [INFO] [stderr] | [INFO] [stderr] 633 | pub fn start_prune(&self, days: u16) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:648:35 [INFO] [stderr] | [INFO] [stderr] 648 | pub fn unban>(&self, user_id: U) -> Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:662:23 [INFO] [stderr] | [INFO] [stderr] 662 | pub fn vanity_url(&self) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:672:21 [INFO] [stderr] | [INFO] [stderr] 672 | pub fn webhooks(&self) -> Result> { http::get_guild_webhooks(self.0) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/role.rs:176:17 [INFO] [stderr] | [INFO] [stderr] 176 | pub fn find(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/audit_log.rs:287:42 [INFO] [stderr] | [INFO] [stderr] 287 | pub fn serialize(num: &u64, s: S) -> StdResult { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/constants.rs:113:16 [INFO] [stderr] | [INFO] [stderr] 113 | pub fn num(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/constants.rs:164:16 [INFO] [stderr] | [INFO] [stderr] 164 | pub fn num(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:47:29 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn broadcast_typing(&self) -> Result<()> { http::broadcast_typing(self.0) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:62:30 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn create_permission(&self, target: &PermissionOverwrite) -> Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:91:34 [INFO] [stderr] | [INFO] [stderr] 91 | pub fn create_reaction(&self, message_id: M, reaction_type: R) -> Result<()> [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:106:19 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn delete(&self) -> Result { http::delete_channel(self.0) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:119:47 [INFO] [stderr] | [INFO] [stderr] 119 | pub fn delete_message>(&self, message_id: M) -> Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:145:75 [INFO] [stderr] | [INFO] [stderr] 145 | pub fn delete_messages, It: IntoIterator>(&self, message_ids: It) -> Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:173:30 [INFO] [stderr] | [INFO] [stderr] 173 | pub fn delete_permission(&self, permission_type: PermissionOverwriteType) -> Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:191:34 [INFO] [stderr] | [INFO] [stderr] 191 | pub fn delete_reaction(&self, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:239:56 [INFO] [stderr] | [INFO] [stderr] 239 | pub fn edit EditChannel>(&self, f: F) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:266:31 [INFO] [stderr] | [INFO] [stderr] 266 | pub fn edit_message(&self, message_id: M, f: F) -> Result [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:291:17 [INFO] [stderr] | [INFO] [stderr] 291 | pub fn find(&self) -> Option { self.to_channel_cached() } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:313:16 [INFO] [stderr] | [INFO] [stderr] 313 | pub fn get(&self) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:342:20 [INFO] [stderr] | [INFO] [stderr] 342 | pub fn invites(&self) -> Result> { http::get_channel_invites(self.0) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:350:40 [INFO] [stderr] | [INFO] [stderr] 350 | pub fn message>(&self, message_id: M) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:370:24 [INFO] [stderr] | [INFO] [stderr] 370 | pub fn messages(&self, f: F) -> Result> [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/mod.rs:1866:16 [INFO] [stderr] | [INFO] [stderr] 1866 | pub fn num(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:396:17 [INFO] [stderr] | [INFO] [stderr] 396 | pub fn name(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/mod.rs:1894:16 [INFO] [stderr] | [INFO] [stderr] 1894 | pub fn num(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:426:36 [INFO] [stderr] | [INFO] [stderr] 426 | pub fn pin>(&self, message_id: M) -> Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:438:17 [INFO] [stderr] | [INFO] [stderr] 438 | pub fn pins(&self) -> Result> { http::get_pins(self.0) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:452:36 [INFO] [stderr] | [INFO] [stderr] 452 | pub fn reaction_users(&self, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/mod.rs:1920:16 [INFO] [stderr] | [INFO] [stderr] 1920 | pub fn num(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:497:40 [INFO] [stderr] | [INFO] [stderr] 497 | pub fn say(&self, content: D) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:558:59 [INFO] [stderr] | [INFO] [stderr] 558 | pub fn send_files<'a, F, T, It: IntoIterator>(&self, files: It, f: F) -> Result [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:598:28 [INFO] [stderr] | [INFO] [stderr] 598 | pub fn send_message(&self, f: F) -> Result [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:624:38 [INFO] [stderr] | [INFO] [stderr] 624 | pub fn unpin>(&self, message_id: M) -> Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/channel_id.rs:638:21 [INFO] [stderr] | [INFO] [stderr] 638 | pub fn webhooks(&self) -> Result> { http::get_channel_webhooks(self.0) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/mod.rs:2005:16 [INFO] [stderr] | [INFO] [stderr] 2005 | pub fn num(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:271:26 [INFO] [stderr] | [INFO] [stderr] 271 | pub fn add_reactions(&self) -> bool { self.contains(Self::ADD_REACTIONS) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:277:26 [INFO] [stderr] | [INFO] [stderr] 277 | pub fn administrator(&self) -> bool { self.contains(Self::ADMINISTRATOR) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:283:25 [INFO] [stderr] | [INFO] [stderr] 283 | pub fn attach_files(&self) -> bool { self.contains(Self::ATTACH_FILES) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:289:24 [INFO] [stderr] | [INFO] [stderr] 289 | pub fn ban_members(&self) -> bool { self.contains(Self::BAN_MEMBERS) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:295:28 [INFO] [stderr] | [INFO] [stderr] 295 | pub fn change_nickname(&self) -> bool { self.contains(Self::CHANGE_NICKNAME) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:301:20 [INFO] [stderr] | [INFO] [stderr] 301 | pub fn connect(&self) -> bool { self.contains(Self::CONNECT) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:307:27 [INFO] [stderr] | [INFO] [stderr] 307 | pub fn view_audit_log(&self) -> bool { self.contains(Self::VIEW_AUDIT_LOG) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:313:29 [INFO] [stderr] | [INFO] [stderr] 313 | pub fn priority_speaker(&self) -> bool { self.contains(Self::PRIORITY_SPEAKER) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:319:26 [INFO] [stderr] | [INFO] [stderr] 319 | pub fn create_invite(&self) -> bool { self.contains(Self::CREATE_INVITE) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:325:27 [INFO] [stderr] | [INFO] [stderr] 325 | pub fn deafen_members(&self) -> bool { self.contains(Self::DEAFEN_MEMBERS) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:331:24 [INFO] [stderr] | [INFO] [stderr] 331 | pub fn embed_links(&self) -> bool { self.contains(Self::EMBED_LINKS) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:337:28 [INFO] [stderr] | [INFO] [stderr] 337 | pub fn external_emojis(&self) -> bool { self.contains(Self::USE_EXTERNAL_EMOJIS) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:343:25 [INFO] [stderr] | [INFO] [stderr] 343 | pub fn kick_members(&self) -> bool { self.contains(Self::KICK_MEMBERS) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:349:28 [INFO] [stderr] | [INFO] [stderr] 349 | pub fn manage_channels(&self) -> bool { self.contains(Self::MANAGE_CHANNELS) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:355:26 [INFO] [stderr] | [INFO] [stderr] 355 | pub fn manage_emojis(&self) -> bool { self.contains(Self::MANAGE_EMOJIS) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:361:25 [INFO] [stderr] | [INFO] [stderr] 361 | pub fn manage_guild(&self) -> bool { self.contains(Self::MANAGE_GUILD) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:367:28 [INFO] [stderr] | [INFO] [stderr] 367 | pub fn manage_messages(&self) -> bool { self.contains(Self::MANAGE_MESSAGES) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:373:29 [INFO] [stderr] | [INFO] [stderr] 373 | pub fn manage_nicknames(&self) -> bool { self.contains(Self::MANAGE_NICKNAMES) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:379:25 [INFO] [stderr] | [INFO] [stderr] 379 | pub fn manage_roles(&self) -> bool { self.contains(Self::MANAGE_ROLES) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:385:28 [INFO] [stderr] | [INFO] [stderr] 385 | pub fn manage_webhooks(&self) -> bool { self.contains(Self::MANAGE_WEBHOOKS) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:391:29 [INFO] [stderr] | [INFO] [stderr] 391 | pub fn mention_everyone(&self) -> bool { self.contains(Self::MENTION_EVERYONE) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:397:25 [INFO] [stderr] | [INFO] [stderr] 397 | pub fn move_members(&self) -> bool { self.contains(Self::MOVE_MEMBERS) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:403:25 [INFO] [stderr] | [INFO] [stderr] 403 | pub fn mute_members(&self) -> bool { self.contains(Self::MUTE_MEMBERS) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:409:33 [INFO] [stderr] | [INFO] [stderr] 409 | pub fn read_message_history(&self) -> bool { self.contains(Self::READ_MESSAGE_HISTORY) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:415:26 [INFO] [stderr] | [INFO] [stderr] 415 | pub fn read_messages(&self) -> bool { self.contains(Self::READ_MESSAGES) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:421:26 [INFO] [stderr] | [INFO] [stderr] 421 | pub fn send_messages(&self) -> bool { self.contains(Self::SEND_MESSAGES) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:427:30 [INFO] [stderr] | [INFO] [stderr] 427 | pub fn send_tts_messages(&self) -> bool { self.contains(Self::SEND_TTS_MESSAGES) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:433:18 [INFO] [stderr] | [INFO] [stderr] 433 | pub fn speak(&self) -> bool { self.contains(Self::SPEAK) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:439:32 [INFO] [stderr] | [INFO] [stderr] 439 | pub fn use_external_emojis(&self) -> bool { self.contains(Self::USE_EXTERNAL_EMOJIS) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:445:20 [INFO] [stderr] | [INFO] [stderr] 445 | pub fn use_vad(&self) -> bool { self.contains(Self::USE_VAD) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/message.rs:692:16 [INFO] [stderr] | [INFO] [stderr] 692 | pub fn num(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/user.rs:304:17 [INFO] [stderr] | [INFO] [stderr] 304 | pub fn name(&self) -> Result { serde_json::to_string(self).map_err(From::from) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/user.rs:754:30 [INFO] [stderr] | [INFO] [stderr] 754 | pub fn create_dm_channel(&self) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/user.rs:765:17 [INFO] [stderr] | [INFO] [stderr] 765 | pub fn find(&self) -> Option>> { self.to_user_cached() } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/user.rs:780:16 [INFO] [stderr] | [INFO] [stderr] 780 | pub fn get(&self) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/channel/mod.rs:633:16 [INFO] [stderr] | [INFO] [stderr] 633 | pub fn num(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/model/event.rs:309:17 [INFO] [stderr] | [INFO] [stderr] 309 | / cache [INFO] [stderr] 310 | | .categories [INFO] [stderr] 311 | | .get_mut(&category.read().id) [INFO] [stderr] 312 | | .map(|c| c.clone_from(category)); [INFO] [stderr] | |____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 309 | if let Some(c) = cache [INFO] [stderr] 310 | .categories [INFO] [stderr] 311 | .get_mut(&category.read().id) { c.clone_from(category) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/client/dispatch.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | Model(Event), [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 69 | Model(Box), [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/help_commands.rs:320:47 [INFO] [stderr] | [INFO] [stderr] 320 | let search_command_name_matched = if let &Some(ref prefixes) = &group.prefixes { [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 321 | | prefixes.iter().any(|prefix| { [INFO] [stderr] 322 | | format!("{} {}", prefix, command_name) == name [INFO] [stderr] 323 | | }) [INFO] [stderr] 324 | | } else { [INFO] [stderr] 325 | | name == *command_name [INFO] [stderr] 326 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 320 | let search_command_name_matched = if let Some(ref prefixes) = group.prefixes { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/framework/standard/help_commands.rs:362:17 [INFO] [stderr] | [INFO] [stderr] 362 | / if let &CommandOrAlias::Command(ref cmd) = command { [INFO] [stderr] 363 | | [INFO] [stderr] 364 | | let command_name = if let &Some(ref prefixes) = &group.prefixes { [INFO] [stderr] 365 | | if let Some(first_prefix) = prefixes.get(0) { [INFO] [stderr] ... | [INFO] [stderr] 383 | | } [INFO] [stderr] 384 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 362 | if let CommandOrAlias::Command(ref cmd) = *command { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/help_commands.rs:364:40 [INFO] [stderr] | [INFO] [stderr] 364 | let command_name = if let &Some(ref prefixes) = &group.prefixes { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 365 | | if let Some(first_prefix) = prefixes.get(0) { [INFO] [stderr] 366 | | format!("{} {}", &first_prefix, &command_name).to_string() [INFO] [stderr] 367 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 371 | | command_name.to_string() [INFO] [stderr] 372 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 364 | let command_name = if let Some(ref prefixes) = group.prefixes { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/help_commands.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / match $behaviour { [INFO] [stderr] 59 | | &HelpBehaviour::Strike => format!("~~`{}`~~", $command_name), [INFO] [stderr] 60 | | &HelpBehaviour::Nothing => format!("`{}`", $command_name), [INFO] [stderr] 61 | | &HelpBehaviour::Hide => continue, [INFO] [stderr] 62 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 455 | let name = format_command_name!(&help_options.lacking_role, &name); [INFO] [stderr] | ------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/help_commands.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / match $behaviour { [INFO] [stderr] 59 | | &HelpBehaviour::Strike => format!("~~`{}`~~", $command_name), [INFO] [stderr] 60 | | &HelpBehaviour::Nothing => format!("`{}`", $command_name), [INFO] [stderr] 61 | | &HelpBehaviour::Hide => continue, [INFO] [stderr] 62 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 463 | let name = format_command_name!(&help_options.lacking_permissions, &name); [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/help_commands.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / match $behaviour { [INFO] [stderr] 59 | | &HelpBehaviour::Strike => format!("~~`{}`~~", $command_name), [INFO] [stderr] 60 | | &HelpBehaviour::Nothing => format!("`{}`", $command_name), [INFO] [stderr] 61 | | &HelpBehaviour::Hide => continue, [INFO] [stderr] 62 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 467 | let name = format_command_name!(&help_options.wrong_channel, &name); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/framework/standard/help_commands.rs:592:23 [INFO] [stderr] | [INFO] [stderr] 592 | let description = if let &Some(ref striked_command_text) = strikethrough_command_tip { [INFO] [stderr] | _______________________^ [INFO] [stderr] 593 | | format!( [INFO] [stderr] 594 | | "{}\n{}", [INFO] [stderr] 595 | | &help_options.individual_command_tip, &striked_command_text [INFO] [stderr] ... | [INFO] [stderr] 598 | | help_options.individual_command_tip.clone() [INFO] [stderr] 599 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 592 | let description = if let Some(ref striked_command_text) = *strikethrough_command_tip { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/help_commands.rs:663:13 [INFO] [stderr] | [INFO] [stderr] 663 | / if let &Some(ref desc) = &command.description { [INFO] [stderr] 664 | | embed = embed.description(desc); [INFO] [stderr] 665 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 663 | if let Some(ref desc) = command.description { [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/help_commands.rs:667:13 [INFO] [stderr] | [INFO] [stderr] 667 | / if let &Some(ref usage) = &command.usage { [INFO] [stderr] 668 | | embed = embed.field(&help_options.usage_label, usage, true); [INFO] [stderr] 669 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 667 | if let Some(ref usage) = command.usage { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/framework/standard/help_commands.rs:699:16 [INFO] [stderr] | [INFO] [stderr] 699 | let text = format!("{}", help_description.replace("{}", &suggestions.join("`, `"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `help_description.replace("{}", &suggestions.join("`, `")).to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/help_commands.rs:737:23 [INFO] [stderr] | [INFO] [stderr] 737 | if let Err(why) = match &formatted_help { [INFO] [stderr] | _______________________^ [INFO] [stderr] 738 | | &CustomisedHelpData::SuggestedCommands { ref help_description, ref suggestions } => [INFO] [stderr] 739 | | send_suggestion_embed( [INFO] [stderr] 740 | | msg.channel_id, [INFO] [stderr] ... | [INFO] [stderr] 765 | | ), [INFO] [stderr] 766 | | } { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 737 | if let Err(why) = match formatted_help { [INFO] [stderr] 738 | CustomisedHelpData::SuggestedCommands { ref help_description, ref suggestions } => [INFO] [stderr] 739 | send_suggestion_embed( [INFO] [stderr] 740 | msg.channel_id, [INFO] [stderr] 741 | &help_description, [INFO] [stderr] 742 | &suggestions, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/help_commands.rs:804:5 [INFO] [stderr] | [INFO] [stderr] 804 | / if let &Some(ref description) = &command.description { [INFO] [stderr] 805 | | let _ = writeln!(result, "**{}**: {}", help_options.description_label, description); [INFO] [stderr] 806 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 804 | if let Some(ref description) = command.description { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/help_commands.rs:808:5 [INFO] [stderr] | [INFO] [stderr] 808 | / if let &Some(ref usage) = &command.usage { [INFO] [stderr] 809 | | let _ = writeln!(result, "**{}**: {}", help_options.usage_label, usage); [INFO] [stderr] 810 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 808 | if let Some(ref usage) = command.usage { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/help_commands.rs:812:5 [INFO] [stderr] | [INFO] [stderr] 812 | / if let &Some(ref usage_sample) = &command.usage_sample { [INFO] [stderr] 813 | | let _ = writeln!(result, "**{}**: `{} {}`", help_options.usage_sample_label, command.name, usage_sample); [INFO] [stderr] 814 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 812 | if let Some(ref usage_sample) = command.usage_sample { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/help_commands.rs:850:18 [INFO] [stderr] | [INFO] [stderr] 850 | let result = match &formatted_help { [INFO] [stderr] | __________________^ [INFO] [stderr] 851 | | &CustomisedHelpData::SuggestedCommands { ref help_description, ref suggestions } => [INFO] [stderr] 852 | | format!("{}: `{}`", help_description, suggestions.join("`, `")), [INFO] [stderr] 853 | | &CustomisedHelpData::NoCommandFound { ref help_error_message } => [INFO] [stderr] ... | [INFO] [stderr] 859 | | }, [INFO] [stderr] 860 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 850 | let result = match formatted_help { [INFO] [stderr] 851 | CustomisedHelpData::SuggestedCommands { ref help_description, ref suggestions } => [INFO] [stderr] 852 | format!("{}: `{}`", help_description, suggestions.join("`, `")), [INFO] [stderr] 853 | CustomisedHelpData::NoCommandFound { ref help_error_message } => [INFO] [stderr] 854 | help_error_message.to_string(), [INFO] [stderr] 855 | CustomisedHelpData::GroupedCommands { ref help_description, ref groups } => [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/framework/standard/mod.rs:1015:5 [INFO] [stderr] | [INFO] [stderr] 1015 | / fn dispatch( [INFO] [stderr] 1016 | | &mut self, [INFO] [stderr] 1017 | | mut context: Context, [INFO] [stderr] 1018 | | message: Message, [INFO] [stderr] ... | [INFO] [stderr] 1305 | | } [INFO] [stderr] 1306 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/mod.rs:1069:17 [INFO] [stderr] | [INFO] [stderr] 1069 | / if let &Some(ref message_without_command) = &self.message_without_command { [INFO] [stderr] 1070 | | [INFO] [stderr] 1071 | | if !(self.configuration.ignore_bots && message.author.bot) { [INFO] [stderr] 1072 | | let message_without_command = message_without_command.clone(); [INFO] [stderr] ... | [INFO] [stderr] 1076 | | } [INFO] [stderr] 1077 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1069 | if let Some(ref message_without_command) = self.message_without_command { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/framework/standard/mod.rs:1127:82 [INFO] [stderr] | [INFO] [stderr] 1127 | && (orginal_round.len() == prefix.len() || built.get(prefix.len()..prefix.len() + 1) == Some(" ")) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `prefix.len()..=prefix.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/mod.rs:1225:25 [INFO] [stderr] | [INFO] [stderr] 1225 | / if let &Some(CommandOrAlias::Command(ref command)) = &group.default_command { [INFO] [stderr] 1226 | | let command = Arc::clone(command); [INFO] [stderr] 1227 | | let mut args = { [INFO] [stderr] 1228 | | Args::new(&orginal_round[longest_matching_prefix_len..], &self.configuration.delimiters) [INFO] [stderr] ... | [INFO] [stderr] 1266 | | return; [INFO] [stderr] 1267 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1225 | if let Some(CommandOrAlias::Command(ref command)) = group.default_command { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/mod.rs:1275:13 [INFO] [stderr] | [INFO] [stderr] 1275 | / if let &Some(ref unrecognised_command) = &self.unrecognised_command { [INFO] [stderr] 1276 | | [INFO] [stderr] 1277 | | // If both functions are set, we need to clone `Context` and [INFO] [stderr] 1278 | | // `Message`, else we can avoid it. [INFO] [stderr] ... | [INFO] [stderr] 1303 | | }); [INFO] [stderr] 1304 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1275 | if let Some(ref unrecognised_command) = self.unrecognised_command { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/mod.rs:1279:17 [INFO] [stderr] | [INFO] [stderr] 1279 | / if let &Some(ref message_without_command) = &self.message_without_command { [INFO] [stderr] 1280 | | let mut context_unrecognised = context.clone(); [INFO] [stderr] 1281 | | let message_unrecognised = message.clone(); [INFO] [stderr] 1282 | | [INFO] [stderr] ... | [INFO] [stderr] 1297 | | }); [INFO] [stderr] 1298 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1279 | if let Some(ref message_without_command) = self.message_without_command { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/mod.rs:1299:20 [INFO] [stderr] | [INFO] [stderr] 1299 | } else if let &Some(ref message_without_command) = &self.message_without_command { [INFO] [stderr] | ____________________^ [INFO] [stderr] 1300 | | let message_without_command = message_without_command.clone(); [INFO] [stderr] 1301 | | threadpool.execute(move || { [INFO] [stderr] 1302 | | (message_without_command)(&mut context, &message); [INFO] [stderr] 1303 | | }); [INFO] [stderr] 1304 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1299 | } else if let Some(ref message_without_command) = self.message_without_command { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/gateway.rs:241:16 [INFO] [stderr] | [INFO] [stderr] 241 | pub fn num(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gateway/ws_client_ext.rs:34:14 [INFO] [stderr] | [INFO] [stderr] 34 | seq: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gateway/mod.rs:148:26 [INFO] [stderr] | [INFO] [stderr] 148 | pub fn is_connecting(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:21:26 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn as_channel_id(&self) -> ChannelId { ChannelId(self.0) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:51:23 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn ban(&self, user: U, ban_options: &BO) -> Result<()> [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn bans(&self) -> Result> { http::get_bans(self.0) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:80:23 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn audit_logs(&self, action_type: Option, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:90:21 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn channels(&self) -> Result> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:120:30 [INFO] [stderr] | [INFO] [stderr] 120 | pub fn create_channel(&self, name: &str, kind: ChannelType, category: C) -> Result [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:158:25 [INFO] [stderr] | [INFO] [stderr] 158 | pub fn create_emoji(&self, name: &str, image: &str) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:173:34 [INFO] [stderr] | [INFO] [stderr] 173 | pub fn create_integration(&self, integration_id: I, kind: &str) -> Result<()> [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:200:57 [INFO] [stderr] | [INFO] [stderr] 200 | pub fn create_role EditRole>(&self, f: F) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:221:19 [INFO] [stderr] | [INFO] [stderr] 221 | pub fn delete(&self) -> Result { http::delete_guild(self.0) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:230:43 [INFO] [stderr] | [INFO] [stderr] 230 | pub fn delete_emoji>(&self, emoji_id: E) -> Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:244:55 [INFO] [stderr] | [INFO] [stderr] 244 | pub fn delete_integration>(&self, integration_id: I) -> Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:263:41 [INFO] [stderr] | [INFO] [stderr] 263 | pub fn delete_role>(&self, role_id: R) -> Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:298:41 [INFO] [stderr] | [INFO] [stderr] 298 | pub fn edit_emoji>(&self, emoji_id: E, name: &str) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:324:30 [INFO] [stderr] | [INFO] [stderr] 324 | pub fn edit_member(&self, user_id: U, f: F) -> Result<()> [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:344:26 [INFO] [stderr] | [INFO] [stderr] 344 | pub fn edit_nickname(&self, new_nickname: Option<&str>) -> Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:365:28 [INFO] [stderr] | [INFO] [stderr] 365 | pub fn edit_role(&self, role_id: R, f: F) -> Result [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:392:34 [INFO] [stderr] | [INFO] [stderr] 392 | pub fn edit_role_position(&self, role_id: R, position: u64) -> Result> [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:398:9 [INFO] [stderr] | [INFO] [stderr] 398 | &self, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:408:17 [INFO] [stderr] | [INFO] [stderr] 408 | pub fn find(&self) -> Option>> { self.to_guild_cached() } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:423:16 [INFO] [stderr] | [INFO] [stderr] 423 | pub fn get(&self) -> Result { self.to_partial_guild() } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:439:25 [INFO] [stderr] | [INFO] [stderr] 439 | pub fn integrations(&self) -> Result> { http::get_guild_integrations(self.0) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:447:20 [INFO] [stderr] | [INFO] [stderr] 447 | pub fn invites(&self) -> Result> { http::get_guild_invites(self.0) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:456:34 [INFO] [stderr] | [INFO] [stderr] 456 | pub fn kick>(&self, user_id: U) -> Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:462:18 [INFO] [stderr] | [INFO] [stderr] 462 | pub fn leave(&self) -> Result<()> { http::leave_guild(self.0) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:472:36 [INFO] [stderr] | [INFO] [stderr] 472 | pub fn member>(&self, user_id: U) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:476:16 [INFO] [stderr] | [INFO] [stderr] 476 | fn _member(&self, user_id: UserId) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:495:23 [INFO] [stderr] | [INFO] [stderr] 495 | pub fn members(&self, limit: Option, after: Option) -> Result> [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:500:17 [INFO] [stderr] | [INFO] [stderr] 500 | fn _members(&self, limit: Option, after: Option) -> Result> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:510:30 [INFO] [stderr] | [INFO] [stderr] 510 | pub fn move_member(&self, user_id: U, channel_id: C) -> Result<()> [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:516:9 [INFO] [stderr] | [INFO] [stderr] 516 | &self, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:536:24 [INFO] [stderr] | [INFO] [stderr] 536 | pub fn prune_count(&self, days: u16) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:553:33 [INFO] [stderr] | [INFO] [stderr] 553 | pub fn reorder_channels(&self, channels: It) -> Result<()> [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:558:26 [INFO] [stderr] | [INFO] [stderr] 558 | fn _reorder_channels(&self, channels: Vec<(ChannelId, u64)>) -> Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:579:21 [INFO] [stderr] | [INFO] [stderr] 579 | pub fn shard_id(&self) -> u64 { ::utils::shard_id(self.0, CACHE.read().shard_count) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:612:59 [INFO] [stderr] | [INFO] [stderr] 612 | pub fn start_integration_sync>(&self, integration_id: I) -> Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:617:9 [INFO] [stderr] | [INFO] [stderr] 617 | &self, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:633:24 [INFO] [stderr] | [INFO] [stderr] 633 | pub fn start_prune(&self, days: u16) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:648:35 [INFO] [stderr] | [INFO] [stderr] 648 | pub fn unban>(&self, user_id: U) -> Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:662:23 [INFO] [stderr] | [INFO] [stderr] 662 | pub fn vanity_url(&self) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/guild_id.rs:672:21 [INFO] [stderr] | [INFO] [stderr] 672 | pub fn webhooks(&self) -> Result> { http::get_guild_webhooks(self.0) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/role.rs:176:17 [INFO] [stderr] | [INFO] [stderr] 176 | pub fn find(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/http/mod.rs:80:25 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn hyper_method(&self) -> Method { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/utils/colour.rs:153:14 [INFO] [stderr] | [INFO] [stderr] 153 | pub fn r(&self) -> u8 { ((self.0 >> 16) & 255) as u8 } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/utils/colour.rs:164:14 [INFO] [stderr] | [INFO] [stderr] 164 | pub fn g(&self) -> u8 { ((self.0 >> 8) & 255) as u8 } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/utils/colour.rs:174:14 [INFO] [stderr] | [INFO] [stderr] 174 | pub fn b(&self) -> u8 { (self.0 & 255) as u8 } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/utils/colour.rs:192:18 [INFO] [stderr] | [INFO] [stderr] 192 | pub fn tuple(&self) -> (u8, u8, u8) { (self.r(), self.g(), self.b()) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/utils/colour.rs:206:16 [INFO] [stderr] | [INFO] [stderr] 206 | pub fn hex(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/audit_log.rs:287:42 [INFO] [stderr] | [INFO] [stderr] 287 | pub fn serialize(num: &u64, s: S) -> StdResult { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utils/mod.rs:662:64 [INFO] [stderr] | [INFO] [stderr] 662 | if let Some(mut mention_end) = s[mention_start..].find(">") { [INFO] [stderr] | ^^^ help: try using a char instead: `'>'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utils/mod.rs:700:64 [INFO] [stderr] | [INFO] [stderr] 700 | if let Some(mut mention_end) = s[mention_start..].find(">") { [INFO] [stderr] | ^^^ help: try using a char instead: `'>'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utils/mod.rs:739:64 [INFO] [stderr] | [INFO] [stderr] 739 | if let Some(mut mention_end) = s[mention_start..].find(">") { [INFO] [stderr] | ^^^ help: try using a char instead: `'>'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/utils/mod.rs:742:13 [INFO] [stderr] | [INFO] [stderr] 742 | / let mut has_exclamation = false; [INFO] [stderr] 743 | | [INFO] [stderr] 744 | | if s[mention_start..].as_bytes().get(0).map_or(false, |c| *c == b'!') { [INFO] [stderr] 745 | | mention_start += "!".len(); [INFO] [stderr] 746 | | has_exclamation = true; [INFO] [stderr] 747 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let has_exclamation = if s[mention_start..].as_bytes().get(0).map_or(false, |c| *c == b'!') { ..; true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/utils/mod.rs:768:32 [INFO] [stderr] | [INFO] [stderr] 768 | let user = cache.read().users.get(&id).map(|user| user.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `cache.read().users.get(&id).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/mod.rs:1866:16 [INFO] [stderr] | [INFO] [stderr] 1866 | pub fn num(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/mod.rs:1894:16 [INFO] [stderr] | [INFO] [stderr] 1894 | pub fn num(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/mod.rs:1920:16 [INFO] [stderr] | [INFO] [stderr] 1920 | pub fn num(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/guild/mod.rs:2005:16 [INFO] [stderr] | [INFO] [stderr] 2005 | pub fn num(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:271:26 [INFO] [stderr] | [INFO] [stderr] 271 | pub fn add_reactions(&self) -> bool { self.contains(Self::ADD_REACTIONS) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:277:26 [INFO] [stderr] | [INFO] [stderr] 277 | pub fn administrator(&self) -> bool { self.contains(Self::ADMINISTRATOR) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:283:25 [INFO] [stderr] | [INFO] [stderr] 283 | pub fn attach_files(&self) -> bool { self.contains(Self::ATTACH_FILES) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:289:24 [INFO] [stderr] | [INFO] [stderr] 289 | pub fn ban_members(&self) -> bool { self.contains(Self::BAN_MEMBERS) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:295:28 [INFO] [stderr] | [INFO] [stderr] 295 | pub fn change_nickname(&self) -> bool { self.contains(Self::CHANGE_NICKNAME) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:301:20 [INFO] [stderr] | [INFO] [stderr] 301 | pub fn connect(&self) -> bool { self.contains(Self::CONNECT) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:307:27 [INFO] [stderr] | [INFO] [stderr] 307 | pub fn view_audit_log(&self) -> bool { self.contains(Self::VIEW_AUDIT_LOG) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:313:29 [INFO] [stderr] | [INFO] [stderr] 313 | pub fn priority_speaker(&self) -> bool { self.contains(Self::PRIORITY_SPEAKER) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:319:26 [INFO] [stderr] | [INFO] [stderr] 319 | pub fn create_invite(&self) -> bool { self.contains(Self::CREATE_INVITE) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:325:27 [INFO] [stderr] | [INFO] [stderr] 325 | pub fn deafen_members(&self) -> bool { self.contains(Self::DEAFEN_MEMBERS) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:331:24 [INFO] [stderr] | [INFO] [stderr] 331 | pub fn embed_links(&self) -> bool { self.contains(Self::EMBED_LINKS) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:337:28 [INFO] [stderr] | [INFO] [stderr] 337 | pub fn external_emojis(&self) -> bool { self.contains(Self::USE_EXTERNAL_EMOJIS) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:343:25 [INFO] [stderr] | [INFO] [stderr] 343 | pub fn kick_members(&self) -> bool { self.contains(Self::KICK_MEMBERS) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:349:28 [INFO] [stderr] | [INFO] [stderr] 349 | pub fn manage_channels(&self) -> bool { self.contains(Self::MANAGE_CHANNELS) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:355:26 [INFO] [stderr] | [INFO] [stderr] 355 | pub fn manage_emojis(&self) -> bool { self.contains(Self::MANAGE_EMOJIS) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:361:25 [INFO] [stderr] | [INFO] [stderr] 361 | pub fn manage_guild(&self) -> bool { self.contains(Self::MANAGE_GUILD) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:367:28 [INFO] [stderr] | [INFO] [stderr] 367 | pub fn manage_messages(&self) -> bool { self.contains(Self::MANAGE_MESSAGES) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:373:29 [INFO] [stderr] | [INFO] [stderr] 373 | pub fn manage_nicknames(&self) -> bool { self.contains(Self::MANAGE_NICKNAMES) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:379:25 [INFO] [stderr] | [INFO] [stderr] 379 | pub fn manage_roles(&self) -> bool { self.contains(Self::MANAGE_ROLES) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:385:28 [INFO] [stderr] | [INFO] [stderr] 385 | pub fn manage_webhooks(&self) -> bool { self.contains(Self::MANAGE_WEBHOOKS) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:391:29 [INFO] [stderr] | [INFO] [stderr] 391 | pub fn mention_everyone(&self) -> bool { self.contains(Self::MENTION_EVERYONE) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:397:25 [INFO] [stderr] | [INFO] [stderr] 397 | pub fn move_members(&self) -> bool { self.contains(Self::MOVE_MEMBERS) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:403:25 [INFO] [stderr] | [INFO] [stderr] 403 | pub fn mute_members(&self) -> bool { self.contains(Self::MUTE_MEMBERS) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:409:33 [INFO] [stderr] | [INFO] [stderr] 409 | pub fn read_message_history(&self) -> bool { self.contains(Self::READ_MESSAGE_HISTORY) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:415:26 [INFO] [stderr] | [INFO] [stderr] 415 | pub fn read_messages(&self) -> bool { self.contains(Self::READ_MESSAGES) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:421:26 [INFO] [stderr] | [INFO] [stderr] 421 | pub fn send_messages(&self) -> bool { self.contains(Self::SEND_MESSAGES) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:427:30 [INFO] [stderr] | [INFO] [stderr] 427 | pub fn send_tts_messages(&self) -> bool { self.contains(Self::SEND_TTS_MESSAGES) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:433:18 [INFO] [stderr] | [INFO] [stderr] 433 | pub fn speak(&self) -> bool { self.contains(Self::SPEAK) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:439:32 [INFO] [stderr] | [INFO] [stderr] 439 | pub fn use_external_emojis(&self) -> bool { self.contains(Self::USE_EXTERNAL_EMOJIS) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/permissions.rs:445:20 [INFO] [stderr] | [INFO] [stderr] 445 | pub fn use_vad(&self) -> bool { self.contains(Self::USE_VAD) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/user.rs:304:17 [INFO] [stderr] | [INFO] [stderr] 304 | pub fn name(&self) -> Result { serde_json::to_string(self).map_err(From::from) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/user.rs:754:30 [INFO] [stderr] | [INFO] [stderr] 754 | pub fn create_dm_channel(&self) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/user.rs:765:17 [INFO] [stderr] | [INFO] [stderr] 765 | pub fn find(&self) -> Option>> { self.to_user_cached() } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model/user.rs:780:16 [INFO] [stderr] | [INFO] [stderr] 780 | pub fn get(&self) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cache/mod.rs:852:28 [INFO] [stderr] | [INFO] [stderr] 852 | timestamp: datetime.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `datetime` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cache/mod.rs:864:20 [INFO] [stderr] | [INFO] [stderr] 864 | assert_eq!(cache.messages.get(&event.message.channel_id).unwrap().len(), 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&cache.messages[&event.message.channel_id]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cache/mod.rs:869:20 [INFO] [stderr] | [INFO] [stderr] 869 | assert_eq!(cache.messages.get(&event.message.channel_id).unwrap().len(), 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&cache.messages[&event.message.channel_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cache/mod.rs:876:27 [INFO] [stderr] | [INFO] [stderr] 876 | let channel = cache.messages.get(&event.message.channel_id).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&cache.messages[&event.message.channel_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/client/dispatch.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | Model(Event), [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 69 | Model(Box), [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/help_commands.rs:320:47 [INFO] [stderr] | [INFO] [stderr] 320 | let search_command_name_matched = if let &Some(ref prefixes) = &group.prefixes { [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 321 | | prefixes.iter().any(|prefix| { [INFO] [stderr] 322 | | format!("{} {}", prefix, command_name) == name [INFO] [stderr] 323 | | }) [INFO] [stderr] 324 | | } else { [INFO] [stderr] 325 | | name == *command_name [INFO] [stderr] 326 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 320 | let search_command_name_matched = if let Some(ref prefixes) = group.prefixes { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/framework/standard/help_commands.rs:362:17 [INFO] [stderr] | [INFO] [stderr] 362 | / if let &CommandOrAlias::Command(ref cmd) = command { [INFO] [stderr] 363 | | [INFO] [stderr] 364 | | let command_name = if let &Some(ref prefixes) = &group.prefixes { [INFO] [stderr] 365 | | if let Some(first_prefix) = prefixes.get(0) { [INFO] [stderr] ... | [INFO] [stderr] 383 | | } [INFO] [stderr] 384 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 362 | if let CommandOrAlias::Command(ref cmd) = *command { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/help_commands.rs:364:40 [INFO] [stderr] | [INFO] [stderr] 364 | let command_name = if let &Some(ref prefixes) = &group.prefixes { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 365 | | if let Some(first_prefix) = prefixes.get(0) { [INFO] [stderr] 366 | | format!("{} {}", &first_prefix, &command_name).to_string() [INFO] [stderr] 367 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 371 | | command_name.to_string() [INFO] [stderr] 372 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 364 | let command_name = if let Some(ref prefixes) = group.prefixes { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/help_commands.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / match $behaviour { [INFO] [stderr] 59 | | &HelpBehaviour::Strike => format!("~~`{}`~~", $command_name), [INFO] [stderr] 60 | | &HelpBehaviour::Nothing => format!("`{}`", $command_name), [INFO] [stderr] 61 | | &HelpBehaviour::Hide => continue, [INFO] [stderr] 62 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 455 | let name = format_command_name!(&help_options.lacking_role, &name); [INFO] [stderr] | ------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/help_commands.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / match $behaviour { [INFO] [stderr] 59 | | &HelpBehaviour::Strike => format!("~~`{}`~~", $command_name), [INFO] [stderr] 60 | | &HelpBehaviour::Nothing => format!("`{}`", $command_name), [INFO] [stderr] 61 | | &HelpBehaviour::Hide => continue, [INFO] [stderr] 62 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 463 | let name = format_command_name!(&help_options.lacking_permissions, &name); [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/help_commands.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / match $behaviour { [INFO] [stderr] 59 | | &HelpBehaviour::Strike => format!("~~`{}`~~", $command_name), [INFO] [stderr] 60 | | &HelpBehaviour::Nothing => format!("`{}`", $command_name), [INFO] [stderr] 61 | | &HelpBehaviour::Hide => continue, [INFO] [stderr] 62 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 467 | let name = format_command_name!(&help_options.wrong_channel, &name); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/framework/standard/help_commands.rs:592:23 [INFO] [stderr] | [INFO] [stderr] 592 | let description = if let &Some(ref striked_command_text) = strikethrough_command_tip { [INFO] [stderr] | _______________________^ [INFO] [stderr] 593 | | format!( [INFO] [stderr] 594 | | "{}\n{}", [INFO] [stderr] 595 | | &help_options.individual_command_tip, &striked_command_text [INFO] [stderr] ... | [INFO] [stderr] 598 | | help_options.individual_command_tip.clone() [INFO] [stderr] 599 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 592 | let description = if let Some(ref striked_command_text) = *strikethrough_command_tip { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/help_commands.rs:663:13 [INFO] [stderr] | [INFO] [stderr] 663 | / if let &Some(ref desc) = &command.description { [INFO] [stderr] 664 | | embed = embed.description(desc); [INFO] [stderr] 665 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 663 | if let Some(ref desc) = command.description { [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/help_commands.rs:667:13 [INFO] [stderr] | [INFO] [stderr] 667 | / if let &Some(ref usage) = &command.usage { [INFO] [stderr] 668 | | embed = embed.field(&help_options.usage_label, usage, true); [INFO] [stderr] 669 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 667 | if let Some(ref usage) = command.usage { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/framework/standard/help_commands.rs:699:16 [INFO] [stderr] | [INFO] [stderr] 699 | let text = format!("{}", help_description.replace("{}", &suggestions.join("`, `"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `help_description.replace("{}", &suggestions.join("`, `")).to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/help_commands.rs:737:23 [INFO] [stderr] | [INFO] [stderr] 737 | if let Err(why) = match &formatted_help { [INFO] [stderr] | _______________________^ [INFO] [stderr] 738 | | &CustomisedHelpData::SuggestedCommands { ref help_description, ref suggestions } => [INFO] [stderr] 739 | | send_suggestion_embed( [INFO] [stderr] 740 | | msg.channel_id, [INFO] [stderr] ... | [INFO] [stderr] 765 | | ), [INFO] [stderr] 766 | | } { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 737 | if let Err(why) = match formatted_help { [INFO] [stderr] 738 | CustomisedHelpData::SuggestedCommands { ref help_description, ref suggestions } => [INFO] [stderr] 739 | send_suggestion_embed( [INFO] [stderr] 740 | msg.channel_id, [INFO] [stderr] 741 | &help_description, [INFO] [stderr] 742 | &suggestions, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/help_commands.rs:804:5 [INFO] [stderr] | [INFO] [stderr] 804 | / if let &Some(ref description) = &command.description { [INFO] [stderr] 805 | | let _ = writeln!(result, "**{}**: {}", help_options.description_label, description); [INFO] [stderr] 806 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 804 | if let Some(ref description) = command.description { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/help_commands.rs:808:5 [INFO] [stderr] | [INFO] [stderr] 808 | / if let &Some(ref usage) = &command.usage { [INFO] [stderr] 809 | | let _ = writeln!(result, "**{}**: {}", help_options.usage_label, usage); [INFO] [stderr] 810 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 808 | if let Some(ref usage) = command.usage { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/help_commands.rs:812:5 [INFO] [stderr] | [INFO] [stderr] 812 | / if let &Some(ref usage_sample) = &command.usage_sample { [INFO] [stderr] 813 | | let _ = writeln!(result, "**{}**: `{} {}`", help_options.usage_sample_label, command.name, usage_sample); [INFO] [stderr] 814 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 812 | if let Some(ref usage_sample) = command.usage_sample { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/help_commands.rs:850:18 [INFO] [stderr] | [INFO] [stderr] 850 | let result = match &formatted_help { [INFO] [stderr] | __________________^ [INFO] [stderr] 851 | | &CustomisedHelpData::SuggestedCommands { ref help_description, ref suggestions } => [INFO] [stderr] 852 | | format!("{}: `{}`", help_description, suggestions.join("`, `")), [INFO] [stderr] 853 | | &CustomisedHelpData::NoCommandFound { ref help_error_message } => [INFO] [stderr] ... | [INFO] [stderr] 859 | | }, [INFO] [stderr] 860 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 850 | let result = match formatted_help { [INFO] [stderr] 851 | CustomisedHelpData::SuggestedCommands { ref help_description, ref suggestions } => [INFO] [stderr] 852 | format!("{}: `{}`", help_description, suggestions.join("`, `")), [INFO] [stderr] 853 | CustomisedHelpData::NoCommandFound { ref help_error_message } => [INFO] [stderr] 854 | help_error_message.to_string(), [INFO] [stderr] 855 | CustomisedHelpData::GroupedCommands { ref help_description, ref groups } => [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/framework/standard/help_commands.rs:939:9 [INFO] [stderr] | [INFO] [stderr] 939 | matrix[(3, 3)]; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/framework/standard/help_commands.rs:946:9 [INFO] [stderr] | [INFO] [stderr] 946 | matrix[(0, 0)]; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/framework/standard/mod.rs:1015:5 [INFO] [stderr] | [INFO] [stderr] 1015 | / fn dispatch( [INFO] [stderr] 1016 | | &mut self, [INFO] [stderr] 1017 | | mut context: Context, [INFO] [stderr] 1018 | | message: Message, [INFO] [stderr] ... | [INFO] [stderr] 1305 | | } [INFO] [stderr] 1306 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/mod.rs:1069:17 [INFO] [stderr] | [INFO] [stderr] 1069 | / if let &Some(ref message_without_command) = &self.message_without_command { [INFO] [stderr] 1070 | | [INFO] [stderr] 1071 | | if !(self.configuration.ignore_bots && message.author.bot) { [INFO] [stderr] 1072 | | let message_without_command = message_without_command.clone(); [INFO] [stderr] ... | [INFO] [stderr] 1076 | | } [INFO] [stderr] 1077 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1069 | if let Some(ref message_without_command) = self.message_without_command { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/framework/standard/mod.rs:1127:82 [INFO] [stderr] | [INFO] [stderr] 1127 | && (orginal_round.len() == prefix.len() || built.get(prefix.len()..prefix.len() + 1) == Some(" ")) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `prefix.len()..=prefix.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/mod.rs:1225:25 [INFO] [stderr] | [INFO] [stderr] 1225 | / if let &Some(CommandOrAlias::Command(ref command)) = &group.default_command { [INFO] [stderr] 1226 | | let command = Arc::clone(command); [INFO] [stderr] 1227 | | let mut args = { [INFO] [stderr] 1228 | | Args::new(&orginal_round[longest_matching_prefix_len..], &self.configuration.delimiters) [INFO] [stderr] ... | [INFO] [stderr] 1266 | | return; [INFO] [stderr] 1267 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1225 | if let Some(CommandOrAlias::Command(ref command)) = group.default_command { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/mod.rs:1275:13 [INFO] [stderr] | [INFO] [stderr] 1275 | / if let &Some(ref unrecognised_command) = &self.unrecognised_command { [INFO] [stderr] 1276 | | [INFO] [stderr] 1277 | | // If both functions are set, we need to clone `Context` and [INFO] [stderr] 1278 | | // `Message`, else we can avoid it. [INFO] [stderr] ... | [INFO] [stderr] 1303 | | }); [INFO] [stderr] 1304 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1275 | if let Some(ref unrecognised_command) = self.unrecognised_command { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/mod.rs:1279:17 [INFO] [stderr] | [INFO] [stderr] 1279 | / if let &Some(ref message_without_command) = &self.message_without_command { [INFO] [stderr] 1280 | | let mut context_unrecognised = context.clone(); [INFO] [stderr] 1281 | | let message_unrecognised = message.clone(); [INFO] [stderr] 1282 | | [INFO] [stderr] ... | [INFO] [stderr] 1297 | | }); [INFO] [stderr] 1298 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1279 | if let Some(ref message_without_command) = self.message_without_command { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/framework/standard/mod.rs:1299:20 [INFO] [stderr] | [INFO] [stderr] 1299 | } else if let &Some(ref message_without_command) = &self.message_without_command { [INFO] [stderr] | ____________________^ [INFO] [stderr] 1300 | | let message_without_command = message_without_command.clone(); [INFO] [stderr] 1301 | | threadpool.execute(move || { [INFO] [stderr] 1302 | | (message_without_command)(&mut context, &message); [INFO] [stderr] 1303 | | }); [INFO] [stderr] 1304 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1299 | } else if let Some(ref message_without_command) = self.message_without_command { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gateway/ws_client_ext.rs:34:14 [INFO] [stderr] | [INFO] [stderr] 34 | seq: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gateway/mod.rs:148:26 [INFO] [stderr] | [INFO] [stderr] 148 | pub fn is_connecting(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/http/mod.rs:80:25 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn hyper_method(&self) -> Method { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/utils/colour.rs:153:14 [INFO] [stderr] | [INFO] [stderr] 153 | pub fn r(&self) -> u8 { ((self.0 >> 16) & 255) as u8 } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/utils/colour.rs:164:14 [INFO] [stderr] | [INFO] [stderr] 164 | pub fn g(&self) -> u8 { ((self.0 >> 8) & 255) as u8 } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/utils/colour.rs:174:14 [INFO] [stderr] | [INFO] [stderr] 174 | pub fn b(&self) -> u8 { (self.0 & 255) as u8 } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/utils/colour.rs:192:18 [INFO] [stderr] | [INFO] [stderr] 192 | pub fn tuple(&self) -> (u8, u8, u8) { (self.r(), self.g(), self.b()) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/utils/colour.rs:206:16 [INFO] [stderr] | [INFO] [stderr] 206 | pub fn hex(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: don't use glob imports for enum variants [INFO] [stderr] --> src/utils/message_builder.rs:998:9 [INFO] [stderr] | [INFO] [stderr] 998 | ContentModifier::*, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | #![warn(enum_glob_use, if_not_else)] [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_glob_use [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 37 [INFO] [stderr] --> src/utils/message_builder.rs:1129:5 [INFO] [stderr] | [INFO] [stderr] 1129 | / fn push_safe() { [INFO] [stderr] 1130 | | gen! { [INFO] [stderr] 1131 | | push_safe => [ [INFO] [stderr] 1132 | | "" => "", [INFO] [stderr] ... | [INFO] [stderr] 1191 | | }; [INFO] [stderr] 1192 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 38 [INFO] [stderr] --> src/utils/message_builder.rs:1195:5 [INFO] [stderr] | [INFO] [stderr] 1195 | / fn push_unsafe() { [INFO] [stderr] 1196 | | gen! { [INFO] [stderr] 1197 | | push_bold => [ [INFO] [stderr] 1198 | | "a" => "**a**", [INFO] [stderr] ... | [INFO] [stderr] 1256 | | }; [INFO] [stderr] 1257 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utils/mod.rs:662:64 [INFO] [stderr] | [INFO] [stderr] 662 | if let Some(mut mention_end) = s[mention_start..].find(">") { [INFO] [stderr] | ^^^ help: try using a char instead: `'>'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utils/mod.rs:700:64 [INFO] [stderr] | [INFO] [stderr] 700 | if let Some(mut mention_end) = s[mention_start..].find(">") { [INFO] [stderr] | ^^^ help: try using a char instead: `'>'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utils/mod.rs:739:64 [INFO] [stderr] | [INFO] [stderr] 739 | if let Some(mut mention_end) = s[mention_start..].find(">") { [INFO] [stderr] | ^^^ help: try using a char instead: `'>'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/utils/mod.rs:742:13 [INFO] [stderr] | [INFO] [stderr] 742 | / let mut has_exclamation = false; [INFO] [stderr] 743 | | [INFO] [stderr] 744 | | if s[mention_start..].as_bytes().get(0).map_or(false, |c| *c == b'!') { [INFO] [stderr] 745 | | mention_start += "!".len(); [INFO] [stderr] 746 | | has_exclamation = true; [INFO] [stderr] 747 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let has_exclamation = if s[mention_start..].as_bytes().get(0).map_or(false, |c| *c == b'!') { ..; true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/utils/mod.rs:768:32 [INFO] [stderr] | [INFO] [stderr] 768 | let user = cache.read().users.get(&id).map(|user| user.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `cache.read().users.get(&id).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/bench_args.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `serenity`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "9a6e546981d8ea0560334e997b869a163d8457dbabc5bef1a4780c1a900342f6"` [INFO] running `"docker" "rm" "-f" "9a6e546981d8ea0560334e997b869a163d8457dbabc5bef1a4780c1a900342f6"` [INFO] [stdout] 9a6e546981d8ea0560334e997b869a163d8457dbabc5bef1a4780c1a900342f6